)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"33c422a02033a5ea3ff6c6818636d67ebd069f63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Panagiotis Karalis \u003cpkaralis@intracom-telecom.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-27 18:30:43 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]Introduce the Barbican in XCI for SFC-HA scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The barbican OS component is introduced for SFC HA deployed scenario."},{"line_number":10,"context_line":"The reason behind is that In HA scenarios we need Openstack Barbican to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_8734d8fb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2018-09-28 12:47:10.000000000","message":"Hello,\n\nThis subject makes no sense here :) I know this is for OPNFV but words like \"XCI\" , \"SFC-HA\" mean nothing in OpenStack-Ansible so you need to explain it a little bit more.","commit_id":"535e0d1e7eabed6dd81bbddc700093c685e12f25"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"33c422a02033a5ea3ff6c6818636d67ebd069f63","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]Introduce the Barbican in XCI for SFC-HA scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The barbican OS component is introduced for SFC HA deployed scenario."},{"line_number":10,"context_line":"The reason behind is that In HA scenarios we need Openstack Barbican to"},{"line_number":11,"context_line":"gather and store the fernet keys so Tacker can access them and be"},{"line_number":12,"context_line":"able to register new VIMs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0728c895","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":68},"updated":"2018-09-28 12:47:10.000000000","message":"similarly, \u0027sfc-ha scenario\u0027 means nothing :)","commit_id":"535e0d1e7eabed6dd81bbddc700093c685e12f25"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"33c422a02033a5ea3ff6c6818636d67ebd069f63","unresolved":false,"context_lines":[{"line_number":11,"context_line":"gather and store the fernet keys so Tacker can access them and be"},{"line_number":12,"context_line":"able to register new VIMs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"JIRA: SFC-131"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I63d40c5239d2585e8bb7ac3b9338252c9e28c4c6"},{"line_number":17,"context_line":"Signed-off-by: Panagiotis Karalis \u003cpkaralis@intracom-telecom.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_a7123460","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"updated":"2018-09-28 12:47:10.000000000","message":"this tracker is unknown to OpenStack.","commit_id":"535e0d1e7eabed6dd81bbddc700093c685e12f25"}],"defaults/main.yml":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"0b7bf55247729a41100a53fc2e296c8466ff3a36","unresolved":false,"context_lines":[{"line_number":130,"context_line":"tacker_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(tacker_service_proto) }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Barbican service"},{"line_number":133,"context_line":"tacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#NOTE:  move password to tests/test-vars.yml"},{"line_number":136,"context_line":"tacker_service_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_bcfc13b6","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":24},"updated":"2018-10-04 08:41:22.000000000","message":"\u0027flag\u0027 is a bit weird as a variable name. Can this be renamed to something more appropriate? Like \u0027barbican_keys_backend\u0027 or something?","commit_id":"dccb8fb2d82578c34a7b9c42d7bbdd23c0c9f5ac"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"0b7bf55247729a41100a53fc2e296c8466ff3a36","unresolved":false,"context_lines":[{"line_number":130,"context_line":"tacker_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(tacker_service_proto) }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Barbican service"},{"line_number":133,"context_line":"tacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#NOTE:  move password to tests/test-vars.yml"},{"line_number":136,"context_line":"tacker_service_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_1cf2e7e3","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":47},"updated":"2018-10-04 08:41:22.000000000","message":"where is this variable defined?","commit_id":"dccb8fb2d82578c34a7b9c42d7bbdd23c0c9f5ac"},{"author":{"_account_id":27749,"name":"Panagiotis Karalis","email":"pkaralis@intracom-telecom.com","username":"pkaralis"},"change_message_id":"b9b4467d44ab3a4ae3001ddad0458360abd3d5ae","unresolved":false,"context_lines":[{"line_number":130,"context_line":"tacker_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(tacker_service_proto) }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Barbican service"},{"line_number":133,"context_line":"tacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#NOTE:  move password to tests/test-vars.yml"},{"line_number":136,"context_line":"tacker_service_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_17cac044","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":47},"in_reply_to":"3f79a3b5_1763a0de","updated":"2018-10-04 09:44:55.000000000","message":"I know and I agree with your view about the project and the relation of this project with other consumers.\n\nMy intention, once I prepare this patch, was to add the variable \u0027tacker_use_barbican_flag\u0027 (forget the name :) I will update it asap), having as default value \u0027False\u0027 for all other projects and uses of this role.\nBut, only for this particular case (os-odl-sfc scenario) the value should be \u0027True\u0027. \n\nThat\u0027s why I\u0027ve prepared the test patch [1] for the SFC scenario and I let the default value \u0027False\u0027 to be set in case other consumer or project is going to use this role.\n\nDo you believe that this approach is not the proper one?","commit_id":"dccb8fb2d82578c34a7b9c42d7bbdd23c0c9f5ac"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"b23b5912028ab9c9c64e4b5242712759b47251ed","unresolved":false,"context_lines":[{"line_number":130,"context_line":"tacker_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(tacker_service_proto) }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Barbican service"},{"line_number":133,"context_line":"tacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#NOTE:  move password to tests/test-vars.yml"},{"line_number":136,"context_line":"tacker_service_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_69047c7e","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":47},"in_reply_to":"3f79a3b5_17cac044","updated":"2018-10-04 10:37:38.000000000","message":"So in ansible, defaults/main.yml is meant to provide default values. My understanding is that what you really want is to always have tacker_use_barbican_flag: False (as default) and then users can simply override that in their user variables files.\n\nThis notation\n\ntacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\"\n\nis rather strange for what you want to achieve\n\nYou can use \n\ntacker_use_barbican_flag: False\n\nand then other projects which use this role can simply use tacker_use_barbican_flag: True as a way to override the default. So in [1] test patch that you prepared, what you need to do is so simply add\n\ntacker_use_barbican_flag: True to\n\nscenarios/os-odl-nofeature/role/os-odl-nofeature/files/user_variables_os-odl-nofeature.yml\n\n(create it if it does not exist)\n\nsimilar to os-nosdn-nofeature.\n\nDoes that make sense?","commit_id":"dccb8fb2d82578c34a7b9c42d7bbdd23c0c9f5ac"},{"author":{"_account_id":27749,"name":"Panagiotis Karalis","email":"pkaralis@intracom-telecom.com","username":"pkaralis"},"change_message_id":"2068d7f2f842687817866dc9fec0a4352f622eb9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"tacker_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(tacker_service_proto) }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Barbican service"},{"line_number":133,"context_line":"tacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#NOTE:  move password to tests/test-vars.yml"},{"line_number":136,"context_line":"tacker_service_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_7c619b10","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":47},"in_reply_to":"3f79a3b5_1cf2e7e3","updated":"2018-10-04 09:09:27.000000000","message":"Please check the test patch [1].\nThose files replace the original ones, if during the XCI deployment, the os-odl-sfc has been selected as DEPLOY_SCENARIO.\nIn case of any other is selected as DEPLOY_SCENARIO, the barbican flag will be set with default value \u0027False\u0027.\n\nThis is the idea behind of my solution.\nPlease let me know if I\u0027ve missed something.\n\n[1] https://gerrit.opnfv.org/gerrit/#/c/59983/\n[I will add you as reviewer]","commit_id":"dccb8fb2d82578c34a7b9c42d7bbdd23c0c9f5ac"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"6179ea5ab6ea562ac26834cbe34afc24abc0b596","unresolved":false,"context_lines":[{"line_number":130,"context_line":"tacker_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(tacker_service_proto) }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Barbican service"},{"line_number":133,"context_line":"tacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#NOTE:  move password to tests/test-vars.yml"},{"line_number":136,"context_line":"tacker_service_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_1763a0de","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":47},"in_reply_to":"3f79a3b5_7c619b10","updated":"2018-10-04 09:15:06.000000000","message":"But [1] is a different project. Again, you are mixing a completely different project (XCI) with OSA. Why are you complicating things like this and not simply use\n\ntacker_use_barbican_flag: False (var name is still questionable of course :))\n\nas default option here and let consumers (like XCI) override it?\n\nXCI is just a project which uses OSA among other things.","commit_id":"dccb8fb2d82578c34a7b9c42d7bbdd23c0c9f5ac"},{"author":{"_account_id":27749,"name":"Panagiotis Karalis","email":"pkaralis@intracom-telecom.com","username":"pkaralis"},"change_message_id":"2068d7f2f842687817866dc9fec0a4352f622eb9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"tacker_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(tacker_service_proto) }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Barbican service"},{"line_number":133,"context_line":"tacker_use_barbican_flag: \"{{ use_barbican_flag | default(False) }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#NOTE:  move password to tests/test-vars.yml"},{"line_number":136,"context_line":"tacker_service_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_5c329f5e","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":24},"in_reply_to":"3f79a3b5_bcfc13b6","updated":"2018-10-04 09:09:27.000000000","message":"I agree!","commit_id":"dccb8fb2d82578c34a7b9c42d7bbdd23c0c9f5ac"}]}