)]}'
{"defaults/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"debug: False"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# tempest_install_method: \u003cdefault is git\u003e"},{"line_number":20,"context_line":"tempest_install_method: \"git\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tempest_plugins_rpm: []"},{"line_number":23,"context_line":"# Set the package install state for distribution and pip packages"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_3797bc3c","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":29},"updated":"2018-08-16 08:40:14.000000000","message":"I think git is very confusing way to \"install\" things -- it\u0027s with pip that you\u0027re installing, from git.\n\nIMO this very much looks like what we did with the install from \"source\" (whether it\u0027s coming as pip package upstream or git folder) vs \"distro\" (deb/rpm package).","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f005bbbb0084f2ee8f731b5c3cb2143a48d079fb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"debug: False"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# tempest_install_method: \u003cdefault is git\u003e"},{"line_number":20,"context_line":"tempest_install_method: \"git\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tempest_plugins_rpm: []"},{"line_number":23,"context_line":"# Set the package install state for distribution and pip packages"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_779774ed","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":29},"in_reply_to":"3f79a3b5_3797bc3c","updated":"2018-08-16 08:46:04.000000000","message":"I suspect that this is borrowing from the pattern in https://github.com/openstack/ansible-role-nodepool/blob/master/tasks/install.yaml where the install types are \u0027git\u0027, \u0027pip\u0027 and if available of course \u0027distro\u0027 could be added to the list.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bb6c85f91c5b728871c69b53fb0c7836d36a32d7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"debug: False"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# tempest_install_method: \u003cdefault is git\u003e"},{"line_number":20,"context_line":"tempest_install_method: \"git\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tempest_plugins_rpm: []"},{"line_number":23,"context_line":"# Set the package install state for distribution and pip packages"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_467902fa","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":29},"in_reply_to":"3f79a3b5_779774ed","updated":"2018-08-21 15:57:50.000000000","message":"Do we need to keep two installation method? one is source coming from git or pip and another from distro coming from rpm, zypper and apt? or we want to keep all the things seperate just like done in nodepool?","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"tempest_tempest_conf_overrides: {}"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"## python-tempestconf vars"},{"line_number":253,"context_line":"generate_tempestconf: False"},{"line_number":254,"context_line":"tempest_dir: \"{{ lookup(\u0027env\u0027,\u0027HOME\u0027)/tempest}}\""},{"line_number":255,"context_line":"source_credentails_command: \"\""},{"line_number":256,"context_line":"tempest_config_file: \"{{ tempest_dir }}/etc/tempest.conf\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_57def83d","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":27},"updated":"2018-08-16 08:40:14.000000000","message":"that\u0027s basically equivalent of our tempest_setup, so maybe we should rename it to tempest_config: and put up a release note.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":252,"context_line":"## python-tempestconf vars"},{"line_number":253,"context_line":"generate_tempestconf: False"},{"line_number":254,"context_line":"tempest_dir: \"{{ lookup(\u0027env\u0027,\u0027HOME\u0027)/tempest}}\""},{"line_number":255,"context_line":"source_credentails_command: \"\""},{"line_number":256,"context_line":"tempest_config_file: \"{{ tempest_dir }}/etc/tempest.conf\""},{"line_number":257,"context_line":"tempest_non_admin: False"},{"line_number":258,"context_line":"tempest_accounts_file: \"\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_17716076","line":255,"range":{"start_line":255,"start_character":7,"end_line":255,"end_character":18},"updated":"2018-08-16 08:40:14.000000000","message":"credentials","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":252,"context_line":"## python-tempestconf vars"},{"line_number":253,"context_line":"generate_tempestconf: False"},{"line_number":254,"context_line":"tempest_dir: \"{{ lookup(\u0027env\u0027,\u0027HOME\u0027)/tempest}}\""},{"line_number":255,"context_line":"source_credentails_command: \"\""},{"line_number":256,"context_line":"tempest_config_file: \"{{ tempest_dir }}/etc/tempest.conf\""},{"line_number":257,"context_line":"tempest_non_admin: False"},{"line_number":258,"context_line":"tempest_accounts_file: \"\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_b76bcc82","line":255,"range":{"start_line":255,"start_character":28,"end_line":255,"end_character":30},"updated":"2018-08-16 08:40:14.000000000","message":"we should provide safe defaults.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":254,"context_line":"tempest_dir: \"{{ lookup(\u0027env\u0027,\u0027HOME\u0027)/tempest}}\""},{"line_number":255,"context_line":"source_credentails_command: \"\""},{"line_number":256,"context_line":"tempest_config_file: \"{{ tempest_dir }}/etc/tempest.conf\""},{"line_number":257,"context_line":"tempest_non_admin: False"},{"line_number":258,"context_line":"tempest_accounts_file: \"\""},{"line_number":259,"context_line":"tempest_deployer_input_file: \"\""},{"line_number":260,"context_line":"tempest_external_network: \"\""},{"line_number":261,"context_line":"tempest_image: \"\""},{"line_number":262,"context_line":"tempest_cloud_name: \"\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_973330ab","line":259,"range":{"start_line":257,"start_character":0,"end_line":259,"end_character":31},"updated":"2018-08-16 08:40:14.000000000","message":"what are those variables? We are using the defaults/main.yml comment to document what our roles do, I think it would be a good idea to follow that pattern.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":257,"context_line":"tempest_non_admin: False"},{"line_number":258,"context_line":"tempest_accounts_file: \"\""},{"line_number":259,"context_line":"tempest_deployer_input_file: \"\""},{"line_number":260,"context_line":"tempest_external_network: \"\""},{"line_number":261,"context_line":"tempest_image: \"\""},{"line_number":262,"context_line":"tempest_cloud_name: \"\""},{"line_number":263,"context_line":"tempest_create_account_file: False"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_57291834","line":260,"range":{"start_line":260,"start_character":0,"end_line":260,"end_character":28},"updated":"2018-08-16 08:40:14.000000000","message":"Isn\u0027t this: tempest_public_net_name ?","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":258,"context_line":"tempest_accounts_file: \"\""},{"line_number":259,"context_line":"tempest_deployer_input_file: \"\""},{"line_number":260,"context_line":"tempest_external_network: \"\""},{"line_number":261,"context_line":"tempest_image: \"\""},{"line_number":262,"context_line":"tempest_cloud_name: \"\""},{"line_number":263,"context_line":"tempest_create_account_file: False"},{"line_number":264,"context_line":"tempest_conf_removal: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d76688bb","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":17},"updated":"2018-08-16 08:40:14.000000000","message":"tempest images are already above.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":259,"context_line":"tempest_deployer_input_file: \"\""},{"line_number":260,"context_line":"tempest_external_network: \"\""},{"line_number":261,"context_line":"tempest_image: \"\""},{"line_number":262,"context_line":"tempest_cloud_name: \"\""},{"line_number":263,"context_line":"tempest_create_account_file: False"},{"line_number":264,"context_line":"tempest_conf_removal: {}"},{"line_number":265,"context_line":"tempest_extra_config: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_57103800","line":262,"range":{"start_line":262,"start_character":20,"end_line":262,"end_character":22},"updated":"2018-08-16 08:40:14.000000000","message":"this should probably be filled in with \"default\"","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":260,"context_line":"tempest_external_network: \"\""},{"line_number":261,"context_line":"tempest_image: \"\""},{"line_number":262,"context_line":"tempest_cloud_name: \"\""},{"line_number":263,"context_line":"tempest_create_account_file: False"},{"line_number":264,"context_line":"tempest_conf_removal: {}"},{"line_number":265,"context_line":"tempest_extra_config: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_77d5341b","line":263,"range":{"start_line":263,"start_character":0,"end_line":263,"end_character":34},"updated":"2018-08-16 08:40:14.000000000","message":"isn\u0027t that what tempest_users already achieves?","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bb6c85f91c5b728871c69b53fb0c7836d36a32d7","unresolved":false,"context_lines":[{"line_number":260,"context_line":"tempest_external_network: \"\""},{"line_number":261,"context_line":"tempest_image: \"\""},{"line_number":262,"context_line":"tempest_cloud_name: \"\""},{"line_number":263,"context_line":"tempest_create_account_file: False"},{"line_number":264,"context_line":"tempest_conf_removal: {}"},{"line_number":265,"context_line":"tempest_extra_config: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_a64a56a9","line":263,"range":{"start_line":263,"start_character":0,"end_line":263,"end_character":34},"in_reply_to":"3f79a3b5_77d5341b","updated":"2018-08-21 15:57:50.000000000","message":"It is related to python-tempestconf tool where user can generate accounts.yaml file which can be used while ruuning tempest tests as well as for refstack tests","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b0e8fde6b5556ad454a7a9882c0b723e64e14e72","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# set the tempest_install_method to source or distro"},{"line_number":21,"context_line":"# on choosing source it will install from git or venv"},{"line_number":22,"context_line":"# on choosing distro it will install based on distribution"},{"line_number":23,"context_line":"tempest_install_method: \"{{ tempest_install_method | default(\u0027source\u0027) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Set the package install state for distribution and pip packages"},{"line_number":26,"context_line":"# # Options are \u0027present\u0027 and \u0027latest\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_7ea1ac94","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":74},"updated":"2018-10-03 09:38:20.000000000","message":"This can simply be set to:\n\ntempest_install_method: \"source\"\n\nIt is already a default, and it cannot get a value from itself.","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da60792bfd9e7d8a6b282fd53e709d68bda6ef0e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# set the tempest_install_method to source or distro"},{"line_number":21,"context_line":"# on choosing source it will install from git or venv"},{"line_number":22,"context_line":"# on choosing distro it will install based on distribution"},{"line_number":23,"context_line":"tempest_install_method: \"{{ tempest_install_method | default(\u0027source\u0027) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Set the package install state for distribution and pip packages"},{"line_number":26,"context_line":"# # Options are \u0027present\u0027 and \u0027latest\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_7ed9acf1","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":74},"in_reply_to":"3f79a3b5_7ea1ac94","updated":"2018-10-03 09:56:52.000000000","message":"Done","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b0e8fde6b5556ad454a7a9882c0b723e64e14e72","unresolved":false,"context_lines":[{"line_number":82,"context_line":"tempest_plugins: \"{{ _tempest_plugins[\u0027keystone\u0027] + _tempest_plugins[\u0027cinder\u0027] + _tempest_plugins[\u0027heat\u0027] + _tempest_plugins[\u0027neutron\u0027] }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# tempest_workspace where tempest can be runned"},{"line_number":85,"context_line":"tempest_workspace: \"{{ tempest_workspace | default(\u0027{{ tempest_venv_bin | dirname }}/workspace\u0027)}}\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The location where the test whitelist/blacklist will be placed"},{"line_number":88,"context_line":"tempest_test_whitelist_file_path: \"{{ tempest_workspace }}/etc/tempest_whitelist.txt\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_5ebb90bc","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":99},"updated":"2018-10-03 09:38:20.000000000","message":"This is already a default, so this should be written as:\n\ntempest_workspace: \"{{ tempest_venv_bin | dirname }}/workspace }}\"","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da60792bfd9e7d8a6b282fd53e709d68bda6ef0e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"tempest_plugins: \"{{ _tempest_plugins[\u0027keystone\u0027] + _tempest_plugins[\u0027cinder\u0027] + _tempest_plugins[\u0027heat\u0027] + _tempest_plugins[\u0027neutron\u0027] }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# tempest_workspace where tempest can be runned"},{"line_number":85,"context_line":"tempest_workspace: \"{{ tempest_workspace | default(\u0027{{ tempest_venv_bin | dirname }}/workspace\u0027)}}\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The location where the test whitelist/blacklist will be placed"},{"line_number":88,"context_line":"tempest_test_whitelist_file_path: \"{{ tempest_workspace }}/etc/tempest_whitelist.txt\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_bee424a9","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":99},"in_reply_to":"3f79a3b5_5ebb90bc","updated":"2018-10-03 09:56:52.000000000","message":"Done","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"70fa9e3a94907c06430d8d6f23f319d64d9cad22","unresolved":false,"context_lines":[{"line_number":82,"context_line":"tempest_plugins: \"{{ _tempest_plugins[\u0027keystone\u0027] + _tempest_plugins[\u0027cinder\u0027] + _tempest_plugins[\u0027heat\u0027] + _tempest_plugins[\u0027neutron\u0027] }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# tempest_workspace where tempest can be runned"},{"line_number":85,"context_line":"tempest_workspace: \"{{ tempest_venv_bin | dirname }}/workspace }}\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The location where the test whitelist/blacklist will be placed"},{"line_number":88,"context_line":"tempest_test_whitelist_file_path: \"{{ tempest_workspace }}/etc/tempest_whitelist.txt\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_e790e198","line":85,"range":{"start_line":85,"start_character":62,"end_line":85,"end_character":65},"updated":"2018-10-15 09:07:19.000000000","message":"you can remove that.","commit_id":"003f24977228b36a208cd2b314fd7ba58d20474c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"tempest_plugins: \"{{ _tempest_plugins[\u0027keystone\u0027] + _tempest_plugins[\u0027cinder\u0027] + _tempest_plugins[\u0027heat\u0027] + _tempest_plugins[\u0027neutron\u0027] }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# tempest_workspace where tempest can be runned"},{"line_number":85,"context_line":"tempest_workspace: \"{{ tempest_venv_bin | dirname }}/workspace\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The location where the test whitelist/blacklist will be placed"},{"line_number":88,"context_line":"tempest_test_whitelist_file_path: \"{{ tempest_workspace }}/etc/tempest_whitelist.txt\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_99ef66b1","line":85,"updated":"2018-10-23 10:25:12.000000000","message":"In previous patch sets, the tempest workspace was set to be located in the user\u0027s home directory for distro installs. I see that\u0027s no longer the case. Why is that?","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"058c430fa043b06e0f95ec53faec5c2ddc1f13c3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"tempest_plugins: \"{{ _tempest_plugins[\u0027keystone\u0027] + _tempest_plugins[\u0027cinder\u0027] + _tempest_plugins[\u0027heat\u0027] + _tempest_plugins[\u0027neutron\u0027] }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# tempest_workspace where tempest can be runned"},{"line_number":85,"context_line":"tempest_workspace: \"{{ tempest_venv_bin | dirname }}/workspace\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The location where the test whitelist/blacklist will be placed"},{"line_number":88,"context_line":"tempest_test_whitelist_file_path: \"{{ tempest_workspace }}/etc/tempest_whitelist.txt\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_bc1c9066","line":85,"in_reply_to":"3f79a3b5_99ef66b1","updated":"2018-10-23 11:11:12.000000000","message":"Sorry, it gets carried from this review https://review.openstack.org/#/c/591424/6/defaults/main.yml@85 we set it and got it, updating it to {{ ansible_env.HOME }} as suggested in tempest_post_install.yml thanks for pointing it, it makes more sense.","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3b1bfa526503ea19d2cd9eeab77a7dbeeed20f22","unresolved":false,"context_lines":[{"line_number":82,"context_line":"tempest_plugins: \"{{ _tempest_plugins[\u0027keystone\u0027] + _tempest_plugins[\u0027cinder\u0027] + _tempest_plugins[\u0027heat\u0027] + _tempest_plugins[\u0027neutron\u0027] }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# tempest_workspace where tempest can be runned"},{"line_number":85,"context_line":"tempest_workspace: \"{{ ansible_env.HOME | dirname }}/workspace\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The location where the test whitelist/blacklist will be placed"},{"line_number":88,"context_line":"tempest_test_whitelist_file_path: \"{{ tempest_workspace }}/etc/tempest_whitelist.txt\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"3f79a3b5_4f126057","line":85,"range":{"start_line":85,"start_character":23,"end_line":85,"end_character":49},"updated":"2018-10-23 11:32:45.000000000","message":"I think you\u0027re looking for just \u0027ansible_env.HOME\u0027 here?\n\nif ansible_env.HOME \u003d /home/zuul, then what you have now will put it into /home, whereas I think you want it in /home/zuul?","commit_id":"b5a08b996b64dc4aa5aba3233e6ed3710c8c44ef"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1626c70b5c9e0549c1c6cb6efe7537a5251aa917","unresolved":false,"context_lines":[{"line_number":82,"context_line":"tempest_plugins: \"{{ _tempest_plugins[\u0027keystone\u0027] + _tempest_plugins[\u0027cinder\u0027] + _tempest_plugins[\u0027heat\u0027] + _tempest_plugins[\u0027neutron\u0027] }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# tempest_workspace where tempest can be runned"},{"line_number":85,"context_line":"tempest_workspace: \"{{ ansible_env.HOME | dirname }}/workspace\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The location where the test whitelist/blacklist will be placed"},{"line_number":88,"context_line":"tempest_test_whitelist_file_path: \"{{ tempest_workspace }}/etc/tempest_whitelist.txt\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"3f79a3b5_0fe78847","line":85,"range":{"start_line":85,"start_character":23,"end_line":85,"end_character":49},"in_reply_to":"3f79a3b5_4f126057","updated":"2018-10-23 12:07:34.000000000","message":"Nope, we need a separate directory all together for tempest which will be /home/zuul/workspace.","commit_id":"b5a08b996b64dc4aa5aba3233e6ed3710c8c44ef"}],"releasenotes/notes/add-support-for-distro-89611067ce74fc2c.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    It has now suppport for installing tempest and it\u0027s plugin from distribution"},{"line_number":5,"context_line":"    packages."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_9931a6f1","line":2,"updated":"2018-10-23 10:25:12.000000000","message":"The two items here will be published in the context of the role and the context of the integrated build among many other roles - so please ensure that each item distinctly indicates the service/role the release note is for. Also, each note may not be published immediately following the other, so do not assume one item will follow the second.\n\nI\u0027d suggest this as a simpler release note:\n\nThe ``os_tempest`` role now has the ability to install from distribution packages by setting ``tempest_install_method`` to ``distro``. The new variable ``tempest_workspace`` has been introduced to set the location of the tempest workspace.","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"058c430fa043b06e0f95ec53faec5c2ddc1f13c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    It has now suppport for installing tempest and it\u0027s plugin from distribution"},{"line_number":5,"context_line":"    packages."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_1c826452","line":2,"in_reply_to":"3f79a3b5_9931a6f1","updated":"2018-10-23 11:11:12.000000000","message":"Done","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d1f8079e71cbfdc03dac11020f38c19efb6fb083","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    The new variable ``tempest_workspace`` has been introduced to set the location of the tempest"},{"line_number":8,"context_line":"    workspace."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The final location of tempest configuration is in `/etc/tempest/tempest.conf` rather then"},{"line_number":11,"context_line":"    tempest workspace."}],"source_content_type":"text/x-yaml","patch_set":45,"id":"3f79a3b5_74001200","line":11,"range":{"start_line":10,"start_character":4,"end_line":11,"end_character":22},"updated":"2018-10-25 14:22:11.000000000","message":"Suggestion:\n\nupgrade:\n  - |\n    The default location of the default tempest configuration is now ``/etc/tempest/tempest.conf`` rather than the previous default of ``$HOME/.tempest/etc``.","commit_id":"a2bd138f0789af9bb5cc305635feaf6c515de00d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d5434167eeff6db63ab6d04d9f72297dece92102","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    The new variable ``tempest_workspace`` has been introduced to set the location of the tempest"},{"line_number":8,"context_line":"    workspace."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The default location of the default tempest configuration is now ``/etc/tempest/tempest.conf``"},{"line_number":11,"context_line":"    rather than the previous default of ``$HOME/.tempest/etc``."}],"source_content_type":"text/x-yaml","patch_set":46,"id":"3f79a3b5_9424ce60","line":10,"range":{"start_line":10,"start_character":96,"end_line":10,"end_character":97},"updated":"2018-10-25 14:31:33.000000000","message":"This needs to be double-back-ticks. ie ``","commit_id":"385042b580d4a0220cf47d25dfaa5e5ca7e81675"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"994008837ae73bfb31044c5159216212d7e2a574","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    The new variable ``tempest_workspace`` has been introduced to set the location of the tempest"},{"line_number":8,"context_line":"    workspace."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The default location of the default tempest configuration is now ``/etc/tempest/tempest.conf``"},{"line_number":11,"context_line":"    rather than the previous default of ``$HOME/.tempest/etc``."}],"source_content_type":"text/x-yaml","patch_set":46,"id":"3f79a3b5_b71469a0","line":10,"range":{"start_line":10,"start_character":96,"end_line":10,"end_character":97},"in_reply_to":"3f79a3b5_9424ce60","updated":"2018-10-25 17:00:22.000000000","message":"I think it is already there ``/etc/tempest/tempest.conf``","commit_id":"385042b580d4a0220cf47d25dfaa5e5ca7e81675"}],"setup.cfg":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    Operating System :: POSIX :: Linux"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[files]"},{"line_number":16,"context_line":"data_files \u003d"},{"line_number":17,"context_line":"    usr/local/share/ansible/roles/tempest/defaults \u003d defaults/*"},{"line_number":18,"context_line":"    usr/local/share/ansible/roles/tempest/meta \u003d meta/*"},{"line_number":19,"context_line":"    usr/local/share/ansible/roles/tempest/tasks \u003d tasks/*"},{"line_number":20,"context_line":"    usr/local/share/ansible/roles/tempest/templates \u003d templates/*"},{"line_number":21,"context_line":"    usr/local/share/ansible/roles/tempest/files \u003d files/*"},{"line_number":22,"context_line":"    usr/local/share/ansible/roles/tempest/vars \u003d vars/*"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[build_sphinx]"},{"line_number":25,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"3f79a3b5_b7ee6cea","line":22,"range":{"start_line":16,"start_character":0,"end_line":22,"end_character":55},"updated":"2018-08-16 08:40:14.000000000","message":"could you explain why this is needed, in the commit message?","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"}],"tasks/config/tempestconf.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  template:"},{"line_number":17,"context_line":"    src: \u0027generate-tempestconf.sh.j2\u0027"},{"line_number":18,"context_line":"    dest: \u0027{{ tempest_dir }}/generate-tempestconf.sh\u0027"},{"line_number":19,"context_line":"  when: generate_tempestconf is True"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Generate tempest.conf using python-tempestconf"},{"line_number":22,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d7c20853","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":36},"updated":"2018-08-16 08:40:14.000000000","message":"generate_tempestconf can be user provided, and therefore there should be some input validation.\nPlease replace this with:\ngenerate_tempestconf | bool","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"}],"tasks/install/distro.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b0e8fde6b5556ad454a7a9882c0b723e64e14e72","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  package:"},{"line_number":17,"context_line":"    name: \"{{ tempest_package_list }}\""},{"line_number":18,"context_line":"    state: \"{{ tempest_package_state }}\""},{"line_number":19,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027, \u0027yum\u0027, \u0027dnf\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":20,"context_line":"    register: install_tempest_packages"},{"line_number":21,"context_line":"    until: install_tempest_packages is success"},{"line_number":22,"context_line":"    retries: 5"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_deb32008","line":19,"range":{"start_line":19,"start_character":58,"end_line":19,"end_character":72},"updated":"2018-10-03 09:38:20.000000000","message":"remove these: update_cache is only a valid option for apt \u0026 zypper, not yum/dnf.","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da60792bfd9e7d8a6b282fd53e709d68bda6ef0e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  package:"},{"line_number":17,"context_line":"    name: \"{{ tempest_package_list }}\""},{"line_number":18,"context_line":"    state: \"{{ tempest_package_state }}\""},{"line_number":19,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027, \u0027yum\u0027, \u0027dnf\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":20,"context_line":"    register: install_tempest_packages"},{"line_number":21,"context_line":"    until: install_tempest_packages is success"},{"line_number":22,"context_line":"    retries: 5"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_d96d7acb","line":19,"range":{"start_line":19,"start_character":58,"end_line":19,"end_character":72},"in_reply_to":"3f79a3b5_deb32008","updated":"2018-10-03 09:56:52.000000000","message":"Done","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b0e8fde6b5556ad454a7a9882c0b723e64e14e72","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  package:"},{"line_number":28,"context_line":"    name: \"{{ tempest_plugins_list }}\""},{"line_number":29,"context_line":"    state: \"{{ tempest_plugins_state }}\""},{"line_number":30,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027, \u0027yum\u0027, \u0027dnf\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":31,"context_line":"    register: install_tempest_plugins"},{"line_number":32,"context_line":"    until: install_tempest_plugins is success"},{"line_number":33,"context_line":"    retries: 5"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_9ec9287a","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":72},"updated":"2018-10-03 09:38:20.000000000","message":"remove these: update_cache is only a valid option for apt \u0026 zypper, not yum/dnf.","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da60792bfd9e7d8a6b282fd53e709d68bda6ef0e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  package:"},{"line_number":28,"context_line":"    name: \"{{ tempest_plugins_list }}\""},{"line_number":29,"context_line":"    state: \"{{ tempest_plugins_state }}\""},{"line_number":30,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027, \u0027yum\u0027, \u0027dnf\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":31,"context_line":"    register: install_tempest_plugins"},{"line_number":32,"context_line":"    until: install_tempest_plugins is success"},{"line_number":33,"context_line":"    retries: 5"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_7968e6b8","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":72},"in_reply_to":"3f79a3b5_9ec9287a","updated":"2018-10-03 09:56:52.000000000","message":"Done","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"63fe55c0203431699028720ee15cc1f82301579a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  package:"},{"line_number":17,"context_line":"    name: \"{{ tempest_package_list }}\""},{"line_number":18,"context_line":"    state: \"{{ tempest_package_state }}\""},{"line_number":19,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027, \u0027yum\u0027, \u0027dnf\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":20,"context_line":"    register: install_tempest_packages"},{"line_number":21,"context_line":"    until: install_tempest_packages is success"},{"line_number":22,"context_line":"    retries: 5"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_682b367b","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":101},"updated":"2018-10-03 07:40:58.000000000","message":"This should be\n\nupdate_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\"\n\nThe update_cache parameter is not usable for the other package managers","commit_id":"651eb1eabc3e9a47643098b47a45415405a70e23"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"63fe55c0203431699028720ee15cc1f82301579a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  package:"},{"line_number":28,"context_line":"    name: \"{{ tempest_plugins_list }}\""},{"line_number":29,"context_line":"    state: \"{{ tempest_plugins_state }}\""},{"line_number":30,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027, \u0027yum\u0027, \u0027dnf\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":31,"context_line":"    register: install_tempest_plugins"},{"line_number":32,"context_line":"    until: install_tempest_plugins is success"},{"line_number":33,"context_line":"    retries: 5"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_284f7e6a","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":101},"updated":"2018-10-03 07:40:58.000000000","message":"as above","commit_id":"651eb1eabc3e9a47643098b47a45415405a70e23"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"d5e5e0001d8e33838fde9a4294089eb147676bc3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":20,"context_line":"    cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(cache_timeout, omit) }}\""},{"line_number":21,"context_line":"    register: install_tempest_packages"},{"line_number":22,"context_line":"    until: install_tempest_packages is success"},{"line_number":23,"context_line":"    retries: 5"},{"line_number":24,"context_line":"    delay: 2"},{"line_number":25,"context_line":"    become: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_536dc296","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":16},"updated":"2018-10-03 13:40:58.000000000","message":"you need something like: https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/nova_install.yml#L35-L46","commit_id":"f4cc3d8b229f1d789cb6fe062d0f127fee8446a6"}],"tasks/install/rpm.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"---"},{"line_number":15,"context_line":"- name: Install openstack tempest"},{"line_number":16,"context_line":"  package:"},{"line_number":17,"context_line":"    name: openstack-tempest"},{"line_number":18,"context_line":"    state: present"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Install python-tempestconf"},{"line_number":22,"context_line":"  package:"},{"line_number":23,"context_line":"    name: python-tempestconf"},{"line_number":24,"context_line":"    state: present"},{"line_number":25,"context_line":"  become: true"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Install openstack services tempest plugins"},{"line_number":28,"context_line":"  yum: state\u003dlatest name\u003d{{ item }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d7a528a0","line":25,"range":{"start_line":17,"start_character":0,"end_line":25,"end_character":14},"updated":"2018-08-16 08:40:14.000000000","message":"you should give both as a list for faster deploys.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  become: true"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Install openstack services tempest plugins"},{"line_number":28,"context_line":"  yum: state\u003dlatest name\u003d{{ item }}"},{"line_number":29,"context_line":"  with_items: \"{{ tempest_plugins_rpm }}\""},{"line_number":30,"context_line":"  become: yes"},{"line_number":31,"context_line":"  when: tempest_plugins|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d7be88ac","line":28,"range":{"start_line":28,"start_character":7,"end_line":28,"end_character":35},"updated":"2018-08-16 08:40:14.000000000","message":"please write those in YAML format, and pass it as a list, that you append on previous task.\n\nOn top of this, it seems very much redhat dependant, and not rpm dependant. Package should do the trick.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Install openstack services tempest plugins"},{"line_number":28,"context_line":"  yum: state\u003dlatest name\u003d{{ item }}"},{"line_number":29,"context_line":"  with_items: \"{{ tempest_plugins_rpm }}\""},{"line_number":30,"context_line":"  become: yes"},{"line_number":31,"context_line":"  when: tempest_plugins|length \u003e 0"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_77df740c","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":37},"updated":"2018-08-16 08:40:14.000000000","message":"We already have a list of distro packages to install.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"b07a42b145d3647a0eb90df23f39038ef88ae4e3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Install openstack services tempest plugins"},{"line_number":28,"context_line":"  yum: state\u003dlatest name\u003d{{ item }}"},{"line_number":29,"context_line":"  with_items: \"{{ tempest_plugins_rpm }}\""},{"line_number":30,"context_line":"  become: yes"},{"line_number":31,"context_line":"  when: tempest_plugins|length \u003e 0"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_e4536d38","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":37},"in_reply_to":"3f79a3b5_77df740c","updated":"2018-08-21 13:27:56.000000000","message":"Mostly of tempest plugins are set their values to True when it is installed, and if we don\u0027t explicitly set it to False in tempest.conf the default value is to run it, and so it will fail, this here is required exactly for this purpose, speaking specifically about tripleo, where we have several scenarios, running different services, we only install the plugin needed for that particular scenario.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Set tempest init command"},{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"      tempest_init: \"tempest init {{ tempest_dir }}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Set tempestconf call"},{"line_number":38,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_f7d2a4ff","line":35,"range":{"start_line":35,"start_character":3,"end_line":35,"end_character":5},"updated":"2018-08-16 08:40:14.000000000","message":"extra two spaces.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Set tempest init command"},{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"      tempest_init: \"tempest init {{ tempest_dir }}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Set tempestconf call"},{"line_number":38,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d7d3e8ff","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":28},"updated":"2018-08-16 08:40:14.000000000","message":"the path to tempest is relative, and should be absolute if rpms are distributed in a venv way.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Set tempestconf call"},{"line_number":38,"context_line":"  set_fact:"},{"line_number":39,"context_line":"      tempestconf: \"/usr/bin/discover-tempest-config\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_37fedc6a","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":6},"updated":"2018-08-16 08:40:14.000000000","message":"extra two spaces","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Set tempestconf call"},{"line_number":38,"context_line":"  set_fact:"},{"line_number":39,"context_line":"      tempestconf: \"/usr/bin/discover-tempest-config\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_b7f18c97","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":53},"updated":"2018-08-16 08:40:14.000000000","message":"what is discover-tempest-config? Sorry for my lack of knowledge there, but is that an rpm command that would work on SUSE?","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"b07a42b145d3647a0eb90df23f39038ef88ae4e3","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Set tempestconf call"},{"line_number":38,"context_line":"  set_fact:"},{"line_number":39,"context_line":"      tempestconf: \"/usr/bin/discover-tempest-config\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_1f0d9234","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":53},"in_reply_to":"3f79a3b5_b7f18c97","updated":"2018-08-21 13:27:56.000000000","message":"discover-tempest-config is a tool that will write the tempest.conf based on discoverable services, it\u0027s under openstack/python-tempestconf, and yes, it can work on SUSE, it\u0027s a pure python program relying on openstack discover behavior, right now we can discover and proper configure volume, identity, image, object-storage, etc, only with the credentials you want tempest to use.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"}],"tasks/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    - tempest-run"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- include: tempest_config.yml"},{"line_number":48,"context_line":"  when: tempest_run | bool and generate_tempestconfig | bool"},{"line_number":49,"context_line":"  tags:"},{"line_number":50,"context_line":"    - tempest-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_37333c64","line":49,"range":{"start_line":48,"start_character":7,"end_line":49,"end_character":7},"updated":"2018-08-16 08:40:14.000000000","message":"that is probably the equivalent tempest_install and tempest_resources, and should probably be done before the run.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"b07a42b145d3647a0eb90df23f39038ef88ae4e3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - tempest-config"},{"line_number":45,"context_line":"    - tempest-run"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- include: tempest_config.yml"},{"line_number":48,"context_line":"  when: tempest_run | bool and generate_tempestconfig | bool"},{"line_number":49,"context_line":"  tags:"},{"line_number":50,"context_line":"    - tempest-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_44d021ca","line":50,"range":{"start_line":46,"start_character":0,"end_line":50,"end_character":20},"updated":"2018-08-21 13:27:56.000000000","message":"If you want to use the tempest.conf generated by tempest_config.yml then this include must be before the tempest_run.yml include","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"642406c6f35d6d306f5de3743852dcace23ca9d9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - always"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- include_tasks: tempest_install.yml"},{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - tempest-install"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include_tasks: tempest_resources.yml"},{"line_number":33,"context_line":"  run_once: yes"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f79a3b5_d025995c","side":"PARENT","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"updated":"2018-10-11 12:48:21.000000000","message":"This task must still remain.","commit_id":"099c74902ffb16e77ef38b8ba35e03782fd1461a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"642406c6f35d6d306f5de3743852dcace23ca9d9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - always"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Gather variables for installation method"},{"line_number":29,"context_line":"  include_vars: \"install/{{ tempest_install_method }}.yml\""},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    - always"},{"line_number":32,"context_line":"    - tempest-install"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f79a3b5_f02a152d","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":24},"updated":"2018-10-11 12:48:21.000000000","message":"This should be \u0027vars\u0027 because you\u0027re including vars, not tasks.","commit_id":"8099fafd6a63e167087e3388b46e9c3fab371c22"}],"tasks/tempest_config.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"---"},{"line_number":15,"context_line":"- include: \"config/tempestconf.yaml\""},{"line_number":16,"context_line":"  when: generate_tempestconf is True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d741a8a7","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":36},"updated":"2018-08-16 08:40:14.000000000","message":"| bool","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"}],"tasks/tempest_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_37581cf8","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":25},"updated":"2018-08-16 08:40:14.000000000","message":"nit: I think you need to add a line, not replace it.","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8e131e2edc762dba3f32affc769a5a7517dbd2bf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"- include: \"install/{{ tempest_install_method }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_52468e52","line":16,"updated":"2018-10-10 10:50:02.000000000","message":"The \u0027distro\u0027 and \u0027source\u0027 builds share a single task which is to install distribution packages. As is done in https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/nova_install.yml#L35-L50 it would be better to apply the same here.","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b2fa6b5a6bbbfb2406b0acab92eecc84b642dfa8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"- include: \"install/{{ tempest_install_method }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_7977db3c","line":16,"in_reply_to":"3f79a3b5_52468e52","updated":"2018-10-11 06:50:02.000000000","message":"Done","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f7c9430702aadd4255de8ceaa9c0a302db8240f5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  include_tasks: install/source.yml"},{"line_number":18,"context_line":"  when: nova_install_method \u003d\u003d \u0027source\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Install Tempest packages from distro"},{"line_number":21,"context_line":"  include_tasks: install/distro.yml"},{"line_number":22,"context_line":"  when: nova_install_method \u003d\u003d \u0027distro\u0027"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_506d0965","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":39},"updated":"2018-10-11 12:53:22.000000000","message":"This, and the related file, is unnecessary. Add the contents of the file above the task above because both source and distro installs need to install packages.","commit_id":"579a93ffe3404fa3f70850b5edc03ec4d8028d1d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d0d8041bef5edd10548ac7c8f2ef85d59e6909e5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  retries: 5"},{"line_number":126,"context_line":"  delay: 2"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"- name: Install OpenStack Tempest and it\u0027s plugins"},{"line_number":129,"context_line":"  package:"},{"line_number":130,"context_line":"    name: \"{{ tempest_package_list }}\""},{"line_number":131,"context_line":"    state: \"{{ tempest_package_state }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_bc78e5c1","line":128,"updated":"2018-10-12 07:59:00.000000000","message":"This task should remain in this file, but at the top. The rest of the tasks in this file should be moved into tempest_install_source.yml and be executed if tempest_install_method \u003d\u003d \u0027source\u0027. See the nova/keystone role for reference.","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  retries: 5"},{"line_number":126,"context_line":"  delay: 2"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"- name: Install OpenStack Tempest and it\u0027s plugins"},{"line_number":129,"context_line":"  package:"},{"line_number":130,"context_line":"    name: \"{{ tempest_package_list }}\""},{"line_number":131,"context_line":"    state: \"{{ tempest_package_state }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_c2e85ae1","line":128,"in_reply_to":"3f79a3b5_bc78e5c1","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"955fc42436780c09a07898c3e3750c4821ff1df0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    until: install_packages is success"},{"line_number":136,"context_line":"    retries: 5"},{"line_number":137,"context_line":"    delay: 2"},{"line_number":138,"context_line":"  when: tempest_install_method \u003d\u003d \u0027distro\u0027"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_fc5bbd51","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":42},"updated":"2018-10-12 07:59:54.000000000","message":"If the above is done, this will be unnecessary because all install types must install the list of packages given.","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    until: install_packages is success"},{"line_number":136,"context_line":"    retries: 5"},{"line_number":137,"context_line":"    delay: 2"},{"line_number":138,"context_line":"  when: tempest_install_method \u003d\u003d \u0027distro\u0027"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_e2e55608","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":42},"in_reply_to":"3f79a3b5_fc5bbd51","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"343b8240d0eb8afe0a0cf93362800f58f0809bd6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install OpenStack Tempest and it\u0027s plugins"},{"line_number":18,"context_line":"  package:"},{"line_number":19,"context_line":"    name: \"{{ tempest_package_list }}\""},{"line_number":20,"context_line":"    state: \"{{ tempest_package_state }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f79a3b5_2207ce1f","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":50},"updated":"2018-10-12 09:37:52.000000000","message":"Given that this task is used to install distro packages for source and non-source builds, rather use the more generic \"Install distro packages\".","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee5da8629d5b93d4e93fcef899b1a142229c48f5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install OpenStack Tempest and it\u0027s plugins"},{"line_number":18,"context_line":"  package:"},{"line_number":19,"context_line":"    name: \"{{ tempest_package_list }}\""},{"line_number":20,"context_line":"    state: \"{{ tempest_package_state }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f79a3b5_9d0643cd","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":50},"in_reply_to":"3f79a3b5_2207ce1f","updated":"2018-10-12 09:53:55.000000000","message":"Done","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a788700452577dc3c16788fd2e96ec2ac2abb9ab","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    state: \"{{ tempest_package_state }}\""},{"line_number":21,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":22,"context_line":"    cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(cache_timeout, omit) }}\""},{"line_number":23,"context_line":"    register: install_packages"},{"line_number":24,"context_line":"    until: install_packages is success"},{"line_number":25,"context_line":"    retries: 5"},{"line_number":26,"context_line":"    delay: 2"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Install Tempest packages from PIP"},{"line_number":29,"context_line":"  include_tasks: tempest_install_source.yml"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3f79a3b5_635e257a","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":12},"updated":"2018-10-12 13:36:16.000000000","message":"These need to be indented two spaces back. They are not module arguments, but task arguments.","commit_id":"962fa6de06bae909cdcbd137f3b232439ac5fae7"}],"tasks/tempest_install_source.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"343b8240d0eb8afe0a0cf93362800f58f0809bd6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    private: yes"},{"line_number":41,"context_line":"  vars:"},{"line_number":42,"context_line":"    venv_install_destination_path: \"{{ tempest_venv_bin | dirname }}\""},{"line_number":43,"context_line":"    venv_install_distro_package_list: \"{{ tempest_distro_packages }}\""},{"line_number":44,"context_line":"    venv_pip_install_args: \"{{ tempest_pip_install_args }}\""},{"line_number":45,"context_line":"    venv_pip_packages: \"{{ tempest_pip_packages }}\""},{"line_number":46,"context_line":"    venv_facts_when_changed:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f79a3b5_e2fc760e","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":69},"updated":"2018-10-12 09:37:52.000000000","message":"This line can be removed to prevent the same packages being installed again.","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee5da8629d5b93d4e93fcef899b1a142229c48f5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    private: yes"},{"line_number":41,"context_line":"  vars:"},{"line_number":42,"context_line":"    venv_install_destination_path: \"{{ tempest_venv_bin | dirname }}\""},{"line_number":43,"context_line":"    venv_install_distro_package_list: \"{{ tempest_distro_packages }}\""},{"line_number":44,"context_line":"    venv_pip_install_args: \"{{ tempest_pip_install_args }}\""},{"line_number":45,"context_line":"    venv_pip_packages: \"{{ tempest_pip_packages }}\""},{"line_number":46,"context_line":"    venv_facts_when_changed:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f79a3b5_1d6d5398","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":69},"in_reply_to":"3f79a3b5_e2fc760e","updated":"2018-10-12 09:53:55.000000000","message":"Done","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"}],"tasks/tempest_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b0e8fde6b5556ad454a7a9882c0b723e64e14e72","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    then"},{"line_number":42,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":"    tempest init {{ tempest_workspace }}"},{"line_number":45,"context_line":"    exit 3"},{"line_number":46,"context_line":"  args:"},{"line_number":47,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_9e77e83b","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":40},"updated":"2018-10-03 09:38:20.000000000","message":"What happens when this is run over an existing workspace?","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da60792bfd9e7d8a6b282fd53e709d68bda6ef0e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    then"},{"line_number":42,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":"    tempest init {{ tempest_workspace }}"},{"line_number":45,"context_line":"    exit 3"},{"line_number":46,"context_line":"  args:"},{"line_number":47,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_b96afeb1","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":40},"in_reply_to":"3f79a3b5_9e77e83b","updated":"2018-10-03 09:56:52.000000000","message":"correct, Fixing it.","commit_id":"1a73d3c2be067839643821b6d58bb9138c90dee3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8cb81215b1f43c4a21ba0fd2d01f657cf29680ca","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  shell: |"},{"line_number":40,"context_line":"    if [ ! -d {{ tempest_workspace}} ]"},{"line_number":41,"context_line":"    then"},{"line_number":42,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    exit 3"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_1cd479ba","line":42,"range":{"start_line":42,"start_character":6,"end_line":42,"end_character":39},"updated":"2018-10-12 07:56:09.000000000","message":"Should this have a conditional around it?\n\nif [ -d {{ tempest_venv_bin }} ]; then\n...\nfi","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  shell: |"},{"line_number":40,"context_line":"    if [ ! -d {{ tempest_workspace}} ]"},{"line_number":41,"context_line":"    then"},{"line_number":42,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    exit 3"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_a22c3e01","line":42,"range":{"start_line":42,"start_character":6,"end_line":42,"end_character":39},"in_reply_to":"3f79a3b5_1cd479ba","updated":"2018-10-12 09:29:42.000000000","message":"Here first we need to check whether a workspace exists or not, then we need to check whether for venv binary then perform operation.","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8cb81215b1f43c4a21ba0fd2d01f657cf29680ca","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    exit 3"},{"line_number":46,"context_line":"  args:"},{"line_number":47,"context_line":"    executable: /bin/bash"},{"line_number":48,"context_line":"  register: tempest_init_workspace"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_fc517d64","line":45,"updated":"2018-10-12 07:56:09.000000000","message":"This should remain inside the conditional as it should only exit with rc 3 if something changed.","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    exit 3"},{"line_number":46,"context_line":"  args:"},{"line_number":47,"context_line":"    executable: /bin/bash"},{"line_number":48,"context_line":"  register: tempest_init_workspace"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_c2405aa6","line":45,"in_reply_to":"3f79a3b5_fc517d64","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"343b8240d0eb8afe0a0cf93362800f58f0809bd6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"        fi"},{"line_number":44,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":45,"context_line":"      exit3"},{"line_number":46,"context_line":"    fi"},{"line_number":47,"context_line":"  args:"},{"line_number":48,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f79a3b5_e22316ba","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":11},"updated":"2018-10-12 09:37:52.000000000","message":"missing a space here","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee5da8629d5b93d4e93fcef899b1a142229c48f5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":43,"context_line":"        fi"},{"line_number":44,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":45,"context_line":"      exit3"},{"line_number":46,"context_line":"    fi"},{"line_number":47,"context_line":"  args:"},{"line_number":48,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f79a3b5_7d5c87ef","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":11},"in_reply_to":"3f79a3b5_e22316ba","updated":"2018-10-12 09:53:55.000000000","message":"Done","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    group: \"root\""},{"line_number":22,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":23,"context_line":"  with_items:"},{"line_number":24,"context_line":"    - path: \"{{ tempest_log_dir | realpath }}\""},{"line_number":25,"context_line":"    - path: \"{{ ansible_env.HOME }}/.tempest/etc\""},{"line_number":26,"context_line":"    - path: \"{{ tempest_image_dir }}\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_79cb6a4a","side":"PARENT","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":42},"updated":"2018-10-23 10:25:12.000000000","message":"This needs to stay as-is. Why is the realpath filter being removed?","commit_id":"9515183359c64e2d8132a7fc25e8e0187f68a8b5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"058c430fa043b06e0f95ec53faec5c2ddc1f13c3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    group: \"root\""},{"line_number":22,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":23,"context_line":"  with_items:"},{"line_number":24,"context_line":"    - path: \"{{ tempest_log_dir | realpath }}\""},{"line_number":25,"context_line":"    - path: \"{{ ansible_env.HOME }}/.tempest/etc\""},{"line_number":26,"context_line":"    - path: \"{{ tempest_image_dir }}\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_7cc0387e","side":"PARENT","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":42},"in_reply_to":"3f79a3b5_79cb6a4a","updated":"2018-10-23 11:11:12.000000000","message":"I am trying to check stestr result generation failure so removed but it doesnot work, adding it back.","commit_id":"9515183359c64e2d8132a7fc25e8e0187f68a8b5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    owner: \"root\""},{"line_number":22,"context_line":"    group: \"root\""},{"line_number":23,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":24,"context_line":"    recurse: yes"},{"line_number":25,"context_line":"  with_items:"},{"line_number":26,"context_line":"    - path: \"{{ tempest_log_dir }}\""},{"line_number":27,"context_line":"    - path: \"{{ tempest_image_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_5940ee32","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":16},"updated":"2018-10-23 10:25:12.000000000","message":"I don\u0027t think this is necessary? Why has this been added?","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"058c430fa043b06e0f95ec53faec5c2ddc1f13c3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    owner: \"root\""},{"line_number":22,"context_line":"    group: \"root\""},{"line_number":23,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":24,"context_line":"    recurse: yes"},{"line_number":25,"context_line":"  with_items:"},{"line_number":26,"context_line":"    - path: \"{{ tempest_log_dir }}\""},{"line_number":27,"context_line":"    - path: \"{{ tempest_image_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_fc5a08f3","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":16},"in_reply_to":"3f79a3b5_5940ee32","updated":"2018-10-23 11:11:12.000000000","message":"Earlier, I thought, it is not creating directory with in a directory so added, but later on discussing with on IRC, found that it is not needed, directory will do the mkdir -p \u003cdir tree\u003e do the job, it is not needed, removing","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    # don\u0027t trigger ANSIBLE0013"},{"line_number":48,"context_line":"    - skip_ansible_lint"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Copy tempest config"},{"line_number":51,"context_line":"  config_template:"},{"line_number":52,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":53,"context_line":"    dest: \"{{ tempest_workspace }}/etc/tempest.conf\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_b99fc2b1","line":50,"updated":"2018-10-23 10:25:12.000000000","message":"The purpose of this task was to put down a default tempest config, then \u0027tempest init\u0027 would copy that into the workspace. It looks like you\u0027re now using Ansible to put it into the workspace, and there is no default - this means any subsequent workspaces will have to be created and have the conf file copied over by hand. Is this intentional? I thought that you were going to put this into /etc/tempest/tempest.conf so that the same as previous behaviour would happen.","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1626c70b5c9e0549c1c6cb6efe7537a5251aa917","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    # don\u0027t trigger ANSIBLE0013"},{"line_number":48,"context_line":"    - skip_ansible_lint"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Copy tempest config"},{"line_number":51,"context_line":"  config_template:"},{"line_number":52,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":53,"context_line":"    dest: \"{{ tempest_workspace }}/etc/tempest.conf\""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_af08d47f","line":50,"in_reply_to":"3f79a3b5_b99fc2b1","updated":"2018-10-23 12:07:34.000000000","message":"So here is the thing going to happen, once doing tempest init workspace, it copies the default config /etc/tempest/tempest.conf to \u003cworkspace dir\u003e/etc/tempest.conf. So i will create a dir /etc/tempest then just call the copy tempest config task and then call tempest workspace creation task, then we have default tempest.conf used.","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3b1bfa526503ea19d2cd9eeab77a7dbeeed20f22","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # don\u0027t trigger ANSIBLE0013"},{"line_number":47,"context_line":"    - skip_ansible_lint"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Copy tempest config"},{"line_number":50,"context_line":"  config_template:"},{"line_number":51,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":52,"context_line":"    dest: \"{{ tempest_workspace }}/etc/tempest.conf\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"3f79a3b5_2f3044e9","line":49,"updated":"2018-10-23 11:32:45.000000000","message":"See question in PS39.","commit_id":"b5a08b996b64dc4aa5aba3233e6ed3710c8c44ef"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f4a1d687a068406efd5d71264253bb21516f140c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: Copy tempest config"},{"line_number":31,"context_line":"  config_template:"},{"line_number":32,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":33,"context_line":"    dest: \"/etc/tempest/tempest.conf\""},{"line_number":34,"context_line":"    owner: \"root\""},{"line_number":35,"context_line":"    group: \"root\""},{"line_number":36,"context_line":"    mode: \"0644\""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_602054f9","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":36},"updated":"2018-10-25 12:21:38.000000000","message":"could you document this change in the release notes?\nPeople are expected to know that their final tempest configuration is now in /etc/tempest rather than in workspace.","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"994008837ae73bfb31044c5159216212d7e2a574","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: Copy tempest config"},{"line_number":31,"context_line":"  config_template:"},{"line_number":32,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":33,"context_line":"    dest: \"/etc/tempest/tempest.conf\""},{"line_number":34,"context_line":"    owner: \"root\""},{"line_number":35,"context_line":"    group: \"root\""},{"line_number":36,"context_line":"    mode: \"0644\""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_e9bc4fb7","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":36},"in_reply_to":"3f79a3b5_602054f9","updated":"2018-10-25 17:00:22.000000000","message":"Done","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f4a1d687a068406efd5d71264253bb21516f140c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if [ -d {{ tempest_venv_bin }} ]; then"},{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":47,"context_line":"      exit 3"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_80c81020","line":46,"updated":"2018-10-25 12:21:38.000000000","message":"please add \u0027\u0026\u0026\u0027 before the exit 3.\n\nLet me explain:\n- I don\u0027t care if activate fails, if it\u0027s silenced fine for me.\n- I care if tempest init fails or succeeds. As this is the last line, knowing its return code is important.\n\nHowever in this case, should tempest init fail, the return code would be 3.","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8c0fbc5daa294ca6d12235bca033561d2a8b806a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if [ -d {{ tempest_venv_bin }} ]; then"},{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":47,"context_line":"      exit 3"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_c4bcd5dc","line":46,"in_reply_to":"3f79a3b5_44be8500","updated":"2018-10-25 15:53:01.000000000","message":"Oh really? Hmm, we may have some hidden bugs elsewhere in OSA then.","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f9d33930e0c20080cb52c10ed9c3efd1c453f0f2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if [ -d {{ tempest_venv_bin }} ]; then"},{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":47,"context_line":"      exit 3"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_e3ff8efd","line":46,"in_reply_to":"3f79a3b5_80c81020","updated":"2018-10-25 12:31:17.000000000","message":"If activate or unit fails the script will exit with RC\u003d1. Bash will not continue to execute to the next line.","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"994008837ae73bfb31044c5159216212d7e2a574","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if [ -d {{ tempest_venv_bin }} ]; then"},{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":47,"context_line":"      exit 3"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_c9063386","line":46,"in_reply_to":"3f79a3b5_e3ff8efd","updated":"2018-10-25 17:00:22.000000000","message":"Done","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"21b6788252b52f3f9fb70efaac9693b069255943","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if [ -d {{ tempest_venv_bin }} ]; then"},{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":47,"context_line":"      exit 3"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_44be8500","line":46,"in_reply_to":"3f79a3b5_e3ff8efd","updated":"2018-10-25 15:47:42.000000000","message":"it will, as no set -e is not present.\n\nSetting set -e is also fine for me.","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d1f8079e71cbfdc03dac11020f38c19efb6fb083","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"      tempest init {{ tempest_workspace }}"},{"line_number":47,"context_line":"      \u0026\u0026 exit 3"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"  args:"},{"line_number":50,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"3f79a3b5_3437fae6","line":47,"updated":"2018-10-25 14:22:11.000000000","message":"This makes no sense. Please revert to PS44.","commit_id":"a2bd138f0789af9bb5cc305635feaf6c515de00d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"74519da78ab64f2adcef5b7ff224224797e3fd2c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    config_type: \"ini\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Initialise tempest workspace"},{"line_number":41,"context_line":"  shell: |"},{"line_number":42,"context_line":"    if [ ! -d {{ tempest_workspace }}/etc ]; then"},{"line_number":43,"context_line":"        if [ -d {{ tempest_venv_bin }} ]; then"},{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"3f79a3b5_a49c3970","line":41,"updated":"2018-10-25 15:55:43.000000000","message":"At \u0027set -e\u0027 at the top of the script to ensure the script stops immediately on any error.","commit_id":"385042b580d4a0220cf47d25dfaa5e5ca7e81675"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"994008837ae73bfb31044c5159216212d7e2a574","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    config_type: \"ini\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Initialise tempest workspace"},{"line_number":41,"context_line":"  shell: |"},{"line_number":42,"context_line":"    if [ ! -d {{ tempest_workspace }}/etc ]; then"},{"line_number":43,"context_line":"        if [ -d {{ tempest_venv_bin }} ]; then"},{"line_number":44,"context_line":"            . {{ tempest_venv_bin }}/activate"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"3f79a3b5_577ab5ee","line":41,"in_reply_to":"3f79a3b5_a49c3970","updated":"2018-10-25 17:00:22.000000000","message":"Done","commit_id":"385042b580d4a0220cf47d25dfaa5e5ca7e81675"}],"tasks/tempest_run.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2f9310bf8b39349c79c1791a6eb8675d3182365","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- block:"},{"line_number":17,"context_line":"  - name: Execute tempest tests"},{"line_number":18,"context_line":"    shell: |"},{"line_number":19,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":20,"context_line":"      then"},{"line_number":21,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":22,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_ec0fc436","line":19,"updated":"2018-10-10 10:29:26.000000000","message":"I think the activation should be if tempest_venv_bin is present, not absent?","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"158662280e4a9093beef8a0bf239f4d9c403262a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- block:"},{"line_number":17,"context_line":"  - name: Execute tempest tests"},{"line_number":18,"context_line":"    shell: |"},{"line_number":19,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":20,"context_line":"      then"},{"line_number":21,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":22,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_92c18684","line":19,"in_reply_to":"3f79a3b5_ec0fc436","updated":"2018-10-10 10:39:57.000000000","message":"yes, you are correct, if tempest_venv_bin is present then activate, fixing it","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2f9310bf8b39349c79c1791a6eb8675d3182365","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # NOTE(mattt): At present we\u0027re not placing this file in a valid location"},{"line_number":39,"context_line":"    # to be used by the OpenStack Health dashboard."},{"line_number":40,"context_line":"    shell: |"},{"line_number":41,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":42,"context_line":"      then"},{"line_number":43,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":44,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_ac09cc32","line":41,"updated":"2018-10-10 10:29:26.000000000","message":"I think the activation should be if tempest_venv_bin is present, not absent?","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"158662280e4a9093beef8a0bf239f4d9c403262a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # NOTE(mattt): At present we\u0027re not placing this file in a valid location"},{"line_number":39,"context_line":"    # to be used by the OpenStack Health dashboard."},{"line_number":40,"context_line":"    shell: |"},{"line_number":41,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":42,"context_line":"      then"},{"line_number":43,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":44,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_b2bcc207","line":41,"in_reply_to":"3f79a3b5_ac09cc32","updated":"2018-10-10 10:39:57.000000000","message":"Done","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2f9310bf8b39349c79c1791a6eb8675d3182365","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  - name: Generate xml subunit results"},{"line_number":56,"context_line":"    shell: |"},{"line_number":57,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":58,"context_line":"      then"},{"line_number":59,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":60,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_8cfe5004","line":57,"updated":"2018-10-10 10:29:26.000000000","message":"I think the activation should be if tempest_venv_bin is present, not absent?","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"158662280e4a9093beef8a0bf239f4d9c403262a","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  - name: Generate xml subunit results"},{"line_number":56,"context_line":"    shell: |"},{"line_number":57,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":58,"context_line":"      then"},{"line_number":59,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":60,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_52bbee0d","line":57,"in_reply_to":"3f79a3b5_8cfe5004","updated":"2018-10-10 10:39:57.000000000","message":"Done","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2f9310bf8b39349c79c1791a6eb8675d3182365","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  - name: Generate html subunit results"},{"line_number":72,"context_line":"    shell: |"},{"line_number":73,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":74,"context_line":"      then"},{"line_number":75,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":76,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_12fb3615","line":73,"updated":"2018-10-10 10:29:26.000000000","message":"I think the activation should be if tempest_venv_bin is present, not absent?","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"158662280e4a9093beef8a0bf239f4d9c403262a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  - name: Generate html subunit results"},{"line_number":72,"context_line":"    shell: |"},{"line_number":73,"context_line":"      if [ ! -d {{ tempest_venv_bin }} ]"},{"line_number":74,"context_line":"      then"},{"line_number":75,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":76,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_72b62a28","line":73,"in_reply_to":"3f79a3b5_12fb3615","updated":"2018-10-10 10:39:57.000000000","message":"Done","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      then"},{"line_number":59,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":60,"context_line":"      fi"},{"line_number":61,"context_line":"      subunit2junitxml {{ tempest_log_dir }}/testrepository.subunit \u003e {{ tempest_log_dir }}/tempest_results.xml"},{"line_number":62,"context_line":"    args:"},{"line_number":63,"context_line":"      chdir: \"{{ tempest_workspace }}\""},{"line_number":64,"context_line":"      executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_79228a04","line":61,"updated":"2018-10-23 10:25:12.000000000","message":"For CentOS distro builds, the xml file is empty because of this error:\n\nhttp://logs.openstack.org/24/591424/39/check/openstack-ansible-functional-distro_install-centos-7/25dc0c2/logs/ara-report/result/b76a42da-3a4e-45d9-a2d6-1bc13aba51b4/","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"058c430fa043b06e0f95ec53faec5c2ddc1f13c3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      then"},{"line_number":59,"context_line":"      . {{ tempest_venv_bin }}/activate"},{"line_number":60,"context_line":"      fi"},{"line_number":61,"context_line":"      subunit2junitxml {{ tempest_log_dir }}/testrepository.subunit \u003e {{ tempest_log_dir }}/tempest_results.xml"},{"line_number":62,"context_line":"    args:"},{"line_number":63,"context_line":"      chdir: \"{{ tempest_workspace }}\""},{"line_number":64,"context_line":"      executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_fc252817","line":61,"in_reply_to":"3f79a3b5_79228a04","updated":"2018-10-23 11:11:12.000000000","message":"I need to install subunit-filters there","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"}],"templates/generate-tempestconf.sh.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"61ded837d364c6ca99a07ec82f3f8348026303b0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"export PATH\u003d$PATH:/usr/local/sbin:/usr/sbin"},{"line_number":16,"context_line":"printenv"},{"line_number":17,"context_line":"{{ source_credentials_commands }}"},{"line_number":18,"context_line":"{{ tempestconf }} --out {{ tempest_config_file }}"},{"line_number":19,"context_line":"--debug"},{"line_number":20,"context_line":"-v"},{"line_number":21,"context_line":"{% if not tempest_non_admin|bool %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_17c3a08a","line":18,"updated":"2018-08-16 08:40:14.000000000","message":"do we need \"\\\" on each end of line?","commit_id":"a80b425a6b0b2c1a8aceb20d70d82fea5a70847f"}],"tests/test-tempest-functional.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2a1fd46b16a18b11dd99eb5af01e3470c0e6b06c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          exit 1"},{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"      with_items: \"{{ tempest_plugins }}\""},{"line_number":31,"context_line":"      when: tempest_install_method \u003d\u003d \u0027source\u0027"},{"line_number":32,"context_line":"      tags:"},{"line_number":33,"context_line":"        - skip_ansible_lint"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":36,"id":"3f79a3b5_6f2651bc","line":31,"updated":"2018-10-22 15:42:28.000000000","message":"This variable is not defined outside of the role, so it will need a default value for this play.\n\n  when:\n    - tempest_install_method | default(\u0027source\u0027) \u003d\u003d \u0027source\u0027","commit_id":"03c202e769eff662dced98b0be04ca72c8a297d0"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f4a1d687a068406efd5d71264253bb21516f140c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"      with_items: \"{{ tempest_plugins }}\""},{"line_number":31,"context_line":"      when:"},{"line_number":32,"context_line":"       - tempest_install_method | default(\u0027source\u0027) \u003d\u003d \u0027source\u0027"},{"line_number":33,"context_line":"      tags:"},{"line_number":34,"context_line":"        - skip_ansible_lint"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_60d374d4","line":32,"range":{"start_line":32,"start_character":32,"end_line":32,"end_character":51},"updated":"2018-10-25 12:21:38.000000000","message":"tempest_install_method has a default already.","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f9d33930e0c20080cb52c10ed9c3efd1c453f0f2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"      with_items: \"{{ tempest_plugins }}\""},{"line_number":31,"context_line":"      when:"},{"line_number":32,"context_line":"       - tempest_install_method | default(\u0027source\u0027) \u003d\u003d \u0027source\u0027"},{"line_number":33,"context_line":"      tags:"},{"line_number":34,"context_line":"        - skip_ansible_lint"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3f79a3b5_a0374cfd","line":32,"range":{"start_line":32,"start_character":32,"end_line":32,"end_character":51},"in_reply_to":"3f79a3b5_60d374d4","updated":"2018-10-25 12:31:17.000000000","message":"Not in this play - only in the role defaults.","commit_id":"8773ea52309ac7afdc54b5348ddbe56dcbdbbcc3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5fb785d08e9033646b5325b10aebd561b136da1e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"      with_items: \"{{ tempest_plugins }}\""},{"line_number":31,"context_line":"      when:"},{"line_number":32,"context_line":"       - tempest_install_method | default(\u0027source\u0027) \u003d\u003d \u0027source\u0027"},{"line_number":33,"context_line":"      tags:"},{"line_number":34,"context_line":"        - skip_ansible_lint"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":47,"id":"3f79a3b5_539b9bc6","line":32,"range":{"start_line":32,"start_character":32,"end_line":32,"end_character":52},"updated":"2018-10-26 08:02:11.000000000","message":"you can still remove this one :)","commit_id":"b72b34b6ca4016200cfda7f7ededc57c5f1438da"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"185dea6905040d84242aa53bcb05f034daf9d8f6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"      with_items: \"{{ tempest_plugins }}\""},{"line_number":31,"context_line":"      when:"},{"line_number":32,"context_line":"       - tempest_install_method | default(\u0027source\u0027) \u003d\u003d \u0027source\u0027"},{"line_number":33,"context_line":"      tags:"},{"line_number":34,"context_line":"        - skip_ansible_lint"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":47,"id":"3f79a3b5_93f613d5","line":32,"range":{"start_line":32,"start_character":32,"end_line":32,"end_character":52},"in_reply_to":"3f79a3b5_539b9bc6","updated":"2018-10-26 08:16:04.000000000","message":"@JP The value in defaults is not available here in a subsequent playbook outside the role - we know because it failed in previous attempts to use the var without setting a default here.","commit_id":"b72b34b6ca4016200cfda7f7ededc57c5f1438da"}],"tox.ini":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cdab03946f174d4ee68d9d0bd0f1aed0ce87369e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"commands \u003d"},{"line_number":93,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"[testenv:distro_install]"},{"line_number":96,"context_line":"setenv \u003d"},{"line_number":97,"context_line":"    {[testenv]setenv}"},{"line_number":98,"context_line":"    ANSIBLE_PARAMETERS\u003d-e @{toxinidir}/tests/common/test-distro_install-vars.yml"}],"source_content_type":"text/x-properties","patch_set":19,"id":"3f79a3b5_707a8525","line":95,"updated":"2018-10-11 12:52:24.000000000","message":"A job should be added to zuul.d/jobs and exercised in the pipeline to confirm that the patch is working as intended.","commit_id":"579a93ffe3404fa3f70850b5edc03ec4d8028d1d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"commands \u003d"},{"line_number":93,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"[testenv:distro_install]"},{"line_number":96,"context_line":"setenv \u003d"},{"line_number":97,"context_line":"    {[testenv]setenv}"},{"line_number":98,"context_line":"    ANSIBLE_PARAMETERS\u003d-e @{toxinidir}/tests/common/test-distro_install-vars.yml"}],"source_content_type":"text/x-properties","patch_set":19,"id":"3f79a3b5_828b4215","line":95,"in_reply_to":"3f79a3b5_707a8525","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"579a93ffe3404fa3f70850b5edc03ec4d8028d1d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8cb81215b1f43c4a21ba0fd2d01f657cf29680ca","unresolved":false,"context_lines":[{"line_number":92,"context_line":"commands \u003d"},{"line_number":93,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"[testenv:linters]"},{"line_number":97,"context_line":"basepython \u003d python3"},{"line_number":98,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":21,"id":"3f79a3b5_bcdc65e2","side":"PARENT","line":95,"updated":"2018-10-12 07:56:09.000000000","message":"Please leave a double-line-break between each env, and add the tox env from PS19 back with an appropriate zuul job exercising it.","commit_id":"099c74902ffb16e77ef38b8ba35e03782fd1461a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"343b8240d0eb8afe0a0cf93362800f58f0809bd6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"[testenv:distro_install]"},{"line_number":97,"context_line":"setenv \u003d"},{"line_number":98,"context_line":"    {[testenv]setenv}"},{"line_number":99,"context_line":"    ANSIBLE_PARAMETERS\u003d-e @{toxinidir}/tests/common/test-distro_install-vars.yml"}],"source_content_type":"text/x-properties","patch_set":22,"id":"3f79a3b5_8216e257","line":96,"updated":"2018-10-12 09:37:52.000000000","message":"There still needs to be a zuul job added to exercise this.","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee5da8629d5b93d4e93fcef899b1a142229c48f5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"[testenv:distro_install]"},{"line_number":97,"context_line":"setenv \u003d"},{"line_number":98,"context_line":"    {[testenv]setenv}"},{"line_number":99,"context_line":"    ANSIBLE_PARAMETERS\u003d-e @{toxinidir}/tests/common/test-distro_install-vars.yml"}],"source_content_type":"text/x-properties","patch_set":22,"id":"3f79a3b5_fd465722","line":96,"in_reply_to":"3f79a3b5_8216e257","updated":"2018-10-12 09:53:55.000000000","message":"Done","commit_id":"93ba7f2c9c2ae4fb2b8da97768face243453ddfe"}],"vars/distro_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"81f05330d1ef22246b92084e503946ef0059fd43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3f79a3b5_d0b35908","updated":"2018-10-11 12:50:14.000000000","message":"There will also need to be a vars/source_install.yml which sets tempest_package_list to just be the contents of tempest_distro_packages","commit_id":"8099fafd6a63e167087e3388b46e9c3fab371c22"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"58b991489ec529d7660db02eeed1b62dda5bb0cb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# whether the host is in the host group and the service is"},{"line_number":19,"context_line":"# enabled."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"tempest_package_list: |-"},{"line_number":22,"context_line":"  {% set packages \u003d tempest_distro_packages %}"},{"line_number":23,"context_line":"  {% set _ \u003d packages.extend(tempest_service_distro_packages) %}"},{"line_number":24,"context_line":"  {{ packages }}"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"3f79a3b5_4a42353e","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":16},"updated":"2018-10-24 09:40:49.000000000","message":"this can be written as\n\ntempest_package_list: \"{{ tempest_distro_packages + tempest_service_distro_packages }}\"","commit_id":"ed860babc057a2ce4e2fe141062ed0d52a71e840"}],"vars/redhat-7.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8e131e2edc762dba3f32affc769a5a7517dbd2bf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tempest_install_method: distro"},{"line_number":18,"context_line":"tempest_package_list: | -"},{"line_number":19,"context_line":"  {% set _ \u003d packages.extend(tempest_distro_packages) %}"},{"line_number":20,"context_line":"  {{ packages }}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_926f4692","line":17,"updated":"2018-10-10 10:50:02.000000000","message":"This now forces a distro install for redhat builds, which is not appropriate. Some still want to deploy from source.\n\nAs is done in https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/main.yml#L67-L70 - have a task to pull in the vars for each install method which sets the appropriate changes per method and prepares the package list. There should be a generic base of \u0027tempest_distro_packages\u0027 and then like in https://github.com/openstack/openstack-ansible-os_nova/blob/master/vars/distro_install.yml#L54 the list should be extended with another list that\u0027s specific for the distro install.","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b2fa6b5a6bbbfb2406b0acab92eecc84b642dfa8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tempest_install_method: distro"},{"line_number":18,"context_line":"tempest_package_list: | -"},{"line_number":19,"context_line":"  {% set _ \u003d packages.extend(tempest_distro_packages) %}"},{"line_number":20,"context_line":"  {{ packages }}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_d95e2f78","line":17,"in_reply_to":"3f79a3b5_926f4692","updated":"2018-10-11 06:50:02.000000000","message":"moved this to distro_install.yml.","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8e131e2edc762dba3f32affc769a5a7517dbd2bf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  - python-tempestconf"},{"line_number":24,"context_line":"  - python-subunit"},{"line_number":25,"context_line":"  - python-keystone-tests-tempest"},{"line_number":26,"context_line":"tempest_workspace: /home/zuul/"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_52c52e5b","line":26,"updated":"2018-10-10 10:50:02.000000000","message":"\u0027/home/zuul\u0027 is only present in gating, and not useful for outside of openstack-infra. This should rather be something like \"{{ ansible_env.HOME }}\" which will be appropriate to the user in question on the target host.","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b2fa6b5a6bbbfb2406b0acab92eecc84b642dfa8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  - python-tempestconf"},{"line_number":24,"context_line":"  - python-subunit"},{"line_number":25,"context_line":"  - python-keystone-tests-tempest"},{"line_number":26,"context_line":"tempest_workspace: /home/zuul/"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_f963eb3f","line":26,"in_reply_to":"3f79a3b5_52c52e5b","updated":"2018-10-11 06:50:02.000000000","message":"Moved to distro_install.yml","commit_id":"a21faa772c47c635ee930cf07eb96f653891447b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"642406c6f35d6d306f5de3743852dcace23ca9d9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"tempest_distro_packages:"},{"line_number":17,"context_line":"  - git"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f79a3b5_f0cf7588","side":"PARENT","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":7},"updated":"2018-10-11 12:48:21.000000000","message":"This list must remain unchanged.","commit_id":"099c74902ffb16e77ef38b8ba35e03782fd1461a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"642406c6f35d6d306f5de3743852dcace23ca9d9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tempest_distro_packages:"},{"line_number":18,"context_line":"  - openstack-tempest"},{"line_number":19,"context_line":"  - python-tempestconf"},{"line_number":20,"context_line":"  - python-subunit"},{"line_number":21,"context_line":"  - python-keystone-tests-tempest"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f79a3b5_b0d57d1c","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":33},"updated":"2018-10-11 12:48:21.000000000","message":"This should be a new var called \u0027tempest_service_distro_packages\u0027","commit_id":"8099fafd6a63e167087e3388b46e9c3fab371c22"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8cb81215b1f43c4a21ba0fd2d01f657cf29680ca","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"tempest_distro_packages:"},{"line_number":17,"context_line":"  - git"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_1c8239a6","side":"PARENT","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":7},"updated":"2018-10-12 07:56:09.000000000","message":"This must stay.","commit_id":"099c74902ffb16e77ef38b8ba35e03782fd1461a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"tempest_distro_packages:"},{"line_number":17,"context_line":"  - git"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_e26b1619","side":"PARENT","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":7},"in_reply_to":"3f79a3b5_1c8239a6","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"099c74902ffb16e77ef38b8ba35e03782fd1461a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8cb81215b1f43c4a21ba0fd2d01f657cf29680ca","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tempest_distro_packages:"},{"line_number":18,"context_line":"  - openstack-tempest"},{"line_number":19,"context_line":"  - python-tempestconf"},{"line_number":20,"context_line":"  - python-subunit"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_fcff3d32","line":17,"updated":"2018-10-12 07:56:09.000000000","message":"This should be named \u0027tempest_service_distro_packages\u0027.","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tempest_distro_packages:"},{"line_number":18,"context_line":"  - openstack-tempest"},{"line_number":19,"context_line":"  - python-tempestconf"},{"line_number":20,"context_line":"  - python-subunit"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_02697224","line":17,"in_reply_to":"3f79a3b5_fcff3d32","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"}],"vars/source_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8cb81215b1f43c4a21ba0fd2d01f657cf29680ca","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# whether the host is in the host group and the service is"},{"line_number":19,"context_line":"# enabled."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"tempest_package_list: |-"},{"line_number":22,"context_line":"  {% set packages \u003d tempest_distro_packages %}"},{"line_number":23,"context_line":"  {% set _ \u003d packages.extend(tempest_service_distro_packages) %}"},{"line_number":24,"context_line":"  {{ packages }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"tempest_workspace: \"{{ ansible_env.HOME }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_9c9649ef","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":16},"updated":"2018-10-12 07:56:09.000000000","message":"This should just be:\n\ntempest_package_list: \"{{ tempest_distro_packages }}\"","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# whether the host is in the host group and the service is"},{"line_number":19,"context_line":"# enabled."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"tempest_package_list: |-"},{"line_number":22,"context_line":"  {% set packages \u003d tempest_distro_packages %}"},{"line_number":23,"context_line":"  {% set _ \u003d packages.extend(tempest_service_distro_packages) %}"},{"line_number":24,"context_line":"  {{ packages }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"tempest_workspace: \"{{ ansible_env.HOME }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_a2bf5e5e","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":16},"in_reply_to":"3f79a3b5_9c9649ef","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8cb81215b1f43c4a21ba0fd2d01f657cf29680ca","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  {% set _ \u003d packages.extend(tempest_service_distro_packages) %}"},{"line_number":24,"context_line":"  {{ packages }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"tempest_workspace: \"{{ ansible_env.HOME }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_3c97f5ec","line":26,"updated":"2018-10-12 07:56:09.000000000","message":"Remove this. It\u0027s not meant to be overridden here. Leave it as the default.","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9c77539f0e0888df1df14c56384222c4b86422c4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  {% set _ \u003d packages.extend(tempest_service_distro_packages) %}"},{"line_number":24,"context_line":"  {{ packages }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"tempest_workspace: \"{{ ansible_env.HOME }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3f79a3b5_224fcebe","line":26,"in_reply_to":"3f79a3b5_3c97f5ec","updated":"2018-10-12 09:29:42.000000000","message":"Done","commit_id":"30275b80e5eefbf6ea7261068b4858ea9fd5d354"}],"vars/suse.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tempest_distro_packages:"},{"line_number":18,"context_line":"  - git-core"},{"line_number":19,"context_line":"tempest_service_distro_packages:"},{"line_number":20,"context_line":"  - openstack-tempest"},{"line_number":21,"context_line":"  - python-subunit"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_79d7ea51","line":19,"updated":"2018-10-23 10:25:12.000000000","message":"Please add a line break before the new var. It makes it a bit easier to read when this file grows.","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"058c430fa043b06e0f95ec53faec5c2ddc1f13c3","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tempest_distro_packages:"},{"line_number":18,"context_line":"  - git-core"},{"line_number":19,"context_line":"tempest_service_distro_packages:"},{"line_number":20,"context_line":"  - openstack-tempest"},{"line_number":21,"context_line":"  - python-subunit"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_5c3e9c26","line":19,"in_reply_to":"3f79a3b5_79d7ea51","updated":"2018-10-23 11:11:12.000000000","message":"Done","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fd178edcdc0b4fd986ac3062f0ff596cb9e78cd7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  - git-core"},{"line_number":19,"context_line":"tempest_service_distro_packages:"},{"line_number":20,"context_line":"  - openstack-tempest"},{"line_number":21,"context_line":"  - python-subunit"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_d9c95eab","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":18},"updated":"2018-10-23 10:25:12.000000000","message":"From https://pkgs.org/download/python-python-subunit it seems the package is python-python-subunit for leap 42 and python2-python-subunit for leap 15 so this should be:\n\n  - \"{{ (ansible_distribution_version is version (\u002742\u0027, \u0027\u003e\u003d\u0027)) | ternary(\u0027python-python-subunit\u0027, \u0027python2-python-subunit\u0027) }}\"","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"058c430fa043b06e0f95ec53faec5c2ddc1f13c3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  - git-core"},{"line_number":19,"context_line":"tempest_service_distro_packages:"},{"line_number":20,"context_line":"  - openstack-tempest"},{"line_number":21,"context_line":"  - python-subunit"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_fc0e888d","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":18},"in_reply_to":"3f79a3b5_d9c95eab","updated":"2018-10-23 11:11:12.000000000","message":"Done","commit_id":"2cf8f31a97808c829e51c2f32163c27db5680790"}]}