)]}'
{"defaults/main.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2ba631cb3ce7a4d381a8de863a7649c421a5541d","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Stackviz tarball url"},{"line_number":260,"context_line":"stackviz_tarball: \"https://tarballs.openstack.org/package-stackviz-element/stackviz-latest.tar.gz\""},{"line_number":261,"context_line":"stackviz_venv_bin: \"/openstack/venvs/stackviz/bin\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_3282b900","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":17},"updated":"2018-10-01 10:43:57.000000000","message":"Thanks for working on it, Just one query cannot we use the same venv where tempest is getting installed?","commit_id":"3b43cd2de344a7bf2d83fc3e1c51682480efcf2e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"78ba91f37553eaf8735ef19762ecae8dcfd67c58","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Stackviz tarball url"},{"line_number":260,"context_line":"stackviz_tarball: \"https://tarballs.openstack.org/package-stackviz-element/stackviz-latest.tar.gz\""},{"line_number":261,"context_line":"stackviz_venv_bin: \"/openstack/venvs/stackviz/bin\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_65786d8e","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":17},"in_reply_to":"3f79a3b5_3282b900","updated":"2018-10-01 11:13:14.000000000","message":"I guess it could be done that way, but I don\u0027t see a strong reason to do it one way or another? Why would you prefer it to be in a shared venv vs its own venv?","commit_id":"3b43cd2de344a7bf2d83fc3e1c51682480efcf2e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5d0bb5c31d8e67d26cd83c7a1c3fff9d9fd954ec","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Stackviz tarball url"},{"line_number":260,"context_line":"stackviz_tarball: \"https://tarballs.openstack.org/package-stackviz-element/stackviz-latest.tar.gz\""},{"line_number":261,"context_line":"stackviz_venv_bin: \"/openstack/venvs/stackviz/bin\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_e5079d1c","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":17},"in_reply_to":"3f79a3b5_65786d8e","updated":"2018-10-01 11:59:52.000000000","message":"In order to avoid maintaining multiple venvs, stackviz can be installed in the same tempest venv and use it from there. That\u0027s why I am suggesting for the same","commit_id":"3b43cd2de344a7bf2d83fc3e1c51682480efcf2e"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"6f5c4f841ceb8a47f4f89fbfd4be6df5eb328f1f","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Stackviz tarball url"},{"line_number":260,"context_line":"stackviz_tarball: \"https://tarballs.openstack.org/package-stackviz-element/stackviz-latest.tar.gz\""},{"line_number":261,"context_line":"stackviz_venv_bin: \"/openstack/venvs/stackviz/bin\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_03d73151","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":17},"in_reply_to":"3f79a3b5_e5079d1c","updated":"2018-10-01 13:05:46.000000000","message":"If later we want to split stackviz, we don\u0027t have problems... I want to keep it splited, if in the future, requirements get conflict, we are safe.","commit_id":"3b43cd2de344a7bf2d83fc3e1c51682480efcf2e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"70e43ae3efc3b9dd0921d36902e2132287944076","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Stackviz tarball url"},{"line_number":260,"context_line":"stackviz_tarball: \"https://tarballs.openstack.org/package-stackviz-element/stackviz-latest.tar.gz\""},{"line_number":261,"context_line":"stackviz_venv_bin: \"/openstack/venvs/stackviz/bin\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_a84adc20","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":17},"in_reply_to":"3f79a3b5_e5079d1c","updated":"2018-10-01 12:15:27.000000000","message":"Will stackviz be used outside of CI tests? If so, there\u0027s no maintenance. If it is, then it\u0027s a fairly low cost.\n\nTo me the value of sharing a venv might be that some of the stackviz deps will already be installed, so it reduces the need to fetch packages again. That said, those deps are probably cached by pip, so it\u0027s not a huge value add.\n\nI don\u0027t feel strongly either way - they\u0027re both suitable options to me.","commit_id":"3b43cd2de344a7bf2d83fc3e1c51682480efcf2e"}],"tasks/stackviz.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b406aeda8780fc6c058d82238f76160cfe65e849","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    path: \"{{ tempest_venv_bin | dirname }}/workspace/.stestr\""},{"line_number":19,"context_line":"  register: stestr"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Set .stestr or .testreopsitory directories and commands"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    test_command: \"{% if stestr.stat.exists %}stestr{% else %}testr{% endif %}\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_5b2c0292","line":21,"range":{"start_line":21,"start_character":23,"end_line":21,"end_character":38},"updated":"2018-09-20 10:55:38.000000000","message":"nit: spelling error","commit_id":"4fd074a55f0b3da27b716b2bedee4a4a2aeb2985"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c50b84208670cae10be2e5d6c7ecf20c2efd90b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Set .stestr or .testreopsitory directories and commands"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    test_command: \"{% if stestr.stat.exists %}stestr{% else %}testr{% endif %}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Download latest stackviz"},{"line_number":26,"context_line":"  get_url:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_0863a21b","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":78},"updated":"2018-09-20 10:54:35.000000000","message":"You can use this, with slightly better performance:\n\n  \"{{ (stestr.stat.exists | bool) | ternary(\u0027stestr\u0027, \u0027testr\u0027) }}\"","commit_id":"4fd074a55f0b3da27b716b2bedee4a4a2aeb2985"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c50b84208670cae10be2e5d6c7ecf20c2efd90b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    test_command: \"{% if stestr.stat.exists %}stestr{% else %}testr{% endif %}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Download latest stackviz"},{"line_number":26,"context_line":"  get_url:"},{"line_number":27,"context_line":"    url: \"{{ stackviz_tarball }}\""},{"line_number":28,"context_line":"    dest: \"{{ ansible_env.HOME }}/stackviz-latest.tar.gz\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Install stackviz"},{"line_number":31,"context_line":"  pip:"},{"line_number":32,"context_line":"    name: \"{{ ansible_env.HOME }}/stackviz-latest.tar.gz\""},{"line_number":33,"context_line":"    virtualenv: \"{{ stackviz_venv_bin | dirname }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: List envs"},{"line_number":36,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_68fed606","line":33,"range":{"start_line":25,"start_character":0,"end_line":33,"end_character":51},"updated":"2018-09-20 10:54:35.000000000","message":"Rather than do this, I\u0027d recommend using our python_venv_build role. It ensures that virtualenv is present and prepares it correctly:\n\n  - name: Install the python venv\n    include_role:\n      name: \"python_venv_build\"\n    vars:\n      venv_install_destination_path: \"{{ stackviz_venv_bin | dirname }}\"\n      venv_pip_install_args: \"--isolated\"\n      venv_pip_packages: \"{{ [stackviz_tarball] }}\"","commit_id":"4fd074a55f0b3da27b716b2bedee4a4a2aeb2985"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c50b84208670cae10be2e5d6c7ecf20c2efd90b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  copy:"},{"line_number":49,"context_line":"    src: \"{{ stackviz_venv_bin | dirname }}/share/stackviz-html/\""},{"line_number":50,"context_line":"    dest: \"{{ ansible_env.HOME }}/stackviz\""},{"line_number":51,"context_line":"    directory_mode: yes"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Collecting data from tempest run"},{"line_number":54,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_6850162d","line":51,"updated":"2018-09-20 10:54:35.000000000","message":"The copy module, by default, copies from the deploy host to the target host. In this case you\u0027re wanting to copy from the target host to the target host, so add \u0027remote_src: yes\u0027 to do that.","commit_id":"4fd074a55f0b3da27b716b2bedee4a4a2aeb2985"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c50b84208670cae10be2e5d6c7ecf20c2efd90b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    directory_mode: yes"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Collecting data from tempest run"},{"line_number":54,"context_line":"  shell: \u003e"},{"line_number":55,"context_line":"    source {{ stackviz_venv_bin }}/activate"},{"line_number":56,"context_line":"    {{ test_command }} last --subunit | subunit-1to2 | stackviz-export  --env --stdin {{ ansible_env.HOME }}/stackviz/data"},{"line_number":57,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_3b182674","line":54,"range":{"start_line":54,"start_character":9,"end_line":54,"end_character":10},"updated":"2018-09-20 10:54:35.000000000","message":"I think you might want to use | here as you\u0027re doing a multi-line script.","commit_id":"4fd074a55f0b3da27b716b2bedee4a4a2aeb2985"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c50b84208670cae10be2e5d6c7ecf20c2efd90b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    source {{ stackviz_venv_bin }}/activate"},{"line_number":56,"context_line":"    {{ test_command }} last --subunit | subunit-1to2 | stackviz-export  --env --stdin {{ ansible_env.HOME }}/stackviz/data"},{"line_number":57,"context_line":"  args:"},{"line_number":58,"context_line":"    chdir: \"{{ tempest_venv_bin | dirname }}/workspace\""},{"line_number":59,"context_line":"  tags:"},{"line_number":60,"context_line":"    # don\u0027t trigger ANSIBLE0013"},{"line_number":61,"context_line":"    - skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_fb270eb5","line":58,"updated":"2018-09-20 10:54:35.000000000","message":"Given that you\u0027re expecting bash to be used, best to add:\n\n  executable: /bin/bash","commit_id":"4fd074a55f0b3da27b716b2bedee4a4a2aeb2985"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e0be91bb72108a35f01f7e5e1605b01f0aa47601","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# Copy module doesn\u0027t copy recursively with remote_src set to true"},{"line_number":34,"context_line":"- name: Copy stackviz-html to home directory"},{"line_number":35,"context_line":"  shell: |"},{"line_number":36,"context_line":"    mv {{ stackviz_venv_bin | dirname }}/share/stackviz-html /openstack/logs/stackviz"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    executable: /bin/bash"},{"line_number":39,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_d383c7ca","line":36,"range":{"start_line":36,"start_character":61,"end_line":36,"end_character":76},"updated":"2018-09-25 11:02:48.000000000","message":"This directory does not exist. This should be {{ tempest_log_dir }}.","commit_id":"4aa27ffadc5d6c87b52d415ef572e904553d9b71"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e0be91bb72108a35f01f7e5e1605b01f0aa47601","unresolved":false,"context_lines":[{"line_number":43,"context_line":"- name: Collecting data from tempest run"},{"line_number":44,"context_line":"  shell: |"},{"line_number":45,"context_line":"    . {{ stackviz_venv_bin }}/activate"},{"line_number":46,"context_line":"    {{ test_command }} last --subunit | subunit-1to2 | stackviz-export  --env --stdin /openstack/logs/stackviz/data"},{"line_number":47,"context_line":"  args:"},{"line_number":48,"context_line":"    chdir: \"{{ tempest_venv_bin | dirname }}/workspace\""},{"line_number":49,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_7368b321","line":46,"range":{"start_line":46,"start_character":86,"end_line":46,"end_character":101},"updated":"2018-09-25 11:02:48.000000000","message":"This directory does not exist. This should be {{ tempest_log_dir }}.","commit_id":"4aa27ffadc5d6c87b52d415ef572e904553d9b71"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eb4d98858f86b876b6c81a86d7927fc022c28b86","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    executable: /bin/bash"},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    # don\u0027t trigger ANSIBLE0013"},{"line_number":32,"context_line":"      - skip_ansible_lint"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Collecting data from tempest run"},{"line_number":35,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_d2e34505","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":25},"updated":"2018-10-01 10:41:22.000000000","message":"nit: The spacing here is two out.","commit_id":"3b43cd2de344a7bf2d83fc3e1c51682480efcf2e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eb4d98858f86b876b6c81a86d7927fc022c28b86","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    # don\u0027t trigger ANSIBLE0013"},{"line_number":43,"context_line":"    - skip_ansible_lint"},{"line_number":44,"context_line":"  register: stackviz_run"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_12d69d27","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":24},"updated":"2018-10-01 10:41:22.000000000","message":"nit: This is an unused register, so it can be removed.","commit_id":"3b43cd2de344a7bf2d83fc3e1c51682480efcf2e"}]}