)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d95810d0c950befc7107194eed1b86856f2d10aa","unresolved":false,"context_lines":[{"line_number":266,"context_line":"tempest_tempest_conf_overrides: {}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"# python-tempestconf variables"},{"line_number":269,"context_line":"tempest_use_tempestconf: true"},{"line_number":270,"context_line":"tempestconf_venv_bin: \"/openstack/venvs/tempestconf/bin\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"# Stackviz tarball url"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_55bf58aa","line":269,"updated":"2018-11-05 12:17:30.000000000","message":"Obviously this should be disabled by default, and activated in a test. If that test is intentionally not included in this patch, please note why that is the case in the commit msg.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6f8e23d88f545a1cf49e4d527f696b02ff429091","unresolved":false,"context_lines":[{"line_number":269,"context_line":"# The tempest_use_tempestconf by default is set to false, set to true if you"},{"line_number":270,"context_line":"# want to generate the tempest.conf file with this tool, instead of"},{"line_number":271,"context_line":"# tempest.conf from the template"},{"line_number":272,"context_line":"tempest_use_tempestconf: true"},{"line_number":273,"context_line":"tempestconf_venv_bin: \"/openstack/venvs/tempestconf/bin\""},{"line_number":274,"context_line":"tempestconf_pip_packages:"},{"line_number":275,"context_line":"  - python-tempestconf"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_062bf89a","line":272,"updated":"2018-11-05 14:36:52.000000000","message":"This should be set to false/no.","commit_id":"ea94a923b2dfafca573303a5950eef8f3b624960"}],"releasenotes/notes/enable-tempestconf-support-0bd13c8393c9450b.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9c0815ae07f8281b603b15f1891d1e95a128a9b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Python-tempestconf is a tool that generates a tempest.conf file, based"},{"line_number":4,"context_line":"    only on the credentials from an openstack installation. It uses the"},{"line_number":5,"context_line":"    discoverable api from openstack to check for services, features, etc."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_1846f77f","line":2,"updated":"2018-11-05 13:20:44.000000000","message":"The prelude should be reserved for PTL announcements of really major features for the series, and I\u0027m not sure this fits the bill. See https://docs.openstack.org/openstack-ansible/latest/contributor/code-rules.html#release-notes\n\nI\u0027d suggest adding this to the feature note below rather than as a prelude note.","commit_id":"407dc282f0e5fe55b1fe947ab94d4e5e09a8339b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9c0815ae07f8281b603b15f1891d1e95a128a9b0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"features:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Add the possibility to use python-tempestconf tool to generate tempest.conf"},{"line_number":10,"context_line":"    file, instead of use the ansible tempest.conf template."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_784e0b91","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":58},"updated":"2018-11-05 13:20:44.000000000","message":"suggestion: rather than using the role template.","commit_id":"407dc282f0e5fe55b1fe947ab94d4e5e09a8339b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"72d886fa9f0664ee9400d38396408855040e1732","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Add the possibility to use python-tempestconf tool to generate tempest.conf"},{"line_number":10,"context_line":"    file, instead of use the ansible tempest.conf template."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_fb053510","line":11,"updated":"2018-11-05 13:22:11.000000000","message":"What about also adding tempest_use_tempestconf to true to enable tempestconf here?","commit_id":"407dc282f0e5fe55b1fe947ab94d4e5e09a8339b"}],"tasks/main.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5596ca9aef2c955b9e161036e48781fb057da2d8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    - tempest-config"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- include_tasks: tempestconf.yml"},{"line_number":47,"context_line":"  when: tempest_use_tempestconf"},{"line_number":48,"context_line":"  tags:"},{"line_number":49,"context_line":"    - tempest-config"},{"line_number":50,"context_line":"    - tempestconf"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_54934cb1","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":31},"updated":"2018-10-30 11:07:39.000000000","message":"It should be  tempest_use_tempestconf | bool.\n\nSince tempest_resources.yaml is also used to create tempest config resource and then in post_run https://github.com/openstack/openstack-ansible-os_tempest/blob/81f6bda4c001784fc9444414d239b88f082eaf0d/tasks/tempest_post_install.yml#L28 to used to override the value and copy the tempest.conf to proper location. Can we disable tempest_resources.yml when tempestconf is used? Because the same operation is done by tempest_resources also http://logs.openstack.org/68/612968/7/check/openstack-ansible-functional-centos-7/c899c78/job-output.txt.gz#_2018-10-30_09_59_31_791331","commit_id":"50db1eedff4cc05e37dbf4e4013a77508f0108a0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d95810d0c950befc7107194eed1b86856f2d10aa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - tempest-config"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- include_tasks: tempestconf.yml"},{"line_number":47,"context_line":"  when: tempest_use_tempestconf"},{"line_number":48,"context_line":"  tags:"},{"line_number":49,"context_line":"    - tempest-config"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_d5ab686e","line":46,"updated":"2018-11-05 12:17:30.000000000","message":"I think that /etc/tempest.conf need to be in place before the workspace is initialized, so this will need to go into tempest_post_install.yml just after the other tempest.conf template task and before the workspace initialization.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"}],"tasks/tempest_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6f8e23d88f545a1cf49e4d527f696b02ff429091","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  when: not tempest_use_tempestconf | bool"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- include_tasks: tempestconf.yml"},{"line_number":42,"context_line":"  when: tempest_use_tempestconf"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - tempest-config"},{"line_number":45,"context_line":"    - tempestconf"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_262e34aa","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":31},"updated":"2018-11-05 14:36:52.000000000","message":"Apply the bool filter here to ensure that it is evaluated as a boolean.","commit_id":"ea94a923b2dfafca573303a5950eef8f3b624960"}],"tasks/tempestconf.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"74748d02d2a4bc0a517211873d6f69b0866ef746","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: Executing python-tempestconf"},{"line_number":25,"context_line":"  shell: |"},{"line_number":26,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":27,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":28,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":29,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":30,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\""},{"line_number":31,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":32,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":33,"context_line":"      --debug \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_c0d621c5","line":30,"range":{"start_line":27,"start_character":3,"end_line":30,"end_character":54},"updated":"2018-10-24 14:09:59.000000000","message":"What if someone passes the path to rc or cloud.yaml file directly then?","commit_id":"527c56099817b3ed60f15a74ca34633f868d4bc5"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"b2123dbee6a04fb8180b786ffaeaba68c1287656","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: Executing python-tempestconf"},{"line_number":25,"context_line":"  shell: |"},{"line_number":26,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":27,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":28,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":29,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":30,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\""},{"line_number":31,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":32,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":33,"context_line":"      --debug \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d38d9935","line":30,"range":{"start_line":27,"start_character":3,"end_line":30,"end_character":54},"in_reply_to":"3f79a3b5_c0d621c5","updated":"2018-10-24 14:35:41.000000000","message":"This is an initial patch to check how this going to work properly","commit_id":"527c56099817b3ed60f15a74ca34633f868d4bc5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"74748d02d2a4bc0a517211873d6f69b0866ef746","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":29,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":30,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\""},{"line_number":31,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":32,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":33,"context_line":"      --debug \\"},{"line_number":34,"context_line":"      --create \\"},{"line_number":35,"context_line":"      auth.use_dynamic_credentials true"},{"line_number":36,"context_line":"  args:"},{"line_number":37,"context_line":"    chdir: \"{{ ansible_env.HOME }}/.tempest\""},{"line_number":38,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_40c3f106","line":35,"range":{"start_line":31,"start_character":4,"end_line":35,"end_character":39},"updated":"2018-10-24 14:09:59.000000000","message":"Can we move this whole part to a template and call that template there?","commit_id":"527c56099817b3ed60f15a74ca34633f868d4bc5"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"b2123dbee6a04fb8180b786ffaeaba68c1287656","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":29,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":30,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\""},{"line_number":31,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":32,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":33,"context_line":"      --debug \\"},{"line_number":34,"context_line":"      --create \\"},{"line_number":35,"context_line":"      auth.use_dynamic_credentials true"},{"line_number":36,"context_line":"  args:"},{"line_number":37,"context_line":"    chdir: \"{{ ansible_env.HOME }}/.tempest\""},{"line_number":38,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_13a8f188","line":35,"range":{"start_line":31,"start_character":4,"end_line":35,"end_character":39},"in_reply_to":"3f79a3b5_40c3f106","updated":"2018-10-24 14:35:41.000000000","message":"I really don\u0027t want to pass to a template, to avoid pollute it with a lot of ifs and things that should be ansible tasks.","commit_id":"527c56099817b3ed60f15a74ca34633f868d4bc5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"128e704527e5a0bf855bfd015022fd356884862f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":31,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\""},{"line_number":32,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":33,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":34,"context_line":"      --debug \\"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_5a7cee20","line":31,"range":{"start_line":31,"start_character":27,"end_line":31,"end_character":50},"updated":"2018-10-29 10:38:42.000000000","message":"it should be keystone_admin_user_name","commit_id":"927c63c86282288dc92745b2ec99d568cab9dc91"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"128e704527e5a0bf855bfd015022fd356884862f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":31,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\""},{"line_number":32,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":33,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":34,"context_line":"      --debug \\"},{"line_number":35,"context_line":"      --create \\"},{"line_number":36,"context_line":"      auth.use_dynamic_credentials true"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    chdir: \"{{ ansible_env.HOME }}/.tempest\""},{"line_number":39,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_5a914e44","line":36,"range":{"start_line":27,"start_character":4,"end_line":36,"end_character":39},"updated":"2018-10-29 10:38:42.000000000","message":"If we put something like this here:\n set -e\nif [ -d {{ tempestconf_venv_bin }} ]\nthen\n. {{ tempestconf_venv_bin }}/activate\nfi\n export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\"\n    export OS_IDENTITY_API_VERSION\u003d\"3\"\n    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\"\n    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\"\n    discover-tempest-config --out etc/tempest.conf \\\n      --network-id \"{{ tempest_neutron_public_network_id }}\" \\\n      --debug \\\n      --create \\","commit_id":"927c63c86282288dc92745b2ec99d568cab9dc91"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"128e704527e5a0bf855bfd015022fd356884862f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":34,"context_line":"      --debug \\"},{"line_number":35,"context_line":"      --create \\"},{"line_number":36,"context_line":"      auth.use_dynamic_credentials true"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    chdir: \"{{ ansible_env.HOME }}/.tempest\""},{"line_number":39,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_fa6a9a4d","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":39},"updated":"2018-10-29 10:38:42.000000000","message":"It stays byfeault by true","commit_id":"927c63c86282288dc92745b2ec99d568cab9dc91"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"86455ce40c5b8c6e0f3192ea147028f72fdc2c25","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":31,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_username }}\""},{"line_number":32,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":33,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":34,"context_line":"      --debug \\"},{"line_number":35,"context_line":"      --create \\"},{"line_number":36,"context_line":"      auth.use_dynamic_credentials true"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    chdir: \"{{ ansible_env.HOME }}/.tempest\""},{"line_number":39,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_facdba5a","line":36,"range":{"start_line":27,"start_character":4,"end_line":36,"end_character":39},"in_reply_to":"3f79a3b5_5a914e44","updated":"2018-10-29 10:45:15.000000000","message":"This is a work in progress, I REALLY, don\u0027t want to make this too much shell scripted, than required, I\u0027m still thinking the best approach to this.","commit_id":"927c63c86282288dc92745b2ec99d568cab9dc91"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"128e704527e5a0bf855bfd015022fd356884862f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      --create \\"},{"line_number":36,"context_line":"      auth.use_dynamic_credentials true"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    chdir: \"{{ ansible_env.HOME }}/.tempest\""},{"line_number":39,"context_line":"    executable: /bin/bash"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    # don\u0027t trigger ANSIBLE0013"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_3a757233","line":38,"range":{"start_line":38,"start_character":11,"end_line":38,"end_character":44},"updated":"2018-10-29 10:38:42.000000000","message":"We can replace this with {{ tempest_workspace }} flag","commit_id":"927c63c86282288dc92745b2ec99d568cab9dc91"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"86455ce40c5b8c6e0f3192ea147028f72fdc2c25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      --create \\"},{"line_number":36,"context_line":"      auth.use_dynamic_credentials true"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    chdir: \"{{ ansible_env.HOME }}/.tempest\""},{"line_number":39,"context_line":"    executable: /bin/bash"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    # don\u0027t trigger ANSIBLE0013"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_7afbea78","line":38,"range":{"start_line":38,"start_character":11,"end_line":38,"end_character":44},"in_reply_to":"3f79a3b5_3a757233","updated":"2018-10-29 10:45:15.000000000","message":"Done","commit_id":"927c63c86282288dc92745b2ec99d568cab9dc91"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bf3bda9c21f1cda5f593455740b4a93f7b06dc67","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":31,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_user_name }}\""},{"line_number":32,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":33,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":34,"context_line":"      --debug \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_d85b1452","line":31,"range":{"start_line":28,"start_character":4,"end_line":31,"end_character":55},"updated":"2018-10-30 08:57:29.000000000","message":"You\u0027re missing OS_PROJECT_NAME, that\u0027s why it\u0027s failing.","commit_id":"9ad9820011566858084ea0bb8a82ac60a32f951e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5115712caa05827451e8bdf38a201329887bbb21","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Install python-tempestconf on venv"},{"line_number":17,"context_line":"  include_role:"},{"line_number":18,"context_line":"    name: \"python_venv_build\""},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    venv_install_destination_path: \"{{ tempestconf_venv_bin | dirname }}\""},{"line_number":21,"context_line":"    venv_pip_install_args: \"--isolated\""},{"line_number":22,"context_line":"    venv_pip_packages:"},{"line_number":23,"context_line":"      - python-tempestconf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_15cc80bc","line":23,"range":{"start_line":16,"start_character":1,"end_line":23,"end_character":26},"updated":"2018-11-05 12:03:05.000000000","message":"I think we can add a condition here when tempest_install_method is source, otherwise on distro jobs it will exercise the venv as well as distro installation both","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"981ea0cb44ec032a33c33846ad9a7c24334e8190","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    name: \"python_venv_build\""},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    venv_install_destination_path: \"{{ tempestconf_venv_bin | dirname }}\""},{"line_number":21,"context_line":"    venv_pip_install_args: \"--isolated\""},{"line_number":22,"context_line":"    venv_pip_packages:"},{"line_number":23,"context_line":"      - python-tempestconf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_95f3b0a0","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":26},"updated":"2018-11-05 12:20:09.000000000","message":"Rather than have this isolated, add a new _pip_packages list with this patch in it - that will ensure that the integrated build\u0027s py_pkgs lookup can find it, then the isolation won\u0027t be required.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"a962be099a6382e739b62cb4acc711721b9c8095","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Install python-tempestconf on venv"},{"line_number":17,"context_line":"  include_role:"},{"line_number":18,"context_line":"    name: \"python_venv_build\""},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    venv_install_destination_path: \"{{ tempestconf_venv_bin | dirname }}\""},{"line_number":21,"context_line":"    venv_pip_install_args: \"--isolated\""},{"line_number":22,"context_line":"    venv_pip_packages:"},{"line_number":23,"context_line":"      - python-tempestconf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_756294a9","line":23,"range":{"start_line":16,"start_character":1,"end_line":23,"end_character":26},"in_reply_to":"3f79a3b5_15cc80bc","updated":"2018-11-05 12:07:03.000000000","message":"In a different patch, I want to make this work in small patches, not have a big patch full of functionalities, let\u0027s do this incremental, and find the best way to do it.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9d9c664a91fb2f6b2c6c9c61b376f6347785f7a3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    name: \"python_venv_build\""},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    venv_install_destination_path: \"{{ tempestconf_venv_bin | dirname }}\""},{"line_number":21,"context_line":"    venv_pip_install_args: \"--isolated\""},{"line_number":22,"context_line":"    venv_pip_packages:"},{"line_number":23,"context_line":"      - python-tempestconf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_b57d8cc4","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":26},"in_reply_to":"3f79a3b5_95f3b0a0","updated":"2018-11-05 12:28:25.000000000","message":"The pip install args should be the same as https://github.com/openstack/openstack-ansible-os_tempest/blob/master/tasks/tempest_install_source.yml#L43","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5115712caa05827451e8bdf38a201329887bbb21","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_b5ba6c09","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":41},"updated":"2018-11-05 12:03:05.000000000","message":"Here we need to add a condition to check whether tempestconf_venv_bin is there then activate it.\nIt is kind of related to above comment.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d95810d0c950befc7107194eed1b86856f2d10aa","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_55a678ae","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":41},"in_reply_to":"3f79a3b5_95f2d0e3","updated":"2018-11-05 12:17:30.000000000","message":"I\u0027d suggest including that this is intentionally supporting source builds only for now in the commit message to prevent the same issue being raised by other reviewers.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"a962be099a6382e739b62cb4acc711721b9c8095","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_95f2d0e3","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":41},"in_reply_to":"3f79a3b5_b5ba6c09","updated":"2018-11-05 12:07:03.000000000","message":"Same as before, right now, let\u0027s support only this, I am really not a big fan of add conditions in shell script, I would like to have it as much ansible as possible.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"981ea0cb44ec032a33c33846ad9a7c24334e8190","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":31,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_user_name }}\""},{"line_number":32,"context_line":"    export OS_PROJECT_NAME\u003d\"{{ keystone_admin_tenant_name }}\""},{"line_number":33,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":34,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":35,"context_line":"      --debug \\"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_35289ceb","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":61},"updated":"2018-11-05 12:20:09.000000000","message":"Can the password (and perhaps the others here) be passed in using the \u0027environment\u0027 argument, so that they\u0027re not logged if this fails.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"90a0aeab0473741b7072d4a220bf7bcc5edc0343","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":31,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_user_name }}\""},{"line_number":32,"context_line":"    export OS_PROJECT_NAME\u003d\"{{ keystone_admin_tenant_name }}\""},{"line_number":33,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":34,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":35,"context_line":"      --debug \\"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_b51cacc3","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":61},"in_reply_to":"3f79a3b5_35289ceb","updated":"2018-11-05 12:22:06.000000000","message":"They are logged anyway in tempest.conf file right? :)","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"343469bf08a011aa83e2cc71499a895ba0065185","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Executing python-tempestconf"},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":28,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":29,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""},{"line_number":30,"context_line":"    export OS_PASSWORD\u003d\"{{ keystone_auth_admin_password }}\""},{"line_number":31,"context_line":"    export OS_USERNAME\u003d\"{{ keystone_admin_user_name }}\""},{"line_number":32,"context_line":"    export OS_PROJECT_NAME\u003d\"{{ keystone_admin_tenant_name }}\""},{"line_number":33,"context_line":"    discover-tempest-config --out etc/tempest.conf \\"},{"line_number":34,"context_line":"      --network-id \"{{ tempest_neutron_public_network_id }}\" \\"},{"line_number":35,"context_line":"      --debug \\"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_f5e6a4af","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":61},"in_reply_to":"3f79a3b5_b51cacc3","updated":"2018-11-05 12:27:34.000000000","message":"They\u0027re added to the file, sure - but not in the ansible console log if environment is used... whereas it may end up in the console log if done like this. Outputting passwords in console logs is not a good security practise.","commit_id":"6e0b5b09044fea59065be79b18f5673374d345fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"390a5d48a5dd1c1467da56fb3465030de93be908","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    name: \"python_venv_build\""},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    venv_install_destination_path: \"{{ tempestconf_venv_bin | dirname }}\""},{"line_number":21,"context_line":"    venv_pip_packages: {{ tempestconf_pip_packages }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Executing python-tempestconf"},{"line_number":24,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_d8ecff29","line":21,"updated":"2018-11-05 12:47:46.000000000","message":"Add:\n\nvenv_pip_install_args: \"{{ tempest_pip_install_args }}\"\n\nThis ensures that upper-constraints are respected for any dependencies which are installed, including ensuring that pip/setuptools/wheel are at the expected versions when using an OSA integrated build.","commit_id":"fc6c91e042316677e3d0ea5e8a5f98d98497c0a4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"390a5d48a5dd1c1467da56fb3465030de93be908","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    venv_pip_packages: {{ tempestconf_pip_packages }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Executing python-tempestconf"},{"line_number":24,"context_line":"  shell: |"},{"line_number":25,"context_line":"    . {{ tempestconf_venv_bin }}/activate"},{"line_number":26,"context_line":"    export OS_AUTH_URL\u003d\"{{ keystone_service_internaluri }}\""},{"line_number":27,"context_line":"    export OS_IDENTITY_API_VERSION\u003d\"3\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_584eaf39","line":24,"updated":"2018-11-05 12:47:46.000000000","message":"At the same level as \u0027args\u0027, add:\n\nenvironment:\n  OS_PASSWORD: \"{{ keystone_auth_admin_password }}\"\n\nThis ensures that the password never gets output to the console log.","commit_id":"fc6c91e042316677e3d0ea5e8a5f98d98497c0a4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9c0815ae07f8281b603b15f1891d1e95a128a9b0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    name: \"python_venv_build\""},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    venv_install_destination_path: \"{{ tempestconf_venv_bin | dirname }}\""},{"line_number":21,"context_line":"    venv_pip_packages: \"{{ tempestconf_pip_packages }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Executing python-tempestconf"},{"line_number":24,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_b819038c","line":21,"updated":"2018-11-05 13:20:44.000000000","message":"See comment for the additional argument to add in PS11.","commit_id":"407dc282f0e5fe55b1fe947ab94d4e5e09a8339b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b14f19e7ef3b89f024971d5fadec9c169d0a6b8b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    name: \"python_venv_build\""},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    venv_install_destination_path: \"{{ tempestconf_venv_bin | dirname }}\""},{"line_number":21,"context_line":"    venv_pip_packages: \"{{ tempestconf_pip_packages }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Executing python-tempestconf"},{"line_number":24,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_e66cbcd0","line":21,"updated":"2018-11-05 14:04:56.000000000","message":"See comment for the additional argument to add in PS11.","commit_id":"84831183a370cba259d55f2445b2498c65ea90f8"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2dcc39d3a282454ab5a964407f657cdee3741aa9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  copy:"},{"line_number":47,"context_line":"    src: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":48,"context_line":"    dest: \"/etc/tempest/tempest.conf\""},{"line_number":49,"context_line":"    remote_src: yes"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f79a3b5_508982c5","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":19},"updated":"2018-11-06 18:15:11.000000000","message":"I think remote_src is used for copying files from host to remote machine. Do we need it?","commit_id":"732b997deb54bfdd3529904b19d5b762b57cddf7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ec6017e498fc775abe3f06e8945685b56df4506c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  copy:"},{"line_number":47,"context_line":"    src: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":48,"context_line":"    dest: \"/etc/tempest/tempest.conf\""},{"line_number":49,"context_line":"    remote_src: yes"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f79a3b5_d0635217","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":19},"in_reply_to":"3f79a3b5_508982c5","updated":"2018-11-06 18:17:17.000000000","message":"remote_src means the copy happens at the target host, not the default of from the deploy host to the target host","commit_id":"732b997deb54bfdd3529904b19d5b762b57cddf7"}]}