)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"a45b1caccd89bce7b8d1a29be702a925bc530f2f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"It also moves stackviz installation to tempest_install.yml and"},{"line_number":19,"context_line":"gather datas to tempest_run.yml."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1.] http://git.openstack.org/cgit/openstack/openstack-ansible-"},{"line_number":22,"context_line":"os_tempest/tree/tasks/tempest_run.yml#n92"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.openstack.org/633179"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fdfeff1_82da3648","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":41},"updated":"2019-01-30 09:27:21.000000000","message":"This links to the master code so will becomes stale very quickly. The behaviour that you are changing in this patch is mostly visible in the diff, so probably we don\u0027t need this link.","commit_id":"3df4ab28ad9d0f37cc39f1da3af1552969e5f7eb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a2225e4abb6339832118b4e6a87edae50549aa68","unresolved":false,"context_lines":[{"line_number":18,"context_line":"It also moves stackviz installation to tempest_install.yml and"},{"line_number":19,"context_line":"gather datas to tempest_run.yml."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1.] http://git.openstack.org/cgit/openstack/openstack-ansible-"},{"line_number":22,"context_line":"os_tempest/tree/tasks/tempest_run.yml#n92"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.openstack.org/633179"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fdfeff1_a2865a12","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":41},"in_reply_to":"9fdfeff1_82da3648","updated":"2019-01-30 09:34:07.000000000","message":"Done","commit_id":"3df4ab28ad9d0f37cc39f1da3af1552969e5f7eb"}],"tasks/tempest_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0e7c35cfa70e80dab44081bae19fcd27fc6a95d7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  vars:"},{"line_number":36,"context_line":"    venv_install_destination_path: \"{{ stackviz_venv_bin | dirname }}\""},{"line_number":37,"context_line":"    venv_pip_install_args: \"--isolated\""},{"line_number":38,"context_line":"    venv_pip_packages: \"{{ [ stackviz_tarball ] }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fdfeff1_965ef773","line":38,"updated":"2019-01-30 10:52:07.000000000","message":"It looks like this is always run, whereas I was under the impression that we had an enablement variable for this. Anyway, it appears this is the same in the current merged code, so changing that is out of scope for this patch.","commit_id":"5ed35b37c7ee4a2560d1a8ce1bb03653ca1eef70"}],"tasks/tempest_run.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7b99be83ac9962962e91d213ff284243f2cebdbf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      # don\u0027t trigger ANSIBLE0013"},{"line_number":89,"context_line":"      - skip_ansible_lint"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - include_tasks: stackviz.yml"},{"line_number":92,"context_line":"    when: tempest_run | bool"},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - tempest-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_b093a44f","line":91,"updated":"2019-01-21 10:50:15.000000000","message":"Rather than include the \u0027install\u0027 and \u0027gather\u0027 tasks here, it might be better to move the \u0027install\u0027 tasks into the tempest_install file and move the \u0027gather results\u0027 task here.","commit_id":"6fb8faf6ac9260ace4de2fdb3340a42bdf569ce0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"21ab9983acb3e44c8fcb52fe362eefc453c830e5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      # don\u0027t trigger ANSIBLE0013"},{"line_number":89,"context_line":"      - skip_ansible_lint"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - include_tasks: stackviz.yml"},{"line_number":92,"context_line":"    when: tempest_run | bool"},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - tempest-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_7060dc33","line":91,"in_reply_to":"9fdfeff1_b093a44f","updated":"2019-01-21 11:08:43.000000000","message":"Done","commit_id":"6fb8faf6ac9260ace4de2fdb3340a42bdf569ce0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7b99be83ac9962962e91d213ff284243f2cebdbf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      - skip_ansible_lint"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - include_tasks: stackviz.yml"},{"line_number":92,"context_line":"    when: tempest_run | bool"},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - tempest-config"},{"line_number":95,"context_line":"      - tempest-run"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_70e1bcfe","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":28},"updated":"2019-01-21 10:50:15.000000000","message":"This conditional is in the parent include, and is therefore not required here.","commit_id":"6fb8faf6ac9260ace4de2fdb3340a42bdf569ce0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"21ab9983acb3e44c8fcb52fe362eefc453c830e5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      - skip_ansible_lint"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - include_tasks: stackviz.yml"},{"line_number":92,"context_line":"    when: tempest_run | bool"},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - tempest-config"},{"line_number":95,"context_line":"      - tempest-run"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_1055d050","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":28},"in_reply_to":"9fdfeff1_70e1bcfe","updated":"2019-01-21 11:08:43.000000000","message":"Done","commit_id":"6fb8faf6ac9260ace4de2fdb3340a42bdf569ce0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7b99be83ac9962962e91d213ff284243f2cebdbf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  - include_tasks: stackviz.yml"},{"line_number":92,"context_line":"    when: tempest_run | bool"},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - tempest-config"},{"line_number":95,"context_line":"      - tempest-run"},{"line_number":96,"context_line":"      - stackviz"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Fail if tempest tests did not succeed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_d0ef48e7","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":19},"updated":"2019-01-21 10:50:15.000000000","message":"These tags should only be used in tasks/main - remove them here.","commit_id":"6fb8faf6ac9260ace4de2fdb3340a42bdf569ce0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"21ab9983acb3e44c8fcb52fe362eefc453c830e5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  - include_tasks: stackviz.yml"},{"line_number":92,"context_line":"    when: tempest_run | bool"},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - tempest-config"},{"line_number":95,"context_line":"      - tempest-run"},{"line_number":96,"context_line":"      - stackviz"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Fail if tempest tests did not succeed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_30525469","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":19},"in_reply_to":"9fdfeff1_d0ef48e7","updated":"2019-01-21 11:08:43.000000000","message":"Done","commit_id":"6fb8faf6ac9260ace4de2fdb3340a42bdf569ce0"}]}