)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c624370370f7c5f50406afb554e164e3e6be47af","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os_tempest role depends on ansible-config_template"},{"line_number":10,"context_line":"role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I56cae67426429928dace571eebb7cd64e6f2ed12"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fdfeff1_d1a3e941","line":11,"updated":"2019-02-18 10:16:51.000000000","message":"Please add:\n\nRelated-Bug: 1791258\n\nAnd set the topic to \u0027bug/1791258\u0027.","commit_id":"357fe4b1d8a68ee6946658e76e3e4581284bcc9a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7fc8f7493a41f20cef5c9608dc5647dcd45358e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os_tempest role depends on ansible-config_template"},{"line_number":10,"context_line":"role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I56cae67426429928dace571eebb7cd64e6f2ed12"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fdfeff1_e47e6d17","line":11,"in_reply_to":"9fdfeff1_d1a3e941","updated":"2019-02-18 10:42:36.000000000","message":"Done","commit_id":"357fe4b1d8a68ee6946658e76e3e4581284bcc9a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"94c9c4f742d1e7871bfcf72b0c17fbebcf94560f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added dependency of os_tempest role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os_tempest role depends on ansible-config_template"},{"line_number":10,"context_line":"role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1791258"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9fdfeff1_64c83d21","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":5},"updated":"2019-02-18 10:51:41.000000000","message":"Apologies, I should have also noted earlier that this doesn\u0027t explain \u0027why\u0027 the meta-dependency needs to be added in useful terms. Perhaps add the following:\n\nIn order to ensure that the config_template action module is loaded by Ansible\nwithout requiring the path to the module being set explicitly in configuration,\nwe set config_template as a meta-dependency. This will make Ansible load the\nmodule automatically.","commit_id":"21413b2de5fc56de605a2c342bc9415c0ef1c8f5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7f6c9b7bddf97c66ec32e0ef05edef9c003bf1fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added dependency of os_tempest role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os_tempest role depends on ansible-config_template"},{"line_number":10,"context_line":"role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1791258"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9fdfeff1_674eff6f","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":5},"in_reply_to":"9fdfeff1_64c83d21","updated":"2019-02-18 11:03:55.000000000","message":"Done","commit_id":"21413b2de5fc56de605a2c342bc9415c0ef1c8f5"}],"meta/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fa1b2a27fc96b52cdefaccc581204fdcb4cad2d3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    - openstack"},{"line_number":39,"context_line":"dependencies:"},{"line_number":40,"context_line":"  - config_template"},{"line_number":41,"context_line":"  - python_venv_build"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9fdfeff1_295d8a78","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":21},"updated":"2019-02-26 11:33:06.000000000","message":"This should not be a meta-dependency - we run the role using include_role, not through the meta-dependency implementation in ansible (which runs the python-venv-build role prior to running the os_tempest role).\n\nAnsible role meta-reps are useful for pre-loading libraries/modules like config_template, but not very good for expressing roles it depends on.","commit_id":"549a1d38e6551e921fd4115fb44c1cb85d2fd843"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d6dce506bbabfba1c490c8de8706c180324e80dc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    - openstack"},{"line_number":39,"context_line":"dependencies:"},{"line_number":40,"context_line":"  - config_template"},{"line_number":41,"context_line":"  - python_venv_build"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9fdfeff1_296eeaff","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":21},"in_reply_to":"9fdfeff1_295d8a78","updated":"2019-02-26 11:40:59.000000000","message":"Thanks, got the idea. But still I have one query, if someone wants to install os_tempest locally and run locally then they need to install python_venv_build role manually, is there a way to automate it? like:\ngit clone \u003cos_tempest\u003e\npython setup.py install -\u003e it should also install python_venv_build role directly? is it possible?\n\nIt will help end user not to install multiple roles manually in order to run os_tempest.","commit_id":"549a1d38e6551e921fd4115fb44c1cb85d2fd843"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c2fba045c194d681c6198ed91e16ff3756417d8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    - openstack"},{"line_number":39,"context_line":"dependencies:"},{"line_number":40,"context_line":"  - config_template"},{"line_number":41,"context_line":"  - python_venv_build"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9fdfeff1_84e25d2f","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":21},"in_reply_to":"9fdfeff1_296eeaff","updated":"2019-02-26 11:58:59.000000000","message":"I imagine the way to do it would be to express the one as a python dependency of the other? I can\u0027t think of any other way to do it off-hand.","commit_id":"549a1d38e6551e921fd4115fb44c1cb85d2fd843"}],"tests/ansible-role-requirements.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5448c1ecc332d70415eeeb6ab31d7bade8b8dd5e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  src: https://git.openstack.org/openstack/ansible-role-python_venv_build"},{"line_number":76,"context_line":"  scm: git"},{"line_number":77,"context_line":"  version: master"},{"line_number":78,"context_line":"- name: config_template"},{"line_number":79,"context_line":"  src: https://git.openstack.org/openstack/ansible-config_template"},{"line_number":80,"context_line":"  scm: git"},{"line_number":81,"context_line":"  version: master"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_c0ce1a59","line":78,"updated":"2019-02-12 18:38:17.000000000","message":"This change is not required - https://review.openstack.org/635841 added the role to the role requirements file which applies to *all* roles.","commit_id":"46fed7fc4c8ed1e54f082fc618fca0f72e96a843"}]}
