)]}'
{"defaults/main.yml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"79d334d04f519ab2c53fc213a7e8e1913d91675a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"tempest_service_setup_host_python_interpreter: \"{{ openstack_service_setup_host_python_interpreter | default((tempest_service_setup_host \u003d\u003d \u0027localhost\u0027) | ternary(ansible_playbook_python, ansible_python[\u0027executable\u0027])) }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# tempest system user info"},{"line_number":39,"context_line":"tempest_system_user_name: \"{{ ansible_user_id }}\""},{"line_number":40,"context_line":"tempest_system_group_name: \"{{ ansible_group_id }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Toggle whether tempest actually executes"},{"line_number":43,"context_line":"tempest_run: no"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_2e93f9a4","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":51},"updated":"2019-03-01 10:28:18.000000000","message":"Will this always be ansible_user_id, or is just a default? If will always be ansible_user_id, why create a variable? If not, please add some notes here explaining why. What if ansible is being executed as root? Are we going to allow that?","commit_id":"3a35a36ee58584521d227f9c605d2c9e74157f8e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2f68a2a959d911b855b8809ab5ada16cb33bc91c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"tempest_service_setup_host_python_interpreter: \"{{ openstack_service_setup_host_python_interpreter | default((tempest_service_setup_host \u003d\u003d \u0027localhost\u0027) | ternary(ansible_playbook_python, ansible_python[\u0027executable\u0027])) }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# tempest system user info"},{"line_number":39,"context_line":"tempest_system_user_name: \"{{ ansible_user_id }}\""},{"line_number":40,"context_line":"tempest_system_group_name: \"{{ ansible_group_id }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Toggle whether tempest actually executes"},{"line_number":43,"context_line":"tempest_run: no"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_7bb8cae7","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":51},"in_reply_to":"9fdfeff1_2e93f9a4","updated":"2019-03-02 12:56:49.000000000","message":"I think adding these is unnecessary. See my comment in the task file.","commit_id":"3a35a36ee58584521d227f9c605d2c9e74157f8e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9ad602be56526760905cc4b2fdbd924b7169f035","unresolved":false,"context_lines":[{"line_number":36,"context_line":"tempest_service_setup_host_python_interpreter: \"{{ openstack_service_setup_host_python_interpreter | default((tempest_service_setup_host \u003d\u003d \u0027localhost\u0027) | ternary(ansible_playbook_python, ansible_python[\u0027executable\u0027])) }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# tempest system user info"},{"line_number":39,"context_line":"tempest_system_user_name: \"{{ ansible_user_id }}\""},{"line_number":40,"context_line":"tempest_system_group_name: \"{{ ansible_group_id }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Toggle whether tempest actually executes"},{"line_number":43,"context_line":"tempest_run: no"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_4ad64956","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":51},"in_reply_to":"9fdfeff1_7bb8cae7","updated":"2019-03-04 07:39:50.000000000","message":"Removed these users, I have few queries adding in the task file itself.","commit_id":"3a35a36ee58584521d227f9c605d2c9e74157f8e"}],"tasks/tempest_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2f68a2a959d911b855b8809ab5ada16cb33bc91c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - path: \"{{ tempest_log_dir | realpath }}\""},{"line_number":26,"context_line":"    - path: \"{{ tempest_image_dir }}\""},{"line_number":27,"context_line":"    - path: \"{{ tempest_workspace }}\""},{"line_number":28,"context_line":"    - path: \"/etc/tempest\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Copy tempest config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_fbe27a02","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":33},"updated":"2019-03-02 12:56:49.000000000","message":"This is in user space, so it can use whatever user Ansible is logged in as. The rest are in paths which a normal user doesn\u0027t have rights to by default. I think the best solution here is to do something like this in the file module arguments:\n\n    owner: \"{{ item.owner | default(omit) }}\"\n    group: \"{{ item.group | default(omit) }}\"\n\nAnd then for those which require ownership by the root user, add the appropriate argument in the with_item list, for example:\n\n  - path: \"{{ tempest_log_dir | realpath }}\"\n    owner: root","commit_id":"3a35a36ee58584521d227f9c605d2c9e74157f8e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9ad602be56526760905cc4b2fdbd924b7169f035","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - path: \"{{ tempest_log_dir | realpath }}\""},{"line_number":26,"context_line":"    - path: \"{{ tempest_image_dir }}\""},{"line_number":27,"context_line":"    - path: \"{{ tempest_workspace }}\""},{"line_number":28,"context_line":"    - path: \"/etc/tempest\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Copy tempest config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_caea390d","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":33},"in_reply_to":"9fdfeff1_fbe27a02","updated":"2019-03-04 07:39:50.000000000","message":"So here, tempest_workspace and tempest_image_dir are taken care by user but /etc/tempest and tempest log_dir should be owned by root, but for creating /etc/tempest we need to root, I have done the same, Please have a look.\n\nthanks!","commit_id":"3a35a36ee58584521d227f9c605d2c9e74157f8e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"249ee291cae766ebd2b891ac8bdfd353a5e09dd9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - path: \"{{ tempest_log_dir | realpath }}\""},{"line_number":26,"context_line":"      owner: root"},{"line_number":27,"context_line":"    - path: \"{{ tempest_image_dir }}\""},{"line_number":28,"context_line":"    - path: \"{{ tempest_workspace }}\""},{"line_number":29,"context_line":"    - path: \"/etc/tempest\""},{"line_number":30,"context_line":"      user: root"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_dbec49f6","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":34},"updated":"2019-03-04 10:19:53.000000000","message":"The default path for this is /opt/cache/files - should this have user/root ownership? Alternatively, should we change this default to use another path? The current path comes from the place where devstack stuff is cached so that we don\u0027t need to download the cirros image within openstack infra, because it\u0027s already there.","commit_id":"1ead7d3ffa978969a465d1b4fedd85131b268b6a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5eacc3ca2abb3629e69637d25687792d61e2b7f3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - path: \"{{ tempest_log_dir | realpath }}\""},{"line_number":26,"context_line":"      owner: root"},{"line_number":27,"context_line":"    - path: \"{{ tempest_image_dir }}\""},{"line_number":28,"context_line":"    - path: \"{{ tempest_workspace }}\""},{"line_number":29,"context_line":"    - path: \"/etc/tempest\""},{"line_number":30,"context_line":"      user: root"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_4a0f242f","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":34},"in_reply_to":"9fdfeff1_d65f400d","updated":"2019-03-04 11:16:39.000000000","message":"Well, We can make it use the user\u0027s home directory by default, something like https://github.com/openstack/openstack-ansible-os_octavia/blob/master/defaults/main.yml#L252 - but then we can make the test override that default location with the path that\u0027s relevant for openstack-infra so that we take advantage of the cached image.","commit_id":"1ead7d3ffa978969a465d1b4fedd85131b268b6a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a9cbbde7d6b60add3efe3c11a30ccd52ed47fcc6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - path: \"{{ tempest_log_dir | realpath }}\""},{"line_number":26,"context_line":"      owner: root"},{"line_number":27,"context_line":"    - path: \"{{ tempest_image_dir }}\""},{"line_number":28,"context_line":"    - path: \"{{ tempest_workspace }}\""},{"line_number":29,"context_line":"    - path: \"/etc/tempest\""},{"line_number":30,"context_line":"      user: root"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_d65f400d","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":34},"in_reply_to":"9fdfeff1_dbec49f6","updated":"2019-03-04 10:49:40.000000000","message":"for tempest_img_dir \u003d /opt/cache/files this path is readable by any user https://git.openstack.org/cgit/openstack-infra/project-config/tree/nodepool/elements/zuul-worker/install.d/60-zuul-worker#n49 but not writable.\n\nSo, I think it is a good idea to change the path may be ansible user home and modify image download task to first check whether image is there if not then download image https://github.com/openstack/openstack-ansible-os_tempest/blob/master/tasks/tempest_resources.yml#L40\n\nwhat you say?\nI will update this change in a separate patch set.","commit_id":"1ead7d3ffa978969a465d1b4fedd85131b268b6a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"249ee291cae766ebd2b891ac8bdfd353a5e09dd9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - path: \"{{ tempest_workspace }}\""},{"line_number":29,"context_line":"    - path: \"/etc/tempest\""},{"line_number":30,"context_line":"      user: root"},{"line_number":31,"context_line":"      owner: root"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Copy tempest config"},{"line_number":34,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_9bcfa18a","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":11},"updated":"2019-03-04 10:19:53.000000000","message":"Is this meant to be \u0027group\u0027?","commit_id":"1ead7d3ffa978969a465d1b4fedd85131b268b6a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a9cbbde7d6b60add3efe3c11a30ccd52ed47fcc6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - path: \"{{ tempest_workspace }}\""},{"line_number":29,"context_line":"    - path: \"/etc/tempest\""},{"line_number":30,"context_line":"      user: root"},{"line_number":31,"context_line":"      owner: root"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Copy tempest config"},{"line_number":34,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_fbbeedac","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":11},"in_reply_to":"9fdfeff1_9bcfa18a","updated":"2019-03-04 10:49:40.000000000","message":"Ah sorry, Nice catch! Will fix it!\nIt should owner/group not user/group.","commit_id":"1ead7d3ffa978969a465d1b4fedd85131b268b6a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e3fe3843a3d759cf9fe6a06c80d5d3e5ea291cd6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  config_template:"},{"line_number":35,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":36,"context_line":"    dest: \"/etc/tempest/tempest.conf\""},{"line_number":37,"context_line":"    owner: \"{{ item.owner | default(omit) }}\""},{"line_number":38,"context_line":"    group: \"{{ item.group | default(omit) }}\""},{"line_number":39,"context_line":"    mode: \"0644\""},{"line_number":40,"context_line":"    config_overrides: \"{{ tempest_tempest_conf_overrides }}\""},{"line_number":41,"context_line":"    config_type: \"ini\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_36700cdb","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":45},"updated":"2019-03-04 11:13:38.000000000","message":"These should remain root owned because they\u0027re in /etc and another user should not be able to modify the system default config. Also, there is no with_items loop here, so using item.* will not work here.","commit_id":"97819e67a139c71cf433348eca115d3db51892cf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f25242afa5c9cee5df3ae02e147fea8d89aa66c2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  config_template:"},{"line_number":35,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":36,"context_line":"    dest: \"/etc/tempest/tempest.conf\""},{"line_number":37,"context_line":"    owner: \"{{ item.owner | default(omit) }}\""},{"line_number":38,"context_line":"    group: \"{{ item.group | default(omit) }}\""},{"line_number":39,"context_line":"    mode: \"0644\""},{"line_number":40,"context_line":"    config_overrides: \"{{ tempest_tempest_conf_overrides }}\""},{"line_number":41,"context_line":"    config_type: \"ini\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_6dc5623d","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":45},"in_reply_to":"9fdfeff1_0db5b632","updated":"2019-03-04 12:18:03.000000000","message":"Something like that could be done, but then the entire role would need to be overhauled to make it usable as a non-root user that has sudo priveleges. I would recommend that be done as a review on its own which is tied to that purpose.","commit_id":"97819e67a139c71cf433348eca115d3db51892cf"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6ba28115566ad9a8050242b2fcaccfe42016d9d8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  config_template:"},{"line_number":35,"context_line":"    src: \"tempest.conf.j2\""},{"line_number":36,"context_line":"    dest: \"/etc/tempest/tempest.conf\""},{"line_number":37,"context_line":"    owner: \"{{ item.owner | default(omit) }}\""},{"line_number":38,"context_line":"    group: \"{{ item.group | default(omit) }}\""},{"line_number":39,"context_line":"    mode: \"0644\""},{"line_number":40,"context_line":"    config_overrides: \"{{ tempest_tempest_conf_overrides }}\""},{"line_number":41,"context_line":"    config_type: \"ini\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_0db5b632","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":45},"in_reply_to":"9fdfeff1_36700cdb","updated":"2019-03-04 12:01:28.000000000","message":"Thanks, I will fix it. Is it possible to use here something like this:\n- name: Copy tempest config\n  config_template:\n    src: \"tempest.conf.j2\"\n    dest: \"/etc/tempest/tempest.conf\"\n  become: true\nso any user having sudo privileges can do the operatin instead of tied to root?","commit_id":"97819e67a139c71cf433348eca115d3db51892cf"}]}
