)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"a4a846bc6998ff36397a868604bc5c328c195d44","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]Set fact tempest_install_method var for meta handler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In os_tempest role, stackviz is installed using python_venv_build"},{"line_number":10,"context_line":"role and tempest is installed from source or distro but once the"},{"line_number":11,"context_line":"tempest run finishes python_venv_build meta handler is called and"},{"line_number":12,"context_line":"it fails with tempest_install_method undefined variable but"},{"line_number":13,"context_line":"setting as a fact explicitly fix the issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I549c3b211a8affff30380435738ca685b794716d"},{"line_number":16,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_10663053","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":43},"updated":"2019-07-23 16:51:14.000000000","message":"Please split this in multiple sentences, even paragraphs. I run out of memory trying to parse it ;)","commit_id":"7c004613ad20f4272ec4b1dd38db3cab14e2e244"}],"tasks/tempest_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"78d869912676ddf74527c774adf32fa11cc0fe95","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# NOTE(noonedeadpunk/chkumar246):"},{"line_number":44,"context_line":"# Applying default filter for tempest_install_method is required despite the variable being defined"},{"line_number":45,"context_line":"# in defaults as in case of non-integrated tests meta handlers from other roles might fail."},{"line_number":46,"context_line":"- name: Set tempest_install_method fact"},{"line_number":47,"context_line":"  set_fact:"},{"line_number":48,"context_line":"     tempest_install_method: \"source\""},{"line_number":49,"context_line":"  when: tempest_run_stackviz | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_bebcd86c","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":35},"updated":"2019-07-23 09:12:44.000000000","message":"You should define tempest_install_method before checking it on L31","commit_id":"7c004613ad20f4272ec4b1dd38db3cab14e2e244"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2b2a873091ae470d0393de16381c0a8f3118e93e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  set_fact:"},{"line_number":38,"context_line":"     tempest_install_method: \"source\""},{"line_number":39,"context_line":"  when:"},{"line_number":40,"context_line":"    - tempest_run_stackviz | bool"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Install stackviz on venv"},{"line_number":43,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_91bd266a","line":40,"updated":"2019-07-25 08:02:00.000000000","message":"Only one when, put it in the same line, not as a list just to keep like the others","commit_id":"c99f3ee5ce116b96300eb8ab6bd23736d60677ba"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a917105fd98c2d776e6c06c8ba576cb719022676","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  set_fact:"},{"line_number":38,"context_line":"     tempest_install_method: \"source\""},{"line_number":39,"context_line":"  when:"},{"line_number":40,"context_line":"    - tempest_run_stackviz | bool"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Install stackviz on venv"},{"line_number":43,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_74597833","line":40,"in_reply_to":"7faddb67_91bd266a","updated":"2019-07-25 08:24:10.000000000","message":"Done","commit_id":"c99f3ee5ce116b96300eb8ab6bd23736d60677ba"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"abc41b294e1b90d30367393cd3d576dd60c5eec3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  import_tasks: tempest_install_source.yml"},{"line_number":31,"context_line":"  when: tempest_install_method \u003d\u003d \u0027source\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(noonedeadpunk/chkumar246):"},{"line_number":34,"context_line":"# Applying default filter for tempest_install_method is required despite the variable being defined"},{"line_number":35,"context_line":"# in defaults as in case of non-integrated tests meta handlers from other roles might fail."},{"line_number":36,"context_line":"- name: Set tempest_install_method fact"},{"line_number":37,"context_line":"  set_fact:"},{"line_number":38,"context_line":"     tempest_install_method: \"source\""},{"line_number":39,"context_line":"  when: tempest_run_stackviz | bool"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Install stackviz on venv"},{"line_number":42,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_14dcc472","line":39,"range":{"start_line":33,"start_character":0,"end_line":39,"end_character":35},"updated":"2019-07-25 08:42:18.000000000","message":"I\u0027m not really able to understand what is happening with the text here or the commit message. This seems to be combining stackviz isntall and source method without any understandable reason. What problem are we actually solving here?\n\nIn particular we are in part of the code here which is not conditional on install method.","commit_id":"7a421c0095fd0da71daa98736fc78ceb0a23a6be"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fc72d73aa397540c2ab96402e20ee22350329228","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  import_tasks: tempest_install_source.yml"},{"line_number":31,"context_line":"  when: tempest_install_method \u003d\u003d \u0027source\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(noonedeadpunk/chkumar246):"},{"line_number":34,"context_line":"# Applying default filter for tempest_install_method is required despite the variable being defined"},{"line_number":35,"context_line":"# in defaults as in case of non-integrated tests meta handlers from other roles might fail."},{"line_number":36,"context_line":"- name: Set tempest_install_method fact"},{"line_number":37,"context_line":"  set_fact:"},{"line_number":38,"context_line":"     tempest_install_method: \"source\""},{"line_number":39,"context_line":"  when: tempest_run_stackviz | bool"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Install stackviz on venv"},{"line_number":42,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_d4e38ca3","line":39,"range":{"start_line":33,"start_character":0,"end_line":39,"end_character":35},"in_reply_to":"7faddb67_14dcc472","updated":"2019-07-25 09:22:33.000000000","message":"I am not sure how to solve http://logs.openstack.org/19/667219/5/check/tripleo-ci-centos-7-standalone/a34fc53/job-output.txt.gz#_2019-07-22_10_35_04_992828 this issue, need help here.","commit_id":"7a421c0095fd0da71daa98736fc78ceb0a23a6be"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"84b51984eda49156c3ac6e817f2d80112e6b39be","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# in defaults as in case of non-integrated tests meta handlers from other roles might fail."},{"line_number":32,"context_line":"- name: Install Tempest packages from PIP"},{"line_number":33,"context_line":"  import_tasks: tempest_install_source.yml"},{"line_number":34,"context_line":"  when: (tempest_install_method | default(\u0027source\u0027)) \u003d\u003d \u0027source\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Install stackviz on venv"},{"line_number":37,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_5c9b2c65","side":"PARENT","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":51},"updated":"2019-07-26 16:34:49.000000000","message":"Missing this default is going to cause problems for OSA","commit_id":"95ed7b840d00a4331b6c5704680d1a1953c6ba58"}]}