)]}'
{"id":"openstack%2Fopenstack-ansible-os_tempest~675624","triplet_id":"openstack%2Fopenstack-ansible-os_tempest~master~I05651bff4eb85fda37eddb80074c23ac48b71201","project":"openstack/openstack-ansible-os_tempest","branch":"master","topic":"fix/os-spec-vars","hashtags":[],"change_id":"I05651bff4eb85fda37eddb80074c23ac48b71201","subject":"Improve loading of operating system specific vars","status":"ABANDONED","created":"2019-08-09 13:32:07.000000000","updated":"2020-01-29 10:19:16.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d0b4ccdacb476e04c29fec436d75ef955d3ba0c7","_number":675624,"virtual_id_number":675624,"owner":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":27379,"name":"jrosser","inactive":true},{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":1,"date":"2019-08-09 18:21:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27379,"name":"jrosser","inactive":true},{"value":1,"date":"2019-10-14 17:23:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-12 10:41:14.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2019-08-09 19:37:31.000000000","_account_id":27379,"name":"jrosser","inactive":true},{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},{"date":"2019-08-11 09:14:58.000000000","_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":27379,"name":"jrosser","inactive":true},{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"_account_id":27379,"name":"jrosser","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-09 13:32:46.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2019-08-09 13:33:15.000000000","updated_by":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"reviewer":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"state":"REVIEWER"},{"updated":"2019-08-09 13:33:25.000000000","updated_by":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"reviewer":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"state":"REVIEWER"},{"updated":"2019-08-09 18:21:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-09 19:37:31.000000000","updated_by":{"_account_id":27379,"name":"jrosser","inactive":true},"reviewer":{"_account_id":27379,"name":"jrosser","inactive":true},"state":"REVIEWER"},{"updated":"2019-08-11 09:14:58.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2019-08-12 10:41:14.000000000","updated_by":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"reviewer":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"state":"REVIEWER"},{"updated":"2019-10-14 17:23:06.000000000","updated_by":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"reviewer":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"state":"REVIEWER"}],"messages":[{"id":"4700885e669ce41bb69da1a740e43b56e8aa97f8","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2019-08-09 13:32:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"40e6f0e4b08eba07be5c97fd59b0a3d8c7eb05ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 15:03:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-ansible-linters https://logs.opendev.org/24/675624/1/check/openstack-ansible-linters/10515ac/ : SUCCESS in 9m 36s\n- openstack-ansible-deploy-aio_metal-debian-stable https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_metal-debian-stable/5ca926b/ : SUCCESS in 1h 09m 18s\n- openstack-ansible-deploy-aio_metal-centos-7 https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_metal-centos-7/c2acbc4/ : FAILURE in 1h 19m 50s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_metal-opensuse-15/f65dcf1/ : FAILURE in 1h 05m 53s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/b786805/ : SUCCESS in 1h 15m 21s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_distro_metal-centos-7/64d00d1/ : FAILURE in 50m 58s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_distro_metal-opensuse-15/393bbe9/ : FAILURE in 46m 33s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic/41eb9d9/ : SUCCESS in 48m 59s\n- openstack-tox-docs https://logs.opendev.org/24/675624/1/check/openstack-tox-docs/83e5a41/html/ : SUCCESS in 4m 55s\n- openstack-ansible-deploy-aio_distro_metal_tempestconf-centos-7 https://logs.opendev.org/24/675624/1/check/openstack-ansible-deploy-aio_distro_metal_tempestconf-centos-7/28ee681/ : FAILURE in 46m 46s\n- tripleo-ci-centos-7-standalone-os-tempest https://logs.opendev.org/24/675624/1/check/tripleo-ci-centos-7-standalone-os-tempest/07bffab/ : FAILURE in 51m 51s","accounts_in_message":[],"_revision_number":1},{"id":"f6a998bc3dc7b6eca2576e07b7b04e536b4b2687","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2019-08-09 16:24:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a3578d3507f80099c00b89429c217fd33a489efc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 18:21:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://logs.opendev.org/24/675624/2/check/openstack-ansible-linters/92103ba/ : SUCCESS in 8m 22s\n- openstack-ansible-deploy-aio_metal-debian-stable https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_metal-debian-stable/156d15a/ : SUCCESS in 1h 05m 58s\n- openstack-ansible-deploy-aio_metal-centos-7 https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_metal-centos-7/022757f/ : SUCCESS in 1h 38m 37s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_metal-opensuse-15/bd20cdb/ : SUCCESS in 1h 11m 31s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/1456a88/ : SUCCESS in 1h 00m 48s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_distro_metal-centos-7/3a62753/ : SUCCESS in 1h 06m 04s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_distro_metal-opensuse-15/4934492/ : SUCCESS in 51m 19s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic/21d95a0/ : SUCCESS in 49m 00s\n- openstack-tox-docs https://logs.opendev.org/24/675624/2/check/openstack-tox-docs/af0a81b/html/ : SUCCESS in 4m 36s\n- openstack-ansible-deploy-aio_distro_metal_tempestconf-centos-7 https://logs.opendev.org/24/675624/2/check/openstack-ansible-deploy-aio_distro_metal_tempestconf-centos-7/8b1571f/ : SUCCESS in 1h 07m 09s\n- tripleo-ci-centos-7-standalone-os-tempest https://logs.opendev.org/24/675624/2/check/tripleo-ci-centos-7-standalone-os-tempest/a71a848/ : SUCCESS in 1h 17m 48s","accounts_in_message":[],"_revision_number":2},{"id":"683199f19e06353ed00c44e11daf1f919112cb21","author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"date":"2019-08-12 10:41:14.000000000","message":"Patch Set 2: Code-Review+1\n\nI check the docs, seems to be okay, I wonder if this way will run faster than conditional...","accounts_in_message":[],"_revision_number":2},{"id":"0348b1301a87e7fd40005a512fa066d0fef322dc","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2019-10-14 17:23:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"daa3c898114569593125977001522014ae01ce60","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2020-01-29 10:19:16.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d04b658e63bc839be1431bba273db064ac896a14","revisions":{"ae4ee0c69e2e15c8de7e7783743c63cb90165e55":{"kind":"REWORK","_number":1,"created":"2019-08-09 13:32:07.000000000","uploader":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"ref":"refs/changes/24/675624/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_tempest","ref":"refs/changes/24/675624/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/1"}}},"commit":{"parents":[{"commit":"6f5e0518dd055678b94df995ac7f841faa4359b4","subject":"Updated from OpenStack Ansible Tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_tempest/commit/6f5e0518dd055678b94df995ac7f841faa4359b4"}]}],"author":{"name":"Sorin Sbarnea","email":"ssbarnea@redhat.com","date":"2019-08-09 13:19:51.000000000","tz":60},"committer":{"name":"Sorin Sbarnea","email":"ssbarnea@redhat.com","date":"2019-08-09 13:19:51.000000000","tz":60},"subject":"Improve loading of operating system specific vars","message":"Improve loading of operating system specific vars\n\nImproves the overlayed var loading pattern by addressing two problems\nwith current implementation:\n\n* Avoid confusion between os_family and distribution\n* Loads all files, allowing to define variable in less places\n\nThat newer pattern is already used in few other repositories.\n\nMore details on https://docs.sbarnea.com/ansible/ansible-disto-vars\n\nChange-Id: I05651bff4eb85fda37eddb80074c23ac48b71201\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_tempest/commit/ae4ee0c69e2e15c8de7e7783743c63cb90165e55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_tempest/commit/ae4ee0c69e2e15c8de7e7783743c63cb90165e55"}]},"branch":"refs/heads/master"},"d04b658e63bc839be1431bba273db064ac896a14":{"kind":"REWORK","_number":2,"created":"2019-08-09 16:24:34.000000000","uploader":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"ref":"refs/changes/24/675624/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_tempest","ref":"refs/changes/24/675624/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_tempest refs/changes/24/675624/2"}}},"commit":{"parents":[{"commit":"6f5e0518dd055678b94df995ac7f841faa4359b4","subject":"Updated from OpenStack Ansible Tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_tempest/commit/6f5e0518dd055678b94df995ac7f841faa4359b4"}]}],"author":{"name":"Sorin Sbarnea","email":"ssbarnea@redhat.com","date":"2019-08-09 13:19:51.000000000","tz":60},"committer":{"name":"Sorin Sbarnea","email":"ssbarnea@redhat.com","date":"2019-08-09 16:23:59.000000000","tz":60},"subject":"Improve loading of operating system specific vars","message":"Improve loading of operating system specific vars\n\nImproves the overlayed var loading pattern by addressing two problems\nwith current implementation:\n\n* Avoid confusion between os_family and distribution\n* Loads all files, allowing to define variable in less places\n\nThat newer pattern is already used in few other repositories.\n\nMore details on https://docs.sbarnea.com/ansible/ansible-disto-vars\n\nChange-Id: I05651bff4eb85fda37eddb80074c23ac48b71201\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_tempest/commit/d04b658e63bc839be1431bba273db064ac896a14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_tempest/commit/d04b658e63bc839be1431bba273db064ac896a14"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}