)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"62815f480ac2ea110db972e13a8b9dff83f3830e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"tempestconf image profile var requires images url so introducing"},{"line_number":16,"context_line":"new var tempest_tempestconf_image will fix the issue."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib1e78a6ce2085df82d2a22db6817e800432f2f05"},{"line_number":19,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df33271e_88ff1700","line":18,"updated":"2020-03-25 15:12:32.000000000","message":"related-bug https://bugs.launchpad.net/tripleo/+bug/1868938","commit_id":"88f9dd7eb51f743bb5c2bafbdba715f35bb51b12"}],"defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7c29fe0598127457ee9d25925ccc774a77c5af01","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  debug: true"},{"line_number":321,"context_line":"  create: true"},{"line_number":322,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":323,"context_line":"  image: \"{{ tempest_images }}\""},{"line_number":324,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":325,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":326,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_e9b6c4d9","line":323,"updated":"2020-03-24 11:07:20.000000000","message":"where is tempest_images defined?\n\nhttps://github.com/openstack/openstack-ansible-os_tempest/search?q\u003dtempest_images\u0026unscoped_q\u003dtempest_images\n\n\nwill we need to set that on our side and make it point to our rdo images location?","commit_id":"2b803be87aa0a82d0f1bf98dac264af2a3d63c6a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4ab8e3147d6ce89cff108f874be8fef3cbb1f164","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  debug: true"},{"line_number":321,"context_line":"  create: true"},{"line_number":322,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":323,"context_line":"  image: \"{{ tempest_images }}\""},{"line_number":324,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":325,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":326,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_df9d725a","line":323,"in_reply_to":"df33271e_e939a441","updated":"2020-03-24 13:03:39.000000000","message":"tempest_images indicates there can be more than 1 image, it\u0027s a list and that lead to an error because tempestconf tried to use the following value as image:\n\nimage_path \u003d [{\u0027url\u0027: \u0027https://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img\u0027, \u0027checksum\u0027: \u0027sha256:a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8\u0027, \u0027name\u0027: \u0027cirros\u0027, \u0027format\u0027: \u0027qcow2\u0027}, {\u0027url\u0027: \u0027https://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img\u0027, \u0027checksum\u0027: \u0027sha256:a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8\u0027, \u0027name\u0027: \u0027cirros\u0027, \u0027format\u0027: \u0027qcow2\u0027}","commit_id":"2b803be87aa0a82d0f1bf98dac264af2a3d63c6a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"16af687cd564c04bbee60736a5656996c98d07ea","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  debug: true"},{"line_number":321,"context_line":"  create: true"},{"line_number":322,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":323,"context_line":"  image: \"{{ tempest_images }}\""},{"line_number":324,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":325,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":326,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_e939a441","line":323,"in_reply_to":"df33271e_e9b6c4d9","updated":"2020-03-24 11:11:30.000000000","message":"https://opendev.org/openstack/openstack-ansible-os_tempest/src/branch/master/defaults/main.yml#L252 is defined here and for tripleo here is the changes https://review.opendev.org/714609","commit_id":"2b803be87aa0a82d0f1bf98dac264af2a3d63c6a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1b2a70fb21e77b69e9a166e3e7cc17df751ae584","unresolved":false,"context_lines":[{"line_number":316,"context_line":"  - \"--constraint {{ tempest_upper_constraints_url }}\""},{"line_number":317,"context_line":"tempest_tempestconf_pip_packages:"},{"line_number":318,"context_line":"  - python-tempestconf"},{"line_number":319,"context_line":"tempest_tempestconf_image: \"{{ tempest_images[0][\u0027url\u0027] }}\""},{"line_number":320,"context_line":"tempest_tempestconf_profile:"},{"line_number":321,"context_line":"  debug: true"},{"line_number":322,"context_line":"  create: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_3ffe0737","line":319,"range":{"start_line":319,"start_character":0,"end_line":319,"end_character":59},"updated":"2020-03-25 13:44:19.000000000","message":"I\u0027d say to comment it out and write some description for docs","commit_id":"0fce7b22c61629b3865562c9a64332eb909fc5cc"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f3e06757ff1536a8658d04de74c3ed88e724f348","unresolved":false,"context_lines":[{"line_number":316,"context_line":"  - \"--constraint {{ tempest_upper_constraints_url }}\""},{"line_number":317,"context_line":"tempest_tempestconf_pip_packages:"},{"line_number":318,"context_line":"  - python-tempestconf"},{"line_number":319,"context_line":"tempest_tempestconf_image: \"{{ tempest_images[0][\u0027url\u0027] }}\""},{"line_number":320,"context_line":"tempest_tempestconf_profile:"},{"line_number":321,"context_line":"  debug: true"},{"line_number":322,"context_line":"  create: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_4d6ec195","line":319,"range":{"start_line":319,"start_character":0,"end_line":319,"end_character":59},"in_reply_to":"df33271e_3ffe0737","updated":"2020-03-25 14:41:56.000000000","message":"Done","commit_id":"0fce7b22c61629b3865562c9a64332eb909fc5cc"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1b2a70fb21e77b69e9a166e3e7cc17df751ae584","unresolved":false,"context_lines":[{"line_number":321,"context_line":"  debug: true"},{"line_number":322,"context_line":"  create: true"},{"line_number":323,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":324,"context_line":"  image: \"{{ tempest_tempestconf_image }}\""},{"line_number":325,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":326,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":327,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_c222a0a4","line":324,"range":{"start_line":324,"start_character":38,"end_line":324,"end_character":39},"updated":"2020-03-25 13:44:19.000000000","message":"| default(\u0027omit\u0027)","commit_id":"0fce7b22c61629b3865562c9a64332eb909fc5cc"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f3e06757ff1536a8658d04de74c3ed88e724f348","unresolved":false,"context_lines":[{"line_number":321,"context_line":"  debug: true"},{"line_number":322,"context_line":"  create: true"},{"line_number":323,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":324,"context_line":"  image: \"{{ tempest_tempestconf_image }}\""},{"line_number":325,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":326,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":327,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_2d69bd8a","line":324,"range":{"start_line":324,"start_character":38,"end_line":324,"end_character":39},"in_reply_to":"df33271e_c222a0a4","updated":"2020-03-25 14:41:56.000000000","message":"Done","commit_id":"0fce7b22c61629b3865562c9a64332eb909fc5cc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bb5d6422a11ef3e781170cb2f64a962c7427bf56","unresolved":false,"context_lines":[{"line_number":323,"context_line":"  debug: true"},{"line_number":324,"context_line":"  create: true"},{"line_number":325,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":326,"context_line":"  image: \"{{ tempest_tempestconf_image | default(\u0027omit\u0027) }}\""},{"line_number":327,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":328,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":329,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_cca2ca4b","line":326,"range":{"start_line":326,"start_character":41,"end_line":326,"end_character":56},"updated":"2020-03-25 23:27:11.000000000","message":"is it \u0027omit\u0027 for sure? ... it ended up in python-tempestconf with: Creating image \u0027omit\u0027  .. so it\u0027s default(omit) not default(\u0027omit\u0027) probably","commit_id":"88f9dd7eb51f743bb5c2bafbdba715f35bb51b12"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b8439b8e28d9dd1267a7e430aa6ecfc45c1678ff","unresolved":false,"context_lines":[{"line_number":323,"context_line":"  debug: true"},{"line_number":324,"context_line":"  create: true"},{"line_number":325,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":326,"context_line":"  image: \"{{ tempest_tempestconf_image | default(\u0027omit\u0027) }}\""},{"line_number":327,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":328,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":329,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_cddc8376","line":326,"range":{"start_line":326,"start_character":41,"end_line":326,"end_character":56},"in_reply_to":"df33271e_cca2ca4b","updated":"2020-03-26 06:28:25.000000000","message":"you are correct https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#omitting-parameters","commit_id":"88f9dd7eb51f743bb5c2bafbdba715f35bb51b12"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6b8e64a755a545f71600a9ea74db95f275823627","unresolved":false,"context_lines":[{"line_number":323,"context_line":"  debug: true"},{"line_number":324,"context_line":"  create: true"},{"line_number":325,"context_line":"  os-cloud: \"{{ tempest_cloud_name }}\""},{"line_number":326,"context_line":"  image: \"{{ tempest_tempestconf_image | default(omit) }}\""},{"line_number":327,"context_line":"  out: \"{{ tempest_workspace }}/etc/tempest.conf\""},{"line_number":328,"context_line":"  network-id: \"{{ tempest_neutron_public_network_id }}\""},{"line_number":329,"context_line":"  overrides: \"{{ tempest_tempest_conf_overrides | default(\u0027omit\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_d61c14c3","line":326,"range":{"start_line":326,"start_character":0,"end_line":326,"end_character":58},"updated":"2020-03-26 11:10:18.000000000","message":"I\u0027m afraid this won\u0027t work, if you set image to whatever value, python-tempestconf will take it as user\u0027s wish and use it .. meaning if it\u0027s set to None, None value will be used and it\u0027ll fail, if it\u0027s set to an empty string the same will happen etc ..\n\nbtw, ansible thanks to default(omit) put some ansible object to the var and it failed with:\n\nCreating image \u0027__omit_place_holder__cb3d8cef9b979f7741c411d11aee6d702e62ce5c\u0027\n\nyou need to figure out a way how to set the var conditionally","commit_id":"03797c5ccd2483631fe95d4d29682b5737fe16e9"}]}