)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     62a2536b (Merge \"Cleanup py27 support\")"},{"line_number":2,"context_line":"Author:     Amol Kahat \u003camolkahat@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2020-04-17 18:10:52 +0530"},{"line_number":4,"context_line":"Commit:     Amol Kahat \u003camolkahat@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4c43b2_8eaf00e2","line":1,"updated":"2020-04-17 13:52:54.000000000","message":"This could really do with some extra detail about how these changes are intended to be used. Is the expectation a single node or multi node CI job? What about if it is used to validate a real world deployment? Please remember that this ansible role is used outside tripleo and as such it should make no assumptions about variables or other data which might be globally defined there.","commit_id":"229d60d21a41db917c0042563021b371c5387280"}],"defaults/main.yml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4ed0eff1b494c41486ba11068a0a922b4c4ba8c3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"tempest_public_subnet_cidr: \"10.1.13.0/24\""},{"line_number":129,"context_line":"# Neutron default gateway to first ip of subnet, usually .1"},{"line_number":130,"context_line":"# tempest_public_subnet_gateway_ip:"},{"line_number":131,"context_line":"tempest_public_net_provider_type: \"flattempest_private_net_physical_name\""},{"line_number":132,"context_line":"# TODO(chkumar246):"},{"line_number":133,"context_line":"# The use of _type is to provide backwards compatibility for"},{"line_number":134,"context_line":"# overrides in S and can be removed in T."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_c35d2a48","line":131,"updated":"2020-04-28 09:37:27.000000000","message":"You should not change the default here you should change it on your job","commit_id":"90ac82d717a8f3de0eef59c0ea8acbb82d88640e"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"b02689dfdd5df12dc752b6bf47d37a6d0c1c14c5","unresolved":false,"context_lines":[{"line_number":128,"context_line":"tempest_public_subnet_cidr: \"10.1.13.0/24\""},{"line_number":129,"context_line":"# Neutron default gateway to first ip of subnet, usually .1"},{"line_number":130,"context_line":"# tempest_public_subnet_gateway_ip:"},{"line_number":131,"context_line":"tempest_public_net_provider_type: \"flattempest_private_net_physical_name\""},{"line_number":132,"context_line":"# TODO(chkumar246):"},{"line_number":133,"context_line":"# The use of _type is to provide backwards compatibility for"},{"line_number":134,"context_line":"# overrides in S and can be removed in T."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_1e9005ed","line":131,"in_reply_to":"1f493fa4_c35d2a48","updated":"2020-04-28 10:52:14.000000000","message":"by mistake i changed here. I mean pasted.","commit_id":"90ac82d717a8f3de0eef59c0ea8acbb82d88640e"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"adeaa4eba32665f188846af5d0c867ca62f70312","unresolved":false,"context_lines":[{"line_number":334,"context_line":"tempest_run_stackviz: true"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"# ironic plugin variables"},{"line_number":337,"context_line":"tinyipa_name: \"tinyipa-master\""},{"line_number":338,"context_line":"tinyipa_kernel: \"{{tinyipa_name}}.vmlinuz\""},{"line_number":339,"context_line":"tinyipa_ramdisk: \"{{tinyipa_name}}.gz\""},{"line_number":340,"context_line":"ironic_tarball: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/{{tinyipa_name}}.tar.gz\""},{"line_number":341,"context_line":"tinyipa_dir: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/tinyipa/\""},{"line_number":342,"context_line":"ironic_network_name: \"provision-network\""},{"line_number":343,"context_line":"ironic_subnet_name: \"provision-subnet\""},{"line_number":344,"context_line":"ironic_network_cidr: 192.168.24.0/24"},{"line_number":345,"context_line":"ironic_network_gateway: 192.168.24.40"},{"line_number":346,"context_line":"ironic_allocation_pool_start: 192.168.24.41"},{"line_number":347,"context_line":"ironic_allocation_pool_end: 192.168.24.100"},{"line_number":348,"context_line":"ironic_ipmi_address: \"127.0.0.1\""},{"line_number":349,"context_line":"ironic_ipmi_username: \"admin\""},{"line_number":350,"context_line":"ironic_ipmi_password: \"password\""},{"line_number":351,"context_line":"ironic_ipmi_port1: 1161"},{"line_number":352,"context_line":"ironic_ipmi_port2: 1162"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_7398f61a","line":352,"range":{"start_line":337,"start_character":0,"end_line":352,"end_character":23},"updated":"2020-05-04 10:48:37.000000000","message":"the variables in this file should start with tempest_ to namespace them to this role","commit_id":"072f39204f0076d53ba8b89ed2f45b4b1f268112"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f60ffd458826a3c8e351a6d6b012762e63c28c8c","unresolved":false,"context_lines":[{"line_number":334,"context_line":"tempest_run_stackviz: true"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"# ironic plugin variables"},{"line_number":337,"context_line":"tinyipa_name: \"tinyipa-master\""},{"line_number":338,"context_line":"tinyipa_kernel: \"{{tinyipa_name}}.vmlinuz\""},{"line_number":339,"context_line":"tinyipa_ramdisk: \"{{tinyipa_name}}.gz\""},{"line_number":340,"context_line":"ironic_tarball: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/{{tinyipa_name}}.tar.gz\""},{"line_number":341,"context_line":"tinyipa_dir: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/tinyipa/\""},{"line_number":342,"context_line":"ironic_network_name: \"provision-network\""},{"line_number":343,"context_line":"ironic_subnet_name: \"provision-subnet\""},{"line_number":344,"context_line":"ironic_network_cidr: 192.168.24.0/24"},{"line_number":345,"context_line":"ironic_network_gateway: 192.168.24.40"},{"line_number":346,"context_line":"ironic_allocation_pool_start: 192.168.24.41"},{"line_number":347,"context_line":"ironic_allocation_pool_end: 192.168.24.100"},{"line_number":348,"context_line":"ironic_ipmi_address: \"127.0.0.1\""},{"line_number":349,"context_line":"ironic_ipmi_username: \"admin\""},{"line_number":350,"context_line":"ironic_ipmi_password: \"password\""},{"line_number":351,"context_line":"ironic_ipmi_port1: 1161"},{"line_number":352,"context_line":"ironic_ipmi_port2: 1162"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_a25eb0e3","line":352,"range":{"start_line":337,"start_character":0,"end_line":352,"end_character":23},"in_reply_to":"1f493fa4_69f9cb7e","updated":"2020-05-29 08:55:12.000000000","message":"I believe that while these variables are here together, it\u0027s fine","commit_id":"072f39204f0076d53ba8b89ed2f45b4b1f268112"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"a6aa63e07610b7822604ad19357c21d8f58f48a8","unresolved":false,"context_lines":[{"line_number":334,"context_line":"tempest_run_stackviz: true"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"# ironic plugin variables"},{"line_number":337,"context_line":"tinyipa_name: \"tinyipa-master\""},{"line_number":338,"context_line":"tinyipa_kernel: \"{{tinyipa_name}}.vmlinuz\""},{"line_number":339,"context_line":"tinyipa_ramdisk: \"{{tinyipa_name}}.gz\""},{"line_number":340,"context_line":"ironic_tarball: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/{{tinyipa_name}}.tar.gz\""},{"line_number":341,"context_line":"tinyipa_dir: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/tinyipa/\""},{"line_number":342,"context_line":"ironic_network_name: \"provision-network\""},{"line_number":343,"context_line":"ironic_subnet_name: \"provision-subnet\""},{"line_number":344,"context_line":"ironic_network_cidr: 192.168.24.0/24"},{"line_number":345,"context_line":"ironic_network_gateway: 192.168.24.40"},{"line_number":346,"context_line":"ironic_allocation_pool_start: 192.168.24.41"},{"line_number":347,"context_line":"ironic_allocation_pool_end: 192.168.24.100"},{"line_number":348,"context_line":"ironic_ipmi_address: \"127.0.0.1\""},{"line_number":349,"context_line":"ironic_ipmi_username: \"admin\""},{"line_number":350,"context_line":"ironic_ipmi_password: \"password\""},{"line_number":351,"context_line":"ironic_ipmi_port1: 1161"},{"line_number":352,"context_line":"ironic_ipmi_port2: 1162"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_69f9cb7e","line":352,"range":{"start_line":337,"start_character":0,"end_line":352,"end_character":23},"in_reply_to":"1f493fa4_7398f61a","updated":"2020-05-08 10:49:52.000000000","message":"Adding variable names with tempest_ is not good idea. Because it is not directly related to the tempest. It is same like stackviz variable added above.","commit_id":"072f39204f0076d53ba8b89ed2f45b4b1f268112"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"71f2ec71c791880f2596f50586736952be1a943d","unresolved":false,"context_lines":[{"line_number":339,"context_line":"tinyipa_ramdisk: \"{{tinyipa_name}}.gz\""},{"line_number":340,"context_line":"ironic_tarball: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/{{tinyipa_name}}.tar.gz\""},{"line_number":341,"context_line":"tinyipa_dir: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/tinyipa/\""},{"line_number":342,"context_line":"ironic_network_name: \"provisioning\""},{"line_number":343,"context_line":"ironic_subnet_name: \"provision-subnet\""},{"line_number":344,"context_line":"ironic_network_cidr: 192.168.24.0/24"},{"line_number":345,"context_line":"ironic_network_gateway: 192.168.24.40"},{"line_number":346,"context_line":"ironic_allocation_pool_start: 192.168.24.41"},{"line_number":347,"context_line":"ironic_allocation_pool_end: 192.168.24.100"},{"line_number":348,"context_line":"ironic_ipmi_address: \"127.0.0.1\""},{"line_number":349,"context_line":"ironic_ipmi_username: \"admin\""},{"line_number":350,"context_line":"ironic_ipmi_password: \"password\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_c956e15c","line":347,"range":{"start_line":342,"start_character":0,"end_line":347,"end_character":42},"updated":"2020-05-18 10:07:02.000000000","message":"It can be reused in featureset 60 by putting vars like this: http://paste.openstack.org/show/793731/","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"790a319f7fb19b91a605f9fa0159de68ae409187","unresolved":false,"context_lines":[{"line_number":330,"context_line":"tempest_run_stackviz: true"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"# ironic plugin variables"},{"line_number":333,"context_line":"tinyipa_name: \"tinyipa-master\""},{"line_number":334,"context_line":"tinyipa_kernel: \"{{tinyipa_name}}.vmlinuz\""},{"line_number":335,"context_line":"tinyipa_ramdisk: \"{{tinyipa_name}}.gz\""},{"line_number":336,"context_line":"ironic_tarball: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/{{tinyipa_name}}.tar.gz\""},{"line_number":337,"context_line":"tinyipa_dir: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/tinyipa/\""},{"line_number":338,"context_line":"ironic_ipmi_address: \"127.0.0.1\""},{"line_number":339,"context_line":"ironic_ipmi_username: \"admin\""},{"line_number":340,"context_line":"ironic_ipmi_password: \"password\""},{"line_number":341,"context_line":"ironic_ipmi_port1: 1161"},{"line_number":342,"context_line":"ironic_ipmi_port2: 1162"},{"line_number":343,"context_line":"ironic_switch_name: \u0027net-ans-br\u0027"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_9bf1bd6e","line":343,"range":{"start_line":333,"start_character":0,"end_line":343,"end_character":32},"updated":"2020-08-05 13:33:44.000000000","message":"The convention across OSA is to namespace these variables with the tempest_ prefix. Is there a reason for these not being prefixed in the same way as the others?","commit_id":"f06f2c4173026f0b452b2bc5a601e6d22279f93f"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"98b4ab770f2ea0f3b807c8709639359e5f1fbee0","unresolved":false,"context_lines":[{"line_number":330,"context_line":"tempest_run_stackviz: true"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"# ironic plugin variables"},{"line_number":333,"context_line":"tinyipa_name: \"tinyipa-master\""},{"line_number":334,"context_line":"tinyipa_kernel: \"{{tinyipa_name}}.vmlinuz\""},{"line_number":335,"context_line":"tinyipa_ramdisk: \"{{tinyipa_name}}.gz\""},{"line_number":336,"context_line":"ironic_tarball: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/{{tinyipa_name}}.tar.gz\""},{"line_number":337,"context_line":"tinyipa_dir: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/tinyipa/\""},{"line_number":338,"context_line":"ironic_ipmi_address: \"127.0.0.1\""},{"line_number":339,"context_line":"ironic_ipmi_username: \"admin\""},{"line_number":340,"context_line":"ironic_ipmi_password: \"password\""},{"line_number":341,"context_line":"ironic_ipmi_port1: 1161"},{"line_number":342,"context_line":"ironic_ipmi_port2: 1162"},{"line_number":343,"context_line":"ironic_switch_name: \u0027net-ans-br\u0027"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_32ffe667","line":343,"range":{"start_line":333,"start_character":0,"end_line":343,"end_character":32},"in_reply_to":"9f560f44_9bf1bd6e","updated":"2020-08-06 07:42:57.000000000","message":"Done","commit_id":"f06f2c4173026f0b452b2bc5a601e6d22279f93f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"67ead8704b14ad39c0110e23328dc0e2454d0141","unresolved":false,"context_lines":[{"line_number":329,"context_line":"stackviz_venv_bin: \"/openstack/venvs/stackviz/bin\""},{"line_number":330,"context_line":"tempest_run_stackviz: true"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"# ironic plugin variables"},{"line_number":333,"context_line":"tempest_tinyipa_name: \"tinyipa-master\""},{"line_number":334,"context_line":"tempest_tinyipa_kernel: \"{{tempest_tinyipa_name}}.vmlinuz\""},{"line_number":335,"context_line":"tempest_tinyipa_ramdisk: \"{{tempest_tinyipa_name}}.gz\""},{"line_number":336,"context_line":"tempest_tinyipa_url: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/files/{{tempest_tinyipa_name}}\""},{"line_number":337,"context_line":"tempest_tinyipa_dir: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/tinyipa/\""},{"line_number":338,"context_line":"tempest_ironic_ipmi_address: \"127.0.0.1\""},{"line_number":339,"context_line":"tempest_ironic_ipmi_username: \"admin\""},{"line_number":340,"context_line":"tempest_ironic_ipmi_password: \"password\""},{"line_number":341,"context_line":"tempest_ironic_ipmi_port1: 1161"},{"line_number":342,"context_line":"tempest_ironic_ipmi_port2: 1162"},{"line_number":343,"context_line":"tempest_ironic_node1_name: \"node1\""},{"line_number":344,"context_line":"tempest_ironic_node1_port_id: \"ovs-node1i1\""},{"line_number":345,"context_line":"tempest_ironic_node1_switch_id: \"66:0d:1d:d8:0b:11\""},{"line_number":346,"context_line":"tempest_ironic_node2_name: \"node2\""},{"line_number":347,"context_line":"tempest_ironic_node2_port_id: \"ovs-node2i1\""},{"line_number":348,"context_line":"tempest_ironic_node2_switch_id: \"66:0d:1d:d8:0b:22\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_53229753","line":348,"range":{"start_line":332,"start_character":0,"end_line":348,"end_character":51},"updated":"2020-08-20 16:29:12.000000000","message":"Can we move it out of defaults to some file inside vars?","commit_id":"659fc7af4983916aa29c1ade31cdbe3a61f18780"}],"tasks/tempest_ironic_node_create.yml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"24649e7b2e6405e1e2f14745af5cbec43eb899b1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    --driver-info ipmi_password\u003d\"{{ ironic_ipmi_password }}\" --driver-info ipmi_address\u003d\"{{ ironic_ipmi_address }}\" \\"},{"line_number":6,"context_line":"    --driver-info ipmi_port\u003d\"{{ port }}\" --resource-class baremetal --name {{ node_name }} -f value -c uuid"},{"line_number":7,"context_line":"  environment:"},{"line_number":8,"context_line":"    OS_CLOUD: \"{{ tempest_cloud_name }}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: \"Create baremetal port\""},{"line_number":11,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ff570b3c_60166658","line":8,"updated":"2020-06-08 07:29:37.000000000","message":"You can remove all these environments and add in the include_task, it will be more easy to track changes","commit_id":"6081c0cefa4f42cb891f21398c35a7b8c71760d2"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"fae315c2006ac333240d713e19b75cc02ae8b0ae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    --driver-info ipmi_password\u003d\"{{ ironic_ipmi_password }}\" --driver-info ipmi_address\u003d\"{{ ironic_ipmi_address }}\" \\"},{"line_number":6,"context_line":"    --driver-info ipmi_port\u003d\"{{ port }}\" --resource-class baremetal --name {{ node_name }} -f value -c uuid"},{"line_number":7,"context_line":"  environment:"},{"line_number":8,"context_line":"    OS_CLOUD: \"{{ tempest_cloud_name }}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: \"Create baremetal port\""},{"line_number":11,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ff570b3c_83546400","line":8,"in_reply_to":"ff570b3c_60166658","updated":"2020-06-08 07:37:43.000000000","message":"I tried it[1]. But it didn\u0027t worked. :(\n\n[1] https://review.opendev.org/#/c/720705/15..11/tasks/tempest_ironic_resources.yml","commit_id":"6081c0cefa4f42cb891f21398c35a7b8c71760d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92d8980490ae3af4816bab71a7543c836d33a905","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    openstack baremetal node create --driver ipmi --driver-info ipmi_username\u003d\"{{ ironic_ipmi_username }}\" \\"},{"line_number":5,"context_line":"    --driver-info ipmi_password\u003d\"{{ ironic_ipmi_password }}\" --driver-info ipmi_address\u003d\"{{ ironic_ipmi_address }}\" \\"},{"line_number":6,"context_line":"    --driver-info ipmi_port\u003d\"{{ item.baremetal_port }}\" --resource-class baremetal --name {{ item.node_name }} \\"},{"line_number":7,"context_line":"    -f value -c uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: \"Create baremetal port\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_5a8851c5","line":6,"updated":"2020-06-16 12:11:04.000000000","message":"do you want to set `--network-interface neutron`? It is required for testing multi-tenant networking.","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"41c265baed62507f7d41e3206abf09af71f43554","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    openstack baremetal node create --driver ipmi --driver-info ipmi_username\u003d\"{{ ironic_ipmi_username }}\" \\"},{"line_number":5,"context_line":"    --driver-info ipmi_password\u003d\"{{ ironic_ipmi_password }}\" --driver-info ipmi_address\u003d\"{{ ironic_ipmi_address }}\" \\"},{"line_number":6,"context_line":"    --driver-info ipmi_port\u003d\"{{ item.baremetal_port }}\" --resource-class baremetal --name {{ item.node_name }} \\"},{"line_number":7,"context_line":"    -f value -c uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: \"Create baremetal port\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_03ecb4c5","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":57},"updated":"2020-06-16 14:10:49.000000000","message":"explicitly setting a port and assuming ipmi basically limits where and how this test can be used. In essence virtually in CI, and in no other live tempest scenario test against live running infrastucture.","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"41c265baed62507f7d41e3206abf09af71f43554","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  shell: |"},{"line_number":11,"context_line":"    openstack baremetal port create --node {{ baremetal_node_created.stdout }} \\"},{"line_number":12,"context_line":"    --local-link-connection port_id\u003d{{ item.port_id }} \\"},{"line_number":13,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 {{ item.switch_id }}"},{"line_number":14,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: \"Set properties to node\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_a377c83a","line":13,"updated":"2020-06-16 14:10:49.000000000","message":"This makes sense if your going to use the neutron network interface as dmitry noted above, otherwise you don\u0027t need local-link-connection information if your on a flat network.","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92d8980490ae3af4816bab71a7543c836d33a905","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"},{"line_number":18,"context_line":"    openstack baremetal node set --property memory_mb\u003d512 --property cpus\u003d1 \\"},{"line_number":19,"context_line":"    --property local_gb\u003d1 --property cpu_arch\u003dx86_64 {{ baremetal_node_created.stdout }}"},{"line_number":20,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: \"Manage node\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_5ab1718f","line":19,"updated":"2020-06-16 12:11:04.000000000","message":"local_gb\u003d1 looks wrong, ironic will refuse to install on such tiny disks. I\u0027d go with a 5G disk (setting 4G here to account for partitioning - an old quirk of ironic).\n\nmemory_mb and cpus are no longer needed","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"41c265baed62507f7d41e3206abf09af71f43554","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"},{"line_number":18,"context_line":"    openstack baremetal node set --property memory_mb\u003d512 --property cpus\u003d1 \\"},{"line_number":19,"context_line":"    --property local_gb\u003d1 --property cpu_arch\u003dx86_64 {{ baremetal_node_created.stdout }}"},{"line_number":20,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: \"Manage node\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_43918c52","line":19,"in_reply_to":"bf51134e_5ab1718f","updated":"2020-06-16 14:10:49.000000000","message":"We should strip out that limitation since nova no longer uses it.","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"41c265baed62507f7d41e3206abf09af71f43554","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    openstack baremetal node set {{ baremetal_node_created.stdout }} \\"},{"line_number":29,"context_line":"    --driver-info deploy_kernel\u003d{{ ipa_kernel_created.id }} \\"},{"line_number":30,"context_line":"    --driver-info deploy_ramdisk\u003d{{ ipa_ramdisk_created.id }}"},{"line_number":31,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: \"Manage node\""},{"line_number":34,"context_line":"  shell: \"openstack baremetal node provide {{ baremetal_node_created.stdout }} --wait\\n\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_439fcc4f","line":31,"updated":"2020-06-16 14:10:49.000000000","message":"fyi, you can set this before managing the node.","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5630875010072247e4a36f6fc4db7f59f3be5efd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  shell: \"openstack baremetal node manage {{ baremetal_node_created.stdout }} --wait\\n\""},{"line_number":30,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"Provision node\""},{"line_number":33,"context_line":"  shell: \"openstack baremetal node provide {{ baremetal_node_created.stdout }} --wait\\n\""},{"line_number":34,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf51134e_a876873d","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":40},"updated":"2020-07-01 22:36:23.000000000","message":"Provide does not provision the node. It moves it to the available state from the manageable state.\n\nYou would need to issue the deploy command to provision a node.","commit_id":"c2fdd6f1dd1704ad09a910f82105a879b22a1ee4"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"f58cb00c08e5662a2f66c3fb3bff44676af0377b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  shell: \"openstack baremetal node manage {{ baremetal_node_created.stdout }} --wait\\n\""},{"line_number":30,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"Provision node\""},{"line_number":33,"context_line":"  shell: \"openstack baremetal node provide {{ baremetal_node_created.stdout }} --wait\\n\""},{"line_number":34,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf51134e_3578e08d","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":40},"in_reply_to":"bf51134e_a876873d","updated":"2020-07-06 13:29:02.000000000","message":"To run successful tests do we need to provision node?\n\nChanges are exercise here: https://review.opendev.org/#/c/723876/\n\nJob: scenario-012","commit_id":"c2fdd6f1dd1704ad09a910f82105a879b22a1ee4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openstack baremetal port create --node {{ baremetal_node_created.stdout }} \\"},{"line_number":12,"context_line":"    --local-link-connection port_id\u003d{{ item.port_id }} \\"},{"line_number":13,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 {{ item.switch_id }}"},{"line_number":14,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_b11679f0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":40},"updated":"2020-08-04 13:12:44.000000000","message":"Are there other return codes? If it returns with an RC !\u003d0 then the \u0027Create baremetal node\u0027 task will fail and none of these will run anyway, so these conditionals are pointless.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    openstack baremetal port create --node {{ baremetal_node_created.stdout }} \\"},{"line_number":12,"context_line":"    --local-link-connection port_id\u003d{{ item.port_id }} \\"},{"line_number":13,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 {{ item.switch_id }}"},{"line_number":14,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_d68b1165","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":40},"in_reply_to":"9f560f44_b11679f0","updated":"2020-08-05 09:57:26.000000000","message":"okay. I\u0027ll remove it.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"},{"line_number":18,"context_line":"    openstack baremetal node set --property local_gb\u003d5 --property cpu_arch\u003dx86_64 {{ baremetal_node_created.stdout }}"},{"line_number":19,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: \"Set Kernel and Ramdisk to node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_11d5a51c","line":18,"range":{"start_line":18,"start_character":75,"end_line":18,"end_character":81},"updated":"2020-08-04 13:12:44.000000000","message":"Is there ever an intent to support other architectures?","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"},{"line_number":18,"context_line":"    openstack baremetal node set --property local_gb\u003d5 --property cpu_arch\u003dx86_64 {{ baremetal_node_created.stdout }}"},{"line_number":19,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: \"Set Kernel and Ramdisk to node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_51db9d4d","line":18,"range":{"start_line":18,"start_character":53,"end_line":18,"end_character":54},"updated":"2020-08-04 13:12:44.000000000","message":"This looks like it\u0027s making an assumption on a specific image. Are we sure that assumption is valid?","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"},{"line_number":18,"context_line":"    openstack baremetal node set --property local_gb\u003d5 --property cpu_arch\u003dx86_64 {{ baremetal_node_created.stdout }}"},{"line_number":19,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: \"Set Kernel and Ramdisk to node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_56f541ec","line":18,"range":{"start_line":18,"start_character":75,"end_line":18,"end_character":81},"in_reply_to":"9f560f44_11d5a51c","updated":"2020-08-05 09:57:26.000000000","message":"Not sure about the other architectures. But currently we are using x86_64 for testing.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: \"Set properties to node\""},{"line_number":17,"context_line":"  shell: |"},{"line_number":18,"context_line":"    openstack baremetal node set --property local_gb\u003d5 --property cpu_arch\u003dx86_64 {{ baremetal_node_created.stdout }}"},{"line_number":19,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: \"Set Kernel and Ramdisk to node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_36d36d62","line":18,"range":{"start_line":18,"start_character":53,"end_line":18,"end_character":54},"in_reply_to":"9f560f44_51db9d4d","updated":"2020-08-05 09:57:26.000000000","message":"Yes. Ironic team uses ipa disk images to provision nodes. And we are using the same images.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: \"Set Kernel and Ramdisk to node\""},{"line_number":22,"context_line":"  shell: |"},{"line_number":23,"context_line":"    openstack baremetal node set {{ baremetal_node_created.stdout }} \\"},{"line_number":24,"context_line":"    --driver-info deploy_kernel\u003d{{ ipa_kernel_created.id }} \\"},{"line_number":25,"context_line":"    --driver-info deploy_ramdisk\u003d{{ ipa_ramdisk_created.id }}"},{"line_number":26,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Manage node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_b1eb19da","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":61},"updated":"2020-08-04 13:12:44.000000000","message":"This can be done with a different continuation which reads easier and is easier to maintain because we won\u0027t be forgetting to add the trailing slash.\n\n  shell: \u003e-\n    openstack baremetal node set {{ baremetal_node_created.stdout }}\n    --driver-info deploy_kernel\u003d{{ ipa_kernel_created.id }}\n    --driver-info deploy_ramdisk\u003d{{ ipa_ramdisk_created.id }}","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: \"Set Kernel and Ramdisk to node\""},{"line_number":22,"context_line":"  shell: |"},{"line_number":23,"context_line":"    openstack baremetal node set {{ baremetal_node_created.stdout }} \\"},{"line_number":24,"context_line":"    --driver-info deploy_kernel\u003d{{ ipa_kernel_created.id }} \\"},{"line_number":25,"context_line":"    --driver-info deploy_ramdisk\u003d{{ ipa_ramdisk_created.id }}"},{"line_number":26,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Manage node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_16d8e978","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":61},"in_reply_to":"9f560f44_b1eb19da","updated":"2020-08-05 09:57:26.000000000","message":"Done.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Manage node\""},{"line_number":29,"context_line":"  shell: \"openstack baremetal node manage {{ baremetal_node_created.stdout }} --wait\\n\""},{"line_number":30,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"Provision node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_91237556","line":29,"range":{"start_line":29,"start_character":84,"end_line":29,"end_character":86},"updated":"2020-08-04 13:12:44.000000000","message":"What\u0027s this for? Is it necessary?","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Manage node\""},{"line_number":29,"context_line":"  shell: \"openstack baremetal node manage {{ baremetal_node_created.stdout }} --wait\\n\""},{"line_number":30,"context_line":"  when: \"baremetal_node_created.rc \u003d\u003d 0\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"Provision node\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_76c965aa","line":29,"range":{"start_line":29,"start_character":84,"end_line":29,"end_character":86},"in_reply_to":"9f560f44_91237556","updated":"2020-08-05 09:57:26.000000000","message":"No. It\u0027s just linter. Fixed.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eeaffc95c04032a15b1d481a144b845ef046a726","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    --local-link-connection port_id\u003d{{ item.port_id }}"},{"line_number":15,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 {{ item.switch_id }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: \"Set properties to node\""},{"line_number":18,"context_line":"  shell: \u003e-"},{"line_number":19,"context_line":"    openstack baremetal node set --property local_gb\u003d5 --property cpu_arch\u003dx86_64 {{ baremetal_node_created.stdout }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: \"Set Kernel and Ramdisk to node\""},{"line_number":22,"context_line":"  shell: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f560f44_d894c939","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":117},"updated":"2020-08-06 09:33:56.000000000","message":"nit: I\u0027d like to have seen this written vertically to make it easier to read.\n\n- name: \"Set properties to node\"\n  shell: \u003e-\n    openstack baremetal node set\n    --property local_gb\u003d5\n    --property cpu_arch\u003dx86_64\n    {{ baremetal_node_created.stdout }}","commit_id":"45203eafce83f41aff3d3d0b63870f8fec17569d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8e4f9c8eb55ef952537703bc46f20f04bb945338","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    --driver-info ipmi_password\u003d\"{{ tempest_ironic_ipmi_password }}\""},{"line_number":7,"context_line":"    --driver-info ipmi_address\u003d\"{{ tempest_ironic_ipmi_address }}\""},{"line_number":8,"context_line":"    --driver-info ipmi_port\u003d\"{{ item.baremetal_port }}\""},{"line_number":9,"context_line":"    --network-interface neutron --resource-class baremetal"},{"line_number":10,"context_line":"    --name {{ item.node_name }} -f value -c uuid"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: \"Create baremetal port\""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"9f560f44_99f66590","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":31},"updated":"2020-09-16 13:00:26.000000000","message":"It should be replaced by this tempest_public_net_provider_type var and https://opendev.org/openstack/openstack-ansible-os_tempest/src/branch/master/defaults/main.yml#L134 and will fix the current issue","commit_id":"75d0158a2d5089eb57529b4cbdf93d64476ee879"}],"tasks/tempest_ironic_resources.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6f954574fcfa669b8bbe2dbc9019ab92cd41231c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: \"Create directory\""},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_7d8de8d1","line":1,"updated":"2020-04-20 10:34:29.000000000","message":"It needs to be moved under tasks/tempest_resources.yaml.\nAll these tasks will be executed when tempest_service_available_ironic is true.","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    group: \"{{ansible_user_gid}}\""},{"line_number":8,"context_line":"    recurse: yes"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: \"Get tineyipa {{release}} stable image\""},{"line_number":11,"context_line":"  get_url:"},{"line_number":12,"context_line":"    url: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/tinyipa-stable-{{release}}.tar.gz\""},{"line_number":13,"context_line":"    dest: \"{{tinyipa_dir}}/tinyipa-stable-{{release}}.tar.gz\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_73ad3b30","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":21},"updated":"2020-04-17 13:52:54.000000000","message":"typo","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    group: \"{{ansible_user_gid}}\""},{"line_number":8,"context_line":"    recurse: yes"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: \"Get tineyipa {{release}} stable image\""},{"line_number":11,"context_line":"  get_url:"},{"line_number":12,"context_line":"    url: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/tinyipa-stable-{{release}}.tar.gz\""},{"line_number":13,"context_line":"    dest: \"{{tinyipa_dir}}/tinyipa-stable-{{release}}.tar.gz\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_937727d5","line":10,"range":{"start_line":10,"start_character":24,"end_line":10,"end_character":31},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined? you should only be using variables which are declared or documented in defaults/main.yml, and they should be namespaced to this role","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: \"Get tineyipa {{release}} stable image\""},{"line_number":11,"context_line":"  get_url:"},{"line_number":12,"context_line":"    url: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/tinyipa-stable-{{release}}.tar.gz\""},{"line_number":13,"context_line":"    dest: \"{{tinyipa_dir}}/tinyipa-stable-{{release}}.tar.gz\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: \"Extract the image\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_334a937f","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":110},"updated":"2020-04-17 13:52:54.000000000","message":"this variable should really be defined in the defaults","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6f954574fcfa669b8bbe2dbc9019ab92cd41231c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    src: \"{{ tinyipa_dir }}/tinyipa-stable-{{release}}.tar.gz\""},{"line_number":18,"context_line":"    dest: \"{{ tinyipa_dir }}/\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: \"Create ipa kernel image\""},{"line_number":21,"context_line":"  os_image:"},{"line_number":22,"context_line":"    cloud: \"{{ tempest_cloud_name }}\""},{"line_number":23,"context_line":"    name: deploy-kernel"},{"line_number":24,"context_line":"    container_format: aki"},{"line_number":25,"context_line":"    disk_format: aki"},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    filename: \"{{ tinyipa_dir }}/tinyipa-stable-{{release}}.vmlinuz\""},{"line_number":28,"context_line":"    is_public: yes"},{"line_number":29,"context_line":"  register: ipa_kernel_created"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: \"Create ipa ram disk\""},{"line_number":32,"context_line":"  os_image:"},{"line_number":33,"context_line":"    cloud: \"{{ tempest_cloud_name }}\""},{"line_number":34,"context_line":"    name: deploy-ramdisk"},{"line_number":35,"context_line":"    container_format: ari"},{"line_number":36,"context_line":"    disk_format: ari"},{"line_number":37,"context_line":"    filename: \"{{ tinyipa_dir }}/tinyipa-stable-{{release}}.gz\""},{"line_number":38,"context_line":"    state: present"},{"line_number":39,"context_line":"    is_public: yes"},{"line_number":40,"context_line":"  register: ipa_ramdisk_created"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: \"Create CirrOS image\""},{"line_number":43,"context_line":"  os_image:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_bdc490f6","line":40,"range":{"start_line":20,"start_character":0,"end_line":40,"end_character":31},"updated":"2020-04-20 10:34:29.000000000","message":"Please take a look at cirros task example, may be we can reuse the same task for creating ironic related images.","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    is_public: yes"},{"line_number":40,"context_line":"  register: ipa_ramdisk_created"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: \"Create CirrOS image\""},{"line_number":43,"context_line":"  os_image:"},{"line_number":44,"context_line":"    cloud: \"{{ tempest_cloud_name }}\""},{"line_number":45,"context_line":"    name: cirros"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_d35a4f4d","line":42,"range":{"start_line":42,"start_character":2,"end_line":42,"end_character":29},"updated":"2020-04-17 13:52:54.000000000","message":"is the previously created cirros image suitable?","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    name: provisioning"},{"line_number":56,"context_line":"    state: present"},{"line_number":57,"context_line":"    external: true"},{"line_number":58,"context_line":"    provider_physical_network: datacenter"},{"line_number":59,"context_line":"    provider_network_type: flat"},{"line_number":60,"context_line":"    shared: yes"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_b3550320","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":41},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    state: present"},{"line_number":57,"context_line":"    external: true"},{"line_number":58,"context_line":"    provider_physical_network: datacenter"},{"line_number":59,"context_line":"    provider_network_type: flat"},{"line_number":60,"context_line":"    shared: yes"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- name: \"Create \u0027provisioning-subnet\u0027 subnet\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_4e585831","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":31},"updated":"2020-04-17 13:52:54.000000000","message":"should probably be a variable","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    name: \u0027provisioning-subnet\u0027"},{"line_number":66,"context_line":"    network_name: \"provisioning\""},{"line_number":67,"context_line":"    state: present"},{"line_number":68,"context_line":"    cidr: 192.168.24.0/24"},{"line_number":69,"context_line":"    gateway_ip: 192.168.24.40"},{"line_number":70,"context_line":"    allocation_pool_start: 192.168.24.41"},{"line_number":71,"context_line":"    allocation_pool_end: 192.168.24.100"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- name: \"Create baremetal node\""},{"line_number":74,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_0e4e506e","line":71,"range":{"start_line":68,"start_character":0,"end_line":71,"end_character":39},"updated":"2020-04-17 13:52:54.000000000","message":"these should probably all be variables","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"- name: \"Create baremetal port\""},{"line_number":81,"context_line":"  shell: |"},{"line_number":82,"context_line":"    openstack baremetal port create --node {{baremetal_node1_created.stdout}} \\"},{"line_number":83,"context_line":"    --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":84,"context_line":"    --local-link-connection port_id\u003dovs-node1i1 \\"},{"line_number":85,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:11"},{"line_number":86,"context_line":"  when: baremetal_node1_created.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_932567c5","line":83,"range":{"start_line":83,"start_character":40,"end_line":83,"end_character":50},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  shell: |"},{"line_number":82,"context_line":"    openstack baremetal port create --node {{baremetal_node1_created.stdout}} \\"},{"line_number":83,"context_line":"    --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":84,"context_line":"    --local-link-connection port_id\u003dovs-node1i1 \\"},{"line_number":85,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:11"},{"line_number":86,"context_line":"  when: baremetal_node1_created.rc \u003d\u003d 0"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_d32fef9e","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":47},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"- name: \"Create baremetal port for node2\""},{"line_number":119,"context_line":"  shell: |"},{"line_number":120,"context_line":"    openstack baremetal port create --node {{baremetal_node2_created.stdout}} \\"},{"line_number":121,"context_line":"    --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":122,"context_line":"    --local-link-connection port_id\u003dovs-node1i2 \\"},{"line_number":123,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:22"},{"line_number":124,"context_line":"  when: baremetal_node2_created.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_4e0a1821","line":121,"range":{"start_line":121,"start_character":40,"end_line":121,"end_character":50},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  shell: |"},{"line_number":120,"context_line":"    openstack baremetal port create --node {{baremetal_node2_created.stdout}} \\"},{"line_number":121,"context_line":"    --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":122,"context_line":"    --local-link-connection port_id\u003dovs-node1i2 \\"},{"line_number":123,"context_line":"    --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:22"},{"line_number":124,"context_line":"  when: baremetal_node2_created.rc \u003d\u003d 0"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_2e0d0c37","line":122,"range":{"start_line":122,"start_character":36,"end_line":122,"end_character":47},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4ed0eff1b494c41486ba11068a0a922b4c4ba8c3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        allocation_pool_start: \"{{ironic_allocation_pool_start}}\""},{"line_number":64,"context_line":"        allocation_pool_end: \"{{ironic_allocation_pool_end}}\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    - name: \"Create baremetal node\""},{"line_number":68,"context_line":"      shell: |"},{"line_number":69,"context_line":"        openstack baremetal node create --driver ipmi --driver-info ipmi_username\u003d\"{{ironic_ipmi_username}}\" \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_2357ae28","line":66,"updated":"2020-04-28 09:37:27.000000000","message":"two lines space here","commit_id":"90ac82d717a8f3de0eef59c0ea8acbb82d88640e"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4ed0eff1b494c41486ba11068a0a922b4c4ba8c3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        openstack baremetal node provide {{baremetal_node2_created.stdout}} --wait"},{"line_number":141,"context_line":"      when: baremetal_node2_created.rc \u003d\u003d 0"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  # TODO: MAC shouldn\u0027t be hardcoded"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_03543220","line":143,"updated":"2020-04-28 09:37:27.000000000","message":"What about this comment? also try to use TODO(youruser):","commit_id":"90ac82d717a8f3de0eef59c0ea8acbb82d88640e"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"b02689dfdd5df12dc752b6bf47d37a6d0c1c14c5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        openstack baremetal node provide {{baremetal_node2_created.stdout}} --wait"},{"line_number":141,"context_line":"      when: baremetal_node2_created.rc \u003d\u003d 0"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  # TODO: MAC shouldn\u0027t be hardcoded"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_fe8c39d8","line":143,"in_reply_to":"1f493fa4_03543220","updated":"2020-04-28 10:52:14.000000000","message":"Done","commit_id":"90ac82d717a8f3de0eef59c0ea8acbb82d88640e"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"adeaa4eba32665f188846af5d0c867ca62f70312","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    - name: \"Create baremetal port\""},{"line_number":74,"context_line":"      shell: |"},{"line_number":75,"context_line":"        openstack baremetal port create --node {{baremetal_node1_created.stdout}} \\"},{"line_number":76,"context_line":"        --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":77,"context_line":"        --local-link-connection port_id\u003dovs-node1i1 \\"},{"line_number":78,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:11"},{"line_number":79,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_93bca26d","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":54},"updated":"2020-05-04 10:48:37.000000000","message":"this should probably also be a variable - is this the name given to an instance of OVS?","commit_id":"072f39204f0076d53ba8b89ed2f45b4b1f268112"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"adeaa4eba32665f188846af5d0c867ca62f70312","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    - name: \"Set properties to node\""},{"line_number":82,"context_line":"      shell: |"},{"line_number":83,"context_line":"        openstack baremetal node set --property memory_mb\u003d4096 --property cpus\u003d4 \\"},{"line_number":84,"context_line":"        --property local_gb\u003d10 --property cpu_arch\u003dx86_64 {{baremetal_node1_created.stdout}}"},{"line_number":85,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_b370bede","line":83,"range":{"start_line":83,"start_character":48,"end_line":83,"end_character":80},"updated":"2020-05-04 10:48:37.000000000","message":"are these nodes booted as virtual machines in the test environment - if so these seem large for 8G 8core test instances","commit_id":"072f39204f0076d53ba8b89ed2f45b4b1f268112"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"adeaa4eba32665f188846af5d0c867ca62f70312","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    - name: \"Create baremetal port for node2\""},{"line_number":110,"context_line":"      shell: |"},{"line_number":111,"context_line":"        openstack baremetal port create --node {{baremetal_node2_created.stdout}} \\"},{"line_number":112,"context_line":"        --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":113,"context_line":"        --local-link-connection port_id\u003dovs-node1i2 \\"},{"line_number":114,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:22"},{"line_number":115,"context_line":"      when: \"baremetal_node2_created.rc \u003d\u003d 0\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_13b0928b","line":112,"range":{"start_line":112,"start_character":44,"end_line":112,"end_character":54},"updated":"2020-05-04 10:48:37.000000000","message":"also should be a variable","commit_id":"072f39204f0076d53ba8b89ed2f45b4b1f268112"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    - name: \"Get tinyipa master image\""},{"line_number":14,"context_line":"      get_url:"},{"line_number":15,"context_line":"        dest: \"{{tinyipa_dir}}\""},{"line_number":16,"context_line":"        url: \"{{ironic_tarball}}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: \"Extract the image\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_7b8b061e","line":15,"updated":"2020-05-19 08:23:14.000000000","message":"space between the {{ }}","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - name: \"Extract the image\""},{"line_number":19,"context_line":"      unarchive:"},{"line_number":20,"context_line":"        dest: \"{{ tinyipa_dir }}/\""},{"line_number":21,"context_line":"        src: \"{{tinyipa_dir}}/{{ironic_tarball.split(\u0027/\u0027)[-1]}}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: \"Create ipa kernel image\""},{"line_number":24,"context_line":"      os_image:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_5b90c24a","line":21,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":26,"context_line":"        container_format: aki"},{"line_number":27,"context_line":"        disk_format: aki"},{"line_number":28,"context_line":"        filename: \"{{tinyipa_dir}}/{{tinyipa_kernel}}\""},{"line_number":29,"context_line":"        is_public: true"},{"line_number":30,"context_line":"        name: deploy-kernel"},{"line_number":31,"context_line":"        state: present"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_bb811efe","line":28,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      os_network:"},{"line_number":47,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":48,"context_line":"        external: true"},{"line_number":49,"context_line":"        name: \"{{ironic_network_name}}\""},{"line_number":50,"context_line":"        provider_network_type: \"{{ tempest_public_net_provider_type }}\""},{"line_number":51,"context_line":"        provider_physical_network: \"{{ tempest_public_net_physical_name | default(omit) }}\""},{"line_number":52,"context_line":"        shared: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_9b86da12","line":49,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        shared: true"},{"line_number":53,"context_line":"        state: present"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: \"Create \u0027provisioning-subnet\u0027 subnet\""},{"line_number":56,"context_line":"      os_subnet:"},{"line_number":57,"context_line":"        allocation_pool_end: \"{{ironic_allocation_pool_end}}\""},{"line_number":58,"context_line":"        allocation_pool_start: \"{{ironic_allocation_pool_start}}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_fb7ef616","line":55,"updated":"2020-05-19 08:23:14.000000000","message":"Why the single quote here?","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      os_subnet:"},{"line_number":57,"context_line":"        allocation_pool_end: \"{{ironic_allocation_pool_end}}\""},{"line_number":58,"context_line":"        allocation_pool_start: \"{{ironic_allocation_pool_start}}\""},{"line_number":59,"context_line":"        cidr: \"{{ironic_network_cidr}}\""},{"line_number":60,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":61,"context_line":"        gateway_ip: \"{{ironic_network_gateway}}\""},{"line_number":62,"context_line":"        name: \"{{ironic_subnet_name}}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_db7b3225","line":59,"updated":"2020-05-19 08:23:14.000000000","message":"space","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        allocation_pool_start: \"{{ironic_allocation_pool_start}}\""},{"line_number":59,"context_line":"        cidr: \"{{ironic_network_cidr}}\""},{"line_number":60,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":61,"context_line":"        gateway_ip: \"{{ironic_network_gateway}}\""},{"line_number":62,"context_line":"        name: \"{{ironic_subnet_name}}\""},{"line_number":63,"context_line":"        network_name: \"{{ironic_network_name}}\""},{"line_number":64,"context_line":"        state: present"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_3b750e33","line":61,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        cidr: \"{{ironic_network_cidr}}\""},{"line_number":60,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":61,"context_line":"        gateway_ip: \"{{ironic_network_gateway}}\""},{"line_number":62,"context_line":"        name: \"{{ironic_subnet_name}}\""},{"line_number":63,"context_line":"        network_name: \"{{ironic_network_name}}\""},{"line_number":64,"context_line":"        state: present"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_1b72ca49","line":62,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":61,"context_line":"        gateway_ip: \"{{ironic_network_gateway}}\""},{"line_number":62,"context_line":"        name: \"{{ironic_subnet_name}}\""},{"line_number":63,"context_line":"        network_name: \"{{ironic_network_name}}\""},{"line_number":64,"context_line":"        state: present"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    - name: \"Create baremetal node\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_7b902644","line":63,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        network_name: \"{{ironic_network_name}}\""},{"line_number":64,"context_line":"        state: present"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    - name: \"Create baremetal node\""},{"line_number":67,"context_line":"      register: baremetal_node1_created"},{"line_number":68,"context_line":"      shell: |"},{"line_number":69,"context_line":"        openstack baremetal node create --driver ipmi --driver-info ipmi_username\u003d\"{{ironic_ipmi_username}}\" \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_5b956232","line":66,"updated":"2020-05-19 08:23:14.000000000","message":"So, you are duplicating all these tasks for node1 and node1, can\u0027t it be a loop?","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    - name: \"Create baremetal node\""},{"line_number":67,"context_line":"      register: baremetal_node1_created"},{"line_number":68,"context_line":"      shell: |"},{"line_number":69,"context_line":"        openstack baremetal node create --driver ipmi --driver-info ipmi_username\u003d\"{{ironic_ipmi_username}}\" \\"},{"line_number":70,"context_line":"        --driver-info ipmi_password\u003d\"{{ironic_ipmi_password}}\" --driver-info ipmi_address\u003d\"{{ironic_ipmi_address}}\" \\"},{"line_number":71,"context_line":"        --driver-info ipmi_port\u003d\"{{ironic_ipmi_port1}}\" --resource-class baremetal --name node1 -f value -c uuid"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_bb963e3d","line":69,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      register: baremetal_node1_created"},{"line_number":68,"context_line":"      shell: |"},{"line_number":69,"context_line":"        openstack baremetal node create --driver ipmi --driver-info ipmi_username\u003d\"{{ironic_ipmi_username}}\" \\"},{"line_number":70,"context_line":"        --driver-info ipmi_password\u003d\"{{ironic_ipmi_password}}\" --driver-info ipmi_address\u003d\"{{ironic_ipmi_address}}\" \\"},{"line_number":71,"context_line":"        --driver-info ipmi_port\u003d\"{{ironic_ipmi_port1}}\" --resource-class baremetal --name node1 -f value -c uuid"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    - name: \"Create baremetal port\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_9b9b7a64","line":70,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    - name: \"Create baremetal port\""},{"line_number":74,"context_line":"      shell: |"},{"line_number":75,"context_line":"        openstack baremetal port create --node {{baremetal_node1_created.stdout}} \\"},{"line_number":76,"context_line":"        --local-link-connection switch_info\u003d{{ironic_switch_name}} \\"},{"line_number":77,"context_line":"        --local-link-connection port_id\u003dovs-node1i1 \\"},{"line_number":78,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:11"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_fba3969c","line":75,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    - name: \"Create baremetal port\""},{"line_number":74,"context_line":"      shell: |"},{"line_number":75,"context_line":"        openstack baremetal port create --node {{baremetal_node1_created.stdout}} \\"},{"line_number":76,"context_line":"        --local-link-connection switch_info\u003d{{ironic_switch_name}} \\"},{"line_number":77,"context_line":"        --local-link-connection port_id\u003dovs-node1i1 \\"},{"line_number":78,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:11"},{"line_number":79,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_dba05293","line":76,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    - name: \"Set properties to node\""},{"line_number":82,"context_line":"      shell: |"},{"line_number":83,"context_line":"        openstack baremetal node set --property memory_mb\u003d512 --property cpus\u003d1 \\"},{"line_number":84,"context_line":"        --property local_gb\u003d1 --property cpu_arch\u003dx86_64 {{baremetal_node1_created.stdout}}"},{"line_number":85,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: \"Manage node\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_3baa2e70","line":84,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: \"Manage node\""},{"line_number":88,"context_line":"      shell: \"openstack baremetal node manage {{baremetal_node1_created.stdout}} --wait\\n\""},{"line_number":89,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    - name: \"Set Kernel and Ramdisk to node\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_1ba76aa9","line":88,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    - name: \"Set Kernel and Ramdisk to node\""},{"line_number":92,"context_line":"      shell: |"},{"line_number":93,"context_line":"        openstack baremetal node set {{baremetal_node1_created.stdout}} \\"},{"line_number":94,"context_line":"        --driver-info deploy_kernel\u003d{{ipa_kernel_created.id}} \\"},{"line_number":95,"context_line":"        --driver-info deploy_ramdisk\u003d{{ipa_ramdisk_created.id}}"},{"line_number":96,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_7bb946ca","line":93,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    - name: \"Set Kernel and Ramdisk to node\""},{"line_number":92,"context_line":"      shell: |"},{"line_number":93,"context_line":"        openstack baremetal node set {{baremetal_node1_created.stdout}} \\"},{"line_number":94,"context_line":"        --driver-info deploy_kernel\u003d{{ipa_kernel_created.id}} \\"},{"line_number":95,"context_line":"        --driver-info deploy_ramdisk\u003d{{ipa_ramdisk_created.id}}"},{"line_number":96,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_5bbe02b4","line":94,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"150b9a47872ff52a1ad847200deb9742341d4a97","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      shell: |"},{"line_number":93,"context_line":"        openstack baremetal node set {{baremetal_node1_created.stdout}} \\"},{"line_number":94,"context_line":"        --driver-info deploy_kernel\u003d{{ipa_kernel_created.id}} \\"},{"line_number":95,"context_line":"        --driver-info deploy_ramdisk\u003d{{ipa_ramdisk_created.id}}"},{"line_number":96,"context_line":"      when: \"baremetal_node1_created.rc \u003d\u003d 0\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    - name: \"Manage node\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_bbaf5e7b","line":95,"updated":"2020-05-19 08:23:14.000000000","message":"ditto","commit_id":"344bcc2bdcb66ce1e556bcaf244f73dba9aead8c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92d8980490ae3af4816bab71a7543c836d33a905","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - name: \"Extract the image\""},{"line_number":19,"context_line":"      unarchive:"},{"line_number":20,"context_line":"        dest: \"{{ tinyipa_dir }}/\""},{"line_number":21,"context_line":"        src: \"{{ tinyipa_dir }}/{{ ironic_tarball.split(\u0027/\u0027)[-1] }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: \"Create ipa kernel image\""},{"line_number":24,"context_line":"      os_image:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_1a9ff903","line":21,"updated":"2020-06-16 12:11:04.000000000","message":"nit: you can download the unpacked files from https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/files/","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"41c265baed62507f7d41e3206abf09af71f43554","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        - name: \"Create baremetal nodes\""},{"line_number":48,"context_line":"          include_tasks: tempest_ironic_node_create.yml"},{"line_number":49,"context_line":"          with_items:"},{"line_number":50,"context_line":"            - { node_name: \"node1\", port_id: \"ovs-node1i1\", switch_id: \"66:0d:1d:d8:0b:11\", baremetal_port: 1161 }"},{"line_number":51,"context_line":"            - { node_name: \"node2\", port_id: \"ovs-node2i1\", switch_id: \"66:0d:1d:d8:0b:22\", baremetal_port: 1162 }"},{"line_number":52,"context_line":"      environment:"},{"line_number":53,"context_line":"        OS_CLOUD: \"{{ tempest_cloud_name }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bf51134e_63cbf052","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":114},"updated":"2020-06-16 14:10:49.000000000","message":"This really is not a great idea to hard code these items because unless something coupled with this is doing this setup, then there is no guarantee that these will be the settings.","commit_id":"d79bc02f9d8e794330caf264419240e6449ba984"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    - name: \"Get tinyipa master image\""},{"line_number":14,"context_line":"      get_url:"},{"line_number":15,"context_line":"        dest: \"{{ tinyipa_dir }}\""},{"line_number":16,"context_line":"        url: \"{{ ironic_tarball }}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: \"Extract the image\""},{"line_number":19,"context_line":"      unarchive:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_11a3e5b3","line":16,"updated":"2020-08-04 13:12:44.000000000","message":"This should have retries in case the connection to the server is flaky.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    - name: \"Get tinyipa master image\""},{"line_number":14,"context_line":"      get_url:"},{"line_number":15,"context_line":"        dest: \"{{ tinyipa_dir }}\""},{"line_number":16,"context_line":"        url: \"{{ ironic_tarball }}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: \"Extract the image\""},{"line_number":19,"context_line":"      unarchive:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_5686e114","line":16,"in_reply_to":"9f560f44_11a3e5b3","updated":"2020-08-05 09:57:26.000000000","message":"Fixed","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - name: \"Extract the image\""},{"line_number":19,"context_line":"      unarchive:"},{"line_number":20,"context_line":"        dest: \"{{ tinyipa_dir }}/\""},{"line_number":21,"context_line":"        src: \"{{ tinyipa_dir }}/{{ ironic_tarball.split(\u0027/\u0027)[-1] }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: \"Create ipa kernel image\""},{"line_number":24,"context_line":"      os_image:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_d1c7ad63","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":64},"updated":"2020-08-04 13:12:44.000000000","message":"Is this to get the basename? Why not just use the basename filter?","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - name: \"Extract the image\""},{"line_number":19,"context_line":"      unarchive:"},{"line_number":20,"context_line":"        dest: \"{{ tinyipa_dir }}/\""},{"line_number":21,"context_line":"        src: \"{{ tinyipa_dir }}/{{ ironic_tarball.split(\u0027/\u0027)[-1] }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: \"Create ipa kernel image\""},{"line_number":24,"context_line":"      os_image:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_b67e5d16","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":64},"in_reply_to":"9f560f44_d1c7ad63","updated":"2020-08-05 09:57:26.000000000","message":"Fixed","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        is_public: true"},{"line_number":30,"context_line":"        name: deploy-kernel"},{"line_number":31,"context_line":"        state: present"},{"line_number":32,"context_line":"      register: ipa_kernel_created"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: \"Create ipa ram disk\""},{"line_number":35,"context_line":"      os_image:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_31aee997","line":32,"updated":"2020-08-04 13:12:44.000000000","message":"This should have retries in case the connection to the server is flaky.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        is_public: true"},{"line_number":30,"context_line":"        name: deploy-kernel"},{"line_number":31,"context_line":"        state: present"},{"line_number":32,"context_line":"      register: ipa_kernel_created"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: \"Create ipa ram disk\""},{"line_number":35,"context_line":"      os_image:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_967b5926","line":32,"in_reply_to":"9f560f44_31aee997","updated":"2020-08-05 09:57:26.000000000","message":"Fixed","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dd7d673465c1547e66bbbdf2f628189fd0de2813","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        is_public: true"},{"line_number":41,"context_line":"        name: deploy-ramdisk"},{"line_number":42,"context_line":"        state: present"},{"line_number":43,"context_line":"      register: ipa_ramdisk_created"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: \"Create nodes\""},{"line_number":46,"context_line":"      block:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_7193415c","line":43,"updated":"2020-08-04 13:12:44.000000000","message":"This should have retries in case the connection to the server is flaky.","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"79bc678cc4f06225a4adf39238a974b5d8c46e6c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        is_public: true"},{"line_number":41,"context_line":"        name: deploy-ramdisk"},{"line_number":42,"context_line":"        state: present"},{"line_number":43,"context_line":"      register: ipa_ramdisk_created"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: \"Create nodes\""},{"line_number":46,"context_line":"      block:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_f6745538","line":43,"in_reply_to":"9f560f44_7193415c","updated":"2020-08-05 09:57:26.000000000","message":"Fixed","commit_id":"65010a0050061e3ffb35a7052e99881e2f140edc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"790a319f7fb19b91a605f9fa0159de68ae409187","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      until: ipa_ramdisk_created.rc \u003d\u003d 0"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: \"Create nodes\""},{"line_number":56,"context_line":"      block:"},{"line_number":57,"context_line":"        - name: \"Create baremetal nodes\""},{"line_number":58,"context_line":"          include_tasks: tempest_ironic_node_create.yml"},{"line_number":59,"context_line":"          with_items:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_9bc89d22","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":12},"updated":"2020-08-05 13:33:44.000000000","message":"There is only one task in this block, so the block is unnecessary.","commit_id":"f06f2c4173026f0b452b2bc5a601e6d22279f93f"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"98b4ab770f2ea0f3b807c8709639359e5f1fbee0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      until: ipa_ramdisk_created.rc \u003d\u003d 0"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: \"Create nodes\""},{"line_number":56,"context_line":"      block:"},{"line_number":57,"context_line":"        - name: \"Create baremetal nodes\""},{"line_number":58,"context_line":"          include_tasks: tempest_ironic_node_create.yml"},{"line_number":59,"context_line":"          with_items:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_e4ce5a58","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":12},"in_reply_to":"9f560f44_9bc89d22","updated":"2020-08-06 07:42:57.000000000","message":"I needed to pass the environment variable with loop. I found block is very easy to use.","commit_id":"f06f2c4173026f0b452b2bc5a601e6d22279f93f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eeaffc95c04032a15b1d481a144b845ef046a726","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- delegate_to: \"{{ tempest_service_setup_host }}\""},{"line_number":3,"context_line":"  name: \"Setup baremetal tempest resources\""},{"line_number":4,"context_line":"  block:"},{"line_number":5,"context_line":"    - name: \"Create directory\""},{"line_number":6,"context_line":"      file:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f560f44_f8ba6dbe","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":43},"updated":"2020-08-06 09:33:56.000000000","message":"nit: I prefer the name to go first.","commit_id":"45203eafce83f41aff3d3d0b63870f8fec17569d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eeaffc95c04032a15b1d481a144b845ef046a726","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- delegate_to: \"{{ tempest_service_setup_host }}\""},{"line_number":3,"context_line":"  name: \"Setup baremetal tempest resources\""},{"line_number":4,"context_line":"  block:"},{"line_number":5,"context_line":"    - name: \"Create directory\""},{"line_number":6,"context_line":"      file:"},{"line_number":7,"context_line":"        group: \"{{ ansible_user_gid }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f560f44_18b481d0","line":4,"updated":"2020-08-06 09:33:56.000000000","message":"This block is missing the following:\n\n  vars:\n    ansible_python_interpreter: \"{{ tempest_service_setup_host_python_interpreter }}\"\n\nThis is essential to allowing the setup to use an alternative python interpreter, which is essential for some use-cases.","commit_id":"45203eafce83f41aff3d3d0b63870f8fec17569d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eeaffc95c04032a15b1d481a144b845ef046a726","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      until: ipa_ramdisk_created.rc \u003d\u003d 0"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: \"Create nodes\""},{"line_number":56,"context_line":"      block:"},{"line_number":57,"context_line":"        - name: \"Create baremetal nodes\""},{"line_number":58,"context_line":"          include_tasks: tempest_ironic_node_create.yml"},{"line_number":59,"context_line":"          with_items:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f560f44_b876353d","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":12},"updated":"2020-08-06 09:33:56.000000000","message":"nit: No need for this block because there\u0027s only one task.","commit_id":"45203eafce83f41aff3d3d0b63870f8fec17569d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1890915009098a7265c29bb9a4a6009b01e0c6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: \"Setup baremetal tempest resources\""},{"line_number":3,"context_line":"  delegate_to: \"{{ tempest_service_setup_host }}\""},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    ansible_python_interpreter: \"{{ tempest_service_setup_host_python_interpreter }}\""},{"line_number":6,"context_line":"  block:"},{"line_number":7,"context_line":"    - name: \"Create directory\""},{"line_number":8,"context_line":"      file:"},{"line_number":9,"context_line":"        group: \"{{ ansible_user_gid }}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f560f44_3c3c79be","line":6,"range":{"start_line":2,"start_character":0,"end_line":6,"end_character":8},"updated":"2020-08-13 12:27:24.000000000","message":"This block is not required because the tasks are imported within a block with the same var and delegation in https://review.opendev.org/#/c/720705/24/tasks/tempest_resources.yml and that is far better. This is now a delegation inside a delegation which is inefficient and could cause some trouble.","commit_id":"e49c09f35949be94f0ece7f80714cea6693cac8a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1890915009098a7265c29bb9a4a6009b01e0c6c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      until: ipa_ramdisk_created.rc \u003d\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - name: \"Create nodes\""},{"line_number":58,"context_line":"      block:"},{"line_number":59,"context_line":"        - name: \"Create baremetal nodes\""},{"line_number":60,"context_line":"          include_tasks: tempest_ironic_node_create.yml"},{"line_number":61,"context_line":"          with_items:"},{"line_number":62,"context_line":"            - { node_name: \"node1\", port_id: \"ovs-node1i1\", switch_id: \"66:0d:1d:d8:0b:11\","},{"line_number":63,"context_line":"                baremetal_port: \"{{ tempest_ironic_ipmi_port1 }}\" }"},{"line_number":64,"context_line":"            - { node_name: \"node2\", port_id: \"ovs-node2i1\", switch_id: \"66:0d:1d:d8:0b:22\","},{"line_number":65,"context_line":"                baremetal_port: \"{{ tempest_ironic_ipmi_port2 }}\" }"},{"line_number":66,"context_line":"      environment:"},{"line_number":67,"context_line":"        OS_CLOUD: \"{{ tempest_cloud_name }}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f560f44_9c494562","line":65,"range":{"start_line":58,"start_character":0,"end_line":65,"end_character":67},"updated":"2020-08-13 12:27:24.000000000","message":"This is one task, so no block required.","commit_id":"e49c09f35949be94f0ece7f80714cea6693cac8a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"150851dc906bacb182598588e2177695cae7f30e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    - name: \"Create baremetal nodes\""},{"line_number":55,"context_line":"      include_tasks: tempest_ironic_node_create.yml"},{"line_number":56,"context_line":"      with_items:"},{"line_number":57,"context_line":"        - { node_name: \"node1\", port_id: \"ovs-node1i1\","},{"line_number":58,"context_line":"            switch_id: \"66:0d:1d:d8:0b:11\","},{"line_number":59,"context_line":"            baremetal_port: \"{{ tempest_ironic_ipmi_port1 }}\" }"},{"line_number":60,"context_line":"        - { node_name: \"node2\", port_id: \"ovs-node2i1\","},{"line_number":61,"context_line":"            switch_id: \"66:0d:1d:d8:0b:22\","},{"line_number":62,"context_line":"            baremetal_port: \"{{ tempest_ironic_ipmi_port2 }}\" }"},{"line_number":63,"context_line":"  environment:"},{"line_number":64,"context_line":"    OS_CLOUD: \"{{ tempest_cloud_name }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f560f44_e2741c9f","line":62,"range":{"start_line":57,"start_character":0,"end_line":62,"end_character":63},"updated":"2020-08-13 14:10:30.000000000","message":"can we pass this as a variable from defaults/main.yml? Currently this is all hardwired and cant be overridden.","commit_id":"dcd8a1caecb82956c0fd0d62a6920d52cc40c588"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"67ead8704b14ad39c0110e23328dc0e2454d0141","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: \"Create directory\""},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    group: \"{{ ansible_user_gid }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_33e4430d","line":1,"updated":"2020-08-20 16:29:12.000000000","message":"Then we can include that file with needed vars here","commit_id":"659fc7af4983916aa29c1ade31cdbe3a61f18780"}],"tasks/tempest_resources.yml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"e55438ce8b1d308174613ef29a3ddcd676cf835a","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        group: \"{{ansible_user_gid}}\""},{"line_number":308,"context_line":"        recurse: yes"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    - name: \"Get tineyipa pkie stable image\""},{"line_number":311,"context_line":"      get_url:"},{"line_number":312,"context_line":"        url: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/tinyipa-stable-pike.tar.gz\""},{"line_number":313,"context_line":"        dest: \"{{tinyipa_dir}}/tinyipa-stable-pike.tar.gz\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_b8e5e2aa","line":310,"range":{"start_line":310,"start_character":26,"end_line":310,"end_character":30},"updated":"2020-04-17 13:01:04.000000000","message":"pike","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"e55438ce8b1d308174613ef29a3ddcd676cf835a","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        recurse: yes"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    - name: \"Get tineyipa pkie stable image\""},{"line_number":311,"context_line":"      get_url:"},{"line_number":312,"context_line":"        url: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/tinyipa-stable-pike.tar.gz\""},{"line_number":313,"context_line":"        dest: \"{{tinyipa_dir}}/tinyipa-stable-pike.tar.gz\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    - name: \"Extract the image\""},{"line_number":316,"context_line":"      unarchive:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_f8f00a6a","line":313,"range":{"start_line":311,"start_character":6,"end_line":313,"end_character":58},"updated":"2020-04-17 13:01:04.000000000","message":"Is this pike related to Pike release? Are we going to use it in all releases? If not, should have some condition here to use the tinyipa-stable-{{ release }}.tar.gz","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        recurse: yes"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    - name: \"Get tineyipa pkie stable image\""},{"line_number":311,"context_line":"      get_url:"},{"line_number":312,"context_line":"        url: \"https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/tinyipa-stable-pike.tar.gz\""},{"line_number":313,"context_line":"        dest: \"{{tinyipa_dir}}/tinyipa-stable-pike.tar.gz\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    - name: \"Extract the image\""},{"line_number":316,"context_line":"      unarchive:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_f3caeb17","line":313,"range":{"start_line":311,"start_character":6,"end_line":313,"end_character":58},"in_reply_to":"3f4c43b2_f8f00a6a","updated":"2020-04-17 13:52:54.000000000","message":"{{ release }} would not be defined outside tripleo?","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        is_public: yes"},{"line_number":340,"context_line":"      register: ipa_ramdisk_created"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    - name: \"Create CirrOS image\""},{"line_number":343,"context_line":"      os_image:"},{"line_number":344,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":345,"context_line":"        name: cirros"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_9356075c","line":342,"range":{"start_line":342,"start_character":6,"end_line":342,"end_character":33},"updated":"2020-04-17 13:52:54.000000000","message":"is the cirros image uploaded as as part of the general tempest resources not sufficient?","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        name: cirros"},{"line_number":346,"context_line":"        container_format: bare"},{"line_number":347,"context_line":"        disk_format: qcow2"},{"line_number":348,"context_line":"        filename: \"{{ tempest_test_image_path }}\""},{"line_number":349,"context_line":"        state: present"},{"line_number":350,"context_line":"        is_public: yes"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_1315d79c","line":348,"range":{"start_line":348,"start_character":22,"end_line":348,"end_character":46},"updated":"2020-04-17 13:52:54.000000000","message":"this variable is undefined in this role","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        name: provisioning"},{"line_number":356,"context_line":"        state: present"},{"line_number":357,"context_line":"        external: true"},{"line_number":358,"context_line":"        provider_physical_network: datacenter"},{"line_number":359,"context_line":"        provider_network_type: flat"},{"line_number":360,"context_line":"        shared: yes"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_b3722310","line":358,"range":{"start_line":358,"start_character":35,"end_line":358,"end_character":45},"updated":"2020-04-17 13:52:54.000000000","message":"this network is not defined outside tripleo?","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    - name: \"Create baremetal port\""},{"line_number":381,"context_line":"      shell: |"},{"line_number":382,"context_line":"        openstack baremetal port create --node {{baremetal_node1_created.stdout}} \\"},{"line_number":383,"context_line":"        --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":384,"context_line":"        --local-link-connection port_id\u003dovs-node1i1 \\"},{"line_number":385,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:11"},{"line_number":386,"context_line":"      when: baremetal_node1_created.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_d3e52faa","line":383,"range":{"start_line":383,"start_character":44,"end_line":383,"end_character":54},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":381,"context_line":"      shell: |"},{"line_number":382,"context_line":"        openstack baremetal port create --node {{baremetal_node1_created.stdout}} \\"},{"line_number":383,"context_line":"        --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":384,"context_line":"        --local-link-connection port_id\u003dovs-node1i1 \\"},{"line_number":385,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:11"},{"line_number":386,"context_line":"      when: baremetal_node1_created.rc \u003d\u003d 0"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_b3e06398","line":384,"range":{"start_line":384,"start_character":40,"end_line":384,"end_character":51},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    - name: \"Create baremetal port for node2\""},{"line_number":419,"context_line":"      shell: |"},{"line_number":420,"context_line":"        openstack baremetal port create --node {{baremetal_node2_created.stdout}} \\"},{"line_number":421,"context_line":"        --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":422,"context_line":"        --local-link-connection port_id\u003dovs-node1i2 \\"},{"line_number":423,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:22"},{"line_number":424,"context_line":"      when: baremetal_node2_created.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_53ebdf77","line":421,"range":{"start_line":421,"start_character":44,"end_line":421,"end_character":54},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c38be6c45026acbd7c7283116a4570461d95119d","unresolved":false,"context_lines":[{"line_number":419,"context_line":"      shell: |"},{"line_number":420,"context_line":"        openstack baremetal port create --node {{baremetal_node2_created.stdout}} \\"},{"line_number":421,"context_line":"        --local-link-connection switch_info\u003dnet-ans-br \\"},{"line_number":422,"context_line":"        --local-link-connection port_id\u003dovs-node1i2 \\"},{"line_number":423,"context_line":"        --local-link-connection switch_id\u003d00:00:00:00:00:00 66:0d:1d:d8:0b:22"},{"line_number":424,"context_line":"      when: baremetal_node2_created.rc \u003d\u003d 0"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_73fffb33","line":422,"range":{"start_line":422,"start_character":40,"end_line":422,"end_character":51},"updated":"2020-04-17 13:52:54.000000000","message":"where is this defined?","commit_id":"700e1861a36e6921d540080ceb9502c989b7c183"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4d3b9338b41b8f0c044f7cae31883ed3b4df1490","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    - tempest_public_net_provider_type not in [\u0027local\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"- name: Setup barematel tempest resources"},{"line_number":298,"context_line":"  deleagate_to: \"{{ tempest_service_setup_host }}\""},{"line_number":299,"context_line":"  import_tasks: tempest_ironic_resources.yml"},{"line_number":300,"context_line":"  vars:"},{"line_number":301,"context_line":"    tinyipa_dir: \"{{ansible_user_dir}}/tinyipa/\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_53b91f78","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":50},"updated":"2020-04-17 13:43:59.000000000","message":"Also I think delegate_to should be in block inside imported file anyway.","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4d3b9338b41b8f0c044f7cae31883ed3b4df1490","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    - tempest_public_net_provider_type not in [\u0027local\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"- name: Setup barematel tempest resources"},{"line_number":298,"context_line":"  deleagate_to: \"{{ tempest_service_setup_host }}\""},{"line_number":299,"context_line":"  import_tasks: tempest_ironic_resources.yml"},{"line_number":300,"context_line":"  vars:"},{"line_number":301,"context_line":"    tinyipa_dir: \"{{ansible_user_dir}}/tinyipa/\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_33a3b351","line":298,"range":{"start_line":298,"start_character":2,"end_line":298,"end_character":14},"updated":"2020-04-17 13:43:59.000000000","message":"typo here","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"b02689dfdd5df12dc752b6bf47d37a6d0c1c14c5","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    - tempest_public_net_provider_type not in [\u0027local\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"- name: Setup barematel tempest resources"},{"line_number":298,"context_line":"  deleagate_to: \"{{ tempest_service_setup_host }}\""},{"line_number":299,"context_line":"  import_tasks: tempest_ironic_resources.yml"},{"line_number":300,"context_line":"  vars:"},{"line_number":301,"context_line":"    tinyipa_dir: \"{{ansible_user_dir}}/tinyipa/\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_781cd6c0","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":50},"in_reply_to":"3f4c43b2_53b91f78","updated":"2020-04-28 10:52:14.000000000","message":"Done","commit_id":"229d60d21a41db917c0042563021b371c5387280"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4ed0eff1b494c41486ba11068a0a922b4c4ba8c3","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    - tempest_public_net_provider_type not in [\u0027local\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"  import_tasks: tempest_ironic_resources.yml"},{"line_number":298,"context_line":"  when: tempest_service_available_ironic | bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_63325612","line":298,"updated":"2020-04-28 09:37:27.000000000","message":"I think you can set the tempest_public_net_provider_type here","commit_id":"90ac82d717a8f3de0eef59c0ea8acbb82d88640e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eeaffc95c04032a15b1d481a144b845ef046a726","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    - tempest_network_ping_gateway | bool"},{"line_number":295,"context_line":"    - tempest_public_net_provider_type not in [\u0027local\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"- import_tasks: tempest_ironic_resources.yml"},{"line_number":298,"context_line":"  when: tempest_service_available_ironic | bool"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f560f44_58cef959","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":47},"updated":"2020-08-06 09:33:56.000000000","message":"I suggest moving this import into the above block so that it inherits the delegation and the vars - then the imported tasks can have that removed. This improves the maintainability just a little.","commit_id":"45203eafce83f41aff3d3d0b63870f8fec17569d"}]}