)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e5ab2f398614eec101a875371a1b3aa95b6f12f6","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  if true: require all other tempest_public_net_* variables to be set"},{"line_number":13,"context_line":"  explanation: it\u0027d be useful to choose if user wants to use already"},{"line_number":14,"context_line":"    existing public net or create a new one/"},{"line_number":15,"context_line":"- private network:"},{"line_number":16,"context_line":"  new variable: bool tempest_private_net_create (default: false)"},{"line_number":17,"context_line":"  if true: require all tempest_private_* variables to be set"},{"line_number":18,"context_line":"  explanation: by default tempest has use_dynamic_credentials \u0026"},{"line_number":19,"context_line":"    create_isolated_networks enabled, so it spawns an usable network,"},{"line_number":20,"context_line":"    subnet, and router when needed for each project it creates, so in"},{"line_number":21,"context_line":"    most cases it doesn\u0027t make sense to create special \u0027private\u0027 net."},{"line_number":22,"context_line":"- router:"},{"line_number":23,"context_line":"  new variable: bool tempest_router_create (default: false)"},{"line_number":24,"context_line":"  if true: both tempest_public_net_create and"},{"line_number":25,"context_line":"    tempest_private_net_create should be enabled"},{"line_number":26,"context_line":"  explanation: same case as for private network"},{"line_number":27,"context_line":"- image:"},{"line_number":28,"context_line":"  new variable: bool tempest_images_create (default: true)"},{"line_number":29,"context_line":"  if false: require tempest_glance_image_id_1,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"35280e16_4e4fe493","line":26,"range":{"start_line":15,"start_character":0,"end_line":26,"end_character":47},"updated":"2021-12-28 13:03:02.000000000","message":"Shouldn\u0027t we also reflect these changes in tempest.conf?\nAs currently networks will be defined in config without being created? \n\nhttps://opendev.org/openstack/openstack-ansible-os_tempest/src/branch/master/templates/tempest.conf.j2#L95-L96\n\nI believe we should cover that in template with if/else and explicitly set create_isolated_networks when these are false?","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1f619098d0ebd84dba7083841ceadf157828170e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  if true: require all other tempest_public_net_* variables to be set"},{"line_number":13,"context_line":"  explanation: it\u0027d be useful to choose if user wants to use already"},{"line_number":14,"context_line":"    existing public net or create a new one/"},{"line_number":15,"context_line":"- private network:"},{"line_number":16,"context_line":"  new variable: bool tempest_private_net_create (default: false)"},{"line_number":17,"context_line":"  if true: require all tempest_private_* variables to be set"},{"line_number":18,"context_line":"  explanation: by default tempest has use_dynamic_credentials \u0026"},{"line_number":19,"context_line":"    create_isolated_networks enabled, so it spawns an usable network,"},{"line_number":20,"context_line":"    subnet, and router when needed for each project it creates, so in"},{"line_number":21,"context_line":"    most cases it doesn\u0027t make sense to create special \u0027private\u0027 net."},{"line_number":22,"context_line":"- router:"},{"line_number":23,"context_line":"  new variable: bool tempest_router_create (default: false)"},{"line_number":24,"context_line":"  if true: both tempest_public_net_create and"},{"line_number":25,"context_line":"    tempest_private_net_create should be enabled"},{"line_number":26,"context_line":"  explanation: same case as for private network"},{"line_number":27,"context_line":"- image:"},{"line_number":28,"context_line":"  new variable: bool tempest_images_create (default: true)"},{"line_number":29,"context_line":"  if false: require tempest_glance_image_id_1,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"843583ed_2460b9d5","line":26,"range":{"start_line":15,"start_character":0,"end_line":26,"end_character":47},"in_reply_to":"35280e16_4e4fe493","updated":"2021-12-28 21:07:24.000000000","message":"TBH I\u0027m getting lost with all of these variables and relations.\n\nCurrently we have hardcoded use_dynamic_credentials(True) and create_isolated_networks(default\u003dTrue) so I assume it\u0027s the only scenario we currently support.\n\nI\u0027m up to making it more flexible by supporting other scenarios, but can we do it later in a separate change?","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"b044e56dbee3aeae5444507dfaba011660b25ba0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  if true: require all other tempest_public_net_* variables to be set"},{"line_number":13,"context_line":"  explanation: it\u0027d be useful to choose if user wants to use already"},{"line_number":14,"context_line":"    existing public net or create a new one/"},{"line_number":15,"context_line":"- private network:"},{"line_number":16,"context_line":"  new variable: bool tempest_private_net_create (default: false)"},{"line_number":17,"context_line":"  if true: require all tempest_private_* variables to be set"},{"line_number":18,"context_line":"  explanation: by default tempest has use_dynamic_credentials \u0026"},{"line_number":19,"context_line":"    create_isolated_networks enabled, so it spawns an usable network,"},{"line_number":20,"context_line":"    subnet, and router when needed for each project it creates, so in"},{"line_number":21,"context_line":"    most cases it doesn\u0027t make sense to create special \u0027private\u0027 net."},{"line_number":22,"context_line":"- router:"},{"line_number":23,"context_line":"  new variable: bool tempest_router_create (default: false)"},{"line_number":24,"context_line":"  if true: both tempest_public_net_create and"},{"line_number":25,"context_line":"    tempest_private_net_create should be enabled"},{"line_number":26,"context_line":"  explanation: same case as for private network"},{"line_number":27,"context_line":"- image:"},{"line_number":28,"context_line":"  new variable: bool tempest_images_create (default: true)"},{"line_number":29,"context_line":"  if false: require tempest_glance_image_id_1,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d4bcdbae_32b1d598","line":26,"range":{"start_line":15,"start_character":0,"end_line":26,"end_character":47},"in_reply_to":"6d0ca613_6ac7c9f7","updated":"2022-01-19 22:49:41.000000000","message":"Done","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"b044e56dbee3aeae5444507dfaba011660b25ba0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  if true: require all other tempest_public_net_* variables to be set"},{"line_number":13,"context_line":"  explanation: it\u0027d be useful to choose if user wants to use already"},{"line_number":14,"context_line":"    existing public net or create a new one/"},{"line_number":15,"context_line":"- private network:"},{"line_number":16,"context_line":"  new variable: bool tempest_private_net_create (default: false)"},{"line_number":17,"context_line":"  if true: require all tempest_private_* variables to be set"},{"line_number":18,"context_line":"  explanation: by default tempest has use_dynamic_credentials \u0026"},{"line_number":19,"context_line":"    create_isolated_networks enabled, so it spawns an usable network,"},{"line_number":20,"context_line":"    subnet, and router when needed for each project it creates, so in"},{"line_number":21,"context_line":"    most cases it doesn\u0027t make sense to create special \u0027private\u0027 net."},{"line_number":22,"context_line":"- router:"},{"line_number":23,"context_line":"  new variable: bool tempest_router_create (default: false)"},{"line_number":24,"context_line":"  if true: both tempest_public_net_create and"},{"line_number":25,"context_line":"    tempest_private_net_create should be enabled"},{"line_number":26,"context_line":"  explanation: same case as for private network"},{"line_number":27,"context_line":"- image:"},{"line_number":28,"context_line":"  new variable: bool tempest_images_create (default: true)"},{"line_number":29,"context_line":"  if false: require tempest_glance_image_id_1,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0076320e_29bb2333","line":26,"range":{"start_line":15,"start_character":0,"end_line":26,"end_character":47},"in_reply_to":"6d0ca613_6ac7c9f7","updated":"2022-01-19 22:49:41.000000000","message":"I slightly edited commit message to avoid any confusions.\n\nAdditionally, I\u0027ve added a support for manipulating use_dynamic_credentials and create_isolated_networks in a separate change: https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825403/1","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"45fc8b55e3dbd1d4e8a15381f8fb20c4b1995e93","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  if true: require all other tempest_public_net_* variables to be set"},{"line_number":13,"context_line":"  explanation: it\u0027d be useful to choose if user wants to use already"},{"line_number":14,"context_line":"    existing public net or create a new one/"},{"line_number":15,"context_line":"- private network:"},{"line_number":16,"context_line":"  new variable: bool tempest_private_net_create (default: false)"},{"line_number":17,"context_line":"  if true: require all tempest_private_* variables to be set"},{"line_number":18,"context_line":"  explanation: by default tempest has use_dynamic_credentials \u0026"},{"line_number":19,"context_line":"    create_isolated_networks enabled, so it spawns an usable network,"},{"line_number":20,"context_line":"    subnet, and router when needed for each project it creates, so in"},{"line_number":21,"context_line":"    most cases it doesn\u0027t make sense to create special \u0027private\u0027 net."},{"line_number":22,"context_line":"- router:"},{"line_number":23,"context_line":"  new variable: bool tempest_router_create (default: false)"},{"line_number":24,"context_line":"  if true: both tempest_public_net_create and"},{"line_number":25,"context_line":"    tempest_private_net_create should be enabled"},{"line_number":26,"context_line":"  explanation: same case as for private network"},{"line_number":27,"context_line":"- image:"},{"line_number":28,"context_line":"  new variable: bool tempest_images_create (default: true)"},{"line_number":29,"context_line":"  if false: require tempest_glance_image_id_1,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6d0ca613_6ac7c9f7","line":26,"range":{"start_line":15,"start_character":0,"end_line":26,"end_character":47},"in_reply_to":"843583ed_2460b9d5","updated":"2021-12-29 10:36:42.000000000","message":"\u003e Currently we have hardcoded use_dynamic_credentials(True) and create_isolated_networks(default\u003dTrue) so I assume it\u0027s the only scenario we currently support.\n\nThat is not really clear neither from commit message not from release note.\n\n\u003e can we do it later in a separate change\n\nYes, totally, but we need to be clear about what exactly we\u0027re trying to do here.\nAs currently we replace one mess with other one, and not clear why, for example, we even have user/project creation if tempest will never use that. So this should be either fixed or user creation should be just dropped at all...\n\nSo maybe this patch should be splitted at first place, so that with introduction of tempest_private_net_create (as example) we also add control of create_isolated_networks?","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e5ab2f398614eec101a875371a1b3aa95b6f12f6","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  new variable: bool tempest_images_create (default: true)"},{"line_number":29,"context_line":"  if false: require tempest_glance_image_id_1,"},{"line_number":30,"context_line":"    tempest_glance_image_id_2 to be set"},{"line_number":31,"context_line":"  explanation: tempest needs public images, so it\u0027d be useful to just"},{"line_number":32,"context_line":"    use already existing ones"},{"line_number":33,"context_line":"- flavor:"},{"line_number":34,"context_line":"  new variable: bool tempest_flavors_create (default: true)"},{"line_number":35,"context_line":"  if false: require tempest_nova_flavor_id_1, tempest_nova_flavor_id_2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3166731f_7978ed1c","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":29},"updated":"2021-12-28 13:03:02.000000000","message":"are we sure it needs public images even when use_dynamic_credentials \u003d false and we enable tempest_projects_create?\n\nI guess it\u0027s just matter of our config file that doesn\u0027t support this?\n\nAs it would make sense to me to have private images/flavors if os_tempest does tenant creation and dynamic are not used?","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1f619098d0ebd84dba7083841ceadf157828170e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  new variable: bool tempest_images_create (default: true)"},{"line_number":29,"context_line":"  if false: require tempest_glance_image_id_1,"},{"line_number":30,"context_line":"    tempest_glance_image_id_2 to be set"},{"line_number":31,"context_line":"  explanation: tempest needs public images, so it\u0027d be useful to just"},{"line_number":32,"context_line":"    use already existing ones"},{"line_number":33,"context_line":"- flavor:"},{"line_number":34,"context_line":"  new variable: bool tempest_flavors_create (default: true)"},{"line_number":35,"context_line":"  if false: require tempest_nova_flavor_id_1, tempest_nova_flavor_id_2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b8b1de6d_a1fcc550","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":29},"in_reply_to":"3166731f_7978ed1c","updated":"2021-12-28 21:07:24.000000000","message":"ditto","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e5ab2f398614eec101a875371a1b3aa95b6f12f6","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  new variable: bool tempest_flavors_create (default: true)"},{"line_number":35,"context_line":"  if false: require tempest_nova_flavor_id_1, tempest_nova_flavor_id_2"},{"line_number":36,"context_line":"    to be set"},{"line_number":37,"context_line":"  explanation: tempest needs public flavors, so it\u0027d be useful to just"},{"line_number":38,"context_line":"    use already existing ones"},{"line_number":39,"context_line":"- projects:"},{"line_number":40,"context_line":"  new variable: bool tempest_projects_create (default:"},{"line_number":41,"context_line":"    \"{{ tempest_public_net_create or tempest_private_net_create or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3dc41df1_8c98d849","line":38,"range":{"start_line":37,"start_character":15,"end_line":38,"end_character":29},"updated":"2021-12-28 13:03:02.000000000","message":"same is image?","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1f619098d0ebd84dba7083841ceadf157828170e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  new variable: bool tempest_flavors_create (default: true)"},{"line_number":35,"context_line":"  if false: require tempest_nova_flavor_id_1, tempest_nova_flavor_id_2"},{"line_number":36,"context_line":"    to be set"},{"line_number":37,"context_line":"  explanation: tempest needs public flavors, so it\u0027d be useful to just"},{"line_number":38,"context_line":"    use already existing ones"},{"line_number":39,"context_line":"- projects:"},{"line_number":40,"context_line":"  new variable: bool tempest_projects_create (default:"},{"line_number":41,"context_line":"    \"{{ tempest_public_net_create or tempest_private_net_create or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"282c4fa0_a068137e","line":38,"range":{"start_line":37,"start_character":15,"end_line":38,"end_character":29},"in_reply_to":"3dc41df1_8c98d849","updated":"2021-12-28 21:07:24.000000000","message":"ditto","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"3fe20c67045238450984516ff3b899a3321fcec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ebbb5172_3c1810fd","updated":"2022-01-19 17:57:15.000000000","message":"\u003e Patch Set 4: Code-Review+1\n\u003e \n\u003e From tripleo perspective, it\u0027s fine, since we use tempestconf instead of tempest.conf template from os_tempest. However, it is a bit confusing all these variables, I believe in the future would be a mess to trackdown errors.\n\nthanks for the review.\nThat\u0027s right, it makes role a bit more complex.\nBut in most cases users don\u0027t need to create these resources.\nTripleO still use it so we can\u0027t just drop them.\nThat\u0027s why I think we should let users decide which resources should be created.\nI added an explanation in commit message.","commit_id":"662c1830fd500b5231273c5eb0946fbf4642beb3"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"fc39f56559d7bd48f04e4f290116fe5fed36eb3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2974a939_3ceb17a6","updated":"2022-02-08 12:08:36.000000000","message":"recheck","commit_id":"216efab42756bcf717b0560d21e46bae9102e3d2"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e5ab2f398614eec101a875371a1b3aa95b6f12f6","unresolved":true,"context_lines":[{"line_number":49,"context_line":"# Toggle whether default resources are implemented"},{"line_number":50,"context_line":"tempest_default_role_resources: yes"},{"line_number":51,"context_line":"tempest_public_net_create: true"},{"line_number":52,"context_line":"tempest_private_net_create: false"},{"line_number":53,"context_line":"tempest_router_create: false"},{"line_number":54,"context_line":"tempest_images_create: true"},{"line_number":55,"context_line":"tempest_flavors_create: true"},{"line_number":56,"context_line":"tempest_projects_create: \"{{ tempest_public_net_create or tempest_private_net_create or tempest_router_create }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e0fb5f6d_faab9558","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":28},"updated":"2021-12-28 13:03:02.000000000","message":"We\u0027re changing current behaviour here.","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1f619098d0ebd84dba7083841ceadf157828170e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Toggle whether default resources are implemented"},{"line_number":50,"context_line":"tempest_default_role_resources: yes"},{"line_number":51,"context_line":"tempest_public_net_create: true"},{"line_number":52,"context_line":"tempest_private_net_create: false"},{"line_number":53,"context_line":"tempest_router_create: false"},{"line_number":54,"context_line":"tempest_images_create: true"},{"line_number":55,"context_line":"tempest_flavors_create: true"},{"line_number":56,"context_line":"tempest_projects_create: \"{{ tempest_public_net_create or tempest_private_net_create or tempest_router_create }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b3148ade_93070c23","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":28},"in_reply_to":"e0fb5f6d_faab9558","updated":"2021-12-28 21:07:24.000000000","message":"that\u0027s true and it\u0027s intentional.\n\ncurrent behavior is to use_dynamic_credentials.\nthen private networks \u0026 routers are created and used during tempest.scenario.test_server_basic_ops test.\n\nFrom my perspective, there\u0027s no reason to create any additional networks.","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"}],"tasks/tempest_resources.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e5ab2f398614eec101a875371a1b3aa95b6f12f6","unresolved":true,"context_lines":[{"line_number":76,"context_line":"          - tempest_nova_flavor_id_2 is defined"},{"line_number":77,"context_line":"      when:"},{"line_number":78,"context_line":"        - not tempest_flavors_create"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    - name: Ensures you have at least one image to upload"},{"line_number":81,"context_line":"      assert:"},{"line_number":82,"context_line":"        that:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"755dc43a_082a802a","line":79,"updated":"2021-12-28 13:03:02.000000000","message":"- tempest_compute_resize_enabled","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1f619098d0ebd84dba7083841ceadf157828170e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"          - tempest_nova_flavor_id_2 is defined"},{"line_number":77,"context_line":"      when:"},{"line_number":78,"context_line":"        - not tempest_flavors_create"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    - name: Ensures you have at least one image to upload"},{"line_number":81,"context_line":"      assert:"},{"line_number":82,"context_line":"        that:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"321ece60_837b4f72","line":79,"in_reply_to":"755dc43a_082a802a","updated":"2021-12-28 21:07:24.000000000","message":"fixed, I\u0027ve also set tempest_nova_flavor_id_* facts to make it possible to choose between using tempest_flavors_create or not(and pass flavor ids explicitly)\n\nit\u0027s required for https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/803492","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e5ab2f398614eec101a875371a1b3aa95b6f12f6","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        keystone_demo_tenant_id: \"{{ (add_project.results | json_query(\u0027[*].project.id\u0027))[0] }}\""},{"line_number":214,"context_line":"      when:"},{"line_number":215,"context_line":"        - tempest_projects_create | bool"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    - name: Ensure private network exists"},{"line_number":218,"context_line":"      openstack.cloud.network:"},{"line_number":219,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":220,"context_line":"        interface: \"{{ tempest_interface_name }}\""},{"line_number":221,"context_line":"        validate_certs: \"{{ tempest_keystone_interface_insecure | ternary(false, true) }}\""},{"line_number":222,"context_line":"        name: \"{{ tempest_private_net_name }}\""},{"line_number":223,"context_line":"        provider_network_type: \"{{ tempest_private_net_provider_type }}\""},{"line_number":224,"context_line":"        provider_physical_network: \"{{ tempest_private_net_physical_name | default(omit) }}\""},{"line_number":225,"context_line":"        provider_segmentation_id: \"{{ tempest_private_net_seg_id | default(omit, true) }}\""},{"line_number":226,"context_line":"        mtu: \"{{ tempest_private_net_mtu | default(omit, true) }}\""},{"line_number":227,"context_line":"        project: \"{{ keystone_demo_tenant_id }}\""},{"line_number":228,"context_line":"      register: tempest_private_network"},{"line_number":229,"context_line":"      until: tempest_private_network is success"},{"line_number":230,"context_line":"      retries: 5"},{"line_number":231,"context_line":"      delay: 10"},{"line_number":232,"context_line":"      when:"},{"line_number":233,"context_line":"        - tempest_service_available_neutron | bool"},{"line_number":234,"context_line":"        - tempest_private_net_create | bool"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    - name: Store neutron private network id"},{"line_number":237,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0c372cb1_5e19cd51","line":234,"range":{"start_line":216,"start_character":0,"end_line":234,"end_character":43},"updated":"2021-12-28 13:03:02.000000000","message":"btw we catch drivers misbehavior here a lot","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1f619098d0ebd84dba7083841ceadf157828170e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        keystone_demo_tenant_id: \"{{ (add_project.results | json_query(\u0027[*].project.id\u0027))[0] }}\""},{"line_number":214,"context_line":"      when:"},{"line_number":215,"context_line":"        - tempest_projects_create | bool"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    - name: Ensure private network exists"},{"line_number":218,"context_line":"      openstack.cloud.network:"},{"line_number":219,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":220,"context_line":"        interface: \"{{ tempest_interface_name }}\""},{"line_number":221,"context_line":"        validate_certs: \"{{ tempest_keystone_interface_insecure | ternary(false, true) }}\""},{"line_number":222,"context_line":"        name: \"{{ tempest_private_net_name }}\""},{"line_number":223,"context_line":"        provider_network_type: \"{{ tempest_private_net_provider_type }}\""},{"line_number":224,"context_line":"        provider_physical_network: \"{{ tempest_private_net_physical_name | default(omit) }}\""},{"line_number":225,"context_line":"        provider_segmentation_id: \"{{ tempest_private_net_seg_id | default(omit, true) }}\""},{"line_number":226,"context_line":"        mtu: \"{{ tempest_private_net_mtu | default(omit, true) }}\""},{"line_number":227,"context_line":"        project: \"{{ keystone_demo_tenant_id }}\""},{"line_number":228,"context_line":"      register: tempest_private_network"},{"line_number":229,"context_line":"      until: tempest_private_network is success"},{"line_number":230,"context_line":"      retries: 5"},{"line_number":231,"context_line":"      delay: 10"},{"line_number":232,"context_line":"      when:"},{"line_number":233,"context_line":"        - tempest_service_available_neutron | bool"},{"line_number":234,"context_line":"        - tempest_private_net_create | bool"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    - name: Store neutron private network id"},{"line_number":237,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8ba3b0f2_e9bdc5f9","line":234,"range":{"start_line":216,"start_character":0,"end_line":234,"end_character":43},"in_reply_to":"0c372cb1_5e19cd51","updated":"2021-12-28 21:07:24.000000000","message":"but we would catch these misbehaviors during tempest.scenario.test_server_basic_ops anyway","commit_id":"2f03429a52afd0acbaa90c49dfee4ca2f3a065ee"}]}