)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"4b0a5261e60ebfe78a618e26f2fb3558c48fd2b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9b56297_49633c78","updated":"2021-12-28 12:19:46.000000000","message":"thanks for suggestions","commit_id":"feafdcf90ed31524cecde00a5ff68be029322bd1"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"72f454bd385f741f7173cf1422f745ab660e7f21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"39b2a32d_f1b76829","updated":"2021-12-28 21:15:35.000000000","message":"I\u0027ve put tempest_nova_flavor_id_* into templates/tempest.conf.j2 to make it possible to manually set flavor ids when tempest_flavors_create\u003dfalse\n\nhttps://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/803477/4/tasks/tempest_resources.yml#144","commit_id":"4557f7e9cd8ccf621db07f9b909c4656b3fd3aff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"908943e2a6724df530589720618c5222a0990d22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2f72bc37_6bf853d0","updated":"2021-12-29 13:17:32.000000000","message":"Ok, I was looking for relation chain instead of depends-on, which confused me:)","commit_id":"4557f7e9cd8ccf621db07f9b909c4656b3fd3aff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9ef39fab7cee29f012264752cfaee0eb1eb1c7bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c90b452_456dba50","in_reply_to":"0ca3d4c3_ee3c5ad5","updated":"2021-12-29 10:18:16.000000000","message":"Patchset 4 makes most sense to me tbh at this point.","commit_id":"4557f7e9cd8ccf621db07f9b909c4656b3fd3aff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"84fdc90b9c2f062767ff9e1e230b5891939f4cc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0ca3d4c3_ee3c5ad5","in_reply_to":"39b2a32d_f1b76829","updated":"2021-12-29 10:16:51.000000000","message":"Wait, wait, wait. Now, you must explicitly set these variables? Then tempest_compute_resize_enabled linking to tempest_flavors length doesn\u0027t make any sense.\n\nAnd introducing variables tempest_nova_flavor_id_1 and tempest_nova_flavor_id_2  makes zero sense to me, as you can use overrides for that then.","commit_id":"4557f7e9cd8ccf621db07f9b909c4656b3fd3aff"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"b9a5dc0173ff81d6871bba7419a24984181ff6fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c1e10143_68da02a3","updated":"2022-02-08 12:08:48.000000000","message":"recheck","commit_id":"cf0dfcfd1d4dacd9996f785fbe45f81bad88159b"}],"templates/tempest.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8eaef0740f2e8015fe558b0cc307551cad2d9908","unresolved":true,"context_lines":[{"line_number":24,"context_line":"[compute]"},{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"08409e72_24b48b3e","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":37},"updated":"2021-09-01 14:07:32.000000000","message":"Small nit. Let\u0027s also be explicit that we\u0027re talking about dict, not objects. Because from python3 you would have AttributeError while doing that. While this still works with Jinja, I\u0027d rather stick to python way jsut in case.","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"4b0a5261e60ebfe78a618e26f2fb3558c48fd2b8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[compute]"},{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"19a0dbd8_11637c15","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":37},"in_reply_to":"08409e72_24b48b3e","updated":"2021-12-28 12:19:46.000000000","message":"fixed","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8eaef0740f2e8015fe558b0cc307551cad2d9908","unresolved":true,"context_lines":[{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"},{"line_number":31,"context_line":"build_timeout \u003d 600"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c1a6218e_35d484f4","line":28,"range":{"start_line":28,"start_character":36,"end_line":28,"end_character":37},"updated":"2021-09-01 14:07:32.000000000","message":"-1","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8eaef0740f2e8015fe558b0cc307551cad2d9908","unresolved":true,"context_lines":[{"line_number":24,"context_line":"[compute]"},{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"},{"line_number":31,"context_line":"build_timeout \u003d 600"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c13d966d_284facc0","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":44},"updated":"2021-09-01 14:07:32.000000000","message":"should we add condition that would verify that tempest_flavors | length \u003e 0?","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c5fea88f4ad48be207f8b448771b081df0ca8608","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[compute]"},{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"},{"line_number":31,"context_line":"build_timeout \u003d 600"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fc76d05a_1fc029c9","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":44},"in_reply_to":"0c7cfa0e_3b328817","updated":"2021-12-28 12:47:01.000000000","message":"Um, maybe then we should set tempest_compute_resize_enabled dependant on tempest_flavors length?\n\nJust check our CI samples:\n- https://opendev.org/openstack/openstack-ansible/src/branch/master/tests/roles/bootstrap-host/templates/user_variables_murano.yml.j2#L25\n- https://opendev.org/openstack/openstack-ansible/src/branch/master/tests/roles/bootstrap-host/templates/user_variables_manila.yml.j2#L18-L33\n\n\nBut they actually don\u0027t run compute scenarios, so maybe doesn\u0027t matter much... But I\u0027d rather set \n\n  tempest_compute_resize_enabled: \"{{ tempest_flavors | length \u003e 1 }}\"","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"4b0a5261e60ebfe78a618e26f2fb3558c48fd2b8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[compute]"},{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"},{"line_number":31,"context_line":"build_timeout \u003d 600"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0c7cfa0e_3b328817","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":44},"in_reply_to":"c13d966d_284facc0","updated":"2021-12-28 12:19:46.000000000","message":"i think setting 2 same flavors here doesn\u0027t make any charm.\nLeaving `flavor_ref_alt` empty when `tempest_compute_resize_enabled` is true by default is not the best idea IMO.","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"4b0a5261e60ebfe78a618e26f2fb3558c48fd2b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"},{"line_number":31,"context_line":"build_timeout \u003d 600"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"17773d40_82e67a2e","line":28,"range":{"start_line":28,"start_character":36,"end_line":28,"end_character":37},"in_reply_to":"c1a6218e_35d484f4","updated":"2021-12-28 12:19:46.000000000","message":"fixed","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"8775d409d56200eda9b5f26233b7d09a738880a1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[compute]"},{"line_number":25,"context_line":"image_ref \u003d {{ tempest_glance_image_id_1 }}"},{"line_number":26,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":27,"context_line":"flavor_ref \u003d {{ tempest_flavors[0].id }}"},{"line_number":28,"context_line":"flavor_ref_alt \u003d {{ tempest_flavors[1].id }}"},{"line_number":29,"context_line":"fixed_network_name \u003d private"},{"line_number":30,"context_line":"endpoint_type \u003d internalURL"},{"line_number":31,"context_line":"build_timeout \u003d 600"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"74c2323d_63ef116a","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":44},"in_reply_to":"fc76d05a_1fc029c9","updated":"2021-12-28 17:21:45.000000000","message":"fair point, fixed","commit_id":"16698e373158e0bd8ac99f52306a02dee0168e86"}]}