)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"8997ee561ad61491d981b73ba3ebb42e8c78e346","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e36ee93f_44edd1ac","updated":"2022-02-08 12:08:54.000000000","message":"recheck","commit_id":"81034c7722176c807f1f33bc2d5d7661a93909a8"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"91da120e9bea774840c16521a750b93a26f23967","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Credential Provider Mechanisms"},{"line_number":49,"context_line":"# If tempest_test_accounts is not an empty string, then use_dynamic_credentials will be turned off"},{"line_number":50,"context_line":"tempest_test_accounts: \"\""},{"line_number":51,"context_line":"tempest_test_accounts_file_path: \"{{ tempest_workspace }}/etc/tempest_accounts.yaml\""},{"line_number":52,"context_line":"# tempest_create_isolated_networks has an effect only when use_dynamic_credentials is enabled"},{"line_number":53,"context_line":"tempest_create_isolated_networks: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2f20a59e_dfe3f2fe","line":50,"updated":"2022-04-26 15:41:32.000000000","message":"Any reason it\u0027s not a bool? What value we expect here? As I see it only being used in conditionals.","commit_id":"81034c7722176c807f1f33bc2d5d7661a93909a8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6d98548b59304685380f646772031c0034784c76","unresolved":true,"context_lines":[{"line_number":48,"context_line":"# Credential Provider Mechanisms"},{"line_number":49,"context_line":"# If tempest_test_accounts is not an empty string, then use_dynamic_credentials will be turned off"},{"line_number":50,"context_line":"tempest_test_accounts: \"\""},{"line_number":51,"context_line":"tempest_test_accounts_file_path: \"{{ tempest_workspace }}/etc/tempest_accounts.yaml\""},{"line_number":52,"context_line":"# tempest_create_isolated_networks has an effect only when use_dynamic_credentials is enabled"},{"line_number":53,"context_line":"tempest_create_isolated_networks: true"},{"line_number":54,"context_line":"# tempest_fixed_network_name has an effect only when tempest_create_isolated_networks is disabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b5b09f8b_b1959a1e","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":31},"updated":"2022-04-26 15:45:08.000000000","message":"ah, I thought it\u0027s local file path (on deploy host). Then any reason why to use copy/content here instead of just copy from deploy host? Or do lookup at worst?","commit_id":"81034c7722176c807f1f33bc2d5d7661a93909a8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"016c375ec29cb96072ad2292b5c6488efd8bec7e","unresolved":true,"context_lines":[{"line_number":48,"context_line":"# Credential Provider Mechanisms"},{"line_number":49,"context_line":"# If tempest_test_accounts is not an empty string, then use_dynamic_credentials will be turned off"},{"line_number":50,"context_line":"tempest_test_accounts: \"\""},{"line_number":51,"context_line":"tempest_test_accounts_file_path: \"{{ tempest_workspace }}/etc/tempest_accounts.yaml\""},{"line_number":52,"context_line":"# tempest_create_isolated_networks has an effect only when use_dynamic_credentials is enabled"},{"line_number":53,"context_line":"tempest_create_isolated_networks: true"},{"line_number":54,"context_line":"# tempest_fixed_network_name has an effect only when tempest_create_isolated_networks is disabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5444b0b4_e106eace","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":31},"in_reply_to":"b5b09f8b_b1959a1e","updated":"2022-04-26 17:04:20.000000000","message":"with copy/content You don\u0027t create a requirement of having this file locally(You just define tempest_test_accounts in a variable). It also simplifies the logic when test accounts file should be used(tempest_test_accounts | length \u003e 0)\n\nAdditionally, when someone wants to store it in file, they can use something like: `tempest_tets_accounts \u003d \"{{ lookup(\u0027file\u0027, \u0027/etc/foo.txt\u0027) }}\"`\n\nTBH it was exactly what You suggested when we were talking about it :D","commit_id":"81034c7722176c807f1f33bc2d5d7661a93909a8"}]}
