)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"b9116dc5ba3b07bd2558b38c24c171ebc4ad77ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"244bb8b6_4e20ff8d","updated":"2022-03-05 11:32:41.000000000","message":"It doesnt feel right that an ansible role to install and run tempest should be creating or adjusting service users for the heat service. That should be done as part of the installation of heat, not tempest. This is feeling like code sprawl covering up a problem elsewhere?","commit_id":"68ca837222a30817ba7eba0906983d46e0a1b265"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"fbc5990d64619fc4e379b4e85ef60913c9fd38fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ed956a8_0b198212","updated":"2022-03-10 16:12:13.000000000","message":"recheck","commit_id":"68ca837222a30817ba7eba0906983d46e0a1b265"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5124f2f9ca8823f4ef1b33ccdd4a9b396916faa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"401ee315_f9d80e9b","updated":"2022-05-12 09:05:04.000000000","message":"this patch no longer applies against the os_tempest role due to more recent changes, Takashi Kajinami - is this still needed from your side?","commit_id":"68ca837222a30817ba7eba0906983d46e0a1b265"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ab0c526114eacf179bc45798218641814580ce27","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75abc769_63419bbb","in_reply_to":"244bb8b6_4e20ff8d","updated":"2022-03-05 14:20:49.000000000","message":"heat_stack_role doesn\u0027t affect service users. This is the role assigned to cloud servers who are alloewd to create stacks.\n\nAlso, there already is a task to create tempest roles. If you are not comfortable with creating roles, then that task should be removed, otherwise the policy is inconsistent IMHO.","commit_id":"68ca837222a30817ba7eba0906983d46e0a1b265"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"978aad0d7dc583c2e1bd5bd2e1c3739aaebc0506","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f36305ba_96cb18cb","in_reply_to":"401ee315_f9d80e9b","updated":"2022-05-12 11:49:57.000000000","message":"I\u0027m good with abandoning this because role creation is now out of scope.","commit_id":"68ca837222a30817ba7eba0906983d46e0a1b265"}],"tasks/tempest_resources.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ff29e2a4e55a2f8691f2723e0bbe48c01a636390","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            cloud: \"{{ tempest_cloud_name }}\""},{"line_number":131,"context_line":"            interface: \"{{ tempest_interface_name }}\""},{"line_number":132,"context_line":"            validate_certs: \"{{ not (tempest_keystone_interface_insecure | bool) }}\""},{"line_number":133,"context_line":"            name: heat_stack_owner"},{"line_number":134,"context_line":"          register: add_heat_role"},{"line_number":135,"context_line":"          until: add_heat_role is success"},{"line_number":136,"context_line":"          retries: 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f5ced181_88557a06","line":133,"range":{"start_line":133,"start_character":18,"end_line":133,"end_character":34},"updated":"2022-03-03 09:18:05.000000000","message":"I think it should ideally be \"{{ heat_stack_owner_name | default(\u0027heat_stack_owner\u0027) }}\"\n\nSame applies below.","commit_id":"68ca837222a30817ba7eba0906983d46e0a1b265"}]}