)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"d7387db766ae7eb1422498d1b756ade18a799178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ddde31f_752728e3","updated":"2022-06-21 10:11:53.000000000","message":"recheck - 503\u0027s from keystone, i don\u0027t think they are related to this change","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"36cb19e9aa5c636dbd0afd57d0231127791b3ffe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e5a870d_68769245","updated":"2022-06-21 21:00:38.000000000","message":"recheck - tripleo-ci-centos-9-standalone has failed(it succeeded during the last check)","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"803f948c6a5f34f043043ca907c863d873e41279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a1bc26b_cdf6970a","updated":"2022-07-05 12:01:36.000000000","message":"recheck - tempest.scenario.test_server_basic_ops.TestServerBasicOps.test_server_basic_ops failed on centos8 for unknown reason:\n\nparamiko.ssh_exception.NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 172.29.249.179","commit_id":"dbde5fda58d87f54b0b19d2cb15914b39eb5cb98"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"772a415ea7812879cb958eae545d43492f2cd77d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7bdcfc1f_a19e4b03","updated":"2022-07-12 16:23:19.000000000","message":"recheck post failure","commit_id":"514b0ca612a7c804dacc94b211fc11be002c7984"}],"templates/tempest.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"88d4fe74f668d74753a25986d5b55938bdc7e14e","unresolved":true,"context_lines":[{"line_number":74,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":75,"context_line":"flavor_ref \u003d {{ tempest_nova_flavor_id_1 }}"},{"line_number":76,"context_line":"flavor_ref_alt \u003d {{ tempest_nova_flavor_id_2 }}"},{"line_number":77,"context_line":"{% if (not tempest_create_isolated_networks | bool) or (tempest_test_accounts | length \u003e 0) %}"},{"line_number":78,"context_line":"fixed_network_name \u003d {{ tempest_fixed_network_name }}"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"endpoint_type \u003d {{ tempest_endpoint_type }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5eb6b856_e85888ce","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":54},"updated":"2022-06-21 07:44:55.000000000","message":"shouldn\u0027t it be \"and\" then?","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"f2b7e1efd59321ad0f46b76ee3fa1c0dc1108e6e","unresolved":true,"context_lines":[{"line_number":74,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":75,"context_line":"flavor_ref \u003d {{ tempest_nova_flavor_id_1 }}"},{"line_number":76,"context_line":"flavor_ref_alt \u003d {{ tempest_nova_flavor_id_2 }}"},{"line_number":77,"context_line":"{% if (not tempest_create_isolated_networks | bool) or (tempest_test_accounts | length \u003e 0) %}"},{"line_number":78,"context_line":"fixed_network_name \u003d {{ tempest_fixed_network_name }}"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"endpoint_type \u003d {{ tempest_endpoint_type }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"4ef3da98_25e0c401","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":54},"in_reply_to":"21f1d47b_e184b5c7","updated":"2022-06-24 08:54:43.000000000","message":"\u003e Another situation which sounds wrong but is possible with OR, when dynamic_credentials are used (tempest_test_accounts length is \u003e 0) but tempest_create_isolated_networks is True.\n\nnot really, You described a case when dynamic_credentials ARE NOT used(tempest_test_accounts length is \u003e 0) ;)\n\n```\n{% if tempest_test_accounts | length \u003e 0 %}\nuse_dynamic_credentials \u003d False\ntest_accounts_file \u003d {{ tempest_test_accounts_file_path }}\n{% else %}\n```\n\n\u003e And what you write, you want to fixed_network_name be defined only when tempest_test_accounts is not defied AND tempest_create_isolated_networks is False?\n\nnot really, maybe I will describe the whole truth table, but lets look what comments do we have in defaults/main.yml first:\n\n```\n# tempest_create_isolated_networks has an effect only when use_dynamic_credentials is enabled\ntempest_create_isolated_networks: true\n# tempest_fixed_network_name has an effect only when tempest_create_isolated_networks is disabled\ntempest_fixed_network_name: public\n```\n\nthen:\n```\n(tempest_test_accounts | length \u003e 0) \u003d\u003d true \u0026\u0026 tempest_create_isolated_networks \u003d\u003d true:\n    define fixed_network_name\n(tempest_test_accounts | length \u003e 0) \u003d\u003d true \u0026\u0026 tempest_create_isolated_networks \u003d\u003d false:\n    define fixed_network_name\n(tempest_test_accounts | length \u003e 0) \u003d\u003d false \u0026\u0026 tempest_create_isolated_networks \u003d\u003d true:\n    NOT define fixed_network_name\n(tempest_test_accounts | length \u003e 0) \u003d\u003d false \u0026\u0026 tempest_create_isolated_networks \u003d\u003d false:\n    define fixed_network_name\n```","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a79d7625a577424443c1a6009016d0fc4ff04b17","unresolved":true,"context_lines":[{"line_number":74,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":75,"context_line":"flavor_ref \u003d {{ tempest_nova_flavor_id_1 }}"},{"line_number":76,"context_line":"flavor_ref_alt \u003d {{ tempest_nova_flavor_id_2 }}"},{"line_number":77,"context_line":"{% if (not tempest_create_isolated_networks | bool) or (tempest_test_accounts | length \u003e 0) %}"},{"line_number":78,"context_line":"fixed_network_name \u003d {{ tempest_fixed_network_name }}"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"endpoint_type \u003d {{ tempest_endpoint_type }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"53984416_97e3da47","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":54},"in_reply_to":"4ef3da98_25e0c401","updated":"2022-06-30 13:15:25.000000000","message":"I guess you meant \"||\" and not \"\u0026\u0026\" as this confused me even more.\n\nBut then according to comment, we actually don\u0027t want fixed_network_name to be defined in first case?\n\nSo when (tempest_test_accounts | length \u003e 0) is true, that means that use_dynamic_credentials is false, right? And we don\u0027t want to define fixed_network_name in that case?\n\nSo I\u0027m still super confused.","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"e4cdb98d2708896b8494f02594ef329ef6ab2723","unresolved":true,"context_lines":[{"line_number":74,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":75,"context_line":"flavor_ref \u003d {{ tempest_nova_flavor_id_1 }}"},{"line_number":76,"context_line":"flavor_ref_alt \u003d {{ tempest_nova_flavor_id_2 }}"},{"line_number":77,"context_line":"{% if (not tempest_create_isolated_networks | bool) or (tempest_test_accounts | length \u003e 0) %}"},{"line_number":78,"context_line":"fixed_network_name \u003d {{ tempest_fixed_network_name }}"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"endpoint_type \u003d {{ tempest_endpoint_type }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6a3cf9c0_3115f33a","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":54},"in_reply_to":"53984416_97e3da47","updated":"2022-06-30 17:19:31.000000000","message":"ok now I realized that our comments are confusing...but i still think my logic is valid\n\nI\u0027ve uploaded a patch to make things a bit more clear. The logic itself didn\u0027t change.\n\nI\u0027ve also created a drawio diagram to describe how should it work to my understanding: https://i.imgur.com/M5GLmvj.png","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"d16e482d46ecdfa72a9144065baa6ef8b65f25e5","unresolved":true,"context_lines":[{"line_number":74,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":75,"context_line":"flavor_ref \u003d {{ tempest_nova_flavor_id_1 }}"},{"line_number":76,"context_line":"flavor_ref_alt \u003d {{ tempest_nova_flavor_id_2 }}"},{"line_number":77,"context_line":"{% if (not tempest_create_isolated_networks | bool) or (tempest_test_accounts | length \u003e 0) %}"},{"line_number":78,"context_line":"fixed_network_name \u003d {{ tempest_fixed_network_name }}"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"endpoint_type \u003d {{ tempest_endpoint_type }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"adbea7e8_66fa1f6f","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":54},"in_reply_to":"5eb6b856_e85888ce","updated":"2022-06-21 08:13:17.000000000","message":"no, because current logic means:\ndefine fixed_network_name when tempest_create_isolated_networks\u003d\u003dFalse OR dynamic credentials not used\n\nif dynamic credentials are not used, the value of tempest_create_isolated_networks shouldn\u0027t be considered at all\nif dynamic credentials are used, then we should define fixed_network_name only when tempest_create_isolated_network\u003d\u003dFalse","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7921c6d44a8312d7c63be0bd802f94de4c2ce6af","unresolved":true,"context_lines":[{"line_number":74,"context_line":"image_ref_alt \u003d {{ tempest_glance_image_id_2 }}"},{"line_number":75,"context_line":"flavor_ref \u003d {{ tempest_nova_flavor_id_1 }}"},{"line_number":76,"context_line":"flavor_ref_alt \u003d {{ tempest_nova_flavor_id_2 }}"},{"line_number":77,"context_line":"{% if (not tempest_create_isolated_networks | bool) or (tempest_test_accounts | length \u003e 0) %}"},{"line_number":78,"context_line":"fixed_network_name \u003d {{ tempest_fixed_network_name }}"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"endpoint_type \u003d {{ tempest_endpoint_type }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"21f1d47b_e184b5c7","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":54},"in_reply_to":"adbea7e8_66fa1f6f","updated":"2022-06-24 06:30:20.000000000","message":"From what I read in text and in condition doesn\u0027t match for me.\n\n\nOR means that fixed_network_name will be defined in both cases, right?\n\nSo if you do not use dynamic_credentials (tempest_test_accounts length is \u003e 0) BUT tempest_create_isolated_networks is False, fixed_network_name will be placed with OR.\n\nAnother situation which sounds wrong but is possible with OR, when dynamic_credentials are used (tempest_test_accounts length is \u003e 0) but tempest_create_isolated_networks is True.\n\nBecause with OR only 1 condition should satisfy.\n\nAnd what you write, you want to fixed_network_name be defined only when tempest_test_accounts is not defied AND tempest_create_isolated_networks is False?\n\nThen it should be even like that?\n\n  if (not tempest_create_isolated_networks | bool) and (tempest_test_accounts | length \u003d\u003d 0)","commit_id":"b627f83bef272b6da43580fe24985e3a8e469567"}]}