)]}'
{".gitreview":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"1a7ea41d95f780f97efa46937d14168351b17491","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[gerrit]"},{"line_number":2,"context_line":"host\u003dreview.openstack.org"},{"line_number":3,"context_line":"port\u003d29418"},{"line_number":4,"context_line":"project\u003dopenstack/openstack-ansible-os_watcher.git"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_461eb95f","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":50},"updated":"2016-08-23 14:39:57.000000000","message":"I would prefer having this file into a separate changeset since it\u0027s not really related to what you are doing but if you don\u0027t want to move it, that\u0027s fine.","commit_id":"c33121da10e6cdf5c3972490ec96589292178e27"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"85529232701ce0ab36f7c083a7b19f0e507fcce7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[gerrit]"},{"line_number":2,"context_line":"host\u003dreview.openstack.org"},{"line_number":3,"context_line":"port\u003d29418"},{"line_number":4,"context_line":"project\u003dopenstack/openstack-ansible-os_watcher.git"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_9b43e312","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":50},"in_reply_to":"1ac06dbe_461eb95f","updated":"2016-08-23 14:57:25.000000000","message":"@Vincent - the first patch is going to have to include anything that makes the role tests work, unless we relax them initially.\n\nAn option, of course, is to comment out sections in tox.ini and just make the tests pass so that the patch can be broken up into purpose specific bits.\n\nThis, in fact, is something I\u0027d prefer to see done.\n\nThe initial patch should simply be scaffolding, similar to https://github.com/openstack/openstack-ansible-ceph_client/commit/b17bda5e261cde126344a9f05135dcb0d3f6f452 but perhaps with bits marked out something like https://github.com/openstack/openstack-ansible-os_magnum/blob/master/tox.ini#L148-L170 to make tests pass and thus a merge possible. From then on add patches which remove the remarked bits and fix one functional thing.","commit_id":"c33121da10e6cdf5c3972490ec96589292178e27"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"dc2d98b1b52aa42cd2daaf9a11f3122b55ea7318","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[gerrit]"},{"line_number":2,"context_line":"host\u003dreview.openstack.org"},{"line_number":3,"context_line":"port\u003d29418"},{"line_number":4,"context_line":"project\u003dopenstack/openstack-ansible-os_watcher.git"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_caa46309","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":50},"in_reply_to":"1ac06dbe_9b43e312","updated":"2016-08-23 15:43:08.000000000","message":"The scaffolding patch was what I was thinking about.","commit_id":"c33121da10e6cdf5c3972490ec96589292178e27"}],"CONTRIBUTING.rst":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"1a7ea41d95f780f97efa46937d14168351b17491","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenStack-Ansible Watcher"},{"line_number":2,"context_line":"#########################"},{"line_number":3,"context_line":":tags: openstack, cloud, ansible"},{"line_number":4,"context_line":":category: \\*nix"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ac06dbe_26cd7db7","line":1,"updated":"2016-08-23 14:39:57.000000000","message":"ditto, this file is more about initial project setup than role configuration.","commit_id":"c33121da10e6cdf5c3972490ec96589292178e27"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"ced8428ab700c55f4ffa1f2d842e4aec3bcdffd0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenStack-Ansible Watcher"},{"line_number":2,"context_line":"#########################"},{"line_number":3,"context_line":":tags: openstack, cloud, ansible"},{"line_number":4,"context_line":":category: \\*nix"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Contributor Guidelines"},{"line_number":7,"context_line":"^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_049af4b8","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":16},"updated":"2016-08-23 15:21:12.000000000","message":"remove","commit_id":"f3ece9422d519f78ae3faa9f1a222940a254509f"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"ced8428ab700c55f4ffa1f2d842e4aec3bcdffd0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Style guide"},{"line_number":55,"context_line":"-----------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"When creating tasks and other roles for use in Ansible please create then"},{"line_number":58,"context_line":"using the YAML dictionary format."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Example YAML dictionary format:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_64d64850","line":57,"range":{"start_line":57,"start_character":69,"end_line":57,"end_character":73},"updated":"2016-08-23 15:21:12.000000000","message":"\"them\"","commit_id":"f3ece9422d519f78ae3faa9f1a222940a254509f"}],"Vagrantfile":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"ced8428ab700c55f4ffa1f2d842e4aec3bcdffd0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    trusty.vm.provision \"shell\", inline: \u003c\u003c-SHELL"},{"line_number":9,"context_line":"      sudo su -"},{"line_number":10,"context_line":"      cd /vagrant"},{"line_number":11,"context_line":"      apt-get update"},{"line_number":12,"context_line":"      ./run_tests.sh"},{"line_number":13,"context_line":"    SHELL"},{"line_number":14,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ac06dbe_640be8d6","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":20},"updated":"2016-08-23 15:21:12.000000000","message":"remove, already in run_tests","commit_id":"f3ece9422d519f78ae3faa9f1a222940a254509f"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"ced8428ab700c55f4ffa1f2d842e4aec3bcdffd0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    xenial.vm.provision \"shell\", inline: \u003c\u003c-SHELL"},{"line_number":19,"context_line":"      sudo su -"},{"line_number":20,"context_line":"      cd /vagrant"},{"line_number":21,"context_line":"      apt-get update"},{"line_number":22,"context_line":"      ./run_tests.sh"},{"line_number":23,"context_line":"    SHELL"},{"line_number":24,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ac06dbe_e4f7d8d0","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":19},"updated":"2016-08-23 15:21:12.000000000","message":"remove, already in run_tests","commit_id":"f3ece9422d519f78ae3faa9f1a222940a254509f"}],"bindep.txt":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"1a7ea41d95f780f97efa46937d14168351b17491","unresolved":false,"context_lines":[{"line_number":16,"context_line":"libssl-dev        [platform:dpkg]"},{"line_number":17,"context_line":"libffi-dev        [platform:dpkg]"},{"line_number":18,"context_line":"python2.7         [platform:dpkg]"},{"line_number":19,"context_line":"python-dev        [platform:dpkg]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Base requirements for CentOS"},{"line_number":22,"context_line":"gcc               [platform:rpm]"}],"source_content_type":"text/plain","patch_set":3,"id":"1ac06dbe_cb7f52a9","line":19,"updated":"2016-08-23 14:39:57.000000000","message":"How about python 3 support? Shouldn\u0027t we add it here?","commit_id":"c33121da10e6cdf5c3972490ec96589292178e27"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"dc2d98b1b52aa42cd2daaf9a11f3122b55ea7318","unresolved":false,"context_lines":[{"line_number":16,"context_line":"libssl-dev        [platform:dpkg]"},{"line_number":17,"context_line":"libffi-dev        [platform:dpkg]"},{"line_number":18,"context_line":"python2.7         [platform:dpkg]"},{"line_number":19,"context_line":"python-dev        [platform:dpkg]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Base requirements for CentOS"},{"line_number":22,"context_line":"gcc               [platform:rpm]"}],"source_content_type":"text/plain","patch_set":3,"id":"1ac06dbe_ca6d83cd","line":19,"in_reply_to":"1ac06dbe_647ac889","updated":"2016-08-23 15:43:08.000000000","message":"Ok, I was just wondering about it and since I\u0027m not really familiar with your process, I preferred asking :)","commit_id":"c33121da10e6cdf5c3972490ec96589292178e27"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2a7e89181745de47925d5c994e037486af48ffa9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"libssl-dev        [platform:dpkg]"},{"line_number":17,"context_line":"libffi-dev        [platform:dpkg]"},{"line_number":18,"context_line":"python2.7         [platform:dpkg]"},{"line_number":19,"context_line":"python-dev        [platform:dpkg]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Base requirements for CentOS"},{"line_number":22,"context_line":"gcc               [platform:rpm]"}],"source_content_type":"text/plain","patch_set":3,"id":"1ac06dbe_647ac889","line":19,"in_reply_to":"1ac06dbe_cb7f52a9","updated":"2016-08-23 15:19:02.000000000","message":"Vincent - These are to make Ansible run successfully and for pip to work properly with https sources. The bindep.txt here is different to the service repositories in that this one is focused on making *deployment* work, not a python build.\n\nBesides - we\u0027ll be tackling Python3 compat in Ocata.","commit_id":"c33121da10e6cdf5c3972490ec96589292178e27"}],"doc/source/index.rst":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"ced8428ab700c55f4ffa1f2d842e4aec3bcdffd0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" OpenStack-Ansible Watcher"},{"line_number":3,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ac06dbe_0476746f","line":1,"range":{"start_line":1,"start_character":26,"end_line":1,"end_character":29},"updated":"2016-08-23 15:21:12.000000000","message":"wrong length","commit_id":"f3ece9422d519f78ae3faa9f1a222940a254509f"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"1bec7c1e0ca1683a3e99cf71a41228a3741ef635","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" OpenStack-Ansible Watcher"},{"line_number":3,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" This Ansible role installs Watcher."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1ac06dbe_0adf9bd9","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-08-23 15:49:19.000000000","message":"This may cause issues with doc linting","commit_id":"b71a8107b90a5b596aec5beaa127918eee1a3885"}],"tasks/watcher_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bd6f62acd8966827332e8284dad232170c87ed18","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: install-apt.yml"},{"line_number":17,"context_line":"  when:"},{"line_number":18,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create developer mode constraint file"},{"line_number":21,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1ac06dbe_0424b45b","side":"PARENT","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":30},"updated":"2016-08-23 15:22:19.000000000","message":"Does this belong here? I\u0027m not sure what this has to do with making the CI tests work?","commit_id":"76a013f8145c5f18766b561f426e22315f22836d"}],"vars/debian.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bd6f62acd8966827332e8284dad232170c87ed18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_84e0a4ce","updated":"2016-08-23 15:22:19.000000000","message":"Does Watcher have absolutely no binary deps? It would seem to me that this change should be in a subsequent patch.","commit_id":"7367945b3a7b1312aff198602671ac1dc1eacc2d"}]}