)]}'
{"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"91db098678292bba63bc0d561d76eb2147d9a1bf","unresolved":true,"context_lines":[{"line_number":311,"context_line":"zun_compute_init_overrides: {}"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"## Default zun+kuryr options used within the system unit file."},{"line_number":314,"context_line":"zun_kuryr_init_overrides:"},{"line_number":315,"context_line":"  Unit:"},{"line_number":316,"context_line":"    Before: docker.service"},{"line_number":317,"context_line":"    After: network-online.target"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ec15b43_43240b41","line":314,"range":{"start_line":314,"start_character":0,"end_line":314,"end_character":24},"updated":"2021-01-06 09:03:54.000000000","message":"tbh I\u0027d renamed this to zun_kuryr_default_overrides, and did combine dicts in order to leave zun_kuryr_init_overrides for deployers","commit_id":"e0ec5592be8baedd42f679dc1b270a2c25778c55"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2b74f6d061065ecc63f3a8372ee231202cc3f2e4","unresolved":true,"context_lines":[{"line_number":311,"context_line":"zun_compute_init_overrides: {}"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"## Default zun+kuryr options used within the system unit file."},{"line_number":314,"context_line":"zun_kuryr_init_overrides:"},{"line_number":315,"context_line":"  Unit:"},{"line_number":316,"context_line":"    Before: docker.service"},{"line_number":317,"context_line":"    After: network-online.target"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c5868d75_7ecbd82f","line":314,"range":{"start_line":314,"start_character":0,"end_line":314,"end_character":24},"in_reply_to":"1ec15b43_43240b41","updated":"2021-01-06 09:09:32.000000000","message":"Also I\u0027m not 100% sure about that, but don\u0027t we need to adjust docker systemd as well? \nhttps://review.opendev.org/c/openstack/ansible-role-systemd_service/+/765815 might be handy but patch might have issues and I\u0027m testing it right now.","commit_id":"e0ec5592be8baedd42f679dc1b270a2c25778c55"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8680cd631652440abfe1598fb7d1af140d65e5a3","unresolved":true,"context_lines":[{"line_number":311,"context_line":"zun_compute_init_overrides: {}"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"## Default zun+kuryr options used within the system unit file."},{"line_number":314,"context_line":"zun_kuryr_init_overrides:"},{"line_number":315,"context_line":"  Unit:"},{"line_number":316,"context_line":"    Before: docker.service"},{"line_number":317,"context_line":"    After: network-online.target"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cb4d971f_b1cb88a4","line":314,"range":{"start_line":314,"start_character":0,"end_line":314,"end_character":24},"in_reply_to":"4c162cef_8eabcb19","updated":"2021-01-06 09:52:20.000000000","message":"yeah, agree, just decided that it\u0027s worth to mention it even exists:)","commit_id":"e0ec5592be8baedd42f679dc1b270a2c25778c55"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"0283aa84a31f11e28176b28d5a01d7052cfaf28a","unresolved":true,"context_lines":[{"line_number":311,"context_line":"zun_compute_init_overrides: {}"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"## Default zun+kuryr options used within the system unit file."},{"line_number":314,"context_line":"zun_kuryr_init_overrides:"},{"line_number":315,"context_line":"  Unit:"},{"line_number":316,"context_line":"    Before: docker.service"},{"line_number":317,"context_line":"    After: network-online.target"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4c162cef_8eabcb19","line":314,"range":{"start_line":314,"start_character":0,"end_line":314,"end_character":24},"in_reply_to":"6decdc4d_97f0ba61","updated":"2021-01-06 09:44:37.000000000","message":"Just a thought. This patch may be worth backporting, so perhaps it\u0027s best I wait to bring it into line with https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/765815 until later.","commit_id":"e0ec5592be8baedd42f679dc1b270a2c25778c55"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"67a5b59ef4e2e489f1d76f6252cce0a4f1aa808a","unresolved":true,"context_lines":[{"line_number":311,"context_line":"zun_compute_init_overrides: {}"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"## Default zun+kuryr options used within the system unit file."},{"line_number":314,"context_line":"zun_kuryr_init_overrides:"},{"line_number":315,"context_line":"  Unit:"},{"line_number":316,"context_line":"    Before: docker.service"},{"line_number":317,"context_line":"    After: network-online.target"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6decdc4d_97f0ba61","line":314,"range":{"start_line":314,"start_character":0,"end_line":314,"end_character":24},"in_reply_to":"c5868d75_7ecbd82f","updated":"2021-01-06 09:13:53.000000000","message":"As far as I can see from testing the Docker service should be fine as it is. I\u0027ll keep an eye on that patch and adjust this one as necessary.\n\nIn general this defaults file needs a bit of a tidy up, but I\u0027m tackling all of the functional issues before coming back to that.","commit_id":"e0ec5592be8baedd42f679dc1b270a2c25778c55"}]}
