)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~366299","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~I2f02a4e772398d0c133d3109058d55c4f96b72f7","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"glance_image_properties","hashtags":[],"change_id":"I2f02a4e772398d0c133d3109058d55c4f96b72f7","subject":"Deserialize glance image_properties","status":"MERGED","created":"2016-09-06 19:18:36.000000000","updated":"2016-09-07 16:43:59.000000000","submitted":"2016-09-07 16:43:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"db83b726f7d43c8fb1791bd5e728c41817c62f3d","_number":366299,"virtual_id_number":366299,"owner":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2016-09-07 16:43:59.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2016-09-07 06:42:18.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":2,"date":"2016-09-07 16:41:59.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":-1,"date":"2016-09-07 08:38:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":1,"date":"2016-09-07 16:41:59.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-06 19:50:44.000000000","updated_by":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"reviewer":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"state":"REVIEWER"},{"updated":"2016-09-07 06:42:18.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2016-09-07 08:38:46.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2016-09-07 16:41:59.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2016-09-07 16:43:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6e84cbed246fda313d8736ac3386e209b50c5035","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2016-09-06 19:18:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e09c844dcafda0c1b9e3f81730376cba79c83a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 19:22:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/99/366299/1/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/9d406e2//doc/build/html/ : SUCCESS in 2m 24s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/99/366299/1/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/83ff4fe/ : SUCCESS in 1m 48s","accounts_in_message":[],"_revision_number":1},{"id":"b00472533dc22adde3da2874dff8872aae7e74d7","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-09-06 19:50:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4ed03aefefb7c359b81e9fe7357faec185f2d838","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2016-09-06 20:12:03.000000000","message":"Patch Set 1: Workflow-1\n\nneed to test this some more","accounts_in_message":[],"_revision_number":1},{"id":"d6a93344e8ea26acd7b41f45c56d75cb113c4586","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2016-09-06 21:03:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8bed628cfc2352e94b4f6966e304e15407e247c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 21:05:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/99/366299/2/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/f244685//doc/build/html/ : SUCCESS in 56s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/99/366299/2/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/5df5a2a/ : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":2},{"id":"3d98347cbe8f96e12040d8535253584b5eed5ade","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-09-07 06:42:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e8e221d33406fc0a343dd23edfab5fc18010c4e8","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2016-09-07 08:38:46.000000000","message":"Patch Set 2: Code-Review-1\n\nIs this the plan to be backported?\n\nIf not, why aren\u0027t we moving away from our glance module and use os_image instead?","accounts_in_message":[],"_revision_number":2},{"id":"81bf9ff7a474de56268530540c5f939d4492aa29","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-09-07 08:59:09.000000000","message":"Patch Set 2:\n\n@JP It\u0027s too late in the cycle for such a large scale change. Considering that Magnum is part of the Newton release, we need to ensure that it\u0027s tested and working properly for the release.\n\nOnce the Newton branch is cut, I\u0027d support moving to using the upstream Ansible modules.","accounts_in_message":[],"_revision_number":2},{"id":"8c4da1ac96145e3c4cb1f52aac11ee10308ef1bf","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2016-09-07 09:18:57.000000000","message":"Patch Set 2:\n\n\u003e @JP It\u0027s too late in the cycle for such a large scale change.\n \u003e Considering that Magnum is part of the Newton release, we need to\n \u003e ensure that it\u0027s tested and working properly for the release.\n \u003e \n \u003e Once the Newton branch is cut, I\u0027d support moving to using the\n \u003e upstream Ansible modules.\n\nI\u0027ve verified that this part of module isn\u0027t used somewhere else, which is the case. I don\u0027t see a problem to backport this as it will be self contained.\n\nI still think this deserves a link to upstream documentation to justify the change, after that we\u0027re good to go.","accounts_in_message":[],"_revision_number":2},{"id":"9354fe442baead56f23a9387fca33c3af91e94ce","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2016-09-07 16:01:45.000000000","message":"Patch Set 2:\n\nWhich upstream documentation are you looking to have updated?\nI\u0027m not sure where this option is documented beyond the example within the library itself.","accounts_in_message":[],"_revision_number":2},{"id":"693889615fdbdf4acdc11cd71b25f709716e3b62","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-09-07 16:41:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"87fb027e9180fadec1ae33aa87af10c76e83e561","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-07 16:42:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c39b9ebf35278f7467d09d99f011eed3509b2e38","date":"2016-09-07 16:43:59.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"6405711fa70c92c189c98d9c0da721271f37eb44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-07 16:43:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/99/366299/2/gate/gate-openstack-ansible-plugins-docs-ubuntu-xenial/05c4267//doc/build/html/ : SUCCESS in 1m 46s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/99/366299/2/gate/gate-openstack-ansible-plugins-linters-ubuntu-xenial/e5ca399/ : SUCCESS in 1m 39s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f974f7a0cd8a256c6fcb8c05d16cf06b69b48382","revisions":{"81ade5bf7faae284e7e295406cba4025cb24e3c2":{"kind":"REWORK","_number":1,"created":"2016-09-06 19:18:36.000000000","uploader":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"ref":"refs/changes/99/366299/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/99/366299/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/1"}}},"commit":{"parents":[{"commit":"ffb02cfb550a0ebf4ab88e9241a8d42bc17751a4","subject":"Fix assumption that the main OSA inventory will be used","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/ffb02cfb550a0ebf4ab88e9241a8d42bc17751a4"}]}],"author":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2016-09-06 18:24:00.000000000","tz":-420},"committer":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2016-09-06 19:17:48.000000000","tz":-420},"subject":"Update glance image properties example","message":"Update glance image properties example\n\nGlance requires that the passed image properties be an iterable\ndictionary.\n\nUpdate the documented example to use YAML\u0027s syntax for a dictionary\ninstead of a JSON string. Using a JSON string would require additional\nlogic within the glance library to deserialize it.\n\nChange-Id: I2f02a4e772398d0c133d3109058d55c4f96b72f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/81ade5bf7faae284e7e295406cba4025cb24e3c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/81ade5bf7faae284e7e295406cba4025cb24e3c2"}]},"branch":"refs/heads/master"},"f974f7a0cd8a256c6fcb8c05d16cf06b69b48382":{"kind":"REWORK","_number":2,"created":"2016-09-06 21:03:30.000000000","uploader":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"ref":"refs/changes/99/366299/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/99/366299/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/99/366299/2"}}},"commit":{"parents":[{"commit":"ffb02cfb550a0ebf4ab88e9241a8d42bc17751a4","subject":"Fix assumption that the main OSA inventory will be used","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/ffb02cfb550a0ebf4ab88e9241a8d42bc17751a4"}]}],"author":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2016-09-06 18:24:00.000000000","tz":-420},"committer":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2016-09-06 21:02:43.000000000","tz":-420},"subject":"Deserialize glance image_properties","message":"Deserialize glance image_properties\n\nGlance requires that the passed image properties be an iterable\ndictionary.\n\nUpdate the documented example to use YAML\u0027s syntax for a dictionary\ninstead of a JSON string. The resulting string will be deserialized\nto a Python dict.\n\nChange-Id: I2f02a4e772398d0c133d3109058d55c4f96b72f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/f974f7a0cd8a256c6fcb8c05d16cf06b69b48382"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/f974f7a0cd8a256c6fcb8c05d16cf06b69b48382"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}