)]}'
{"tox.ini":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b780fee030af9e7fcf798beb7706cfa1a9b91311","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    {[testenv:ansible]commands}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[testenv:func_base]"},{"line_number":112,"context_line":"# NOTE(odyssey4me): this target does not use constraints because"},{"line_number":113,"context_line":"# it doesn\u0027t work in OpenStack-CI yet. Once that\u0027s fixed, we can"},{"line_number":114,"context_line":"# drop the install_command."},{"line_number":115,"context_line":"install_command \u003d"},{"line_number":116,"context_line":"    pip install -U --force-reinstall {opts} {packages}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"[testenv:func_logs]"},{"line_number":120,"context_line":"commands \u003d"},{"line_number":121,"context_line":"    bash -c \u0027mkdir -p {toxinidir}/logs\u0027"},{"line_number":122,"context_line":"    bash -c \u0027rsync --archive --verbose --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":123,"context_line":"    bash -c \u0027find \"{toxinidir}/logs/\" -type f | sed \"p;s|$|.txt|\" | xargs -n2 mv\u0027"},{"line_number":124,"context_line":"    bash -c \u0027command gzip --best --recursive \"{toxinidir}/logs/\"\u0027"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[testenv:releasenotes]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7a8ec9b2_c1a372b0","line":124,"range":{"start_line":111,"start_character":0,"end_line":124,"end_character":65},"updated":"2016-09-19 09:15:20.000000000","message":"There\u0027s currently no functional test in this role. Should we add one? It looks like we\u0027re running functional tests inside the lint test right now.","commit_id":"88d73c4ad915f5d56095609c8efc61ea6750f9af"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4048609b415aefa14fbfcf196f1a74593bb03a86","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    {[testenv:ansible]commands}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[testenv:func_base]"},{"line_number":112,"context_line":"# NOTE(odyssey4me): this target does not use constraints because"},{"line_number":113,"context_line":"# it doesn\u0027t work in OpenStack-CI yet. Once that\u0027s fixed, we can"},{"line_number":114,"context_line":"# drop the install_command."},{"line_number":115,"context_line":"install_command \u003d"},{"line_number":116,"context_line":"    pip install -U --force-reinstall {opts} {packages}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"[testenv:func_logs]"},{"line_number":120,"context_line":"commands \u003d"},{"line_number":121,"context_line":"    bash -c \u0027mkdir -p {toxinidir}/logs\u0027"},{"line_number":122,"context_line":"    bash -c \u0027rsync --archive --verbose --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":123,"context_line":"    bash -c \u0027find \"{toxinidir}/logs/\" -type f | sed \"p;s|$|.txt|\" | xargs -n2 mv\u0027"},{"line_number":124,"context_line":"    bash -c \u0027command gzip --best --recursive \"{toxinidir}/logs/\"\u0027"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[testenv:releasenotes]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7a8ec9b2_ede643e7","line":124,"range":{"start_line":111,"start_character":0,"end_line":124,"end_character":65},"in_reply_to":"7a8ec9b2_8decdff4","updated":"2016-09-20 15:41:26.000000000","message":"Sure - if you can update this review to add the functional test job - I\u0027ll get the change done in infra to exercise it.","commit_id":"88d73c4ad915f5d56095609c8efc61ea6750f9af"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"53fb6d32e84d150d495c61e767a8d9c103f4f146","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    {[testenv:ansible]commands}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[testenv:func_base]"},{"line_number":112,"context_line":"# NOTE(odyssey4me): this target does not use constraints because"},{"line_number":113,"context_line":"# it doesn\u0027t work in OpenStack-CI yet. Once that\u0027s fixed, we can"},{"line_number":114,"context_line":"# drop the install_command."},{"line_number":115,"context_line":"install_command \u003d"},{"line_number":116,"context_line":"    pip install -U --force-reinstall {opts} {packages}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"[testenv:func_logs]"},{"line_number":120,"context_line":"commands \u003d"},{"line_number":121,"context_line":"    bash -c \u0027mkdir -p {toxinidir}/logs\u0027"},{"line_number":122,"context_line":"    bash -c \u0027rsync --archive --verbose --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":123,"context_line":"    bash -c \u0027find \"{toxinidir}/logs/\" -type f | sed \"p;s|$|.txt|\" | xargs -n2 mv\u0027"},{"line_number":124,"context_line":"    bash -c \u0027command gzip --best --recursive \"{toxinidir}/logs/\"\u0027"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[testenv:releasenotes]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7a8ec9b2_8decdff4","line":124,"range":{"start_line":111,"start_character":0,"end_line":124,"end_character":65},"in_reply_to":"7a8ec9b2_c1a372b0","updated":"2016-09-20 15:38:24.000000000","message":"I think we can add one, this is more just making the tox.ini configs consistent across our roles.","commit_id":"88d73c4ad915f5d56095609c8efc61ea6750f9af"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eb744ca515317a16269cdb92691abb205ba3c16e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    {[testenv:ansible]commands}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[testenv:func_base]"},{"line_number":112,"context_line":"# NOTE(odyssey4me): this target does not use constraints because"},{"line_number":113,"context_line":"# it doesn\u0027t work in OpenStack-CI yet. Once that\u0027s fixed, we can"},{"line_number":114,"context_line":"# drop the install_command."},{"line_number":115,"context_line":"install_command \u003d"},{"line_number":116,"context_line":"    pip install -U --force-reinstall {opts} {packages}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"[testenv:func_logs]"},{"line_number":120,"context_line":"commands \u003d"},{"line_number":121,"context_line":"    bash -c \u0027mkdir -p {toxinidir}/logs\u0027"},{"line_number":122,"context_line":"    bash -c \u0027rsync --archive --verbose --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":123,"context_line":"    bash -c \u0027find \"{toxinidir}/logs/\" -type f | sed \"p;s|$|.txt|\" | xargs -n2 mv\u0027"},{"line_number":124,"context_line":"    bash -c \u0027command gzip --best --recursive \"{toxinidir}/logs/\"\u0027"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[testenv:releasenotes]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7a8ec9b2_584b7759","line":124,"range":{"start_line":111,"start_character":0,"end_line":124,"end_character":65},"in_reply_to":"7a8ec9b2_ede643e7","updated":"2016-09-20 15:50:01.000000000","message":"Standard functional tests applied across platforms: https://review.openstack.org/373434","commit_id":"88d73c4ad915f5d56095609c8efc61ea6750f9af"}]}