)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~444416","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~I0ade538e20f2a926b33c1637446c2d4f650cd13d","project":"openstack/openstack-ansible-plugins","branch":"master","hashtags":[],"change_id":"I0ade538e20f2a926b33c1637446c2d4f650cd13d","subject":"Always update existing matching endpoints","status":"MERGED","created":"2017-03-10 17:05:01.000000000","updated":"2017-03-28 08:45:58.000000000","submitted":"2017-03-14 12:42:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"56acca9cf2f0a74eb15f15a35b328db95f1776e3","_number":444416,"virtual_id_number":444416,"owner":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2017-03-14 12:42:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2017-03-14 12:39:37.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":2,"date":"2017-03-14 11:11:11.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":1,"date":"2017-03-14 12:39:37.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-10 17:50:04.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2017-03-14 11:11:11.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2017-03-14 12:39:37.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2017-03-14 12:42:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e41fab48fa21f908b63ba53c1b22cec088d7c833","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2017-03-10 17:05:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fc6c42b6456dc494b9fba098c85ccbda056712c0","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-10 17:09:30.000000000","message":"Patch Set 1: Code-Review-1\n\nThis definitely needs a release note as it\u0027s a big change in behaviour. Previously a user could have their own DNS entries and change the catalogue at will - now they are forced to use the external_lb_address properly.\n\nI definitely think that this is better implemented as a var which can be set in each role, and we should default to updating but allow a single var to be set which tells the task not to update if the deployer wants it.","accounts_in_message":[],"_revision_number":1},{"id":"aeeb99c4249c3c66bf03549417a25eb8a3204f65","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-10 17:10:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/16/444416/1/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/986d158//doc/build/html/ : SUCCESS in 2m 09s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/16/444416/1/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/b544e8d/ : SUCCESS in 1m 49s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/16/444416/1/check/gate-openstack-ansible-plugins-ansible-func-centos-7/ac3c8dd/ : SUCCESS in 2m 20s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/16/444416/1/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/27b816e/ : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":1},{"id":"cdd23c48d32d3133019f2bc1d444507920fa92c3","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-03-10 17:50:04.000000000","message":"Patch Set 1: Code-Review+1\n\nI\u0027m in favor of this change however I do agree with Jesse that we should have a release note regarding the change.","accounts_in_message":[],"_revision_number":1},{"id":"47b58fad42fe5a656a2ff1ab84ad1cc02c381fe5","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2017-03-11 14:16:43.000000000","message":"Patch Set 1:\n\nWill add a rel-note - definitely needs one, i don\u0027t think it makes sense to not do this though.\nIf you don\u0027t do this you will just get duplicate endpoints per service that are different - at which point how do you know what service you will get based on a a request from a service - you don\u0027t really, and i think it\u0027ll create inconsistency.","accounts_in_message":[],"_revision_number":1},{"id":"c1f0448e61ab4300b5fb3b1623f9e9d3723f6462","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2017-03-11 14:24:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bada87996082f8d8654d8147eba7f3b942a36c64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-11 14:25:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/16/444416/2/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/a17fc21//doc/build/html/ : SUCCESS in 1m 07s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/16/444416/2/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/e563455/ : SUCCESS in 1m 13s\n- gate-openstack-ansible-plugins-releasenotes http://docs-draft.openstack.org/16/444416/2/check/gate-openstack-ansible-plugins-releasenotes/7af4a6e//releasenotes/build/html/ : SUCCESS in 34s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/16/444416/2/check/gate-openstack-ansible-plugins-ansible-func-centos-7/e7e40fa/ : SUCCESS in 1m 11s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/16/444416/2/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/b403b08/ : SUCCESS in 59s","accounts_in_message":[],"_revision_number":2},{"id":"dec30251fb5eaa9584a9ed28eaa41c7273c92c1a","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-13 10:22:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"17a539c61594fc6d90e6fcee5eb31d0f373fa452","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-03-13 21:32:03.000000000","message":"Patch Set 2: Code-Review-1\n\nWhen I introduced \"update\" I was told changing endpoint could be a breaking change for many services, and have to be done in a more coordinated manner.\n\nThat\u0027s why this was never set as the default.\nWe could have many ways to make this simpler (like having a force: true to update, else throw an error) than having a different state.\n\nI\u0027m enclined to give this a go, and deprecate the old \"update\" feature, because we never got the change to document it.\n\nI\u0027d say the upper part of the library deserves a change too, to indicate this, because it\u0027s used in the plugins role documentation, at least IIRC.","accounts_in_message":[],"_revision_number":2},{"id":"527d6039ff06fce32cdad19e27f7fe626a682d53","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-03-13 21:33:04.000000000","message":"Patch Set 2:\n\n\u003e When I introduced \"update\" I was told changing endpoint could be a\n \u003e breaking change for many services, and have to be done in a more\n \u003e coordinated manner.\n \u003e \n \u003e That\u0027s why this was never set as the default.\n \u003e We could have many ways to make this simpler (like having a force:\n \u003e true to update, else throw an error) than having a different state.\n \u003e \n \u003e I\u0027m enclined to give this a go, and deprecate the old \"update\"\n \u003e feature, because we never got the change to document it.\n \u003e \n \u003e I\u0027d say the upper part of the library deserves a change too, to\n \u003e indicate this, because it\u0027s used in the plugins role documentation,\n \u003e at least IIRC.\n\nL203.","accounts_in_message":[],"_revision_number":2},{"id":"29720f23b50bfbaf815ff8bdb797e27f89b27d51","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-03-14 10:52:59.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"8541702d5581d75f3191acf1436854bcf2bebab6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-14 10:56:58.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/16/444416/3/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/439994e//doc/build/html/ : SUCCESS in 1m 29s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/16/444416/3/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/92d98d4/ : FAILURE in 1m 00s\n- gate-openstack-ansible-plugins-releasenotes http://docs-draft.openstack.org/16/444416/3/check/gate-openstack-ansible-plugins-releasenotes/7d97216//releasenotes/build/html/ : SUCCESS in 1m 17s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/16/444416/3/check/gate-openstack-ansible-plugins-ansible-func-centos-7/3157f8d/ : SUCCESS in 2m 04s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/16/444416/3/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/2c3d24e/ : SUCCESS in 2m 42s","accounts_in_message":[],"_revision_number":3},{"id":"a2937accd62ac21137aa26748aeb9890802988cb","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2017-03-14 11:10:19.000000000","message":"Patch Set 4: Published edit on patch set 3","accounts_in_message":[],"_revision_number":4},{"id":"24fa966c868f32e05205c5548c5acdd4516f966d","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-03-14 11:11:11.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d7bcd4aa8f745cf080e4d999f7b0570e707eb8f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-14 11:15:32.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/16/444416/4/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/54f0212//doc/build/html/ : SUCCESS in 1m 46s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/16/444416/4/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/3e4291c/ : SUCCESS in 3m 32s\n- gate-openstack-ansible-plugins-releasenotes http://docs-draft.openstack.org/16/444416/4/check/gate-openstack-ansible-plugins-releasenotes/603cfda//releasenotes/build/html/ : SUCCESS in 49s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/16/444416/4/check/gate-openstack-ansible-plugins-ansible-func-centos-7/53474dd/ : SUCCESS in 1m 33s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/16/444416/4/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/14dee81/ : SUCCESS in 1m 16s","accounts_in_message":[],"_revision_number":4},{"id":"9da17665db187b457d684de322d58f8d39900d26","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-14 12:39:37.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"09efe6ffd7b0ba2112dad526bf06a36094399b6a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-14 12:39:48.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"122aae12b4c6e052923d83567f5b2d7ccb8ccd67","date":"2017-03-14 12:42:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"cd91f13f72cb221c891cd522292a5b66f51c9a13","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-14 12:42:19.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/16/444416/4/gate/gate-openstack-ansible-plugins-docs-ubuntu-xenial/836b210//doc/build/html/ : SUCCESS in 1m 53s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/16/444416/4/gate/gate-openstack-ansible-plugins-linters-ubuntu-xenial/544ab12/ : SUCCESS in 1m 52s\n- gate-openstack-ansible-plugins-releasenotes http://docs-draft.openstack.org/16/444416/4/gate/gate-openstack-ansible-plugins-releasenotes/56d42bd//releasenotes/build/html/ : SUCCESS in 1m 52s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/16/444416/4/gate/gate-openstack-ansible-plugins-ansible-func-centos-7/3780f3e/ : SUCCESS in 1m 17s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/16/444416/4/gate/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/04a2890/ : SUCCESS in 1m 52s","accounts_in_message":[],"_revision_number":4},{"id":"56acca9cf2f0a74eb15f15a35b328db95f1776e3","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2017-03-28 08:45:58.000000000","message":"Patch Set 4: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ocata as commit 75265d139c13603e088473d262648b16327a536e","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"5822e29d4128421b6879496605a2987b0e128a8b","revisions":{"9edb941bf7e97486ffadc1ce5e47373e55b9a66c":{"kind":"REWORK","_number":1,"created":"2017-03-10 17:05:01.000000000","uploader":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"ref":"refs/changes/16/444416/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/16/444416/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/1"}}},"commit":{"parents":[{"commit":"14d2727c0474d794d491ebde2251a7e190654a8d","subject":"Remove quotes when assigning values from an openrc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/14d2727c0474d794d491ebde2251a7e190654a8d"}]}],"author":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2017-03-10 17:02:22.000000000","tz":0},"committer":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2017-03-10 17:02:22.000000000","tz":0},"subject":"Always update existing matching endpoints","message":"Always update existing matching endpoints\n\nThere is no usecase for having 2 endpoints that have the same Region,\ninterface, service_name and service_type.\n\nThe keystone module should default to update these endpoints if the url\nis different, but the Region, interface, service_name and service_type\nmatch.\n\nThis will make the default behaviour of state \"present\" to match that of\nstate \"update\".\n\nChange-Id: I0ade538e20f2a926b33c1637446c2d4f650cd13d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/9edb941bf7e97486ffadc1ce5e47373e55b9a66c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/9edb941bf7e97486ffadc1ce5e47373e55b9a66c"}]},"branch":"refs/heads/master"},"929292526b32947e7edce8b0ef4116a0eb64af00":{"kind":"REWORK","_number":2,"created":"2017-03-11 14:24:33.000000000","uploader":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"ref":"refs/changes/16/444416/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/16/444416/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/2"}}},"commit":{"parents":[{"commit":"14d2727c0474d794d491ebde2251a7e190654a8d","subject":"Remove quotes when assigning values from an openrc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/14d2727c0474d794d491ebde2251a7e190654a8d"}]}],"author":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2017-03-10 17:02:22.000000000","tz":0},"committer":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2017-03-11 14:24:19.000000000","tz":0},"subject":"Always update existing matching endpoints","message":"Always update existing matching endpoints\n\nThere is no usecase for having 2 endpoints that have the same Region,\ninterface, service_name and service_type.\n\nThe keystone module should default to update these endpoints if the url\nis different, but the Region, interface, service_name and service_type\nmatch.\n\nThis will make the default behaviour of state \"present\" to match that of\nstate \"update\".\n\nChange-Id: I0ade538e20f2a926b33c1637446c2d4f650cd13d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/929292526b32947e7edce8b0ef4116a0eb64af00"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/929292526b32947e7edce8b0ef4116a0eb64af00"}]},"branch":"refs/heads/master"},"fbd7beb86b58cb3d5ad203fa464b73e42eb074c8":{"kind":"REWORK","_number":3,"created":"2017-03-14 10:52:59.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/16/444416/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/16/444416/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/3"}}},"commit":{"parents":[{"commit":"14d2727c0474d794d491ebde2251a7e190654a8d","subject":"Remove quotes when assigning values from an openrc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/14d2727c0474d794d491ebde2251a7e190654a8d"}]}],"author":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2017-03-10 17:02:22.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-14 10:52:57.000000000","tz":0},"subject":"Always update existing matching endpoints","message":"Always update existing matching endpoints\n\nThere is no usecase for having 2 endpoints that have the same Region,\ninterface, service_name and service_type.\n\nThe keystone module should default to update these endpoints if the url\nis different, but the Region, interface, service_name and service_type\nmatch.\n\nThis will make the default behaviour of state \"present\" to match that of\nstate \"update\".\n\nChange-Id: I0ade538e20f2a926b33c1637446c2d4f650cd13d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/fbd7beb86b58cb3d5ad203fa464b73e42eb074c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/fbd7beb86b58cb3d5ad203fa464b73e42eb074c8"}]},"branch":"refs/heads/master"},"5822e29d4128421b6879496605a2987b0e128a8b":{"kind":"REWORK","_number":4,"created":"2017-03-14 11:10:19.000000000","uploader":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"ref":"refs/changes/16/444416/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/16/444416/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/16/444416/4"}}},"commit":{"parents":[{"commit":"14d2727c0474d794d491ebde2251a7e190654a8d","subject":"Remove quotes when assigning values from an openrc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/14d2727c0474d794d491ebde2251a7e190654a8d"}]}],"author":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2017-03-10 17:02:22.000000000","tz":0},"committer":{"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","date":"2017-03-14 11:10:17.000000000","tz":0},"subject":"Always update existing matching endpoints","message":"Always update existing matching endpoints\n\nThere is no usecase for having 2 endpoints that have the same Region,\ninterface, service_name and service_type.\n\nThe keystone module should default to update these endpoints if the url\nis different, but the Region, interface, service_name and service_type\nmatch.\n\nThis will make the default behaviour of state \"present\" to match that of\nstate \"update\".\n\nChange-Id: I0ade538e20f2a926b33c1637446c2d4f650cd13d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/5822e29d4128421b6879496605a2987b0e128a8b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/5822e29d4128421b6879496605a2987b0e128a8b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}