)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~449274","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"packages_to_install_lookup","hashtags":[],"change_id":"I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0","subject":"Add list of packages to install lookup","status":"ABANDONED","created":"2017-03-23 18:40:43.000000000","updated":"2019-04-24 16:23:16.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1d7cec09107a50337982ee8fa51c28b878f36a7b","_number":449274,"virtual_id_number":449274,"owner":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":1,"date":"2017-04-03 10:21:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"},{"date":"2017-04-05 08:31:35.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-04-04 03:09:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-27 11:10:27.000000000","updated_by":{"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"},"reviewer":{"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"},"state":"REVIEWER"},{"updated":"2017-03-28 11:50:46.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2017-04-03 10:21:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-04-04 03:09:44.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"}],"messages":[{"id":"d3014fffb81fd638458142c4e9f0d74ba9261206","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-03-23 18:40:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b9c70ae4a6c68a8b884c855fb16a90541180950","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-23 20:30:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/74/449274/1/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/2384cee//doc/build/html/ : SUCCESS in 1m 36s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/74/449274/1/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/fff36e3/ : SUCCESS in 2m 17s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/74/449274/1/check/gate-openstack-ansible-plugins-ansible-func-centos-7/7147e89/ : SUCCESS in 2m 09s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/74/449274/1/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/8b9fc52/ : SUCCESS in 2m 57s","accounts_in_message":[],"_revision_number":1},{"id":"49f86abb26af1eb9685af08756fe70d4f2364bff","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-03-27 10:33:47.000000000","message":"Patch Set 1: Workflow-1\n\nWIP, cleanup of regexp matching to do.","accounts_in_message":[],"_revision_number":1},{"id":"f80cd2e9047c56c005d0dd380fae65ec916b6231","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-03-27 11:10:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d3bea93c0554416033ebbf2a7b8be51133b1ee98","author":{"_account_id":19339,"name":"Dell EMC Ironic CI","email":"openstack-ironic-ci@dell.com","username":"openstack-ironic-ci"},"date":"2017-03-27 11:10:27.000000000","message":"Patch Set 2:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"6d777ed4f832f8476f4f4f8a57a9fe8d6c18d42d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-27 11:16:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/74/449274/2/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/4080186//doc/build/html/ : SUCCESS in 52s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/74/449274/2/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/37f849b/ : SUCCESS in 1m 37s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/74/449274/2/check/gate-openstack-ansible-plugins-ansible-func-centos-7/bcf18e4/ : SUCCESS in 2m 22s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/74/449274/2/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/44b90a5/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":2},{"id":"0f4d77fe5b1a77b7fb8da79d96ecb45f11304018","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-28 11:50:46.000000000","message":"Patch Set 2: Code-Review-1\n\nIt\u0027d be better if this included tests.","accounts_in_message":[],"_revision_number":2},{"id":"1d1e90b12c187f1a5d1350764952c99fd6349523","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-03-28 18:25:13.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI find myself wondering why this is needed. We have the package sets in the repo-build process which is generated by the `py_packages` plugin. It stands to reason that we\u0027d only need to parse that output which is all contained within the \"role_distro_packages\" key when the py_package plugin is executed, like so [ https://github.com/openstack/openstack-ansible/blob/master/playbooks/repo-build.yml#L57-L63 ].","accounts_in_message":[],"_revision_number":2},{"id":"7d2a1389768f8e66f94b588f4ed19c4a213d66fa","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-03-28 18:27:30.000000000","message":"Patch Set 2:\n\nexample data from the existing plugin http://cdn.pasteraw.com/fpcsnjk58l0rlb4zc0xghn1cnczwn2g","accounts_in_message":[],"_revision_number":2},{"id":"699923bb6c7b9970405940b8b5ad649230a56576","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-03 09:46:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9fce65b697d3862995e1e342f1a839389e8abf1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 09:50:59.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/74/449274/3/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/b9d7592//doc/build/html/ : SUCCESS in 1m 50s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/74/449274/3/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/58cae54/ : SUCCESS in 1m 50s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/74/449274/3/check/gate-openstack-ansible-plugins-ansible-func-centos-7/537b5e9/ : FAILURE in 1m 55s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/74/449274/3/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/a7dfc6d/ : FAILURE in 1m 29s","accounts_in_message":[],"_revision_number":3},{"id":"58237e09e94c23687fa9a04a44ef1b98062bb73d","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-03 09:55:21.000000000","message":"Patch Set 4: Published edit on patch set 3","accounts_in_message":[],"_revision_number":4},{"id":"1a2ded8cc2524fb6a737657545aaaf219631f178","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 10:02:44.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/74/449274/4/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/106b972//doc/build/html/ : SUCCESS in 1m 38s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/74/449274/4/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/88e2c02/ : SUCCESS in 1m 39s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/74/449274/4/check/gate-openstack-ansible-plugins-ansible-func-centos-7/a16a128/ : FAILURE in 1m 59s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/74/449274/4/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/9c3a55b/ : FAILURE in 2m 14s","accounts_in_message":[],"_revision_number":4},{"id":"d60aa4549760231ff4b0379c7bd245f435117c10","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-03 10:04:11.000000000","message":"Patch Set 5: Published edit on patch set 4","accounts_in_message":[],"_revision_number":5},{"id":"664299b1120f99f7359977fb19b2f57a225086ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 10:08:19.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/74/449274/5/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/85572a0//doc/build/html/ : SUCCESS in 2m 10s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/74/449274/5/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/a3f14a1/ : SUCCESS in 1m 20s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/74/449274/5/check/gate-openstack-ansible-plugins-ansible-func-centos-7/2525d46/ : FAILURE in 2m 38s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/74/449274/5/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/9c3d4a8/ : FAILURE in 1m 03s","accounts_in_message":[],"_revision_number":5},{"id":"ed5cb490b94a3ac47b6b05f1dacb9c6b518cf150","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-03 10:12:37.000000000","message":"Patch Set 6: Published edit on patch set 5","accounts_in_message":[],"_revision_number":6},{"id":"9d838c7f3dd1e1a84c665edc8c28877553ebb18b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 10:15:32.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/74/449274/6/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/86a7be7//doc/build/html/ : SUCCESS in 47s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/74/449274/6/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/391eea0/ : SUCCESS in 2m 28s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/74/449274/6/check/gate-openstack-ansible-plugins-ansible-func-centos-7/cd966ea/ : SUCCESS in 1m 48s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/74/449274/6/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/0b915fd/ : SUCCESS in 1m 36s","accounts_in_message":[],"_revision_number":6},{"id":"a1dfaac67f66d031f7293cb06ed80f70c6d19943","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-03 10:17:13.000000000","message":"Patch Set 7: Published edit on patch set 6","accounts_in_message":[],"_revision_number":7},{"id":"4c08f5a39b670508f98cf499a903f2260bfc4e7f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 10:21:30.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/74/449274/7/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/9739965//doc/build/html/ : SUCCESS in 50s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/74/449274/7/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/b44cc42/ : SUCCESS in 50s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/74/449274/7/check/gate-openstack-ansible-plugins-ansible-func-centos-7/da9b12d/ : SUCCESS in 2m 09s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/74/449274/7/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/91d06b7/ : SUCCESS in 1m 38s","accounts_in_message":[],"_revision_number":7},{"id":"f8e75ab008a786fca7d6064bb03aa69ea4b85dff","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-04-04 03:09:44.000000000","message":"Patch Set 7: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"87af45c7a20e5d7ef1c14860ea52a61eeab2303d","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-04-04 03:59:47.000000000","message":"Patch Set 7:\n\nAn example filter would look something like this http://cdn.pasteraw.com/hgtukswxs17hykknf26vy61pyk1xtr3","accounts_in_message":[],"_revision_number":7},{"id":"2386c2c609356ad211d9b7e6f5d9be1d6e1baf63","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-04-04 05:02:51.000000000","message":"Patch Set 7:\n\nExample working filter: [ http://cdn.pasteraw.com/4hwj5sia2886m6vs5fhag4sumulludb ]\n\nExample playbook consuming the filter: [ http://cdn.pasteraw.com/9inyb6a1jwxguyusyuxx9hkhmqyqjxi ]","accounts_in_message":[],"_revision_number":7},{"id":"a2f2c8dc6b79e9e06eb0df9b774b269e97e4d7fa","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-05 08:31:35.000000000","message":"Patch Set 7:\n\n\u003e Example working filter: [ http://cdn.pasteraw.com/4hwj5sia2886m6vs5fhag4sumulludb\n \u003e ]\n \u003e \n \u003e Example playbook consuming the filter: [ http://cdn.pasteraw.com/9inyb6a1jwxguyusyuxx9hkhmqyqjxi\n \u003e ]\n\nI don\u0027t understand why I would chain the lookup and the filter. It would work, like the way I could get a set_fact and implement jinja looping, but I think a lookup should do one thing and doing it well.\n\nI think py_pkgs should be for python packages as distro_pkgs would be for deb/rpm pkgs.\n\nDo you think we should have a reusable python generic directory traversal for those two instead?","accounts_in_message":[],"_revision_number":7},{"id":"491d44ecabc234b1ba6e5d526b345c7ad52fcb4d","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-04-06 01:59:56.000000000","message":"Patch Set 7:\n\n\u003e \u003e Example working filter: [ http://cdn.pasteraw.com/4hwj5sia2886m6vs5fhag4sumulludb\n \u003e \u003e ]\n \u003e \u003e\n \u003e \u003e Example playbook consuming the filter: [ http://cdn.pasteraw.com/9inyb6a1jwxguyusyuxx9hkhmqyqjxi\n \u003e \u003e ]\n \u003e \n \u003e I don\u0027t understand why I would chain the lookup and the filter. It\n \u003e would work, like the way I could get a set_fact and implement jinja\n \u003e looping, but I think a lookup should do one thing and doing it\n \u003e well.\n \u003e \n \u003e I think py_pkgs should be for python packages as distro_pkgs would\n \u003e be for deb/rpm pkgs.\n \u003e \n \u003e Do you think we should have a reusable python generic directory\n \u003e traversal for those two instead?\n\nRunning the existing lookup and using a filter, like the one in my example, is less cycles in terms of loops and and code duplication than the purposed change. If we\u0027re hung up on the name of \"py_pkgs\" then maybe we rename it to \"packages_to_install\" which covers both py and distro.\n\nBecause ansible plugins can\u0027t share code like a common python install-ables I\u0027d not be in favor of creating such a structure where two lookups use the same common lib.\n\nWe already have a plugin that does this work, does it fast, does it well, and is well curated. It was built for this very purpose and it seems crazy to me to do a similar thing in a different way when we already have the ability to achieve all of the above with nothing more than a simple filter.","accounts_in_message":[],"_revision_number":7},{"id":"5cb54f3edbeb96ff0c2bb26a6a1fdb2db03e2254","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-18 12:24:16.000000000","message":"Patch Set 7:\n\nIf you\u0027re not for loading a separate library, and not for this lookup plugin we are in a deadlock.\n\nThe only part I reuse would be https://github.com/openstack/openstack-ansible-plugins/blob/master/lookup/py_pkgs.py#L329-L358, the main call (not used for ansible), and a few vars, so around 30 lines at best on 800+.\n\nBringing more features to our py_pkg lookup is possible, but I think it\u0027s already doing too much. Let\u0027s keep our lookups as simple as possible.","accounts_in_message":[],"_revision_number":7},{"id":"9ce7daa2b0be22f888f8179f3812b427570fdac1","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-04-24 16:23:16.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"6616a61e5d43a5c8babe198810294f99337f946e","revisions":{"8f78b75579d3b6604562893310cee0ef5474d306":{"kind":"REWORK","_number":1,"created":"2017-03-23 18:40:43.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/74/449274/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/74/449274/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/1"}}},"commit":{"parents":[{"commit":"cb7ad3f484cebee17c401ef675229dac13e860d4","subject":"Fix the pep8 fixing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/cb7ad3f484cebee17c401ef675229dac13e860d4"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"subject":"Add list of packages to install lookup","message":"Add list of packages to install lookup\n\nThis new lookup makes easy to check into any folder list\n (for example /etc/ansible/roles), find in these folder the\n variable files for a distribution (given in lookup parameters),\n find the system packages to install for this distribution.\n\n In short with one lookup, you get exactly the list of what you\n will be installing on your host.\n\n You can blacklist variable names (standard matching) and\n package names (regexp matching).\n\nChange-Id: I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/8f78b75579d3b6604562893310cee0ef5474d306"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/8f78b75579d3b6604562893310cee0ef5474d306"}]},"branch":"refs/heads/master"},"1284c1ee9fb24007e4ad2bed2587de2cf271ff0c":{"kind":"REWORK","_number":2,"created":"2017-03-27 11:10:16.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/74/449274/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/74/449274/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/2"}}},"commit":{"parents":[{"commit":"cb7ad3f484cebee17c401ef675229dac13e860d4","subject":"Fix the pep8 fixing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/cb7ad3f484cebee17c401ef675229dac13e860d4"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-27 11:09:16.000000000","tz":0},"subject":"Add list of packages to install lookup","message":"Add list of packages to install lookup\n\nThis new lookup makes easy to check into any folder list\n(for example /etc/ansible/roles), find in these folder the\nvariable files for a distribution (given in lookup parameters),\nfind the system packages to install for this distribution.\n\nIn short with one lookup, you get exactly the list of what you\nwill be installing on your host.\n\nYou can blacklist variable names (standard matching) and\npackage names (regexp matching).\n\nChange-Id: I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/1284c1ee9fb24007e4ad2bed2587de2cf271ff0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/1284c1ee9fb24007e4ad2bed2587de2cf271ff0c"}]},"branch":"refs/heads/master"},"b75bf592a13d4a16756fe3af86df0895a4fdace9":{"kind":"REWORK","_number":3,"created":"2017-04-03 09:46:41.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/74/449274/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/74/449274/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/3"}}},"commit":{"parents":[{"commit":"3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7","subject":"Merge \"Add Packages file parsing lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-04-03 09:45:39.000000000","tz":0},"subject":"[WIP] Add list of packages to install lookup","message":"[WIP] Add list of packages to install lookup\n\nThis new lookup makes easy to check into any folder list\n(for example /etc/ansible/roles), find in these folder the\nvariable files for a distribution (given in lookup parameters),\nfind the system packages to install for this distribution.\n\nIn short with one lookup, you get exactly the list of what you\nwill be installing on your host.\n\nYou can blacklist variable names (standard matching) and\npackage names (regexp matching).\n\nThis lookup could technically be replaced by jinja on the\npy_pkgs output, but:\n- We would then need to build the pkg_blacklist into the\n  jinja everytime\n- We would need to build the \"convenience mapping\" into\n  the jinja everytime\nThis makes it simple and re-usable.\n\nChange-Id: I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/b75bf592a13d4a16756fe3af86df0895a4fdace9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/b75bf592a13d4a16756fe3af86df0895a4fdace9"}]},"branch":"refs/heads/master"},"4e78ac317955238293f107fe0f5ed96f6a405bc1":{"kind":"REWORK","_number":4,"created":"2017-04-03 09:55:21.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/74/449274/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/74/449274/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/4"}}},"commit":{"parents":[{"commit":"3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7","subject":"Merge \"Add Packages file parsing lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-04-03 09:55:15.000000000","tz":0},"subject":"[WIP] Add list of packages to install lookup","message":"[WIP] Add list of packages to install lookup\n\nThis new lookup makes easy to check into any folder list\n(for example /etc/ansible/roles), find in these folder the\nvariable files for a distribution (given in lookup parameters),\nfind the system packages to install for this distribution.\n\nIn short with one lookup, you get exactly the list of what you\nwill be installing on your host.\n\nYou can blacklist variable names (standard matching) and\npackage names (regexp matching).\n\nThis lookup could technically be replaced by jinja on the\npy_pkgs output, but:\n- We would then need to build the pkg_blacklist into the\n  jinja everytime\n- We would need to build the \"convenience mapping\" into\n  the jinja everytime\nThis makes it simple and re-usable.\n\nChange-Id: I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/4e78ac317955238293f107fe0f5ed96f6a405bc1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/4e78ac317955238293f107fe0f5ed96f6a405bc1"}]},"branch":"refs/heads/master"},"e2067647fc20dcc5080abebf69c57273ed80c72e":{"kind":"REWORK","_number":5,"created":"2017-04-03 10:04:11.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/74/449274/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/74/449274/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/5"}}},"commit":{"parents":[{"commit":"3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7","subject":"Merge \"Add Packages file parsing lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-04-03 10:04:07.000000000","tz":0},"subject":"[WIP] Add list of packages to install lookup","message":"[WIP] Add list of packages to install lookup\n\nThis new lookup makes easy to check into any folder list\n(for example /etc/ansible/roles), find in these folder the\nvariable files for a distribution (given in lookup parameters),\nfind the system packages to install for this distribution.\n\nIn short with one lookup, you get exactly the list of what you\nwill be installing on your host.\n\nYou can blacklist variable names (standard matching) and\npackage names (regexp matching).\n\nThis lookup could technically be replaced by jinja on the\npy_pkgs output, but:\n- We would then need to build the pkg_blacklist into the\n  jinja everytime\n- We would need to build the \"convenience mapping\" into\n  the jinja everytime\nThis makes it simple and re-usable.\n\nChange-Id: I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/e2067647fc20dcc5080abebf69c57273ed80c72e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/e2067647fc20dcc5080abebf69c57273ed80c72e"}]},"branch":"refs/heads/master"},"222e03cd2bf713faade25d253590915c58e22152":{"kind":"REWORK","_number":6,"created":"2017-04-03 10:12:37.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/74/449274/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/74/449274/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/6"}}},"commit":{"parents":[{"commit":"3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7","subject":"Merge \"Add Packages file parsing lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-04-03 10:12:35.000000000","tz":0},"subject":"[WIP] Add list of packages to install lookup","message":"[WIP] Add list of packages to install lookup\n\nThis new lookup makes easy to check into any folder list\n(for example /etc/ansible/roles), find in these folder the\nvariable files for a distribution (given in lookup parameters),\nfind the system packages to install for this distribution.\n\nIn short with one lookup, you get exactly the list of what you\nwill be installing on your host.\n\nYou can blacklist variable names (standard matching) and\npackage names (regexp matching).\n\nThis lookup could technically be replaced by jinja on the\npy_pkgs output, but:\n- We would then need to build the pkg_blacklist into the\n  jinja everytime\n- We would need to build the \"convenience mapping\" into\n  the jinja everytime\nThis makes it simple and re-usable.\n\nChange-Id: I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/222e03cd2bf713faade25d253590915c58e22152"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/222e03cd2bf713faade25d253590915c58e22152"}]},"branch":"refs/heads/master"},"6616a61e5d43a5c8babe198810294f99337f946e":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2017-04-03 10:17:13.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/74/449274/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/74/449274/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/74/449274/7"}}},"commit":{"parents":[{"commit":"3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7","subject":"Merge \"Add Packages file parsing lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/3d2e23bb7e1d6775789d7f65ce8a878a7ee1d3c7"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-03-23 18:36:55.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe.evrard@rackspace.co.uk","date":"2017-04-03 10:17:11.000000000","tz":0},"subject":"Add list of packages to install lookup","message":"Add list of packages to install lookup\n\nThis new lookup makes easy to check into any folder list\n(for example /etc/ansible/roles), find in these folder the\nvariable files for a distribution (given in lookup parameters),\nfind the system packages to install for this distribution.\n\nIn short with one lookup, you get exactly the list of what you\nwill be installing on your host.\n\nYou can blacklist variable names (standard matching) and\npackage names (regexp matching).\n\nThis lookup could technically be replaced by jinja on the\npy_pkgs output, but:\n- We would then need to build the pkg_blacklist into the\n  jinja everytime\n- We would need to build the \"convenience mapping\" into\n  the jinja everytime\nThis makes it simple and re-usable.\n\nChange-Id: I74d498fbe9e61df854aa766b6e3dc84d82f2c6c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/6616a61e5d43a5c8babe198810294f99337f946e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/6616a61e5d43a5c8babe198810294f99337f946e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}