)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~471472","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~Ic3b8bf9a9aaf8738c49490e22fec2fc0b5140ac0","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"lxc-transport-clear-env","hashtags":[],"change_id":"Ic3b8bf9a9aaf8738c49490e22fec2fc0b5140ac0","subject":"connection: ssh: Clear environment when connecting to LXC containers","status":"MERGED","created":"2017-06-06 20:09:54.000000000","updated":"2017-06-07 10:36:08.000000000","submitted":"2017-06-07 09:53:26.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"77f91d1b00dc30d0a9b0f4d560a8ae611a4a82cd","_number":471472,"virtual_id_number":471472,"owner":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2017-06-07 09:53:26.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2017-06-07 08:39:50.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-06-07 09:49:06.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-06-07 09:49:06.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-07 08:39:50.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2017-06-07 09:49:06.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2017-06-07 09:53:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0615a04e0e3ad6ff27eed670015cc3fb0e34d8ab","author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"date":"2017-06-06 20:09:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b75f77b546959c3f7613ae9e223b9984018b73c0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-06 20:32:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/72/471472/1/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/5d919c7//doc/build/html/ : SUCCESS in 1m 17s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/72/471472/1/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/0747f6b/ : SUCCESS in 1m 32s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/72/471472/1/check/gate-openstack-ansible-plugins-ansible-func-centos-7/4d345e5/ : SUCCESS in 2m 14s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/72/471472/1/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/aa44909/ : SUCCESS in 2m 30s","accounts_in_message":[],"_revision_number":1},{"id":"b13911c78441b6da4489ae0ce6582f0aaeb8f696","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-06-07 08:39:50.000000000","message":"Patch Set 1: Code-Review+2\n\nExcellent, thanks for ferreting this out!","accounts_in_message":[],"_revision_number":1},{"id":"3125a7f0f1a157328424bf1712ca557b0b3c4920","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-06-07 09:49:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"953ea8802fba41b3a55242e1d43d07bb70d0b047","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-07 09:49:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3d2c4c432c13413289898b96ab85f130f2b27b31","date":"2017-06-07 09:53:26.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"1874a00ebf9ba46d07430fdcf72114b4233d7487","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-07 09:53:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/72/471472/1/gate/gate-openstack-ansible-plugins-docs-ubuntu-xenial/b8370cd//doc/build/html/ : SUCCESS in 1m 14s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/72/471472/1/gate/gate-openstack-ansible-plugins-linters-ubuntu-xenial/ee97c6a/ : SUCCESS in 1m 42s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/72/471472/1/gate/gate-openstack-ansible-plugins-ansible-func-centos-7/71c0ca2/ : SUCCESS in 2m 34s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/72/471472/1/gate/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/1216f2e/ : SUCCESS in 2m 37s","accounts_in_message":[],"_revision_number":1},{"id":"2db743bb1e19f1f04fd81bb62ed1e8c310866072","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-06-07 10:36:08.000000000","message":"Patch Set 1: Reverted\n\nThis patchset was reverted in change: I5981e72d8153e6ea490446ac9e2e8e31959d9f72","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c2c71bc2b078ad6b16774e76b735dd8251565633","revisions":{"c2c71bc2b078ad6b16774e76b735dd8251565633":{"kind":"REWORK","_number":1,"created":"2017-06-06 20:09:54.000000000","uploader":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"ref":"refs/changes/72/471472/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/72/471472/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/72/471472/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/72/471472/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/72/471472/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/72/471472/1"}}},"commit":{"parents":[{"commit":"36ff6fb6dacba1ee9236196c85081479880d0480","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/36ff6fb6dacba1ee9236196c85081479880d0480"}]}],"author":{"name":"Markos Chandras","email":"mchandras@suse.de","date":"2017-06-06 20:00:12.000000000","tz":60},"committer":{"name":"Markos Chandras","email":"mchandras@suse.de","date":"2017-06-06 20:09:32.000000000","tz":60},"subject":"connection: ssh: Clear environment when connecting to LXC containers","message":"connection: ssh: Clear environment when connecting to LXC containers\n\nWe should clear the environment before connecting to an LXC container to\navoid inheriting host variables that may break container services like\nthe following failure in rabbitmqctl:\n\nTASK [Get status of rabbitmq] *************************************************************************************************************************************************************************************\nfatal: [container1]: FAILED! \u003d\u003e {\"changed\": true, \"cmd\": [\"rabbitmqctl\", \"status\"], \"delta\": \"0:00:00.705116\", \"end\": \"2017-06-06 20:03:13.771796\", \"failed\": true, \"rc\": 69, \"start\": \"2017-06-06 20:03:13.066680\", \"stderr\": \"Error: unable to connect to node \u0027rabbit@vagrant-openSUSE-Leap\u0027: nodedown\\n\\nDIAGNOSTICS\\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\\n\\nattempted to contact: [\u0027rabbit@vagrant-openSUSE-Leap\u0027]\\n\\nrabbit@vagrant-openSUSE-Leap:\\n  * unable to connect to epmd (port 4369) on vagrant-openSUSE-Leap: address (cannot connect to host/port)\\n\\n\\ncurrent node details:\\n- node name: \u0027rabbitmq-cli-82@localhost\u0027\\n- home dir: /var/lib/rabbitmq\\n- cookie hash: NqWRA5RzO5daz4Jb5LJsXg\u003d\u003d\", \"stderr_lines\": [\"Error: unable to connect to node \u0027rabbit@vagrant-openSUSE-Leap\u0027: nodedown\", \"\", \"DIAGNOSTICS\", \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\", \"\", \"attempted to contact: [\u0027rabbit@vagrant-openSUSE-Leap\u0027]\", \"\", \"rabbit@vagrant-openSUSE-Leap:\", \"  * unable to connect to epmd (port 4369) on vagrant-openSUSE-Leap: address (cannot connect to host/port)\", \"\", \"\", \"current node details:\", \"- node name: \u0027rabbitmq-cli-82@localhost\u0027\", \"- home dir: /var/lib/rabbitmq\", \"- cookie hash: NqWRA5RzO5daz4Jb5LJsXg\u003d\u003d\"], \"stdout\": \"Status of node \u0027rabbit@vagrant-openSUSE-Leap\u0027 ...\", \"stdout_lines\": [\"Status of node \u0027rabbit@vagrant-openSUSE-Leap\u0027 ...\"]}\n\tto retry, use: --limit @/vagrant/tests/test-rabbitmq-server-functional.retry\n\nThe reason for this failure is that the HOSTNAME variable is being\ninherited by the host (vagrant-openSUSE-Leap) and the rabbitmqctl\ncommand uses this variable to guess the host it should try to\nconnect to.\n\nThis is similar to what the upstream lxc connection module is doing.\n\nLink: https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/lxc.py#L121\nChange-Id: Ic3b8bf9a9aaf8738c49490e22fec2fc0b5140ac0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/c2c71bc2b078ad6b16774e76b735dd8251565633"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/c2c71bc2b078ad6b16774e76b735dd8251565633"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}