)]}'
{"strategy/linear.py":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"c271a1f69ebc44b3ef7f0903d01eee0097246722","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        _play_context \u003d copy.deepcopy(play_context)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        groups \u003d self._inventory.get_group_dict()"},{"line_number":120,"context_line":"        physical_hosts \u003d groups.get(\u0027hosts\u0027, groups.get(\u0027all\u0027, {}))"},{"line_number":121,"context_line":"        physical_host_addrs \u003d {}"},{"line_number":122,"context_line":"        for physical_host in physical_hosts:"},{"line_number":123,"context_line":"            physical_host_vars \u003d self._inventory.get_host_variables(physical_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_56a36901","line":120,"range":{"start_line":120,"start_character":36,"end_line":120,"end_character":43},"updated":"2017-06-20 01:06:08.000000000","message":"Pretty standard ansible group but I still hate to hardcode a non-builtin group name. I guess the other alternative would be to loop over \"all\" which of course will always exist. Not sure if there\u0027s another cleaner way to filter this down to only the physical hosts we care about.","commit_id":"8b1a07d2d60cb5e0a48fc152f1eee8a3bc051902"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"1b7c3bf05f31a4c09d50646afcbaff1c5614d72b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        _play_context \u003d copy.deepcopy(play_context)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        groups \u003d self._inventory.get_group_dict()"},{"line_number":120,"context_line":"        physical_hosts \u003d groups.get(\u0027hosts\u0027, groups.get(\u0027all\u0027, {}))"},{"line_number":121,"context_line":"        physical_host_addrs \u003d {}"},{"line_number":122,"context_line":"        for physical_host in physical_hosts:"},{"line_number":123,"context_line":"            physical_host_vars \u003d self._inventory.get_host_variables(physical_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_962c614b","line":120,"range":{"start_line":120,"start_character":36,"end_line":120,"end_character":43},"in_reply_to":"7f231b9d_56a36901","updated":"2017-06-20 01:17:32.000000000","message":"Yeah, that part\u0027s pretty terrible.\n\nThere\u0027s the \u0027lxc_hosts\u0027 group, but that would still need to be hardcoded here, would still be an integrated-repo specific group, and, to make it even more complicated, is overridable by deployers.\n\nThis plugin still gets used on all individual roles\u0027 gating where \u0027all\u0027 might be the only group. This will fallback to \u0027all\u0027 if the \u0027hosts\u0027 group doesn\u0027t exist, and if some reason weird reason that doesn\u0027t exist, just ignores groups completely and should end up trying to use whatever hostname was set as \u0027physical_host\u0027.","commit_id":"8b1a07d2d60cb5e0a48fc152f1eee8a3bc051902"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"7489190fa977acddfd7a0417edddfe3163814381","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        _play_context \u003d copy.deepcopy(play_context)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        groups \u003d self._inventory.get_group_dict()"},{"line_number":120,"context_line":"        physical_hosts \u003d groups.get(\u0027hosts\u0027, groups.get(\u0027all\u0027, {}))"},{"line_number":121,"context_line":"        physical_host_addrs \u003d {}"},{"line_number":122,"context_line":"        for physical_host in physical_hosts:"},{"line_number":123,"context_line":"            physical_host_vars \u003d self._inventory.get_host_variables(physical_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_b6a75da8","line":120,"range":{"start_line":120,"start_character":36,"end_line":120,"end_character":43},"in_reply_to":"7f231b9d_962c614b","updated":"2017-06-20 01:24:05.000000000","message":"Ah the \"all\" fallback if \"hosts\" is not defined.. good point, I missed that the first time. Seems reasonable enough, since \"all\" should always exist if ansible\u0027s reserved groups are working correctly. :)","commit_id":"8b1a07d2d60cb5e0a48fc152f1eee8a3bc051902"}]}