)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~477173","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~Icc386307a88c2a9ed2a3e7957b5f12a54c8ce8f4","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"bp/goal-python35","hashtags":[],"change_id":"Icc386307a88c2a9ed2a3e7957b5f12a54c8ce8f4","subject":"Replace use of basestring","status":"MERGED","created":"2017-06-24 21:44:43.000000000","updated":"2017-06-28 16:51:39.000000000","submitted":"2017-06-28 16:51:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0ba768486a6805aa0fd5842805396aa0de409aae","_number":477173,"virtual_id_number":477173,"owner":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-06-28 16:51:39.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":2,"date":"2017-06-28 16:48:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"value":2,"date":"2017-06-28 16:48:06.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":1,"date":"2017-06-28 16:48:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-25 15:15:09.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2017-06-28 16:48:06.000000000","updated_by":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"reviewer":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"state":"REVIEWER"},{"updated":"2017-06-28 16:48:29.000000000","updated_by":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"reviewer":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"state":"REVIEWER"},{"updated":"2017-06-28 16:51:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"69d7cff8f16d78c4eb66ad1b9410e05283ca23f8","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2017-06-24 21:44:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0cb4abd6091dac07d6700771c7406e6ff5dd0cd5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-24 21:48:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/73/477173/1/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/2021bcd//doc/build/html/ : SUCCESS in 1m 07s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/73/477173/1/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/c3f53de/ : SUCCESS in 41s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/73/477173/1/check/gate-openstack-ansible-plugins-ansible-func-centos-7/92c065e/ : SUCCESS in 3m 13s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/73/477173/1/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/5b08127/ : SUCCESS in 1m 39s","accounts_in_message":[],"_revision_number":1},{"id":"c564c90821dff51252832a4d7dc2f9444467fba0","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2017-06-25 06:39:17.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"041fa87482ea595923f011a050cca9aad3b3c659","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-06-25 15:15:09.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks fine to me, waiting on -W from Jimmy.","accounts_in_message":[],"_revision_number":1},{"id":"1fa90a50aade54d5b616e8aad89b5bec25835db7","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2017-06-26 15:35:22.000000000","message":"Patch Set 1: -Workflow\n\nI think this is ok.\nThere\u0027s still something else in this plugin that needs to be fixed for python 3 though.\n\nhttp://logs.openstack.org/94/471094/7/check/gate-openstack-ansible-openstack-ansible-aio-ubuntu-xenial/b04b2e0/console.html#_2017-06-24_22_03_41_058678","accounts_in_message":[],"_revision_number":1},{"id":"4983002c7f2cd33d9fc4b669e2d9a9b1e34c2c4c","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2017-06-28 16:05:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e87385a364d49147591f0b265a30ded25faa8e37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-28 16:08:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/73/477173/2/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/f4dbeea//doc/build/html/ : SUCCESS in 2m 06s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/73/477173/2/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/afc933a/ : SUCCESS in 37s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/73/477173/2/check/gate-openstack-ansible-plugins-ansible-func-centos-7/c8134dd/ : SUCCESS in 3m 24s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/73/477173/2/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/89697f3/ : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":2},{"id":"73fdc08026f74eb8190ea6f05963b7392333a275","author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"date":"2017-06-28 16:14:36.000000000","message":"Patch Set 2: Code-Review+1\n\ncode looks ok, are we waiting for that warning to be addressed to implement?","accounts_in_message":[],"_revision_number":2},{"id":"7781613bba3d5d0833b4b2fd2a06b8ed797bc59b","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2017-06-28 16:47:28.000000000","message":"Patch Set 2:\n\nThis is good to go now. I moved the fix for that error off into https://review.openstack.org/#/c/478544/ and the latest integrated test that includes that looks have made it past that point now.\n\nhttp://logs.openstack.org/94/471094/8/check/gate-openstack-ansible-openstack-ansible-aio-ubuntu-xenial/142a0d8/","accounts_in_message":[],"_revision_number":2},{"id":"0d2655ec94e33ceebbbf028b519a48bb9d861abb","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2017-06-28 16:48:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"21c46b3419a87a573f43dcaeefca7fa8925f8f4a","author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"date":"2017-06-28 16:48:29.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks Jimmy","accounts_in_message":[],"_revision_number":2},{"id":"08288e469784e7377f8ee9d759b9c70405f0bdd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-28 16:48:51.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7af66e5810ca720a37ea4861d9de68142c826d7d","date":"2017-06-28 16:51:39.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"c72baeecf944021232d6f192c2b88918272376ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-28 16:51:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/73/477173/2/gate/gate-openstack-ansible-plugins-docs-ubuntu-xenial/c08ad39//doc/build/html/ : SUCCESS in 1m 24s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/73/477173/2/gate/gate-openstack-ansible-plugins-linters-ubuntu-xenial/0574e92/ : SUCCESS in 2m 42s\n- gate-openstack-ansible-plugins-ansible-func-centos-7 http://logs.openstack.org/73/477173/2/gate/gate-openstack-ansible-plugins-ansible-func-centos-7/cd6f23c/ : SUCCESS in 2m 03s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/73/477173/2/gate/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/48bb07f/ : SUCCESS in 1m 57s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"60363db63b6ff46d669d56ae8165333a98aaf378","revisions":{"019a5ebaf72ea130dc86d43513a1cebf8c8a7f49":{"kind":"REWORK","_number":1,"created":"2017-06-24 21:44:43.000000000","uploader":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"ref":"refs/changes/73/477173/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/73/477173/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/1"}}},"commit":{"parents":[{"commit":"30af08208de4ac3488fc8b8d018f919b3ea12162","subject":"Merge \"Handle \u0027dict\u0027 type as input of \u0027content\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/30af08208de4ac3488fc8b8d018f919b3ea12162"}]}],"author":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2017-06-24 21:40:06.000000000","tz":-420},"committer":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2017-06-24 21:41:02.000000000","tz":-420},"subject":"Replace use of basestring","message":"Replace use of basestring\n\nbasestring no longer exists in Python 3, str can be used in its place.\n\nChange-Id: Icc386307a88c2a9ed2a3e7957b5f12a54c8ce8f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/019a5ebaf72ea130dc86d43513a1cebf8c8a7f49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/019a5ebaf72ea130dc86d43513a1cebf8c8a7f49"}]},"branch":"refs/heads/master"},"60363db63b6ff46d669d56ae8165333a98aaf378":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2017-06-28 16:05:12.000000000","uploader":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"ref":"refs/changes/73/477173/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/73/477173/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/73/477173/2"}}},"commit":{"parents":[{"commit":"d8cd4901ba1d9b4d27c9edad61830282a0495479","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/d8cd4901ba1d9b4d27c9edad61830282a0495479"}]}],"author":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2017-06-24 21:40:06.000000000","tz":-420},"committer":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2017-06-28 16:03:55.000000000","tz":-420},"subject":"Replace use of basestring","message":"Replace use of basestring\n\nbasestring no longer exists in Python 3, str can be used in its place.\n\nChange-Id: Icc386307a88c2a9ed2a3e7957b5f12a54c8ce8f4\nImplements: blueprint goal-python35\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/60363db63b6ff46d669d56ae8165333a98aaf378"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/60363db63b6ff46d669d56ae8165333a98aaf378"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
