)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~486754","triplet_id":"openstack%2Fopenstack-ansible-plugins~stable%2Fnewton~I5927cdcd06b4398c76b4e4d33f7a21335a6abbf2","project":"openstack/openstack-ansible-plugins","branch":"stable/newton","topic":"bug/1705469","hashtags":[],"change_id":"I5927cdcd06b4398c76b4e4d33f7a21335a6abbf2","subject":"Do not convert integers to strings","status":"MERGED","created":"2017-07-24 21:11:34.000000000","updated":"2017-07-24 22:00:06.000000000","submitted":"2017-07-24 22:00:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"36fdcb7dee0ded27bce09ce0e991952e40e2263a","_number":486754,"virtual_id_number":486754,"owner":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-07-24 22:00:06.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-24 21:57:31.000000000","_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":2,"date":"2017-07-24 21:13:38.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-07-24 21:57:31.000000000","_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-24 21:13:38.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2017-07-24 21:57:31.000000000","updated_by":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"reviewer":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"state":"REVIEWER"},{"updated":"2017-07-24 22:00:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fe77251edc8cbaea4570f2a2666ac8efcaf4cbc6","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2017-07-24 21:11:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"780a558e286455ac9c48f1206488d4c47d0c0875","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-07-24 21:13:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"062cd411dc0e1d0d045bf9bf66c37652b99c43fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-24 21:13:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/54/486754/1/check/gate-openstack-ansible-plugins-docs-ubuntu-xenial/d8ea0ec//doc/build/html/ : SUCCESS in 1m 05s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/54/486754/1/check/gate-openstack-ansible-plugins-linters-ubuntu-xenial/605d0f7/ : SUCCESS in 1m 07s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-trusty http://logs.openstack.org/54/486754/1/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-trusty/20bfc10/ : SUCCESS in 1m 28s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/54/486754/1/check/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/7a3b685/ : SUCCESS in 1m 53s","accounts_in_message":[],"_revision_number":1},{"id":"982eb7037109e106b80ae04969cd8ce335da401b","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2017-07-24 21:57:31.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0a93fff8c5ecae5aab7e219d804a876d16b599bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-24 21:57:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"73f5b154961a0b016b3ef3d897d85249e96dfea9","date":"2017-07-24 22:00:06.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"0f26c28aded296aa700d930a9a61be9252022283","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-24 22:00:06.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-plugins-docs-ubuntu-xenial http://docs-draft.openstack.org/54/486754/1/gate/gate-openstack-ansible-plugins-docs-ubuntu-xenial/03054d7//doc/build/html/ : SUCCESS in 1m 18s\n- gate-openstack-ansible-plugins-linters-ubuntu-xenial http://logs.openstack.org/54/486754/1/gate/gate-openstack-ansible-plugins-linters-ubuntu-xenial/a3aef22/ : SUCCESS in 1m 10s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-trusty http://logs.openstack.org/54/486754/1/gate/gate-openstack-ansible-plugins-ansible-func-ubuntu-trusty/f413eed/ : SUCCESS in 1m 34s\n- gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial http://logs.openstack.org/54/486754/1/gate/gate-openstack-ansible-plugins-ansible-func-ubuntu-xenial/1963598/ : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"782460644902f391cadb83e61c882956c0e569ee","revisions":{"782460644902f391cadb83e61c882956c0e569ee":{"kind":"REWORK","_number":1,"created":"2017-07-24 21:11:34.000000000","uploader":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"ref":"refs/changes/54/486754/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/54/486754/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/54/486754/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/54/486754/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/54/486754/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/54/486754/1"}}},"commit":{"parents":[{"commit":"64353d8ff0d0c2d803aba1f2af607e7ffb13c662","subject":"Fix config template\u0027s consumption of unicode dictionaries","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/64353d8ff0d0c2d803aba1f2af607e7ffb13c662"}]}],"author":{"name":"Matthew Thode","email":"mthode@mthode.org","date":"2017-07-24 21:05:12.000000000","tz":-300},"committer":{"name":"Matthew Thode","email":"mthode@mthode.org","date":"2017-07-24 21:05:12.000000000","tz":-300},"subject":"Do not convert integers to strings","message":"Do not convert integers to strings\n\nWhen overrides are used in config templates the previous behavior was to\nnot convert the integers to strings.  The previous change,\nI8986688efbd7e05ba17c3d61ee032dcc29d3b05d changed this behavior.  The\nreason why try-except was used instead of isnumeric is because isnumeric\nonly accepts positive numbers, while we could strip signs off the ends,\nthat could alter things past what we want.\n\nCloses-Bug: #1705469\n\nChange-Id: I5927cdcd06b4398c76b4e4d33f7a21335a6abbf2\nSigned-off-by: Matthew Thode \u003cmthode@mthode.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/782460644902f391cadb83e61c882956c0e569ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/782460644902f391cadb83e61c882956c0e569ee"}]},"branch":"refs/heads/stable/newton"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
