)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~517315","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~I6e57b64c767bc0c761d61f5f5b07da4f85f1ad08","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"517315","hashtags":[],"change_id":"I6e57b64c767bc0c761d61f5f5b07da4f85f1ad08","subject":"Make possible to use ansible 2.4","status":"MERGED","created":"2017-11-02 13:54:58.000000000","updated":"2018-01-12 10:45:54.000000000","submitted":"2017-11-02 15:40:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"517315-1509637240222-57388c2f","meta_rev_id":"c761c93e913656948927ed3040397ea299f76866","_number":517315,"virtual_id_number":517315,"owner":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"date":"2017-11-02 15:01:45.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":2,"date":"2017-11-02 15:40:40.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"all":[{"value":2,"date":"2017-11-02 15:14:51.000000000","_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":1,"date":"2017-11-02 14:03:30.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":2,"date":"2017-11-02 15:20:29.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"all":[{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":1,"date":"2017-11-02 15:20:29.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-02 14:03:30.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2017-11-02 15:14:51.000000000","updated_by":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"reviewer":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"state":"REVIEWER"},{"updated":"2017-11-02 15:20:29.000000000","updated_by":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"reviewer":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"state":"REVIEWER"},{"updated":"2017-11-02 15:40:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ddea667300fff03956cc21f91d0546c33342e0e1","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-11-02 13:54:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99d9fd36fab7ad9d78203e1bde2903b60f59b638","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-11-02 13:57:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"52713396a4efae81324eed01a0ce37012fc621b0","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-11-02 13:59:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1428dd802325b2f72084ac79f3daa20a0384e318","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2017-11-02 14:03:30.000000000","message":"Patch Set 3: Code-Review+1\n\nSeems fine to me -- my only concern of course is whether or not the vars plugin is still loaded correctly in \u003c2.4. I guess an easy way to test that would be a depends-on patch in the integrated repo and see if it passes?","accounts_in_message":[],"_revision_number":3},{"id":"2795575c1b78a19914f420302b0fa8965d94fdee","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 14:31:54.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/15/517315/3/check/build-openstack-sphinx-docs/019115a/html/ : SUCCESS in 2m 19s\n- openstack-ansible-linters http://logs.openstack.org/15/517315/3/check/openstack-ansible-linters/2efb6e1/ : SUCCESS in 4m 08s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/15/517315/3/check/openstack-ansible-functional-centos-7/f43e064/ : SUCCESS in 18m 04s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/15/517315/3/check/openstack-ansible-functional-opensuse-423/674e769/ : SUCCESS in 14m 22s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/15/517315/3/check/openstack-ansible-functional-ubuntu-xenial/849f233/ : SUCCESS in 12m 01s\n- openstack-ansible-python3-ubuntu-xenial-nv http://logs.openstack.org/15/517315/3/check/openstack-ansible-python3-ubuntu-xenial-nv/f47e891/ : FAILURE in 13m 13s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"3d328e1bd2aba9811fd9078a00e4b70e19cb3430","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-11-02 15:01:45.000000000","message":"Patch Set 3:\n\n\u003e Seems fine to me -- my only concern of course is whether or not the\n \u003e vars plugin is still loaded correctly in \u003c2.4. I guess an easy way\n \u003e to test that would be a depends-on patch in the integrated repo and\n \u003e see if it passes?\n\nIt should. I will do a PoC for you.","accounts_in_message":[],"_revision_number":3},{"id":"7661ea9957f028c76da58103b91ea1f10bf2ac7f","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2017-11-02 15:14:51.000000000","message":"Patch Set 3: Code-Review+2\n\nLooks good, tested locally.\n\nLoaded and made use of my overridden group_var in 2.3.2\n\n 11073 1509635656.47289: Loading VarsModule \u0027override_folder\u0027 from /etc/ansible/roles/plugins/vars_plugins/override_folder.py\n\nSkipped with warning in 2.4\n\n [WARNING]: Skipping plugin (/etc/ansible/roles/plugins/vars_plugins/override_folder.py) as it seems to be invalid: module \u0027ansible.plugins.vars.override_folder\u0027 has no attribute \u0027VarsModule\u0027","accounts_in_message":[],"_revision_number":3},{"id":"4107f159b0f699fbaa65c728c5a3efa7f29019ce","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2017-11-02 15:20:29.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"12b140d760518f8ae2f84e22204afb6359e4c1ff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 15:20:45.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"7f9b25fa5229eee9b7c08af09a8d8b663d6f98f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 15:40:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"94da88f6b59a10368dd9b791464b407ea2a88e61","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 15:40:40.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/15/517315/3/gate/build-openstack-sphinx-docs/a796dcf/html/ : SUCCESS in 3m 09s\n- openstack-ansible-linters http://logs.openstack.org/15/517315/3/gate/openstack-ansible-linters/3bd1255/ : SUCCESS in 3m 48s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/15/517315/3/gate/openstack-ansible-functional-centos-7/dede2cc/ : SUCCESS in 18m 23s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/15/517315/3/gate/openstack-ansible-functional-opensuse-423/f3986ba/ : SUCCESS in 11m 37s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/15/517315/3/gate/openstack-ansible-functional-ubuntu-xenial/49a3271/ : SUCCESS in 11m 32s","accounts_in_message":[],"_revision_number":3},{"id":"cc14bdaba4169bd82adbc7b40c067ba6d59a008c","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2018-01-12 10:45:54.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit da1a2dc59b7dbfa96c5213c29097172a48c5b6a3","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ad91b1a12bf7b4d92af84fa3f393ae6f03ca8834","revisions":{"0fba39c922062f9ce58c64e001457515f1b72ea2":{"kind":"REWORK","_number":1,"created":"2017-11-02 13:54:58.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/15/517315/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/15/517315/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/1"}}},"commit":{"parents":[{"commit":"6a64c8e7dbc1d3a6cbb444dbcdefbeb4632c01fa","subject":"Remove unified queue from gate pipeline","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/6a64c8e7dbc1d3a6cbb444dbcdefbeb4632c01fa"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe@evrard.me","date":"2017-11-02 13:51:30.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe@evrard.me","date":"2017-11-02 13:54:50.000000000","tz":0},"subject":"Make possible to use ansible 2.4","message":"Make possible to use ansible 2.4\n\nAnsible 2.4 has changed the interface for var plugins.\nOur vars plugin shouldn\u0027t be used in ansible 2.4, because the\nfeatures we were looking for are now standard.\n\nHowever the plugin is still shipped. So we need to ensure\nthis vars plugin doesn\u0027t get loaded on ansible 2.4.\n\nAnsible will not load a vars plugin in its plugin location\nif no VarsModule is defined. This commit abuses this\nmechanism to conditionally load the vars module depending on\nthe version, at the expense of throwing a warning in\nAnsible 2.4.\n\nChange-Id: I6e57b64c767bc0c761d61f5f5b07da4f85f1ad08\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/0fba39c922062f9ce58c64e001457515f1b72ea2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/0fba39c922062f9ce58c64e001457515f1b72ea2"}]},"branch":"refs/heads/master"},"5a03496a31b462f9138123d426686a647da29b0f":{"kind":"REWORK","_number":2,"created":"2017-11-02 13:57:59.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/15/517315/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/15/517315/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/2"}}},"commit":{"parents":[{"commit":"6a64c8e7dbc1d3a6cbb444dbcdefbeb4632c01fa","subject":"Remove unified queue from gate pipeline","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/6a64c8e7dbc1d3a6cbb444dbcdefbeb4632c01fa"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe@evrard.me","date":"2017-11-02 13:51:30.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe@evrard.me","date":"2017-11-02 13:57:55.000000000","tz":0},"subject":"Make possible to use ansible 2.4","message":"Make possible to use ansible 2.4\n\nAnsible 2.4 has changed the interface for var plugins.\nOur vars plugin shouldn\u0027t be used in ansible 2.4, because the\nfeatures we were looking for are now standard.\n\nHowever the plugin is still shipped. So we need to ensure\nthis vars plugin doesn\u0027t get loaded on ansible 2.4.\n\nAnsible will not load a vars plugin in its plugin location\nif no VarsModule is defined. This commit abuses this\nmechanism to conditionally load the vars module depending on\nthe version, at the expense of throwing a warning in\nAnsible 2.4.\n\nChange-Id: I6e57b64c767bc0c761d61f5f5b07da4f85f1ad08\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/5a03496a31b462f9138123d426686a647da29b0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/5a03496a31b462f9138123d426686a647da29b0f"}]},"branch":"refs/heads/master"},"ad91b1a12bf7b4d92af84fa3f393ae6f03ca8834":{"kind":"REWORK","_number":3,"created":"2017-11-02 13:59:40.000000000","uploader":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"ref":"refs/changes/15/517315/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/15/517315/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/15/517315/3"}}},"commit":{"parents":[{"commit":"6a64c8e7dbc1d3a6cbb444dbcdefbeb4632c01fa","subject":"Remove unified queue from gate pipeline","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/6a64c8e7dbc1d3a6cbb444dbcdefbeb4632c01fa"}]}],"author":{"name":"Jean-Philippe Evrard","email":"jean-philippe@evrard.me","date":"2017-11-02 13:51:30.000000000","tz":0},"committer":{"name":"Jean-Philippe Evrard","email":"jean-philippe@evrard.me","date":"2017-11-02 14:00:23.000000000","tz":0},"subject":"Make possible to use ansible 2.4","message":"Make possible to use ansible 2.4\n\nAnsible 2.4 has changed the interface for var plugins.\nOur vars plugin shouldn\u0027t be used in ansible 2.4, because the\nfeatures we were looking for are now standard.\n\nHowever the plugin is still shipped. So we need to ensure\nthis vars plugin doesn\u0027t get loaded on ansible 2.4.\n\nAnsible will not load a vars plugin in its plugin location\nif no VarsModule is defined. This commit abuses this\nmechanism to conditionally load the vars module depending on\nthe version, at the expense of throwing a warning in\nAnsible 2.4.\n\nChange-Id: I6e57b64c767bc0c761d61f5f5b07da4f85f1ad08\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/ad91b1a12bf7b4d92af84fa3f393ae6f03ca8834"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/ad91b1a12bf7b4d92af84fa3f393ae6f03ca8834"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}