)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~532917","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~Ibe2cff5fabf23e5ba6d5d165fb5406bca690a1e2","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"use-individual-host-variables","hashtags":[],"change_id":"Ibe2cff5fabf23e5ba6d5d165fb5406bca690a1e2","subject":"connection: ssh: Use individuals\u0027 host variables for physical host IP","status":"MERGED","created":"2018-01-11 17:28:15.000000000","updated":"2018-01-12 12:11:05.000000000","submitted":"2018-01-12 12:11:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"532917-1515759065796-ca8e402b","meta_rev_id":"66a437e814cfca1c22365e25ff00c25ba26da06f","_number":532917,"virtual_id_number":532917,"owner":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":2,"date":"2018-01-12 12:11:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"all":[{"value":2,"date":"2018-01-11 19:31:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":2,"date":"2018-01-11 18:23:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":2,"date":"2018-01-11 17:50:45.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"all":[{"value":1,"date":"2018-01-11 19:31:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-11 17:50:45.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2018-01-11 18:23:28.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2018-01-11 19:31:57.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2018-01-12 12:11:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"97e19fa349c2558bdfb0fb904781b6895f02bc7b","author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"date":"2018-01-11 17:28:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70e97f684c3d6d078dc0603baf5dba1d118e1b0c","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2018-01-11 17:39:15.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM. Looking at how to put together a test case for this briefly","accounts_in_message":[],"_revision_number":1},{"id":"a60611c10828840dbbf629da4a6806ca93fbcd8e","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2018-01-11 17:50:45.000000000","message":"Patch Set 1: Code-Review+2\n\nMake sense, would like other eyes.","accounts_in_message":[],"_revision_number":1},{"id":"02857a8dd491746f24efdd856e78044dff7d5965","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2018-01-11 17:51:04.000000000","message":"Patch Set 1:\n\ncheck experimental","accounts_in_message":[],"_revision_number":1},{"id":"3e994f62c826cf04e09564319c6d4581490fe29c","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2018-01-11 18:23:28.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM - keeping back +w for now as Logan looks into test cases.","accounts_in_message":[],"_revision_number":1},{"id":"60e220a27d52546288ee92083025799d4742cb02","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2018-01-11 19:31:57.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\nIt seems like the physical_host_addrs is ONLY empty on the first task to run. I don\u0027t see a way to construct a reliable test case in OSA since test.yml runs all in one go. Our existing test case has coverage for this bug but it is not triggered since tasks do not run against container3 until well into the test playbook.\n\nI did manually test \u0026 confirm this patch fixes the problem.\n\nhttp://paste.openstack.org/raw/643016/","accounts_in_message":[],"_revision_number":1},{"id":"2f970d9aaf9ffb5a8cc0f2a54b7ee2ddf1288eec","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 19:43:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (experimental pipeline).\n\n- openstack-ansible-integrated-deploy-aio http://logs.openstack.org/17/532917/1/experimental/openstack-ansible-integrated-deploy-aio/8b1a86e/ : POST_FAILURE in 1h 51m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"61c597390cbe3a089925ee45f6dbe69415fdb3f8","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2018-01-12 10:29:48.000000000","message":"Patch Set 1:\n\n\u003e It seems like the physical_host_addrs is ONLY empty on the first\n \u003e task to run. I don\u0027t see a way to construct a reliable test case in\n \u003e OSA since test.yml runs all in one go. Our existing test case has\n \u003e coverage for this bug but it is not triggered since tasks do not\n \u003e run against container3 until well into the test playbook.\n \u003e \n \u003e I did manually test \u0026 confirm this patch fixes the problem.\n \u003e \n \u003e http://paste.openstack.org/raw/643016/\n\nOn top of it get_vars() is the way to go in ansible code IIRC.","accounts_in_message":[],"_revision_number":1},{"id":"44c387f62ef7894233e353e0503874cd822b3f73","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2018-01-12 10:30:44.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"c9d21f78f998026d8b2b575dab67730342ee3d2a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 11:40:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/17/532917/1/check/build-openstack-sphinx-docs/bc4f688/html/ : SUCCESS in 2m 20s\n- openstack-ansible-linters http://logs.openstack.org/17/532917/1/check/openstack-ansible-linters/9a7e7bc/ : SUCCESS in 5m 53s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/17/532917/1/check/openstack-ansible-functional-centos-7/d40cc65/ : SUCCESS in 20m 29s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/17/532917/1/check/openstack-ansible-functional-opensuse-423/a580794/ : SUCCESS in 11m 33s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/17/532917/1/check/openstack-ansible-functional-ubuntu-xenial/8016233/ : SUCCESS in 9m 45s\n- openstack-ansible-python3-ubuntu-xenial-nv http://logs.openstack.org/17/532917/1/check/openstack-ansible-python3-ubuntu-xenial-nv/90994fb/ : FAILURE in 10m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"51067adcf34898ebe9d038d617670df4503202fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 11:41:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6b079af20051750b720c767e94e93b14570c9372","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 12:11:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/17/532917/1/gate/build-openstack-sphinx-docs/a3b64ce/html/ : SUCCESS in 3m 22s\n- openstack-ansible-linters http://logs.openstack.org/17/532917/1/gate/openstack-ansible-linters/bc0b82f/ : SUCCESS in 9m 33s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/17/532917/1/gate/openstack-ansible-functional-centos-7/c9b0713/ : SUCCESS in 19m 30s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/17/532917/1/gate/openstack-ansible-functional-opensuse-423/053cf2a/ : SUCCESS in 13m 23s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/17/532917/1/gate/openstack-ansible-functional-ubuntu-xenial/d05ecc2/ : SUCCESS in 9m 22s","accounts_in_message":[],"_revision_number":1},{"id":"1e0cdcab66b9c25df51ac5a359e5d05b72eb1631","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 12:11:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cbd43992bd21496747ae46dca2f6475a1466e1d6","revisions":{"cbd43992bd21496747ae46dca2f6475a1466e1d6":{"kind":"REWORK","_number":1,"created":"2018-01-11 17:28:15.000000000","uploader":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"ref":"refs/changes/17/532917/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/17/532917/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/17/532917/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/17/532917/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/17/532917/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/17/532917/1"}}},"commit":{"parents":[{"commit":"c665f9f2a2dea2ac532402d41b68b6132fd774bc","subject":"Remove the vars plugin as it\u0027s no longer used","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/c665f9f2a2dea2ac532402d41b68b6132fd774bc"}]}],"author":{"name":"Markos Chandras","email":"mchandras@suse.de","date":"2018-01-11 17:25:05.000000000","tz":0},"committer":{"name":"Markos Chandras","email":"mchandras@suse.de","date":"2018-01-11 17:25:05.000000000","tz":0},"subject":"connection: ssh: Use individuals\u0027 host variables for physical host IP","message":"connection: ssh: Use individuals\u0027 host variables for physical host IP\n\nIt appears that since Ansible 2.4 the \u0027hostvars\u0027 variable does not\ncontain the host variables set by the linear plugin. However, the\nphysical_host_addrs variable set by that plugin is already present on\nthe host we are interested in. As such we can obtain that variable by\nsimply using the get_vars() method on the Host object.\n\nChange-Id: Ibe2cff5fabf23e5ba6d5d165fb5406bca690a1e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/cbd43992bd21496747ae46dca2f6475a1466e1d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/cbd43992bd21496747ae46dca2f6475a1466e1d6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}