)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~554301","triplet_id":"openstack%2Fopenstack-ansible-plugins~stable%2Fqueens~I7c7cd9ef1dd767a2a5d754ac4663cf8655dd60c2","project":"openstack/openstack-ansible-plugins","branch":"stable/queens","topic":"fix_ordering-stable/queens","hashtags":[],"change_id":"I7c7cd9ef1dd767a2a5d754ac4663cf8655dd60c2","subject":"Utilise sorted to ensure no random changes","status":"MERGED","created":"2018-03-19 17:36:11.000000000","updated":"2018-03-20 20:23:41.000000000","submitted":"2018-03-20 20:23:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"554301-1521577421526-3b0d49df","meta_rev_id":"6fd5422af5fd982d61d42daf92580ac29630db8f","_number":554301,"virtual_id_number":554301,"owner":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":2,"date":"2018-03-20 20:23:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2018-03-20 19:56:07.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2018-03-20 19:55:19.000000000","_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":1,"date":"2018-03-20 19:56:07.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-19 17:36:11.000000000","updated_by":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"reviewer":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"state":"REVIEWER"},{"updated":"2018-03-20 19:55:19.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2018-03-20 19:56:07.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2018-03-20 20:23:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1b5a9cc3bbbf2af5c8d1bd6b1793d080b749614c","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2018-03-19 17:36:11.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"6acd66684becdeb7895894a590a988f94d347b25","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2018-03-19 17:39:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7395a1e218c919d14ff248fb32dd42a807c99fcb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-19 18:20:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/01/554301/1/check/build-openstack-sphinx-docs/3cdced8/html/ : SUCCESS in 2m 36s\n- openstack-ansible-linters http://logs.openstack.org/01/554301/1/check/openstack-ansible-linters/1d24a4f/ : SUCCESS in 5m 41s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/01/554301/1/check/openstack-ansible-functional-centos-7/dd607e8/ : SUCCESS in 17m 57s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/01/554301/1/check/openstack-ansible-functional-opensuse-423/2bb9d2f/ : SUCCESS in 12m 31s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/01/554301/1/check/openstack-ansible-functional-ubuntu-xenial/2a94734/ : SUCCESS in 10m 47s\n- openstack-ansible-python3-ubuntu-xenial-nv http://logs.openstack.org/01/554301/1/check/openstack-ansible-python3-ubuntu-xenial-nv/1cf086e/ : FAILURE in 13m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2de46fafc720227071a421c7073aebbd54f1a8e0","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2018-03-20 17:21:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fb6baa0b2cffa67fb62d07545c86922ed393ac4c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 19:17:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/01/554301/2/check/build-openstack-sphinx-docs/e0a22fc/html/ : SUCCESS in 2m 33s\n- openstack-ansible-linters http://logs.openstack.org/01/554301/2/check/openstack-ansible-linters/d18f762/ : SUCCESS in 5m 37s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/01/554301/2/check/openstack-ansible-functional-centos-7/18ecbcb/ : SUCCESS in 18m 24s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/01/554301/2/check/openstack-ansible-functional-opensuse-423/dd5a88e/ : SUCCESS in 12m 01s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/01/554301/2/check/openstack-ansible-functional-ubuntu-xenial/b7943ad/ : SUCCESS in 10m 32s\n- openstack-ansible-python3-ubuntu-xenial-nv http://logs.openstack.org/01/554301/2/check/openstack-ansible-python3-ubuntu-xenial-nv/975f07a/ : TIMED_OUT in 1h 33m 30s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"3007b87e8eb7afe08398c60eda51f02e697538d2","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2018-03-20 19:55:19.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8823f72744f43b49b52d00cbb21c4b6ded817398","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2018-03-20 19:56:07.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"35359c3ef792190e89e8fb138af1504d5b423748","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 19:56:19.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"af50e2114514bb30c1a6dfc397c524d402e95010","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 20:23:40.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/01/554301/2/gate/build-openstack-sphinx-docs/3d3e855/html/ : SUCCESS in 3m 11s\n- openstack-ansible-linters http://logs.openstack.org/01/554301/2/gate/openstack-ansible-linters/71efc3d/ : SUCCESS in 5m 35s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/01/554301/2/gate/openstack-ansible-functional-centos-7/10b4a6b/ : SUCCESS in 19m 45s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/01/554301/2/gate/openstack-ansible-functional-opensuse-423/1411baf/ : SUCCESS in 10m 58s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/01/554301/2/gate/openstack-ansible-functional-ubuntu-xenial/6302158/ : SUCCESS in 12m 05s","accounts_in_message":[],"_revision_number":2},{"id":"c370475f05c62e7fd9203e81eaae8c9d860a9fec","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 20:23:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fce9a020a3f70e5b518968e995fd2735a3a79b34","revisions":{"c153d538503839a54314b4d93b69b8c1411a41dc":{"kind":"REWORK","_number":1,"created":"2018-03-19 17:36:11.000000000","uploader":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"ref":"refs/changes/01/554301/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/01/554301/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/1"}}},"commit":{"parents":[{"commit":"35727b8eb88b32d67a717aed5d44be06a264a0a4","subject":"Reduce interactions by nearly 50%","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/35727b8eb88b32d67a717aed5d44be06a264a0a4"}]}],"author":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2018-03-16 11:37:33.000000000","tz":0},"committer":{"name":"Kevin Carter (cloudnull)","email":"kevin@cloudnull.com","date":"2018-03-19 17:36:11.000000000","tz":0},"subject":"Utilise sorted to ensure no random changes","message":"Utilise sorted to ensure no random changes\n\nAs part of the ceph-ansible project, this change was put in:\nhttps://github.com/ceph/ceph-ansible/commit/ec042219e64a321fa67fce0384af76eeb238c645\nThis was to handle the case where the config would change, initiating a\nrestart handler, even though no actual change happened.\n\nWe can juse use sorted() since we are passing back a list with .items()\nwhich can then be sorted.\n\nThe above change didn\u0027t include a change to ensure the order of the\nsections, which meant that although the individual items were sorted the\nsections could change order causing unnecessary changes.\n\nAdditionally, this adds a test to retemplate the file 3 times, with a\nlot more sections to ensure the order remains the same, this will fail\nwhen the config template changes even though no changes have happened.\n\nChange-Id: I7c7cd9ef1dd767a2a5d754ac4663cf8655dd60c2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/c153d538503839a54314b4d93b69b8c1411a41dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/c153d538503839a54314b4d93b69b8c1411a41dc"}]},"branch":"refs/heads/stable/queens"},"fce9a020a3f70e5b518968e995fd2735a3a79b34":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-03-20 17:21:27.000000000","uploader":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"ref":"refs/changes/01/554301/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/01/554301/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/01/554301/2"}}},"commit":{"parents":[{"commit":"35727b8eb88b32d67a717aed5d44be06a264a0a4","subject":"Reduce interactions by nearly 50%","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/35727b8eb88b32d67a717aed5d44be06a264a0a4"}]}],"author":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2018-03-16 11:37:33.000000000","tz":0},"committer":{"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","date":"2018-03-20 17:21:27.000000000","tz":0},"subject":"Utilise sorted to ensure no random changes","message":"Utilise sorted to ensure no random changes\n\nAs part of the ceph-ansible project, this change was put in:\nhttps://github.com/ceph/ceph-ansible/commit/ec042219e64a321fa67fce0384af76eeb238c645\nThis was to handle the case where the config would change, initiating a\nrestart handler, even though no actual change happened.\n\nWe can juse use sorted() since we are passing back a list with .items()\nwhich can then be sorted.\n\nThe above change didn\u0027t include a change to ensure the order of the\nsections, which meant that although the individual items were sorted the\nsections could change order causing unnecessary changes.\n\nAdditionally, this adds a test to retemplate the file 3 times, with a\nlot more sections to ensure the order remains the same, this will fail\nwhen the config template changes even though no changes have happened.\n\nChange-Id: I7c7cd9ef1dd767a2a5d754ac4663cf8655dd60c2\n(cherry picked from commit a5ef4eadd1b7ab056e5bb16dc2a1284226871903)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/fce9a020a3f70e5b518968e995fd2735a3a79b34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/fce9a020a3f70e5b518968e995fd2735a3a79b34"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}