)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~655993","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~I476701f435a44ffa556177e1540cbee84af59e71","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"bug/1826246","hashtags":[],"change_id":"I476701f435a44ffa556177e1540cbee84af59e71","subject":"Closes-Bug: #1826246","status":"ABANDONED","created":"2019-04-26 18:36:11.000000000","updated":"2019-04-26 19:12:33.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"94d6a85f55a818c0a0d13e4f91ea099529adbbae","_number":655993,"virtual_id_number":655993,"owner":{"_account_id":30324,"name":"Kanishk Godha","email":"kanishkg@vexxhost.com","username":"kanishk.godha"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-04-26 18:36:26.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":-1,"date":"2019-04-26 19:01:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"date":"2019-04-26 19:04:57.000000000","_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-04-26 18:44:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-26 18:36:26.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2019-04-26 18:44:17.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2019-04-26 19:01:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-26 19:04:57.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"}],"messages":[{"id":"50f5c205d8a0aa25ff1b39c63572dbc7fa73504e","author":{"_account_id":30324,"name":"Kanishk Godha","email":"kanishkg@vexxhost.com","username":"kanishk.godha"},"date":"2019-04-26 18:36:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b3d89cd47af9e17dcebc484c924065607d5d284","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2019-04-26 18:36:26.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\nYour patch will now be tested automatically by OpenStack testing frameworks\nand once the automatic tests pass, it will be reviewed by other friendly\ndevelopers. They will give you feedback and may require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches usually take 3 to 7 days to be reviewed so be patient and be\navailable on IRC to ask and answer questions about your work. Also it\ntakes generally at least a couple of weeks for cores to get around to\nreviewing code. The more you participate in the community the more\nrewarding it is for you. You may also notice that the more you get to know\npeople and get to be known, the faster your patches will be reviewed and\neventually approved. Get to know others and become known by doing code\nreviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for supporting OpenStack, we look forward to working with you.\n\nIRC: https://wiki.openstack.org/wiki/IRC\nWorkflow: https://docs.openstack.org/infra/manual/developers.html\nCommit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"5b6b1a3995f09a9fd16ee8c357757bc2f403e1ff","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-04-26 18:44:17.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c908cf12918c5bfce17832ca077af30a3db78be","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-04-26 18:55:32.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n\nBefore we can merge this, the use of the openstack-ansible-plugins keystone module needs to be replaced with the built-in ansible equivalent in at least the os_keystone, os_swift and os_trove ansible roles. There may be more uses of the module, needs a thorough check.","accounts_in_message":[],"_revision_number":1},{"id":"04f52ef51aa3b2eeb0fdd6f32f606338d6e246d6","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-04-26 18:56:34.000000000","message":"Patch Set 1:\n\nI\u0027m pretty sure none of the roles are actually using this specific module anymore from my basic search..","accounts_in_message":[],"_revision_number":1},{"id":"e6bea1ab01f9b4829902c7191a7141eaabf6d1aa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-26 19:01:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/93/655993/1/check/openstack-tox-docs/36af470/html/ : SUCCESS in 3m 27s\n- openstack-ansible-linters http://logs.openstack.org/93/655993/1/check/openstack-ansible-linters/f1e9b59/ : SUCCESS in 6m 56s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/93/655993/1/check/openstack-ansible-functional-centos-7/501cd20/ : FAILURE in 18m 59s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/93/655993/1/check/openstack-ansible-functional-ubuntu-bionic/895f9f0/ : SUCCESS in 15m 33s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/93/655993/1/check/openstack-ansible-functional-ubuntu-xenial/077fe2e/ : SUCCESS in 15m 46s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/93/655993/1/check/openstack-ansible-python3-ubuntu-bionic/b4e0b9d/ : SUCCESS in 12m 10s","accounts_in_message":[],"_revision_number":1},{"id":"259c23fba5012ec9e22391a9edcd59ca0f6dacb5","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-04-26 19:04:57.000000000","message":"Patch Set 1:\n\n\u003e I\u0027m pretty sure none of the roles are actually using this specific\n \u003e module anymore from my basic search..\n\nhttps://opendev.org/openstack/openstack-ansible-os_keystone/src/branch/master/tasks/keystone_federation_sp_idp_setup.yml#L26\n\nhttps://opendev.org/openstack/openstack-ansible-os_swift/src/branch/master/tasks/swift_proxy_hosts.yml#L17\n\nhttps://opendev.org/openstack/openstack-ansible-os_trove/src/branch/master/tasks/trove_service_network.yml#L23","accounts_in_message":[],"_revision_number":1},{"id":"633e4518380f594125b0266820789e98714ffcc4","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-04-26 19:12:33.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f1b8d8929f2b2f2ab0e137864ccbe89025683fa1","revisions":{"f1b8d8929f2b2f2ab0e137864ccbe89025683fa1":{"kind":"REWORK","_number":1,"created":"2019-04-26 18:36:11.000000000","uploader":{"_account_id":30324,"name":"Kanishk Godha","email":"kanishkg@vexxhost.com","username":"kanishk.godha"},"ref":"refs/changes/93/655993/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/93/655993/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/93/655993/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/93/655993/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/93/655993/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/93/655993/1"}}},"commit":{"parents":[{"commit":"df270c6bd059d1c56939ef757c193672b2691629","subject":"Merge \"Add code source link and bugs link to README\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/df270c6bd059d1c56939ef757c193672b2691629"}]}],"author":{"name":"Kanishk Godha","email":"kanishk.godha@live.com","date":"2019-04-26 18:31:53.000000000","tz":330},"committer":{"name":"Kanishk Godha","email":"kanishk.godha@live.com","date":"2019-04-26 18:31:53.000000000","tz":330},"subject":"Closes-Bug: #1826246","message":"Closes-Bug: #1826246\n\nChange-Id: I476701f435a44ffa556177e1540cbee84af59e71\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/f1b8d8929f2b2f2ab0e137864ccbe89025683fa1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/f1b8d8929f2b2f2ab0e137864ccbe89025683fa1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
