)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~662875","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~Id62e510af035988084453883278c3db85c8b7519","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"connection-optimize","hashtags":[],"change_id":"Id62e510af035988084453883278c3db85c8b7519","subject":"connection: use close from superclass","status":"MERGED","created":"2019-06-03 23:21:09.000000000","updated":"2019-06-11 21:12:59.000000000","submitted":"2019-06-11 21:12:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662875-1560287579596-43f1f006","meta_rev_id":"d0e98198ac8379336dbd014c00c3cbaf9da2afd4","_number":662875,"virtual_id_number":662875,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":2,"date":"2019-06-11 21:12:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"all":[{"value":2,"date":"2019-06-04 00:05:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-05 19:31:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-05 19:31:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-04 00:05:02.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2019-06-05 19:31:31.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-06-11 21:12:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ee6a89c809b5ef7a1d1f93e3081a2572f7864d7d","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-03 23:21:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"24dfdc33b77d0bd6679e67be0b4649051c7b17db","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-03 23:48:23.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"9c80cb4c7f707ed1fb7a385d84599d0044f19c77","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-06-04 00:05:02.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ec4e9213211c4eb55b549c7084b4b4665f0f0f65","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 00:11:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/662875/2/check/openstack-tox-docs/cb6d7c6/html/ : SUCCESS in 2m 35s\n- openstack-ansible-linters http://logs.openstack.org/75/662875/2/check/openstack-ansible-linters/d3a34d7/ : SUCCESS in 5m 38s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/75/662875/2/check/openstack-ansible-functional-centos-7/64d92a5/ : SUCCESS in 16m 24s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/75/662875/2/check/openstack-ansible-functional-ubuntu-bionic/2e6362b/ : SUCCESS in 14m 51s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/75/662875/2/check/openstack-ansible-python3-ubuntu-bionic/a5b3430/ : SUCCESS in 14m 48s","accounts_in_message":[],"_revision_number":2},{"id":"8123a979b0a5a7d6d96690c004c73c3404f3a01d","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-06-05 19:31:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a30fd4bec8635b039e62d600d7484cba16b967b5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 20:25:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"55bb9b1bc62b23ae15de62cd2345824bb72adfd8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 21:12:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/662875/2/gate/openstack-tox-docs/d8edb32/html/ : SUCCESS in 3m 09s\n- openstack-ansible-linters http://logs.openstack.org/75/662875/2/gate/openstack-ansible-linters/8ecc166/ : SUCCESS in 5m 40s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/75/662875/2/gate/openstack-ansible-functional-centos-7/1da4ecf/ : SUCCESS in 15m 52s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/75/662875/2/gate/openstack-ansible-functional-ubuntu-bionic/f576512/ : SUCCESS in 11m 59s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/75/662875/2/gate/openstack-ansible-python3-ubuntu-bionic/e4ee89e/ : SUCCESS in 12m 30s","accounts_in_message":[],"_revision_number":2},{"id":"38ab4139ebafb869c47c7f54c71518c99d242087","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 21:12:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"74ae653e2fd387de59f31568d9ae8dea7daed8bd","revisions":{"06cb7750c03d4a957b9f82a75f39f84bcbdcaa31":{"kind":"REWORK","_number":1,"created":"2019-06-03 23:21:09.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/75/662875/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/75/662875/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/1"}}},"commit":{"parents":[{"commit":"7a2c4329346bcb6b1d4b06ce24099bda0bca5ed7","subject":"connection: stop running chown all the time","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/7a2c4329346bcb6b1d4b06ce24099bda0bca5ed7"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:00:54.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:00:54.000000000","tz":-240},"subject":"connection: use close from superclass","message":"connection: use close from superclass\n\nWe had our own re-implemented close function from when this was\nfirst introduced which has since then drifted a lot from Ansible.\n\nThis drops all that code so that we can use the superclass when\nclosing the connection.\n\nChange-Id: Id62e510af035988084453883278c3db85c8b7519\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/06cb7750c03d4a957b9f82a75f39f84bcbdcaa31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/06cb7750c03d4a957b9f82a75f39f84bcbdcaa31"}]},"branch":"refs/heads/master"},"74ae653e2fd387de59f31568d9ae8dea7daed8bd":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-06-03 23:48:23.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/75/662875/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/75/662875/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/75/662875/2"}}},"commit":{"parents":[{"commit":"e085907160b1c5405950ec9eecb509a89b9cb40f","subject":"connection: stop running chown all the time","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/e085907160b1c5405950ec9eecb509a89b9cb40f"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:00:54.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:24:37.000000000","tz":-240},"subject":"connection: use close from superclass","message":"connection: use close from superclass\n\nWe had our own re-implemented close function from when this was\nfirst introduced which has since then drifted a lot from Ansible.\n\nThis drops all that code so that we can use the superclass when\nclosing the connection.\n\nChange-Id: Id62e510af035988084453883278c3db85c8b7519\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/74ae653e2fd387de59f31568d9ae8dea7daed8bd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/74ae653e2fd387de59f31568d9ae8dea7daed8bd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}