)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~662884","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~Iaa6e2d3a149caec239be18380a1859247ff5c9e3","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"connection-optimize","hashtags":[],"change_id":"Iaa6e2d3a149caec239be18380a1859247ff5c9e3","subject":"connection: don\u0027t sudo if we\u0027re running as root","status":"ABANDONED","created":"2019-06-03 23:48:23.000000000","updated":"2020-07-30 20:09:36.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"398075daa931d107056f2cc9e9504396e9eb5942","_number":662884,"virtual_id_number":662884,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"date":"2019-06-11 23:32:33.000000000","_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":-1,"date":"2019-06-04 22:53:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-04 00:08:02.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2019-06-04 22:53:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c4787c34b766c5ddb8814b1788c1f69d253fd257","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-03 23:48:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"27aded802460eb2a2f164789d6cd18fce40846a5","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-06-04 00:02:47.000000000","message":"Patch Set 1:\n\nI\u0027m not sure on this -- isn\u0027t the idea there that we don\u0027t want to be root, we want to be $container_user instead, so we sudo to it?","accounts_in_message":[],"_revision_number":1},{"id":"5994aad7d76c72c35a17401f72b6dd4386834b8e","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-06-04 00:08:02.000000000","message":"Patch Set 1:\n\nUpon re-read, nevermind my previous comment.\n\nBut, this assumes the user attaching to the container is root, which may not be the case in an unprivileged container.","accounts_in_message":[],"_revision_number":1},{"id":"03eb3df29c74434840f92ac8c0d0fc2bbb62437d","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-04 00:12:39.000000000","message":"Patch Set 1:\n\n\"If no command is specified, the current default shell of the user running lxc-attach will be looked up inside the container and executed. This will fail if no such user exists inside the container or the container does not have a working nsswitch mechanism.\"\n\nSo, perhaps what we need to do is check if container_user !\u003d remote_user then..","accounts_in_message":[],"_revision_number":1},{"id":"359e5699a7d0e9685767c4573c7e236a82feb1db","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 00:14:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/84/662884/1/check/openstack-tox-docs/db68e7f/html/ : SUCCESS in 2m 40s\n- openstack-ansible-linters http://logs.openstack.org/84/662884/1/check/openstack-ansible-linters/2169778/ : SUCCESS in 5m 00s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/84/662884/1/check/openstack-ansible-functional-centos-7/dc8bdb9/ : FAILURE in 16m 57s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/84/662884/1/check/openstack-ansible-functional-ubuntu-bionic/8008bc2/ : FAILURE in 12m 05s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/84/662884/1/check/openstack-ansible-python3-ubuntu-bionic/ed6c1bc/ : FAILURE in 11m 31s","accounts_in_message":[],"_revision_number":1},{"id":"2021ac4231240af252bd374ff7fa2c71f59eeddb","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-04 00:18:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6ad6a060ef16228e0422a7bdd1c1fed4b2e717cc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 00:40:11.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/84/662884/2/check/openstack-tox-docs/a908e3f/html/ : SUCCESS in 2m 35s\n- openstack-ansible-linters http://logs.openstack.org/84/662884/2/check/openstack-ansible-linters/1ff3eed/ : SUCCESS in 4m 16s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/84/662884/2/check/openstack-ansible-functional-centos-7/1773040/ : FAILURE in 13m 14s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/84/662884/2/check/openstack-ansible-functional-ubuntu-bionic/3353f8d/ : FAILURE in 10m 59s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/84/662884/2/check/openstack-ansible-python3-ubuntu-bionic/3663fb9/ : FAILURE in 10m 32s","accounts_in_message":[],"_revision_number":2},{"id":"4e236dd9408312bdf8cb62125d6bdcc8f5d84a3f","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-04 22:28:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"972f9c858f10032e04486528c08a64c0ff866323","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-04 22:41:18.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b742d061a15306f6f7f660ebaa421cbe5c825018","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 22:41:25.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/84/662884/3/check/openstack-tox-docs/1a65e58/html/ : SUCCESS in 2m 36s\n- openstack-ansible-linters http://logs.openstack.org/84/662884/3/check/openstack-ansible-linters/78adeb6/ : FAILURE in 5m 28s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/84/662884/3/check/openstack-ansible-functional-centos-7/84a3674/ : FAILURE in 7m 46s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/84/662884/3/check/openstack-ansible-functional-ubuntu-bionic/58252fd/ : FAILURE in 8m 13s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/84/662884/3/check/openstack-ansible-python3-ubuntu-bionic/772e753/ : FAILURE in 4m 56s","accounts_in_message":[],"_revision_number":3},{"id":"54827d6225ae97e03fa04e4b4a0c962d03f9ed70","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 22:53:46.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/84/662884/4/check/openstack-tox-docs/28976d3/html/ : SUCCESS in 2m 58s\n- openstack-ansible-linters http://logs.openstack.org/84/662884/4/check/openstack-ansible-linters/b1851ab/ : FAILURE in 4m 46s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/84/662884/4/check/openstack-ansible-functional-centos-7/9ce346c/ : FAILURE in 6m 21s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/84/662884/4/check/openstack-ansible-functional-ubuntu-bionic/df3bf14/ : FAILURE in 5m 02s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/84/662884/4/check/openstack-ansible-python3-ubuntu-bionic/fac2d10/ : FAILURE in 4m 49s","accounts_in_message":[],"_revision_number":4},{"id":"e0dfb675861b8ad8aad6f209399fce99ea765b6c","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-11 23:32:33.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"e000b47c17a9b9412704aedb9edb89aa53029c28","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-12 00:02:31.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/84/662884/4/check/openstack-tox-docs/5526a56/html/ : SUCCESS in 2m 40s\n- openstack-ansible-linters http://logs.openstack.org/84/662884/4/check/openstack-ansible-linters/a8b051d/ : SUCCESS in 8m 46s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/84/662884/4/check/openstack-ansible-functional-centos-7/f12e220/ : FAILURE in 12m 40s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/84/662884/4/check/openstack-ansible-functional-ubuntu-bionic/7b597c6/ : FAILURE in 10m 07s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/84/662884/4/check/openstack-ansible-python3-ubuntu-bionic/67a1690/ : FAILURE in 9m 37s","accounts_in_message":[],"_revision_number":4},{"id":"c5af1f1dfa9cd34d88ab94f2d6fc3f0d4ecde3b1","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-07-30 20:09:36.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"321b129f27f1f1e211695fc8c1ff5c126adc6fd4","revisions":{"83e4ff2aa3a6be95af7726d39d4a9bcbaff13a0e":{"kind":"REWORK","_number":1,"created":"2019-06-03 23:48:23.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/84/662884/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/84/662884/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/1"}}},"commit":{"parents":[{"commit":"74ae653e2fd387de59f31568d9ae8dea7daed8bd","subject":"connection: use close from superclass","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/74ae653e2fd387de59f31568d9ae8dea7daed8bd"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:46:36.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:46:36.000000000","tz":-240},"subject":"connection: don\u0027t sudo if we\u0027re running as root","message":"connection: don\u0027t sudo if we\u0027re running as root\n\nThis patch avoids running su inside the container to run the\ncommand if we\u0027re trying to run as root, as we\u0027re already\nin the host as root to be able to run all these commands in the\nfirst place.\n\nChange-Id: Iaa6e2d3a149caec239be18380a1859247ff5c9e3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/83e4ff2aa3a6be95af7726d39d4a9bcbaff13a0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/83e4ff2aa3a6be95af7726d39d4a9bcbaff13a0e"}]},"branch":"refs/heads/master"},"f8473dacce788e3772622ba3c0384ef25ecbb6d3":{"kind":"REWORK","_number":2,"created":"2019-06-04 00:18:53.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/84/662884/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/84/662884/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/2"}}},"commit":{"parents":[{"commit":"10fc539014cb96c6d54bfc764aaab6aca7ef196d","subject":"connection: drop shlex_quote import","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/10fc539014cb96c6d54bfc764aaab6aca7ef196d"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:46:36.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-04 00:18:21.000000000","tz":-240},"subject":"connection: don\u0027t sudo if we\u0027re running as root","message":"connection: don\u0027t sudo if we\u0027re running as root\n\nThis patch avoids running su inside the container if the\nremote_user which is connected to run the task matches the\nspecified container_user.\n\nThis is because lxc-attach behaviour by default will actually\ngive you a shell that matches the user which executes lxc-attach.\n\nChange-Id: Iaa6e2d3a149caec239be18380a1859247ff5c9e3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/f8473dacce788e3772622ba3c0384ef25ecbb6d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/f8473dacce788e3772622ba3c0384ef25ecbb6d3"}]},"branch":"refs/heads/master"},"d5119584c1bc6ba286e25806498e8790d9a94796":{"kind":"REWORK","_number":3,"created":"2019-06-04 22:28:43.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/84/662884/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/84/662884/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/3"}}},"commit":{"parents":[{"commit":"10fc539014cb96c6d54bfc764aaab6aca7ef196d","subject":"connection: drop shlex_quote import","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/10fc539014cb96c6d54bfc764aaab6aca7ef196d"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:46:36.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-04 22:28:32.000000000","tz":-240},"subject":"connection: don\u0027t sudo if we\u0027re running as root","message":"connection: don\u0027t sudo if we\u0027re running as root\n\nThis patch avoids running su inside the container if the\nremote_user which is connected to run the task matches the\nspecified container_user.\n\nThis is because lxc-attach behaviour by default will actually\ngive you a shell that matches the user which executes lxc-attach.\n\nChange-Id: Iaa6e2d3a149caec239be18380a1859247ff5c9e3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/d5119584c1bc6ba286e25806498e8790d9a94796"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/d5119584c1bc6ba286e25806498e8790d9a94796"}]},"branch":"refs/heads/master"},"321b129f27f1f1e211695fc8c1ff5c126adc6fd4":{"kind":"REWORK","_number":4,"created":"2019-06-04 22:41:18.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/84/662884/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/84/662884/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/84/662884/4"}}},"commit":{"parents":[{"commit":"10fc539014cb96c6d54bfc764aaab6aca7ef196d","subject":"connection: drop shlex_quote import","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/10fc539014cb96c6d54bfc764aaab6aca7ef196d"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:46:36.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-04 22:36:09.000000000","tz":-240},"subject":"connection: don\u0027t sudo if we\u0027re running as root","message":"connection: don\u0027t sudo if we\u0027re running as root\n\nThis patch avoids running su inside the container if the\nremote_user which is connected to run the task matches the\nspecified container_user.\n\nThis is because lxc-attach behaviour by default will actually\ngive you a shell that matches the user which executes lxc-attach.\n\nChange-Id: Iaa6e2d3a149caec239be18380a1859247ff5c9e3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/321b129f27f1f1e211695fc8c1ff5c126adc6fd4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/321b129f27f1f1e211695fc8c1ff5c126adc6fd4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}