)]}'
{"id":"openstack%2Fopenstack-ansible-plugins~662885","triplet_id":"openstack%2Fopenstack-ansible-plugins~master~I6be4e5fdce16154ea664ccb5cb26add268b8c9b2","project":"openstack/openstack-ansible-plugins","branch":"master","topic":"connection-optimize","hashtags":[],"change_id":"I6be4e5fdce16154ea664ccb5cb26add268b8c9b2","subject":"connection: drop shlex_quote import","status":"MERGED","created":"2019-06-03 23:52:57.000000000","updated":"2019-06-12 00:27:09.000000000","submitted":"2019-06-12 00:27:09.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662885-1560299229810-e232e0c4","meta_rev_id":"e6cc61f9acbb85634b3b10e4e6fb1bcd47bc1ab5","_number":662885,"virtual_id_number":662885,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"date":"2019-06-11 23:32:12.000000000","_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":2,"date":"2019-06-12 00:27:09.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"all":[{"value":2,"date":"2019-06-04 00:18:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-05 19:26:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-05 19:26:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-04 00:04:17.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2019-06-05 19:26:56.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-06-12 00:27:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b0cde141359da76e5dd89601a145eda873db7828","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-03 23:52:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"625d457688b28bdc82cb9475b511d3c6ad0443e6","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-06-04 00:04:17.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3259d7759a49e859ff5478953d9d46d9f9934d67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 00:12:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/85/662885/1/check/openstack-tox-docs/e9737ff/html/ : SUCCESS in 2m 18s\n- openstack-ansible-linters http://logs.openstack.org/85/662885/1/check/openstack-ansible-linters/526a4bb/ : SUCCESS in 4m 52s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/85/662885/1/check/openstack-ansible-functional-centos-7/7f4872b/ : FAILURE in 13m 55s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/85/662885/1/check/openstack-ansible-functional-ubuntu-bionic/5b946d7/ : FAILURE in 10m 52s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/85/662885/1/check/openstack-ansible-python3-ubuntu-bionic/dd41dcf/ : FAILURE in 13m 27s","accounts_in_message":[],"_revision_number":1},{"id":"845c7ba582aba77f07d95277e4417ff9f3418592","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-04 00:18:53.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a4af473f922e0eb4781cffc8717778a82694fbd0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 00:47:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/85/662885/2/check/openstack-tox-docs/63cf07f/html/ : SUCCESS in 2m 32s\n- openstack-ansible-linters http://logs.openstack.org/85/662885/2/check/openstack-ansible-linters/8478d1f/ : SUCCESS in 5m 38s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/85/662885/2/check/openstack-ansible-functional-centos-7/84363fa/ : SUCCESS in 16m 57s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/85/662885/2/check/openstack-ansible-functional-ubuntu-bionic/e4431c9/ : SUCCESS in 13m 57s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/85/662885/2/check/openstack-ansible-python3-ubuntu-bionic/b32a6d7/ : SUCCESS in 11m 28s","accounts_in_message":[],"_revision_number":2},{"id":"ee5d7954fc64ee067c15d1474bcfbb30ea662f8c","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-06-05 19:26:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"52bd86dc608e2e9a2a7c675f674933de2ba31241","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 20:25:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"fabc23a065bc60e6140f1973c344850969cf0e4b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 21:13:00.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/85/662885/2/gate/openstack-tox-docs/f4c0714/html/ : SUCCESS in 3m 07s\n- openstack-ansible-linters http://logs.openstack.org/85/662885/2/gate/openstack-ansible-linters/c7326f6/ : SUCCESS in 5m 34s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/85/662885/2/gate/openstack-ansible-functional-centos-7/efd052b/ : FAILURE in 16m 00s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/85/662885/2/gate/openstack-ansible-functional-ubuntu-bionic/07c329f/ : SUCCESS in 12m 45s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/85/662885/2/gate/openstack-ansible-python3-ubuntu-bionic/d1483ff/ : SUCCESS in 15m 32s","accounts_in_message":[],"_revision_number":2},{"id":"0fd850fff462204e90ca76aa80cbd7ed2f80ce10","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-06-11 23:32:12.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"28174d935c2bb4c5596e686b0f1921ae1d35d78f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 23:54:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/85/662885/2/check/openstack-tox-docs/f349d7b/html/ : SUCCESS in 2m 41s\n- openstack-ansible-linters http://logs.openstack.org/85/662885/2/check/openstack-ansible-linters/9503c82/ : SUCCESS in 5m 49s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/85/662885/2/check/openstack-ansible-functional-centos-7/3125573/ : SUCCESS in 14m 57s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/85/662885/2/check/openstack-ansible-functional-ubuntu-bionic/64ac533/ : SUCCESS in 10m 37s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/85/662885/2/check/openstack-ansible-python3-ubuntu-bionic/f9ac98b/ : SUCCESS in 12m 11s","accounts_in_message":[],"_revision_number":2},{"id":"098a0dba3d63dbe7c2ec6eec87758afe9993e3d9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 23:55:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"7e1a538dc5a58cbd3bcea603d139f3610825378a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-12 00:27:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"7c8d1b6ef202d0152aaf0f498b17bd16551f9384","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-12 00:27:09.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/85/662885/2/gate/openstack-tox-docs/832e334/html/ : SUCCESS in 2m 55s\n- openstack-ansible-linters http://logs.openstack.org/85/662885/2/gate/openstack-ansible-linters/5d9a261/ : SUCCESS in 5m 31s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/85/662885/2/gate/openstack-ansible-functional-centos-7/0e50b27/ : SUCCESS in 15m 09s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/85/662885/2/gate/openstack-ansible-functional-ubuntu-bionic/89adca2/ : SUCCESS in 11m 24s\n- openstack-ansible-python3-ubuntu-bionic http://logs.openstack.org/85/662885/2/gate/openstack-ansible-python3-ubuntu-bionic/b1e7801/ : SUCCESS in 10m 54s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"10fc539014cb96c6d54bfc764aaab6aca7ef196d","revisions":{"b35690e3e20580845859370e375ee88337b1b4dc":{"kind":"REWORK","_number":1,"created":"2019-06-03 23:52:57.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/85/662885/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/85/662885/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/1"}}},"commit":{"parents":[{"commit":"83e4ff2aa3a6be95af7726d39d4a9bcbaff13a0e","subject":"connection: don\u0027t sudo if we\u0027re running as root","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/83e4ff2aa3a6be95af7726d39d4a9bcbaff13a0e"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:52:24.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:52:24.000000000","tz":-240},"subject":"connection: drop shlex_quote import","message":"connection: drop shlex_quote import\n\nshlex_quote has been part of the connection plugin since the\nAnsible 2.3 release.  We don\u0027t need to do this anymore.\n\nChange-Id: I6be4e5fdce16154ea664ccb5cb26add268b8c9b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/b35690e3e20580845859370e375ee88337b1b4dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/b35690e3e20580845859370e375ee88337b1b4dc"}]},"branch":"refs/heads/master"},"10fc539014cb96c6d54bfc764aaab6aca7ef196d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-06-04 00:18:53.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/85/662885/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-plugins","ref":"refs/changes/85/662885/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-plugins refs/changes/85/662885/2"}}},"commit":{"parents":[{"commit":"74ae653e2fd387de59f31568d9ae8dea7daed8bd","subject":"connection: use close from superclass","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/74ae653e2fd387de59f31568d9ae8dea7daed8bd"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-03 23:52:24.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-06-04 00:13:03.000000000","tz":-240},"subject":"connection: drop shlex_quote import","message":"connection: drop shlex_quote import\n\nshlex_quote has been part of the connection plugin since the\nAnsible 2.3 release.  We don\u0027t need to do this anymore.\n\nChange-Id: I6be4e5fdce16154ea664ccb5cb26add268b8c9b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/10fc539014cb96c6d54bfc764aaab6aca7ef196d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-plugins/commit/10fc539014cb96c6d54bfc764aaab6aca7ef196d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}