)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"53b5fd626f9c056207619c4bf6d1433ed007fa93","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     george paraskevas \u003cgparaskevas@stackmasters.eu\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-05 12:36:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This patch enables rabbitmq_server role to create an admin user for the management web interface."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a2a8d042cf28600fee15df2504d5eed7ad380ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_8cae9996","line":7,"updated":"2016-02-05 10:55:02.000000000","message":"Please shorten the subject line to something like \u0027Create rabbitmq admin user for web administration\u0027.\n\nThen in the body of the commit message indicate what the patch is for, and why it\u0027s being done. Also indicate the inclusion of new variables:\n\n  rabbitmq_admin_user\n  rabbitmq_admin_password\n\nThis provides information for documentation purposes.","commit_id":"8724bd5a19670ed3a2d761b63cf9294fa6fb2c56"}],"defaults/main.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"f0094756b1918ac35ef4f134c98f502ac896753a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    state: enabled"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"rabbitmq_admin_user: admin"},{"line_number":55,"context_line":"rabbitmq_admin_password: secret"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# RabbitMQ SSL support"},{"line_number":58,"context_line":"rabbitmq_ssl_cert: /etc/rabbitmq/rabbitmq.pem"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_1716364c","line":55,"updated":"2016-02-05 11:10:35.000000000","message":"I think having a default password is a bad idea.","commit_id":"926383448935d2a67017a647563b2b15d9874556"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f13499765385f3056a4b1277b57decfdcecef755","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  - names: rabbitmq_management"},{"line_number":52,"context_line":"    state: enabled"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"rabbitmq_admin_user: admin"},{"line_number":55,"context_line":"rabbitmq_admin_password:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# RabbitMQ SSL support"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a5ae5dd_77082f92","line":54,"updated":"2016-02-09 15:45:50.000000000","message":"Add a comment above this line in order document the purpose of the variable.","commit_id":"b482a3bf3fb6c12cbacfb5b9e61aaf5a77f1a895"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f13499765385f3056a4b1277b57decfdcecef755","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    state: enabled"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"rabbitmq_admin_user: admin"},{"line_number":55,"context_line":"rabbitmq_admin_password:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# RabbitMQ SSL support"},{"line_number":58,"context_line":"rabbitmq_ssl_cert: /etc/rabbitmq/rabbitmq.pem"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a5ae5dd_f73bbf36","line":55,"updated":"2016-02-09 15:45:50.000000000","message":"Comment this line so that the var is not set at all by default, but the deployer can see that it\u0027s an option.","commit_id":"b482a3bf3fb6c12cbacfb5b9e61aaf5a77f1a895"}],"tasks/rabbitmq_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3e0f4160de47c606b7cb80d595087eb2743a0b76","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  tags:"},{"line_number":68,"context_line":"    - rabbitmq-user"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Create an admin user for the web interface "},{"line_number":71,"context_line":"  rabbitmq_user:"},{"line_number":72,"context_line":"    user: \"{{ rabbitmq_admin_user }}\""},{"line_number":73,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a5ae5dd_e9bcdf07","line":70,"updated":"2016-02-05 10:31:37.000000000","message":"nit: remove trailing whitespace","commit_id":"79977eb7fda151fa496d99a07e8a1465202b7265"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3e0f4160de47c606b7cb80d595087eb2743a0b76","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    configure_priv: \".*\""},{"line_number":77,"context_line":"    read_priv: \".*\""},{"line_number":78,"context_line":"    write_priv: \".*\""},{"line_number":79,"context_line":"  delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - rabbitmq-admin-user"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a5ae5dd_29751763","line":79,"updated":"2016-02-05 10:31:37.000000000","message":"Perhaps rather \u0027when: inventory_hostname \u003d\u003d groups[\u0027rabbitmq_all\u0027][0]\u0027 so that it only gets executed on one host once, rather than on all hosts delegated to the first?","commit_id":"79977eb7fda151fa496d99a07e8a1465202b7265"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"fe7d0ba14be643ea72901159d33f47ed04f0e765","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    configure_priv: \".*\""},{"line_number":77,"context_line":"    read_priv: \".*\""},{"line_number":78,"context_line":"    write_priv: \".*\""},{"line_number":79,"context_line":"  delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - rabbitmq-admin-user"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a5ae5dd_a906e783","line":79,"in_reply_to":"5a5ae5dd_29751763","updated":"2016-02-05 10:37:22.000000000","message":"Run once exists for this situation\n\nhttp://docs.ansible.com/ansible/playbooks_delegation.html#run-once","commit_id":"79977eb7fda151fa496d99a07e8a1465202b7265"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"53b5fd626f9c056207619c4bf6d1433ed007fa93","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    configure_priv: \".*\""},{"line_number":77,"context_line":"    read_priv: \".*\""},{"line_number":78,"context_line":"    write_priv: \".*\""},{"line_number":79,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027rabbitmq_all\u0027][0]"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - rabbitmq-admin-user"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a5ae5dd_ac911549","line":79,"updated":"2016-02-05 10:55:02.000000000","message":"run_once could be used, but I\u0027m ok with this as it\u0027s an existing pattern here - I\u0027d like us to decide on appropriate patterns and debate this thoroughly before making one or other pattern a hard and fast rule","commit_id":"8724bd5a19670ed3a2d761b63cf9294fa6fb2c56"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f13499765385f3056a4b1277b57decfdcecef755","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    configure_priv: \".*\""},{"line_number":78,"context_line":"    read_priv: \".*\""},{"line_number":79,"context_line":"    write_priv: \".*\""},{"line_number":80,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027rabbitmq_all\u0027][0] and rabbitmq_admin_password is defined"},{"line_number":81,"context_line":"  tags:"},{"line_number":82,"context_line":"    - rabbitmq-admin-user"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a5ae5dd_97e4cbac","line":80,"updated":"2016-02-09 15:45:50.000000000","message":"switch to list format, ie\n\n  when:\n    - inventory_hostname \u003d\u003d groups[\u0027rabbitmq_all\u0027][0]\n    - rabbitmq_admin_password is defined","commit_id":"b482a3bf3fb6c12cbacfb5b9e61aaf5a77f1a895"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"e8b183bc77653d19e584ec6d68d77b54f511ee0d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    configure_priv: \".*\""},{"line_number":78,"context_line":"    read_priv: \".*\""},{"line_number":79,"context_line":"    write_priv: \".*\""},{"line_number":80,"context_line":"  when: "},{"line_number":81,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027rabbitmq_all\u0027][0]"},{"line_number":82,"context_line":"    - rabbitmq_admin_password is defined"},{"line_number":83,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_8805497b","line":80,"updated":"2016-02-11 13:11:39.000000000","message":"Can you remove this unnecessary space here?","commit_id":"41e43b8b64febea79a854d64df4bfeb8056d541e"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"e8b183bc77653d19e584ec6d68d77b54f511ee0d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    write_priv: \".*\""},{"line_number":80,"context_line":"  when: "},{"line_number":81,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027rabbitmq_all\u0027][0]"},{"line_number":82,"context_line":"    - rabbitmq_admin_password is defined"},{"line_number":83,"context_line":"  tags:"},{"line_number":84,"context_line":"    - rabbitmq-admin-user"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_287455cd","line":82,"updated":"2016-02-11 13:11:39.000000000","message":"What if I just uncomment rabbitmq_admin_password but do not specify a password?  We probably need to ensure the password is a non-empty string.","commit_id":"41e43b8b64febea79a854d64df4bfeb8056d541e"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"018dfd9a6dc9f18d6a4f4f340bb37d5f0f9782fa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027rabbitmq_all\u0027][0]"},{"line_number":82,"context_line":"    - rabbitmq_admin_password is defined"},{"line_number":83,"context_line":"    - rabbitmq_admin_password is not none"},{"line_number":84,"context_line":"    - rabbitmq_admin_password | trim !\u003d \"\""},{"line_number":85,"context_line":"  tags:"},{"line_number":86,"context_line":"    - rabbitmq-admin-user"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bae84128_d1c64748","line":83,"updated":"2016-02-24 19:51:57.000000000","message":"this can be optimized, remove the \u0027is not none\u0027 line as that case is safely/sufficiently evaluated with the \u0027| trim !\u003d \"\"\u0027 test","commit_id":"0a5c1cd0fa3774dbfa21bb03ebb17354d7c8eff3"}]}