)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"be3ac11adce70c463857cc75ed2c841cf999ad62","unresolved":false,"context_lines":[{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of vars files to search for distro specific variables"},{"line_number":20,"context_line":"vars_files_var:"},{"line_number":21,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\""},{"line_number":22,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":23,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":24,"context_line":"  - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"  - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"rabbitmq_primary_cluster_node: \"{{ hostvars[groups[\u0027rabbitmq_all\u0027][0]][\u0027ansible_hostname\u0027] }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_451bae1b","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":41},"updated":"2016-05-13 17:52:08.000000000","message":"Instead of doing this, would it work to have default vars here for url, version, sha256, etc which use values by default in the vars files. This should allow the vars here to be overridden and do away with the extra set of vars files.","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"210ad86b56842bea55881028e019e87877b152da","unresolved":false,"context_lines":[{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of vars files to search for distro specific variables"},{"line_number":20,"context_line":"vars_files_var:"},{"line_number":21,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\""},{"line_number":22,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":23,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":24,"context_line":"  - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"  - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"rabbitmq_primary_cluster_node: \"{{ hostvars[groups[\u0027rabbitmq_all\u0027][0]][\u0027ansible_hostname\u0027] }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_882c8b4b","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":41},"in_reply_to":"dab17558_451bae1b","updated":"2016-05-13 18:24:30.000000000","message":"Not sure if I\u0027m understanding correctly.\nThe default vars would do a lookup within the distro specific var files and then tests would directly override the defaults?\n\nCould you provide an example?","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"de3f715e954889a5de08e38168a55a712aae9d8b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of vars files to search for distro specific variables"},{"line_number":20,"context_line":"vars_files_var:"},{"line_number":21,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\""},{"line_number":22,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":23,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":24,"context_line":"  - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"  - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"rabbitmq_primary_cluster_node: \"{{ hostvars[groups[\u0027rabbitmq_all\u0027][0]][\u0027ansible_hostname\u0027] }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_a8b98f7b","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":41},"in_reply_to":"dab17558_882c8b4b","updated":"2016-05-13 18:28:51.000000000","message":"Like this: https://gist.github.com/odyssey4me/122b8cd5cc2f0441eaf7169fba8d2afb","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"54ce3385c2226582867224862703de4d2ea8a2ed","unresolved":false,"context_lines":[{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of vars files to search for distro specific variables"},{"line_number":20,"context_line":"vars_files_var:"},{"line_number":21,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\""},{"line_number":22,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":23,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":24,"context_line":"  - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"  - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"rabbitmq_primary_cluster_node: \"{{ hostvars[groups[\u0027rabbitmq_all\u0027][0]][\u0027ansible_hostname\u0027] }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_aeb357e8","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":41},"in_reply_to":"dab17558_a8b98f7b","updated":"2016-05-13 19:06:19.000000000","message":"Done","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"994ca1606bc0ef1d7ec0dc3024e013380282bc8a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of vars files to search for distro specific variables"},{"line_number":20,"context_line":"vars_files_var:"},{"line_number":21,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\""},{"line_number":22,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":23,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":24,"context_line":"  - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"  - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"rabbitmq_primary_cluster_node: \"{{ hostvars[groups[\u0027rabbitmq_all\u0027][0]][\u0027ansible_hostname\u0027] }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"dab17558_cee7bbe2","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":41},"updated":"2016-05-13 19:11:23.000000000","message":"Is this needed now?","commit_id":"f1e2fcba2f397690620a7ce7486146ea67dd814f"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"12034c06583c3150132102420aecb9812eaa6f22","unresolved":false,"context_lines":[{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of vars files to search for distro specific variables"},{"line_number":20,"context_line":"vars_files_var:"},{"line_number":21,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\""},{"line_number":22,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":23,"context_line":"  - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":24,"context_line":"  - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"  - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"rabbitmq_primary_cluster_node: \"{{ hostvars[groups[\u0027rabbitmq_all\u0027][0]][\u0027ansible_hostname\u0027] }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"dab17558_d941470d","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":41},"in_reply_to":"dab17558_cee7bbe2","updated":"2016-05-13 19:28:21.000000000","message":"Oops, no. Can be removed.","commit_id":"f1e2fcba2f397690620a7ce7486146ea67dd814f"}],"other-requirements.txt":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"833d5d615095151ed2e5836244ac8ce5aa311d5f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# TODO(odyssey4me) remove this once https://review.openstack.org/288634 has merged"},{"line_number":15,"context_line":"# and the disk images are rebuilt and redeployed."},{"line_number":16,"context_line":"curl"},{"line_number":17,"context_line":"# Required for copy/file/template related functions in Ansible"},{"line_number":18,"context_line":"libselinux-python [platform:rpm]"}],"source_content_type":"text/plain","patch_set":18,"id":"1a122d0e_20bf08ab","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":32},"updated":"2016-04-20 13:41:19.000000000","message":"Is this only needed on the deployment host, or on the targets? If the targets, then we should include it in the package list for installation rather than here.","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f38ba91153902f85febdf7e4122ffbf000194abf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# TODO(odyssey4me) remove this once https://review.openstack.org/288634 has merged"},{"line_number":15,"context_line":"# and the disk images are rebuilt and redeployed."},{"line_number":16,"context_line":"curl"},{"line_number":17,"context_line":"# Required for copy/file/template related functions in Ansible"},{"line_number":18,"context_line":"libselinux-python [platform:rpm]"}],"source_content_type":"text/plain","patch_set":18,"id":"1a122d0e_af65adaf","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":32},"in_reply_to":"1a122d0e_20bf08ab","updated":"2016-04-28 23:54:12.000000000","message":"Still need to figure this out.\nIt\u0027ll be required on targets but, in testing, is required by the test-prepare-keys playbook before the actual role runs and may be a basic requirement of every CentOS host being deployed to (every role?).","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"}],"releasenotes/notes/deprecate-rabbitmq_apt_packages-b85ea1b449dc136e.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"be3ac11adce70c463857cc75ed2c841cf999ad62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The rabbitmq_apt_packages variable has been deprecated."},{"line_number":4,"context_line":"    rabbitmq_dependencies should be used instead to override"},{"line_number":5,"context_line":"    additional packages to install alongside rabbitmq-server."}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_05c5268d","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":29},"updated":"2016-05-13 17:52:08.000000000","message":"put `` on either side of the variable name","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"54ce3385c2226582867224862703de4d2ea8a2ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The rabbitmq_apt_packages variable has been deprecated."},{"line_number":4,"context_line":"    rabbitmq_dependencies should be used instead to override"},{"line_number":5,"context_line":"    additional packages to install alongside rabbitmq-server."}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_2ec0072a","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":29},"in_reply_to":"dab17558_05c5268d","updated":"2016-05-13 19:06:19.000000000","message":"Done","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"be3ac11adce70c463857cc75ed2c841cf999ad62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The rabbitmq_apt_packages variable has been deprecated."},{"line_number":4,"context_line":"    rabbitmq_dependencies should be used instead to override"},{"line_number":5,"context_line":"    additional packages to install alongside rabbitmq-server."}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_e5bf42fa","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":25},"updated":"2016-05-13 17:52:08.000000000","message":"put `` on either side of the variable name","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"54ce3385c2226582867224862703de4d2ea8a2ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The rabbitmq_apt_packages variable has been deprecated."},{"line_number":4,"context_line":"    rabbitmq_dependencies should be used instead to override"},{"line_number":5,"context_line":"    additional packages to install alongside rabbitmq-server."}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_8eddb316","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":25},"in_reply_to":"dab17558_e5bf42fa","updated":"2016-05-13 19:06:19.000000000","message":"Done","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"}],"tasks/install_apt.yml":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"173735dd701bc246f2e7fb1d816fb6d3b0132d9a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  until: install_packages|success"},{"line_number":39,"context_line":"  retries: 5"},{"line_number":40,"context_line":"  delay: 2"},{"line_number":41,"context_line":"  with_items: rabbitmq_packages"},{"line_number":42,"context_line":"  tags:"},{"line_number":43,"context_line":"    - rabbitmq-apt-packages"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5aef4532_ba199c8a","line":41,"updated":"2016-03-09 18:24:11.000000000","message":"Suggestion:  Perhaps rename this to something like rabbitmq_dependencies or similar.","commit_id":"b70a090497ebf095dddab24fd889e1d0f4120d1f"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"510e6d9c0aad3801b4ed8cf0beee64b84723acf3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  until: install_packages|success"},{"line_number":39,"context_line":"  retries: 5"},{"line_number":40,"context_line":"  delay: 2"},{"line_number":41,"context_line":"  with_items: rabbitmq_packages"},{"line_number":42,"context_line":"  tags:"},{"line_number":43,"context_line":"    - rabbitmq-apt-packages"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5aef4532_252e0443","line":41,"in_reply_to":"5aef4532_ba199c8a","updated":"2016-03-09 21:08:33.000000000","message":"Done","commit_id":"b70a090497ebf095dddab24fd889e1d0f4120d1f"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"29dcc1388666a80ee54e7ceaf386b0be4189f483","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  until: install_packages|success"},{"line_number":39,"context_line":"  retries: 5"},{"line_number":40,"context_line":"  delay: 2"},{"line_number":41,"context_line":"  with_items: \"{{ rabbitmq_dependencies | deprecated(rabbitmq_apt_packages, \u0027rabbitmq_apt_packages\u0027, \u0027rabbitmq_dependencies\u0027, \u0027Newton\u0027) }}\""},{"line_number":42,"context_line":"  tags:"},{"line_number":43,"context_line":"    - rabbitmq-apt-packages"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a18252c_f03bb4e9","line":41,"updated":"2016-04-12 18:39:49.000000000","message":"Here\u0027s where I attempted to deprecate rabbitmq_apt_packages.\nMy first time trying to use the filter, so not sure if I\u0027ve done it entirely correctly.","commit_id":"e7a371664ef652064bbaf0bfe9cbf45841ba8365"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"833d5d615095151ed2e5836244ac8ce5aa311d5f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  until: install_packages|success"},{"line_number":39,"context_line":"  retries: 5"},{"line_number":40,"context_line":"  delay: 2"},{"line_number":41,"context_line":"  with_items: \"{{ rabbitmq_dependencies | deprecated(rabbitmq_apt_packages, \u0027rabbitmq_apt_packages\u0027, \u0027rabbitmq_dependencies\u0027, \u0027Newton\u0027) }}\""},{"line_number":42,"context_line":"  tags:"},{"line_number":43,"context_line":"    - rabbitmq-apt-packages"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_404964cf","line":41,"range":{"start_line":41,"start_character":127,"end_line":41,"end_character":133},"updated":"2016-04-20 13:41:19.000000000","message":"I expect that we should deprecate this for one cycle, so the removal should happen in Ocata.","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f38ba91153902f85febdf7e4122ffbf000194abf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  until: install_packages|success"},{"line_number":39,"context_line":"  retries: 5"},{"line_number":40,"context_line":"  delay: 2"},{"line_number":41,"context_line":"  with_items: \"{{ rabbitmq_dependencies | deprecated(rabbitmq_apt_packages, \u0027rabbitmq_apt_packages\u0027, \u0027rabbitmq_dependencies\u0027, \u0027Newton\u0027) }}\""},{"line_number":42,"context_line":"  tags:"},{"line_number":43,"context_line":"    - rabbitmq-apt-packages"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_924d7640","line":41,"range":{"start_line":41,"start_character":127,"end_line":41,"end_character":133},"in_reply_to":"1a122d0e_404964cf","updated":"2016-04-28 23:54:12.000000000","message":"Done","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"}],"tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"85ee29f04945920bd2ee8bced5432d46a4889fb1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found: \"{{ vars_files_var }}\""},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - always"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: rabbitmq_pre_install.yml"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_20582132","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":12},"updated":"2016-05-09 10:08:40.000000000","message":"Why the change in pattern? Why is this better than what\u0027s been done in all other roles?","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"019f58a1f086c2709aa1bb238d1f006a9076f5a7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found: \"{{ vars_files_var }}\""},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - always"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: rabbitmq_pre_install.yml"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_e45f3b3f","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":12},"in_reply_to":"dab17558_20582132","updated":"2016-05-09 17:10:38.000000000","message":"This was done to make upgrade testing work.\nThe test playbook needs to include a var file with an earlier package version, but the this file overwrites it with this task.\n\nhttps://review.openstack.org/#/c/286282/33/tests/test.yml is where vars_files_var is passed to use tests/vars/.\n\nOpen to other ways of handling this, it\u0027s not the most intuitive thing.","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"994ca1606bc0ef1d7ec0dc3024e013380282bc8a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found: \"{{ vars_files_var }}\""},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - always"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: rabbitmq_pre_install.yml"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":39,"id":"dab17558_cefe9b6a","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":12},"updated":"2016-05-13 19:11:23.000000000","message":"This should be able to revert to the more standard:\n\n- name: Gather variables for each operating system\n  include_vars: \"{{ item }}\"\n  with_first_found:\n    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\"\n    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\"\n    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\"\n    - \"{{ ansible_distribution | lower }}.yml\"\n    - \"{{ ansible_os_family | lower }}.yml\"\n  tags:\n    - always","commit_id":"f1e2fcba2f397690620a7ce7486146ea67dd814f"}],"tasks/rabbitmq_upgrade_check.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"833d5d615095151ed2e5836244ac8ce5aa311d5f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  failed_when: false"},{"line_number":20,"context_line":"  register: installed_rabbitmq_deb"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    not rabbitmq_upgrade | bool and"},{"line_number":23,"context_line":"    ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":24,"context_line":"  tags:"},{"line_number":25,"context_line":"    - rabbitmq-package-deb"},{"line_number":26,"context_line":"    - rabbitmq-apt-packages"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_601e2071","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":28},"updated":"2016-04-20 13:41:19.000000000","message":"This can be expressed like this:\n\n    - not rabbitmq_upgrade | bool\n    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f38ba91153902f85febdf7e4122ffbf000194abf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  failed_when: false"},{"line_number":20,"context_line":"  register: installed_rabbitmq_deb"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    not rabbitmq_upgrade | bool and"},{"line_number":23,"context_line":"    ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":24,"context_line":"  tags:"},{"line_number":25,"context_line":"    - rabbitmq-package-deb"},{"line_number":26,"context_line":"    - rabbitmq-apt-packages"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_72489a2d","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":28},"in_reply_to":"1a122d0e_601e2071","updated":"2016-04-28 23:54:12.000000000","message":"Done","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"833d5d615095151ed2e5836244ac8ce5aa311d5f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rpm -qa | grep rabbitmq-server"},{"line_number":31,"context_line":"  failed_when: false"},{"line_number":32,"context_line":"  register: installed_rabbitmq_rpm"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"    not rabbitmq_upgrade | bool and"},{"line_number":35,"context_line":"    ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - rabbitmq-package-rpm"},{"line_number":38,"context_line":"    - rabbitmq-apt-packages"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_541da564","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"updated":"2016-04-20 13:41:19.000000000","message":"As above","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f38ba91153902f85febdf7e4122ffbf000194abf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rpm -qa | grep rabbitmq-server"},{"line_number":31,"context_line":"  failed_when: false"},{"line_number":32,"context_line":"  register: installed_rabbitmq_rpm"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"    not rabbitmq_upgrade | bool and"},{"line_number":35,"context_line":"    ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - rabbitmq-package-rpm"},{"line_number":38,"context_line":"    - rabbitmq-apt-packages"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_d2536ee0","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"in_reply_to":"1a122d0e_541da564","updated":"2016-04-28 23:54:12.000000000","message":"Done","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"833d5d615095151ed2e5836244ac8ce5aa311d5f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  fail:"},{"line_number":50,"context_line":"    msg: \"To install a new major/minor version of RabbitMQ set \u0027-e rabbitmq_upgrade\u003dtrue\u0027.\""},{"line_number":51,"context_line":"  when: \u003e"},{"line_number":52,"context_line":"    not rabbitmq_upgrade | bool and"},{"line_number":53,"context_line":"    installed_rabbitmq.rc \u003d\u003d 0 and"},{"line_number":54,"context_line":"    not installed_rabbitmq.stdout | search(rabbitmq_package_version)"},{"line_number":55,"context_line":"  tags:"},{"line_number":56,"context_line":"    - rabbitmq-package-deb"},{"line_number":57,"context_line":"    - rabbitmq-package-rpm"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_d41ff558","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":68},"updated":"2016-04-20 13:41:19.000000000","message":"As above","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f38ba91153902f85febdf7e4122ffbf000194abf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  fail:"},{"line_number":50,"context_line":"    msg: \"To install a new major/minor version of RabbitMQ set \u0027-e rabbitmq_upgrade\u003dtrue\u0027.\""},{"line_number":51,"context_line":"  when: \u003e"},{"line_number":52,"context_line":"    not rabbitmq_upgrade | bool and"},{"line_number":53,"context_line":"    installed_rabbitmq.rc \u003d\u003d 0 and"},{"line_number":54,"context_line":"    not installed_rabbitmq.stdout | search(rabbitmq_package_version)"},{"line_number":55,"context_line":"  tags:"},{"line_number":56,"context_line":"    - rabbitmq-package-deb"},{"line_number":57,"context_line":"    - rabbitmq-package-rpm"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_b24eb235","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":68},"in_reply_to":"1a122d0e_d41ff558","updated":"2016-04-28 23:54:12.000000000","message":"Done","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"be3ac11adce70c463857cc75ed2c841cf999ad62","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - not rabbitmq_upgrade | bool"},{"line_number":53,"context_line":"    - installed_rabbitmq.rc \u003d\u003d 0"},{"line_number":54,"context_line":"    - not installed_rabbitmq.stdout | search(rabbitmq_package_version)"},{"line_number":55,"context_line":"  tags:"},{"line_number":56,"context_line":"    - rabbitmq-package-deb"},{"line_number":57,"context_line":"    - rabbitmq-package-rpm"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_e56d829a","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":70},"updated":"2016-05-13 17:52:08.000000000","message":"Do we potentially lose a degree of accuracy here versus the previous method?","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"78cd69a3aac50951fd71db23b4fdbb2c61f9fe62","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - not rabbitmq_upgrade | bool"},{"line_number":53,"context_line":"    - installed_rabbitmq.rc \u003d\u003d 0"},{"line_number":54,"context_line":"    - not installed_rabbitmq.stdout | search(rabbitmq_package_version)"},{"line_number":55,"context_line":"  tags:"},{"line_number":56,"context_line":"    - rabbitmq-package-deb"},{"line_number":57,"context_line":"    - rabbitmq-package-rpm"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_ee90bf50","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":70},"in_reply_to":"dab17558_484c6370","updated":"2016-05-13 19:03:56.000000000","message":"That\u0027s what it was.\n\nubuntu:\nii  rabbitmq-server                    3.5.7-1                         all          AMQP server written in Erlang\n\ncentos:\nrabbitmq-server-3.5.7-1.noarch\n\nSearch is for the version to upgrade to, so shouldn\u0027t be an issue.","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"210ad86b56842bea55881028e019e87877b152da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - not rabbitmq_upgrade | bool"},{"line_number":53,"context_line":"    - installed_rabbitmq.rc \u003d\u003d 0"},{"line_number":54,"context_line":"    - not installed_rabbitmq.stdout | search(rabbitmq_package_version)"},{"line_number":55,"context_line":"  tags:"},{"line_number":56,"context_line":"    - rabbitmq-package-deb"},{"line_number":57,"context_line":"    - rabbitmq-package-rpm"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_484c6370","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":70},"in_reply_to":"dab17558_e56d829a","updated":"2016-05-13 18:24:30.000000000","message":"I think this was done because of the different output between ubuntu and centos, if the index didn\u0027t exist it would fail the task.\nWill do some testing to confirm that.","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"33ee7b6bf72a41dcbf41ef1ec97733b27fc40484","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - not rabbitmq_upgrade | bool"},{"line_number":53,"context_line":"    - installed_rabbitmq.rc \u003d\u003d 0"},{"line_number":54,"context_line":"    - not installed_rabbitmq.stdout | search(rabbitmq_package_version)"},{"line_number":55,"context_line":"  tags:"},{"line_number":56,"context_line":"    - rabbitmq-package-deb"},{"line_number":57,"context_line":"    - rabbitmq-package-rpm"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"dab17558_ae9cf75d","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":70},"in_reply_to":"dab17558_ee90bf50","updated":"2016-05-13 19:05:08.000000000","message":"Great, thanks for verifying!","commit_id":"29a60b587c84ec5511bf2e8782218031d0194fac"}],"tests/group_vars/all_containers.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"85ee29f04945920bd2ee8bced5432d46a4889fb1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"container_name: \"{{ inventory_hostname }}\""},{"line_number":18,"context_line":"container_networks:"},{"line_number":19,"context_line":"  management_address:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_c085d559","side":"PARENT","line":16,"updated":"2016-05-09 10:08:40.000000000","message":"The line deletion seems unnecessary?","commit_id":"d036e44e533118f98bfd7ced92c218a27347f975"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"019f58a1f086c2709aa1bb238d1f006a9076f5a7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"container_name: \"{{ inventory_hostname }}\""},{"line_number":18,"context_line":"container_networks:"},{"line_number":19,"context_line":"  management_address:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_2450235d","side":"PARENT","line":16,"in_reply_to":"dab17558_c085d559","updated":"2016-05-09 17:10:38.000000000","message":"All other files keep 1 line of separation after the license, think the extra line was added accidentally in I6aa877b10945a265d7484c9aacb3c232d82d8ebb","commit_id":"d036e44e533118f98bfd7ced92c218a27347f975"}],"tests/test-container-create.yml":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"fed47d2855b4047ddc0ae67afa71e2f3a07e1d89","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\","},{"line_number":24,"context_line":"        \"vars/{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"      ]"},{"line_number":26,"context_line":"    - \"vars/{{ ansible_os_family | lower }}.yml\""},{"line_number":27,"context_line":"  pre_tasks:"},{"line_number":28,"context_line":"    - name: Destroy test containers"},{"line_number":29,"context_line":"      lxc_container:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a061dce_15cbd51f","line":26,"updated":"2016-04-08 14:25:37.000000000","message":"What is the intension here?  The above fails on CentOS because the first item finds nothing.","commit_id":"e7a371664ef652064bbaf0bfe9cbf45841ba8365"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"29dcc1388666a80ee54e7ceaf386b0be4189f483","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\","},{"line_number":24,"context_line":"        \"vars/{{ ansible_distribution | lower }}.yml\""},{"line_number":25,"context_line":"      ]"},{"line_number":26,"context_line":"    - \"vars/{{ ansible_os_family | lower }}.yml\""},{"line_number":27,"context_line":"  pre_tasks:"},{"line_number":28,"context_line":"    - name: Destroy test containers"},{"line_number":29,"context_line":"      lxc_container:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a18252c_50a8a81f","line":26,"in_reply_to":"9a061dce_15cbd51f","updated":"2016-04-12 18:39:49.000000000","message":"This was put in place for a future CentOS 7 specific file that would provide lxc_container_caches, similar to https://review.openstack.org/#/c/286282/14/tests/vars/ubuntu-trusty.yml","commit_id":"e7a371664ef652064bbaf0bfe9cbf45841ba8365"}],"tests/test-install-rabbitmq-server.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"85ee29f04945920bd2ee8bced5432d46a4889fb1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  gather_facts: true"},{"line_number":20,"context_line":"  roles:"},{"line_number":21,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":22,"context_line":"  post_tasks:"},{"line_number":23,"context_line":"    - include: test-rabbitmq-server-functional.yml"},{"line_number":24,"context_line":"  vars_files:"},{"line_number":25,"context_line":"    - test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_00cebdb3","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":50},"updated":"2016-05-09 10:08:40.000000000","message":"Can this include be done from the main test meta-playbook instead of from here? It makes the flow easier to follow.","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"019f58a1f086c2709aa1bb238d1f006a9076f5a7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  gather_facts: true"},{"line_number":20,"context_line":"  roles:"},{"line_number":21,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":22,"context_line":"  post_tasks:"},{"line_number":23,"context_line":"    - include: test-rabbitmq-server-functional.yml"},{"line_number":24,"context_line":"  vars_files:"},{"line_number":25,"context_line":"    - test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_c4cdd75e","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":50},"in_reply_to":"dab17558_00cebdb3","updated":"2016-05-09 17:10:38.000000000","message":"Done","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"}],"tests/test-prepare-host.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"1f7a6b009b04e594c68780c6a754aec7af2fca34","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }"},{"line_number":48,"context_line":"          - { src: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027, dest: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027 }"},{"line_number":49,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":50,"context_line":"      when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":51,"context_line":"    - name: Determine the existing Ubuntu repo configuration"},{"line_number":52,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":53,"context_line":"      register: ubuntu_repo"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1a122d0e_1d2e57a5","line":50,"updated":"2016-05-02 18:00:36.000000000","message":"have a second \u0027when\u0027 here","commit_id":"e95063ab0846462929800d23f87935a101291d04"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"85ee29f04945920bd2ee8bced5432d46a4889fb1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Perform basic LXC host setup"},{"line_number":18,"context_line":"  hosts: localhost"},{"line_number":19,"context_line":"  connection: local"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Ensure apt cache is always refreshed"},{"line_number":22,"context_line":"      apt:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_604ce942","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":19},"updated":"2016-05-09 10:08:40.000000000","message":"This shouldn\u0027t be necessary if the inventory is correct.","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"019f58a1f086c2709aa1bb238d1f006a9076f5a7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Perform basic LXC host setup"},{"line_number":18,"context_line":"  hosts: localhost"},{"line_number":19,"context_line":"  connection: local"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Ensure apt cache is always refreshed"},{"line_number":22,"context_line":"      apt:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_a4d253d0","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":19},"in_reply_to":"dab17558_604ce942","updated":"2016-05-09 17:10:38.000000000","message":"Done","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"85ee29f04945920bd2ee8bced5432d46a4889fb1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      stat:"},{"line_number":34,"context_line":"        path: /etc/nodepool/provider"},{"line_number":35,"context_line":"      register: nodepool"},{"line_number":36,"context_line":"    - name: Set the default files to copy into the container cache for OpenStack-CI instances"},{"line_number":37,"context_line":"      set_fact:"},{"line_number":38,"context_line":"        lxc_container_cache_files:"},{"line_number":39,"context_line":"          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }"},{"line_number":40,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":41,"context_line":"    - name: Set a fact for file to disable GPG signature checking of apt sources for OpenStack-CI instances"},{"line_number":42,"context_line":"      set_fact:"},{"line_number":43,"context_line":"        apt_disable_gpg_checking:"},{"line_number":44,"context_line":"          - { src: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027, dest: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027 }"},{"line_number":45,"context_line":"      when:"},{"line_number":46,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":47,"context_line":"        - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":48,"context_line":"    - name: Update the files to copy into the container cache for OpenStack-CI instances"},{"line_number":49,"context_line":"      set_fact:"},{"line_number":50,"context_line":"        lxc_container_cache_files:"},{"line_number":51,"context_line":"          \"{{ lxc_container_cache_files + apt_disable_gpg_checking }}\""},{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":54,"context_line":"        - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":55,"context_line":"    - name: Determine the existing Ubuntu repo configuration"},{"line_number":56,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":57,"context_line":"      register: ubuntu_repo"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_a01b711a","line":54,"range":{"start_line":36,"start_character":0,"end_line":54,"end_character":34},"updated":"2016-05-09 10:08:40.000000000","message":"This is a rather laborious way of doing what could be done in two tasks:\n\n    - name: Set the files to copy into the container cache for OpenStack-CI instances (deb)\n      set_fact:\n        lxc_container_cache_files:\n          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }\n          - { src: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027, dest: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027 }\n      when:\n        - nodepool.stat.exists | bool\n        - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027\n\n    - name: Set the files to copy into the container cache for OpenStack-CI instances (deb)\n      set_fact:\n        lxc_container_cache_files:\n          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }\n      when:\n        - nodepool.stat.exists | bool\n        - ansible_pkg_mgr \u003d\u003d \u0027yum\u0027","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"019f58a1f086c2709aa1bb238d1f006a9076f5a7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      stat:"},{"line_number":34,"context_line":"        path: /etc/nodepool/provider"},{"line_number":35,"context_line":"      register: nodepool"},{"line_number":36,"context_line":"    - name: Set the default files to copy into the container cache for OpenStack-CI instances"},{"line_number":37,"context_line":"      set_fact:"},{"line_number":38,"context_line":"        lxc_container_cache_files:"},{"line_number":39,"context_line":"          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }"},{"line_number":40,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":41,"context_line":"    - name: Set a fact for file to disable GPG signature checking of apt sources for OpenStack-CI instances"},{"line_number":42,"context_line":"      set_fact:"},{"line_number":43,"context_line":"        apt_disable_gpg_checking:"},{"line_number":44,"context_line":"          - { src: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027, dest: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027 }"},{"line_number":45,"context_line":"      when:"},{"line_number":46,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":47,"context_line":"        - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":48,"context_line":"    - name: Update the files to copy into the container cache for OpenStack-CI instances"},{"line_number":49,"context_line":"      set_fact:"},{"line_number":50,"context_line":"        lxc_container_cache_files:"},{"line_number":51,"context_line":"          \"{{ lxc_container_cache_files + apt_disable_gpg_checking }}\""},{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":54,"context_line":"        - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":55,"context_line":"    - name: Determine the existing Ubuntu repo configuration"},{"line_number":56,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":57,"context_line":"      register: ubuntu_repo"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"dab17558_84d58fba","line":54,"range":{"start_line":36,"start_character":0,"end_line":54,"end_character":34},"in_reply_to":"dab17558_a01b711a","updated":"2016-05-09 17:10:38.000000000","message":"Done","commit_id":"737f772fea223890e095ba4f1c5db799cd4add37"}],"tests/test-prepare-keys.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"833d5d615095151ed2e5836244ac8ce5aa311d5f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create ssh key pairs for use with containers"},{"line_number":17,"context_line":"  hosts: 127.0.0.1"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: false"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Create ssh key pair for root"},{"line_number":22,"context_line":"      user:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_34b46933","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":15},"updated":"2016-04-20 13:41:19.000000000","message":"Check https://github.com/openstack/openstack-ansible-os_nova/blob/master/tests/test-prepare-keys.yml for an updated way of doing this which requires the inventory to be done right.","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f38ba91153902f85febdf7e4122ffbf000194abf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create ssh key pairs for use with containers"},{"line_number":17,"context_line":"  hosts: 127.0.0.1"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: false"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Create ssh key pair for root"},{"line_number":22,"context_line":"      user:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_325902fe","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":15},"in_reply_to":"1a122d0e_34b46933","updated":"2016-04-28 23:54:12.000000000","message":"Rebased on https://review.openstack.org/#/c/310965 to get this review more focused and in a better starting place as far as the layout of test playbooks go.","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"}],"tests/test.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"994ca1606bc0ef1d7ec0dc3024e013380282bc8a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Install previous version of RabbitMQ server"},{"line_number":39,"context_line":"- include: test-install-rabbitmq-server.yml"},{"line_number":40,"context_line":"  vars_files:"},{"line_number":41,"context_line":"    - ["},{"line_number":42,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\","},{"line_number":43,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\","},{"line_number":44,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\","},{"line_number":45,"context_line":"        \"vars/{{ ansible_distribution | lower }}.yml\","},{"line_number":46,"context_line":"        \"vars/{{ ansible_os_family | lower }}.yml\""},{"line_number":47,"context_line":"      ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Run tests"},{"line_number":50,"context_line":"- include: test-rabbitmq-server-functional.yml"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"dab17558_2ef80749","line":47,"range":{"start_line":40,"start_character":0,"end_line":47,"end_character":7},"updated":"2016-05-13 19:11:23.000000000","message":"Is this still needed? You should now be able to override the defaults with a dict map held in test-vars.yml then use those vars here as overrides.","commit_id":"f1e2fcba2f397690620a7ce7486146ea67dd814f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c131a79d754dd2ea117ffc67659c7ab0facd43bc","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Install previous version of RabbitMQ server"},{"line_number":39,"context_line":"- include: test-install-rabbitmq-server.yml"},{"line_number":40,"context_line":"  vars_files:"},{"line_number":41,"context_line":"    - ["},{"line_number":42,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\","},{"line_number":43,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\","},{"line_number":44,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\","},{"line_number":45,"context_line":"        \"vars/{{ ansible_distribution | lower }}.yml\","},{"line_number":46,"context_line":"        \"vars/{{ ansible_os_family | lower }}.yml\""},{"line_number":47,"context_line":"      ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Run tests"},{"line_number":50,"context_line":"- include: test-rabbitmq-server-functional.yml"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"dab17558_79777b9f","line":47,"range":{"start_line":40,"start_character":0,"end_line":47,"end_character":7},"in_reply_to":"dab17558_2ef80749","updated":"2016-05-13 19:20:13.000000000","message":"I was thinking something along the lines of what I\u0027ve put into the updated gist: https://gist.github.com/odyssey4me/122b8cd5cc2f0441eaf7169fba8d2afb","commit_id":"f1e2fcba2f397690620a7ce7486146ea67dd814f"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"12034c06583c3150132102420aecb9812eaa6f22","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Install previous version of RabbitMQ server"},{"line_number":39,"context_line":"- include: test-install-rabbitmq-server.yml"},{"line_number":40,"context_line":"  vars_files:"},{"line_number":41,"context_line":"    - ["},{"line_number":42,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\","},{"line_number":43,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\","},{"line_number":44,"context_line":"        \"vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\","},{"line_number":45,"context_line":"        \"vars/{{ ansible_distribution | lower }}.yml\","},{"line_number":46,"context_line":"        \"vars/{{ ansible_os_family | lower }}.yml\""},{"line_number":47,"context_line":"      ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Run tests"},{"line_number":50,"context_line":"- include: test-rabbitmq-server-functional.yml"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"dab17558_39ffb3ab","line":47,"range":{"start_line":40,"start_character":0,"end_line":47,"end_character":7},"in_reply_to":"dab17558_79777b9f","updated":"2016-05-13 19:28:21.000000000","message":"That should work, left it for some future case of needing to override test vars for specific distro release.\nMuch better to keep it simple and contained in test-vars though.","commit_id":"f1e2fcba2f397690620a7ce7486146ea67dd814f"}],"tests/vars/centos-7.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"833d5d615095151ed2e5836244ac8ce5aa311d5f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Replace with CentOS 7 lxc cache image location details when available"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# lxc_container_caches:"},{"line_number":19,"context_line":"#   - url: "},{"line_number":20,"context_line":"#     name:"},{"line_number":21,"context_line":"#     sha256sum:"},{"line_number":22,"context_line":"#     chroot_path: centos7/rootfs-amd64"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_54e7653f","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":11},"updated":"2016-04-20 13:41:19.000000000","message":"whitespace","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f38ba91153902f85febdf7e4122ffbf000194abf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Replace with CentOS 7 lxc cache image location details when available"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# lxc_container_caches:"},{"line_number":19,"context_line":"#   - url: "},{"line_number":20,"context_line":"#     name:"},{"line_number":21,"context_line":"#     sha256sum:"},{"line_number":22,"context_line":"#     chroot_path: centos7/rootfs-amd64"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_f262eaab","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":11},"in_reply_to":"1a122d0e_54e7653f","updated":"2016-04-28 23:54:12.000000000","message":"Done","commit_id":"cfe1a47bc5e5125b8eb946007828696eb542cb1e"}]}