)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e1e56d2414d3509abd5c7ba0fda39ab2bee4508b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92d913dc_fc6c490a","updated":"2023-11-10 16:50:26.000000000","message":"1 small nit, but it\u0027s good.","commit_id":"e46cf7c9889885a48720aafb2b66bc9a6750e55f"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"6ddd58b7ff573ad2f9de3ad50075400927bd57cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"901c4ae4_e4bd42ec","updated":"2023-11-07 08:57:49.000000000","message":"Thanks for the review. I have added a feature release note to the docs as well as the default variable. In addition to these changes I have renamed the variable from `rabbitmq_custom_config` to `rabbitmq_additional_config` to make it more clear for what purpose the variable can be used. Let me know what you think","commit_id":"e46cf7c9889885a48720aafb2b66bc9a6750e55f"}],"doc/source/configure-rabbitmq.rst":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7e6ff2c7ad292e1c1df653bed1d17b46a6cf0497","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c896338b_67123388","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":0},"updated":"2023-11-06 12:26:38.000000000","message":"I would also encourage to have that in form of native ansible dict, like we do for other services, ie:\n```\n   rabbitmq_custom_config:\n      prometheus.tcp.port: 15680\n      prometheus.tcp.ip: 0.0.0.0\n```","commit_id":"d679f33bf9fbbe9444e4ca3b70abca143776950d"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"6ddd58b7ff573ad2f9de3ad50075400927bd57cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3816a72_27a28854","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":0},"in_reply_to":"c896338b_67123388","updated":"2023-11-07 08:57:49.000000000","message":"Done","commit_id":"d679f33bf9fbbe9444e4ca3b70abca143776950d"}],"templates/rabbitmq.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e58e3af6f7081555e0fd359b79a9ffd2ae2c6210","unresolved":true,"context_lines":[{"line_number":75,"context_line":"management.tcp.port \u003d {{ rabbitmq_management_bind_tcp_port }}"},{"line_number":76,"context_line":"{% endif %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% if rabbitmq_custom_config is defined %}"},{"line_number":79,"context_line":"# Custom configuration"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"{{ rabbitmq_custom_config }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d0d66505_ef7987fb","line":78,"range":{"start_line":78,"start_character":6,"end_line":78,"end_character":28},"updated":"2023-11-06 08:01:59.000000000","message":"can you also kindly:\n* add this variable also to the defaults/main.yml\n* change condition from `is defined` to checking length\n* preferably add a \"feature\" release note to mention the variable\n\nthanks in advance!","commit_id":"d679f33bf9fbbe9444e4ca3b70abca143776950d"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"6ddd58b7ff573ad2f9de3ad50075400927bd57cd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"management.tcp.port \u003d {{ rabbitmq_management_bind_tcp_port }}"},{"line_number":76,"context_line":"{% endif %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% if rabbitmq_custom_config is defined %}"},{"line_number":79,"context_line":"# Custom configuration"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"{{ rabbitmq_custom_config }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b7d878e7_58a1c494","line":78,"range":{"start_line":78,"start_character":6,"end_line":78,"end_character":28},"in_reply_to":"d0d66505_ef7987fb","updated":"2023-11-07 08:57:49.000000000","message":"Done","commit_id":"d679f33bf9fbbe9444e4ca3b70abca143776950d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e1e56d2414d3509abd5c7ba0fda39ab2bee4508b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"management.tcp.port \u003d {{ rabbitmq_management_bind_tcp_port }}"},{"line_number":76,"context_line":"{% endif %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% if rabbitmq_additional_config | length \u003e 0 %}"},{"line_number":79,"context_line":"# Custom configuration"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"{% for config_key, config_value in rabbitmq_additional_config.items() %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1cac4fe6_74aa7c8f","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":48},"updated":"2023-11-10 16:50:26.000000000","message":"nit: I think you actually don\u0027t need this {% if %} - by default it\u0027s an empty dict, thus it\u0027s kinda safe to just iterate over it (as there will be no result anyway).","commit_id":"e46cf7c9889885a48720aafb2b66bc9a6750e55f"}]}