)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4fc86bee636adf393453049c4fa3a37ed36b7991","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"151ac631_52fd6f84","updated":"2023-12-04 17:07:10.000000000","message":"recheck centos","commit_id":"83d8ec2a3049e81c8cdb07acc97f16ab2d57e08e"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"fc28e0f84a678e5adb7a9edc23b44c2b1685d39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6ee7c078_634d46f9","updated":"2023-11-30 08:02:08.000000000","message":"recheck rocky","commit_id":"83d8ec2a3049e81c8cdb07acc97f16ab2d57e08e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c7c7b0b58488a4c5041cbe1a6b53885694233055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8e09102c_07199eb3","updated":"2023-12-01 10:33:19.000000000","message":"recheck rocky","commit_id":"83d8ec2a3049e81c8cdb07acc97f16ab2d57e08e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d9396096264f7288448411897ad49f3fbf3d5f78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"182a00a8_e98dec81","updated":"2023-12-04 08:54:48.000000000","message":"recheck rocky failure","commit_id":"83d8ec2a3049e81c8cdb07acc97f16ab2d57e08e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1da56cf3b4c848923de64880cf707aea7640745a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"634e3324_26fe062a","updated":"2023-12-05 08:28:14.000000000","message":"recheck rocky failure","commit_id":"83d8ec2a3049e81c8cdb07acc97f16ab2d57e08e"}],"defaults/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c90e8dfd8e3ba3a45dff243b892d1dede1f859a6","unresolved":true,"context_lines":[{"line_number":154,"context_line":"rabbitmq_pki_intermediate_cert_path: \u003e-"},{"line_number":155,"context_line":"  {{ rabbitmq_pki_dir ~ \u0027/roots/\u0027 ~ rabbitmq_pki_intermediate_cert_name ~ \u0027/certs/\u0027 ~ rabbitmq_pki_intermediate_cert_name ~ \u0027.crt\u0027 }}"},{"line_number":156,"context_line":"rabbitmq_pki_regen_cert: \u0027\u0027"},{"line_number":157,"context_line":"rabbitmq_pki_certificates:"},{"line_number":158,"context_line":"  - name: \"rabbitmq_{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":159,"context_line":"    provider: ownca"},{"line_number":160,"context_line":"    cn: \"{{ ansible_facts[\u0027hostname\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a6116ce_66f6948f","line":157,"updated":"2023-11-15 10:14:16.000000000","message":"is any change required here to put the long name / fqdn in the certificate, instead of the hostname?","commit_id":"18fe603821f618b38cbe61dee6d36142617d55cd"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"fc2c197deb028fe0bcdf931f6b4e911f75f071ca","unresolved":true,"context_lines":[{"line_number":154,"context_line":"rabbitmq_pki_intermediate_cert_path: \u003e-"},{"line_number":155,"context_line":"  {{ rabbitmq_pki_dir ~ \u0027/roots/\u0027 ~ rabbitmq_pki_intermediate_cert_name ~ \u0027/certs/\u0027 ~ rabbitmq_pki_intermediate_cert_name ~ \u0027.crt\u0027 }}"},{"line_number":156,"context_line":"rabbitmq_pki_regen_cert: \u0027\u0027"},{"line_number":157,"context_line":"rabbitmq_pki_certificates:"},{"line_number":158,"context_line":"  - name: \"rabbitmq_{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":159,"context_line":"    provider: ownca"},{"line_number":160,"context_line":"    cn: \"{{ ansible_facts[\u0027hostname\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b08ed55d_f5cf446a","line":157,"in_reply_to":"02360621_d778cc10","updated":"2023-11-15 13:05:19.000000000","message":"The FQDN should be in the san, your right. Is it a possibility to add the fqdn to the san instead of an if condition to check if the fqdn is used? This would have the change that the san contains the hostname, the ip and the fqdn of the host","commit_id":"18fe603821f618b38cbe61dee6d36142617d55cd"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8966cf410b261c1867a9bd2f82ca0a7e736bf0e0","unresolved":true,"context_lines":[{"line_number":154,"context_line":"rabbitmq_pki_intermediate_cert_path: \u003e-"},{"line_number":155,"context_line":"  {{ rabbitmq_pki_dir ~ \u0027/roots/\u0027 ~ rabbitmq_pki_intermediate_cert_name ~ \u0027/certs/\u0027 ~ rabbitmq_pki_intermediate_cert_name ~ \u0027.crt\u0027 }}"},{"line_number":156,"context_line":"rabbitmq_pki_regen_cert: \u0027\u0027"},{"line_number":157,"context_line":"rabbitmq_pki_certificates:"},{"line_number":158,"context_line":"  - name: \"rabbitmq_{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":159,"context_line":"    provider: ownca"},{"line_number":160,"context_line":"    cn: \"{{ ansible_facts[\u0027hostname\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"02360621_d778cc10","line":157,"in_reply_to":"3a6116ce_66f6948f","updated":"2023-11-15 10:15:58.000000000","message":"yeah. true, worth adding fqdn to the SAN indeed I guess","commit_id":"18fe603821f618b38cbe61dee6d36142617d55cd"}],"templates/rabbitmq-env.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"33eddfc51c804b1a166cc5852bb64872affdd664","unresolved":true,"context_lines":[{"line_number":5,"context_line":"RABBITMQ_IO_THREAD_POOL_SIZE\u003d{{ rabbitmq_async_threads }}"},{"line_number":6,"context_line":"RABBITMQ_SERVER_ERL_ARGS\u003d\"+P {{ rabbitmq_process_limit }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"USE_LONGNAMES\u003d{{ rabbitmq_env_use_longnames | lower }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if rabbitmq_erlang_extra_args %}"},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"{{ rabbitmq_erlang_extra_args }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ac05f29b_416ac2da","line":8,"range":{"start_line":8,"start_character":44,"end_line":8,"end_character":51},"updated":"2023-11-15 08:25:35.000000000","message":"maybe it\u0027s worth to add `| bool | lower`? As the values could be also 1, yes, no, 0, etc","commit_id":"6e8d0392bb3fb954dad221bea13c907085b38dcf"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"e24b6a5c1b88b617126e52b732faeacb020c2699","unresolved":false,"context_lines":[{"line_number":5,"context_line":"RABBITMQ_IO_THREAD_POOL_SIZE\u003d{{ rabbitmq_async_threads }}"},{"line_number":6,"context_line":"RABBITMQ_SERVER_ERL_ARGS\u003d\"+P {{ rabbitmq_process_limit }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"USE_LONGNAMES\u003d{{ rabbitmq_env_use_longnames | lower }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if rabbitmq_erlang_extra_args %}"},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"{{ rabbitmq_erlang_extra_args }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a64e448a_cc880492","line":8,"range":{"start_line":8,"start_character":44,"end_line":8,"end_character":51},"in_reply_to":"ac05f29b_416ac2da","updated":"2023-11-15 08:36:32.000000000","message":"Good pick. Thanks.","commit_id":"6e8d0392bb3fb954dad221bea13c907085b38dcf"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"8eab3e806764001e8bbba21146adae4f3ff0c161","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Set ERLANG VM parameters"},{"line_number":4,"context_line":"NODENAME\u003drabbit@{{ ansible_facts[\u0027hostname\u0027] }}"},{"line_number":5,"context_line":"RABBITMQ_IO_THREAD_POOL_SIZE\u003d{{ rabbitmq_async_threads }}"},{"line_number":6,"context_line":"RABBITMQ_SERVER_ERL_ARGS\u003d\"+P {{ rabbitmq_process_limit }}\""},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"c45242e8_d975247e","line":4,"updated":"2023-11-16 08:22:20.000000000","message":"Should the NODENAME then also be set to the FQDN if the LONGNAMES are used?","commit_id":"349a318a2e0211e6d7a113c5f0bec556db071e73"}]}