)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cd8b268087364ea8043e51e5182c83a7354156f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b0e32b9_16b6a450","updated":"2023-12-07 11:05:27.000000000","message":"I think that is waaaaaay bigger topic, as right now all logging for all services are assumed to ideally end up in journald.\n\nWhile it makes sense to do it configurable, we pretty much need to do so everywhere.","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"03a8001d5a8deeccfb6de6c38eaf9845be1c5577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78880cb4_dc786c66","updated":"2024-01-16 13:45:14.000000000","message":"LGTM","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"f0149b562f2c236a554f8da3d1908722b0cfaf94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b1632fa_34ba5f5a","updated":"2024-02-09 07:37:09.000000000","message":"recheck","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"2cd78e09981d382b3f39ccc775b3124626c3871a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9e8848d_8e4ef994","updated":"2024-01-31 08:36:27.000000000","message":"recheck","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"65a2dd0e9b955c59158dc690e21934b2d82258e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a187d1f5_408919b3","in_reply_to":"0b0e32b9_16b6a450","updated":"2023-12-07 12:30:30.000000000","message":"OK. What about a change to add only additional logging options and keep the log.journald \u003d true as a \"hardcoded\" value which cannot be changed by any configuration\nWould that be a more acceptable and smaller change? Or where should this topic about logging configuration be discussed?","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"f4b550597c0b2106b1d6da195fa25a777a087ef1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85ffb9ab_b253a7f3","in_reply_to":"6287c23c_51e4a44a","updated":"2023-12-14 07:51:22.000000000","message":"For my need I want to configure the rabbitmq-server to log to a file and use the builtin features like logrotation of the server. This logmethod is currently default.","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"622d7816d19a95e937a3720eba01e2b859640a5e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e2fbaf98_c4ebeae9","in_reply_to":"85ffb9ab_b253a7f3","updated":"2023-12-15 17:24:57.000000000","message":"So, what is the usecase you\u0027ve described for the value is not being boolean then? I was just thinking it\u0027s for smth else rather then journald/file.\n\nwell, rotation of journald is also builtin feature for pretty much all OS (except docker images that do not have systemd)... But ok, maybe there is some reason for filelog usage I just don\u0027t see.","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"917ee19a63557c47ef79fcb91eed4c8fa1ee60d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6287c23c_51e4a44a","in_reply_to":"a187d1f5_408919b3","updated":"2023-12-11 09:07:02.000000000","message":"Can you elaborate a bit more about what logging way you\u0027re looking to add right now?\nI\u0027m not saying that this patch is not acceptable though, just more trying to understand needs more and if we actually need to have that logging topic for other services as well.\n\nAbout discussion part - we held a regular IRC meetings on OFTC network in #openstack-ansible channel every Tuesday at 15:00 UTC.\nAnd folks hanging out in channel outside of this time as well, so feel free to join and fire up questions whenever needed.","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"5cc130c744d3f1b7afa1243aeda0e2901199c155","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c19af7f9_612afc1e","in_reply_to":"e2fbaf98_c4ebeae9","updated":"2024-01-11 08:04:59.000000000","message":"Sorry for the late response.\n\nJournald and file are just two logging configurations available for the rabbitmq-server with more complex details (see https://www.rabbitmq.com/logging.html), as well as the ability to configure multiple logging systems.\n\nA more specific use case is, from my experience, the migration from openstack-puppet to openstack-ansible, while running the same cloud. You want as little change to the system as possible. This cannot be achieved for every little detail but in my opinion logging should not be a part of such a change.","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"}],"templates/rabbitmq.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"57d482e2995036e48acd059f7293f806b2e7cab0","unresolved":true,"context_lines":[{"line_number":2,"context_line":"collect_statistics_interval \u003d {{ rabbitmq_collect_statistics_interval }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% for key, value in rabbitmq_log.items() %}"},{"line_number":5,"context_line":"{% if value is boolean %}"},{"line_number":6,"context_line":"log.{{ key }} \u003d {{ value | lower }}"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"log.{{ key }} \u003d {{ value }}"},{"line_number":9,"context_line":"{% endif%}"},{"line_number":10,"context_line":"{% endfor %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"heartbeat \u003d 640"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f17f94cf_14b6718a","line":9,"range":{"start_line":5,"start_character":0,"end_line":9,"end_character":10},"updated":"2024-01-03 10:26:55.000000000","message":"Can we probably simplify this to\n\n`log.{{ key }} \u003d {{ (value is truthy) | ternary(\u0027true\u0027, \u0027false\u0027) }}`","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"03a8001d5a8deeccfb6de6c38eaf9845be1c5577","unresolved":false,"context_lines":[{"line_number":2,"context_line":"collect_statistics_interval \u003d {{ rabbitmq_collect_statistics_interval }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% for key, value in rabbitmq_log.items() %}"},{"line_number":5,"context_line":"{% if value is boolean %}"},{"line_number":6,"context_line":"log.{{ key }} \u003d {{ value | lower }}"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"log.{{ key }} \u003d {{ value }}"},{"line_number":9,"context_line":"{% endif%}"},{"line_number":10,"context_line":"{% endfor %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"heartbeat \u003d 640"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"11a89571_ea53564b","line":9,"range":{"start_line":5,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"9cdc4dfb_fb659339","updated":"2024-01-16 13:45:14.000000000","message":"Oh, ok, now I see what specifically you meant.","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"5cc130c744d3f1b7afa1243aeda0e2901199c155","unresolved":true,"context_lines":[{"line_number":2,"context_line":"collect_statistics_interval \u003d {{ rabbitmq_collect_statistics_interval }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% for key, value in rabbitmq_log.items() %}"},{"line_number":5,"context_line":"{% if value is boolean %}"},{"line_number":6,"context_line":"log.{{ key }} \u003d {{ value | lower }}"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"log.{{ key }} \u003d {{ value }}"},{"line_number":9,"context_line":"{% endif%}"},{"line_number":10,"context_line":"{% endfor %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"heartbeat \u003d 640"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9cdc4dfb_fb659339","line":9,"range":{"start_line":5,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"f17f94cf_14b6718a","updated":"2024-01-11 08:04:59.000000000","message":"Just looking at the documentation for the file logging of the rabbitmq server (https://www.rabbitmq.com/logging.html#logging-to-a-file) I think it is not possible to change this in the suggested simplified way.\nSince the keys can also contains values as strings, like file path, log-levels, formats and so on, from my testing the truthy function also evaluates just the strings as true and does not set the value itself. So it is also not possible to change the \"if value is boolean\".\nPlease correct me if I am wrong","commit_id":"d10da56560c850e3f05dcfa858f0f773b9b198c4"}]}