)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bf2c8826d62c521af96f37e003e6ca97e517c8e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fbc52222_dbb953af","updated":"2024-11-12 17:40:33.000000000","message":"I do recall I removed flags","commit_id":"9847546fe1490abfd626a4c9a98c939a7811174a"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"22e79b1f032932bf773ea67ca15f882e680aee25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f23b328_2ee29799","updated":"2024-11-12 10:07:42.000000000","message":"I\u0027ve given this a try and it seems to work well. The only thing I noted is that we no longer appear to enable feature flags post-upgrade, but only before. That\u0027s not an issue necessarily, but we had originally done this in both places to ensure deployments could run with them turned on for a while to check for any issues.","commit_id":"9847546fe1490abfd626a4c9a98c939a7811174a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bf2c8826d62c521af96f37e003e6ca97e517c8e6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5d328cdf_b99a5315","in_reply_to":"1f23b328_2ee29799","updated":"2024-11-12 17:40:33.000000000","message":"I wonder why? As I have not touched https://opendev.org/openstack/openstack-ansible-rabbitmq_server/src/branch/master/tasks/main.yml#L85-L111 which should execute it? At least not here?","commit_id":"9847546fe1490abfd626a4c9a98c939a7811174a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e0ee94f1408d8609621d98214616bf3c151f12f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"84bb908a_9b40a9a2","in_reply_to":"5d328cdf_b99a5315","updated":"2024-11-12 17:42:23.000000000","message":"Was you checking it together with https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/931905 ?","commit_id":"9847546fe1490abfd626a4c9a98c939a7811174a"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"3dd3a4317993bc390816dd077a71ec22ea9e75e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d161ae88_9f20d63c","in_reply_to":"84bb908a_9b40a9a2","updated":"2024-11-13 08:37:50.000000000","message":"I\u0027ve re-checked and feature flags do get enabled. I just missed them because they were marked as \u0027ok\u0027 rather than \u0027changed\u0027. Given the extra checks you\u0027ve implemented, perhaps we could remove the \u0027changed_when: False\u0027 from https://opendev.org/openstack/openstack-ansible-rabbitmq_server/src/branch/master/tasks/rabbitmq_feature_flags.yml#L26 ? The note above the task isn\u0027t valid anymore because experimental flags get excluded.","commit_id":"9847546fe1490abfd626a4c9a98c939a7811174a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bdd07984167bf5097e65a86d4e326cfecbc3759c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5c300454_10fd1cc9","in_reply_to":"d161ae88_9f20d63c","updated":"2024-11-13 11:55:19.000000000","message":"yeah, probably makes sense. but then we need to add skip-lint as ansible-lint doesn\u0027t like commands without changed_when.","commit_id":"9847546fe1490abfd626a4c9a98c939a7811174a"}]}