)]}'
{"tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"206f5b08abc8ff4f7edbaf3b31847c5aa0e92623","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - always"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Check init system"},{"line_number":26,"context_line":"  command: cat /proc/1/comm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_67ec2d90","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":12},"updated":"2016-05-24 13:53:47.000000000","message":"This task should be changed like so: \n\n- name: Gather variables for each operating system\n  include_vars: \"{{ item }}\"\n  with_first_found:\n    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\"\n    - \"{{ ansible_distribution | lower }}.yml\"\n    - \"{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split(\u0027.\u0027)[0] }}.yml\"\n    - \"{{ ansible_os_family | lower }}.yml\"\n  tags:\n    - always\n\nThis is the pattern that ensure we the role can source a variable file using the distro name without or without an exact distribution version or the family with or without the major distribution version. This is the pattern being used in all of the roles we have which support ubuntu14/16.04, and RHEL7.","commit_id":"5791b078d2dac63df8cc982898c6159349594409"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"95ecc5cb7819d0844ed49f403f9e4c673076b28f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - always"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Check init system"},{"line_number":26,"context_line":"  command: cat /proc/1/comm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9abb7d3a_87b5f132","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":12},"in_reply_to":"9abb7d3a_5d3de38d","updated":"2016-06-02 11:24:09.000000000","message":"I\u0027m fine with that.\nThey were three patterns overall the repos:\nThe one from this commit, the one above from kevin, and this one:\n- \"{{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }}.yml\"\n- \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\"\n- \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\"\n- \"{{ ansible_distribution | lower }}.yml\"\n- \"{{ ansible_os_family | lower }}.yml\"\n\nGo for Kevin\u0027s ?","commit_id":"5791b078d2dac63df8cc982898c6159349594409"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4efd6f7f221dbd431e722ad9162c4cd17eaafb44","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - always"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Check init system"},{"line_number":26,"context_line":"  command: cat /proc/1/comm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9abb7d3a_c207e77f","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":12},"in_reply_to":"9abb7d3a_87b5f132","updated":"2016-06-02 11:50:51.000000000","message":"This one seems like it will fit the needs. We need to ensure that CentOS/RHEL can have a shared, versioned var file (ie CentOS-7, RHEL-7) share the same var file. If that is covered by this last list, then I think it\u0027s a much cleaner and more flexible list.","commit_id":"5791b078d2dac63df8cc982898c6159349594409"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"903323bb8a191a6831931d6c85b31b6b683ac669","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - always"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Check init system"},{"line_number":26,"context_line":"  command: cat /proc/1/comm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9abb7d3a_5d3de38d","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":12},"in_reply_to":"bab6814e_67ec2d90","updated":"2016-06-01 09:38:39.000000000","message":"Can we change all the roles to the version suggested by Kevin above. It appears that is the appropriate standard.","commit_id":"5791b078d2dac63df8cc982898c6159349594409"}]}