)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"5f6980167093d52e39ec13097666f6e0db6f2259","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c207a099_9eda0e75","updated":"2022-04-14 20:07:43.000000000","message":"jsu","commit_id":"2202a33e1775de3a40673113b7a7023b167c3211"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"49d495265054feb8cf6056ad181594dc4fa9b568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9e5fdc2b_f3dd9d9e","updated":"2022-04-25 15:19:24.000000000","message":"recheck - ansible-sshd SHA has been updated","commit_id":"c966363bd44f0e9032b35406d75fa61d46aad3cb"}],"defaults/main.yml":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"5f6980167093d52e39ec13097666f6e0db6f2259","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Temporary variable to disable sync manager installation when transtioning to a"},{"line_number":91,"context_line":"# shared filesystem"},{"line_number":92,"context_line":"repo_server_enable_sync_manager: True"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Multiple repo servers must have a shared /var/www/repo"},{"line_number":95,"context_line":"repo_server_systemd_mounts: []"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"24c4f405_703ca7bd","line":92,"updated":"2022-04-14 20:07:43.000000000","message":"The comment says it disables sync manager, while it actually enables it.\n\nbut it\u0027s probably not important when the variable is removed later on.\n(just don\u0027t forget to remove it from openstack-ansible main repo as well please, I don\u0027t see any change for its removal in main repo)","commit_id":"2202a33e1775de3a40673113b7a7023b167c3211"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1a15f4f72ffcb3ee317a5368c232758d8d862ec2","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Temporary variable to disable sync manager installation when transtioning to a"},{"line_number":91,"context_line":"# shared filesystem"},{"line_number":92,"context_line":"repo_server_enable_sync_manager: True"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Multiple repo servers must have a shared /var/www/repo"},{"line_number":95,"context_line":"repo_server_systemd_mounts: []"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a4519e3_7efdaf6e","line":92,"in_reply_to":"0a63177a_adaea005","updated":"2022-04-19 11:10:51.000000000","message":"Done","commit_id":"2202a33e1775de3a40673113b7a7023b167c3211"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c205afdeb4041899d4ac720ea2b8cf4d06235c84","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Temporary variable to disable sync manager installation when transtioning to a"},{"line_number":91,"context_line":"# shared filesystem"},{"line_number":92,"context_line":"repo_server_enable_sync_manager: True"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Multiple repo servers must have a shared /var/www/repo"},{"line_number":95,"context_line":"repo_server_systemd_mounts: []"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0a63177a_adaea005","line":92,"in_reply_to":"24c4f405_703ca7bd","updated":"2022-04-14 21:43:56.000000000","message":"Oh I see - the wording is unclear I agree, you\u0027re right though, this variable will will be removed in a future patch. Its really just here to enable things to merge in a sensible order without breaking everything.","commit_id":"2202a33e1775de3a40673113b7a7023b167c3211"}],"tasks/repo_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8504f528d850927bfcc3ad2951408ef51e526a97","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    name: systemd_mount"},{"line_number":71,"context_line":"  vars:"},{"line_number":72,"context_line":"    systemd_mounts: \"{{ repo_server_systemd_mounts }}\""},{"line_number":73,"context_line":"  when: (groups[\u0027repo_all\u0027] | length) \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8bcf0f5f_592b6ea7","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":41},"updated":"2022-04-12 15:26:31.000000000","message":"and when repo_server_systemd_mounts | length \u003e 0 ?","commit_id":"10a0158f0abc135525ae909b7ad02a339a7aef25"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"7402ac5cd0971b160106035e20582ea4ca916b6c","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    name: systemd_mount"},{"line_number":71,"context_line":"  vars:"},{"line_number":72,"context_line":"    systemd_mounts: \"{{ repo_server_systemd_mounts }}\""},{"line_number":73,"context_line":"  when: (groups[\u0027repo_all\u0027] | length) \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff711f83_e901e774","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":41},"in_reply_to":"8bcf0f5f_592b6ea7","updated":"2022-04-12 15:40:07.000000000","message":"yeah good point - perhaps we can use the glusterfs mount on all AIO even with just one repo server, would get better test coverage like that","commit_id":"10a0158f0abc135525ae909b7ad02a339a7aef25"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"f36614adad937e1441ead19cf6d04ae32ee97a99","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    name: systemd_mount"},{"line_number":71,"context_line":"  vars:"},{"line_number":72,"context_line":"    systemd_mounts: \"{{ repo_server_systemd_mounts }}\""},{"line_number":73,"context_line":"  when: (groups[\u0027repo_all\u0027] | length) \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6b039f90_7bfed53f","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":41},"in_reply_to":"ff711f83_e901e774","updated":"2022-04-12 15:46:05.000000000","message":"Done","commit_id":"10a0158f0abc135525ae909b7ad02a339a7aef25"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c205afdeb4041899d4ac720ea2b8cf4d06235c84","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  notify:"},{"line_number":66,"context_line":"    - reload nginx"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: Mount any remote volumes"},{"line_number":69,"context_line":"  include_role:"},{"line_number":70,"context_line":"    name: systemd_mount"},{"line_number":71,"context_line":"  vars:"},{"line_number":72,"context_line":"    systemd_mounts: \"{{ repo_server_systemd_mounts }}\""},{"line_number":73,"context_line":"  when: repo_server_systemd_mounts | length \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"78c29c26_a08ca8c3","line":73,"range":{"start_line":68,"start_character":0,"end_line":73,"end_character":47},"updated":"2022-04-14 21:43:56.000000000","message":"this should be in the pre-install so that the mount point is ready for the directories to be created, otherwise they are made on the host then over-mounted","commit_id":"1659f63cb62c2f6a5b55073c004f75d390a675b5"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"3acf491c15a06e20a49c242043412d04f05cce76","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  notify:"},{"line_number":66,"context_line":"    - reload nginx"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: Mount any remote volumes"},{"line_number":69,"context_line":"  include_role:"},{"line_number":70,"context_line":"    name: systemd_mount"},{"line_number":71,"context_line":"  vars:"},{"line_number":72,"context_line":"    systemd_mounts: \"{{ repo_server_systemd_mounts }}\""},{"line_number":73,"context_line":"  when: repo_server_systemd_mounts | length \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ceab596d_9308551e","line":73,"range":{"start_line":68,"start_character":0,"end_line":73,"end_character":47},"in_reply_to":"78c29c26_a08ca8c3","updated":"2022-04-20 06:55:31.000000000","message":"Done","commit_id":"1659f63cb62c2f6a5b55073c004f75d390a675b5"}],"tasks/repo_pre_install.yml":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"5f6980167093d52e39ec13097666f6e0db6f2259","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    createhome: \"yes\""},{"line_number":30,"context_line":"    home: \"{{ repo_service_home_folder }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Mount any remote volumes"},{"line_number":33,"context_line":"  include_role:"},{"line_number":34,"context_line":"    name: systemd_mount"},{"line_number":35,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4e1932f5_4b4684fe","line":32,"updated":"2022-04-14 20:07:43.000000000","message":"just so You know, when running this playbook twice, task \u0027Set the state of the mount\u0027 fails with error, because gluster FUSE doesn\u0027t support remounts(journald shows \u0027Invalid option remount\u0027).\n\nThis task is rescued later so it\u0027s not a big deal and we can live with it. Just writing it here as You may have some idea how to fix it.","commit_id":"2202a33e1775de3a40673113b7a7023b167c3211"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"3acf491c15a06e20a49c242043412d04f05cce76","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    createhome: \"yes\""},{"line_number":30,"context_line":"    home: \"{{ repo_service_home_folder }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Mount any remote volumes"},{"line_number":33,"context_line":"  include_role:"},{"line_number":34,"context_line":"    name: systemd_mount"},{"line_number":35,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c7ff78ff_2d8abc40","line":32,"in_reply_to":"198c2f3d_310d7098","updated":"2022-04-20 06:55:31.000000000","message":"Done","commit_id":"2202a33e1775de3a40673113b7a7023b167c3211"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c205afdeb4041899d4ac720ea2b8cf4d06235c84","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    createhome: \"yes\""},{"line_number":30,"context_line":"    home: \"{{ repo_service_home_folder }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Mount any remote volumes"},{"line_number":33,"context_line":"  include_role:"},{"line_number":34,"context_line":"    name: systemd_mount"},{"line_number":35,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"198c2f3d_310d7098","line":32,"in_reply_to":"4e1932f5_4b4684fe","updated":"2022-04-14 21:43:56.000000000","message":"Yes I\u0027d seen that - I\u0027ve not yet looked if there is a change we can make to the systemd_mount role to prevent that happening.\n\nThe playbook does succeed though with the block/rescue?","commit_id":"2202a33e1775de3a40673113b7a7023b167c3211"}]}