)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"458d95cda91cce697e698c835c0196ef1c962172","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9504c64_6415923e","updated":"2023-04-04 07:26:05.000000000","message":"recheck","commit_id":"2aecebce3472d998ab802ca4d2ed73f094e4af16"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"b5ecb0a089370a9428a02531f86a16e27d8d89de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0c82ab6_5c6e0ba8","updated":"2023-04-04 17:35:59.000000000","message":"recheck - +W this without seeing the unmerged dependancy","commit_id":"2aecebce3472d998ab802ca4d2ed73f094e4af16"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c54d7995bca55de5c163e622e58489d33fe1b8d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dfef3002_d83473d0","updated":"2023-04-25 20:25:27.000000000","message":"LGTM","commit_id":"33becd8ccbb1150b0b13dc5e7cd1fb59d3e58528"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"f24689a598bd40a7508c30e6c06a6a81ed94b9c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b4132132_e973e209","updated":"2023-04-28 11:29:22.000000000","message":"recheck - rocky failed to retrieve u-c","commit_id":"2d0e465fd3bab22790213993eecafa6727785924"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"ec8fa4b64911863727d1e2a83f439ff7fcb19885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2ced5d51_3a209bf3","updated":"2023-04-28 09:28:46.000000000","message":"small correction:\n\nI realized that /etc/repo directory does not exist by default so I changed certs directories to /etc/ssl/certs and /etc/ssl/private","commit_id":"2d0e465fd3bab22790213993eecafa6727785924"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3cfe892673a51d280f8e6227d8d6f5a277bd8227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"95deb7a7_2ac36b2f","in_reply_to":"2ced5d51_3a209bf3","updated":"2023-04-28 09:46:31.000000000","message":"I think that pki role does handle directory creation? https://opendev.org/openstack/ansible-role-pki/src/branch/master/tasks/main_certs.yml#L53\n\nanyway","commit_id":"2d0e465fd3bab22790213993eecafa6727785924"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"9783e390044c413066c59a5363ef2c2a5a51cc03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fcb52afb_b16bdd7b","in_reply_to":"95deb7a7_2ac36b2f","updated":"2023-04-28 10:30:23.000000000","message":"yes, it worked before.\n\nI just realized that it doesn\u0027t make much sense to create a new directory only to store certificates there when we have another, more suitable place to store them.\n\nFor other roles that use webservers(horizon and keystone) we also store certificates in /etc/ssl","commit_id":"2d0e465fd3bab22790213993eecafa6727785924"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b0b19937afdcdade9ddffb8512178308847c632e","unresolved":true,"context_lines":[{"line_number":69,"context_line":"repo_backend_ssl: \"{{ openstack_service_backend_ssl | default(False) }}\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Storage location for SSL certificate authority"},{"line_number":72,"context_line":"repo_pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# Delegated host for operating the certificate authority"},{"line_number":75,"context_line":"repo_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"00bbf929_d40c3518","line":72,"range":{"start_line":72,"start_character":18,"end_line":72,"end_character":35},"updated":"2023-04-24 14:59:25.000000000","message":"I think we should have default for this?","commit_id":"386b680d42d4cfba8c37fae5597a342f35897c90"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"ee1eae8ed26b10338a98d5beb96b7c5d6f08c418","unresolved":false,"context_lines":[{"line_number":69,"context_line":"repo_backend_ssl: \"{{ openstack_service_backend_ssl | default(False) }}\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Storage location for SSL certificate authority"},{"line_number":72,"context_line":"repo_pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# Delegated host for operating the certificate authority"},{"line_number":75,"context_line":"repo_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"20260b11_8615a275","line":72,"range":{"start_line":72,"start_character":18,"end_line":72,"end_character":35},"in_reply_to":"00bbf929_d40c3518","updated":"2023-04-24 22:09:05.000000000","message":"fixed(here and in other roles)","commit_id":"386b680d42d4cfba8c37fae5597a342f35897c90"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b0b19937afdcdade9ddffb8512178308847c632e","unresolved":true,"context_lines":[{"line_number":75,"context_line":"repo_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The local address used for the repo node"},{"line_number":78,"context_line":"repo_node_address: \"{{ management_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# repo server certificate"},{"line_number":81,"context_line":"repo_pki_keys_path: \"{{ repo_pki_dir ~ \u0027/certs/private/\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba86394b_5ac67c55","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":68},"updated":"2023-04-24 14:59:25.000000000","message":"I think it\u0027s kinda the same as repo_server_bind_address?","commit_id":"386b680d42d4cfba8c37fae5597a342f35897c90"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"ee1eae8ed26b10338a98d5beb96b7c5d6f08c418","unresolved":false,"context_lines":[{"line_number":75,"context_line":"repo_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The local address used for the repo node"},{"line_number":78,"context_line":"repo_node_address: \"{{ management_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# repo server certificate"},{"line_number":81,"context_line":"repo_pki_keys_path: \"{{ repo_pki_dir ~ \u0027/certs/private/\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d92c35da_b4fd87f0","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":68},"in_reply_to":"ba86394b_5ac67c55","updated":"2023-04-24 22:09:05.000000000","message":"fixed(here and in other roles)","commit_id":"386b680d42d4cfba8c37fae5597a342f35897c90"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b0b19937afdcdade9ddffb8512178308847c632e","unresolved":true,"context_lines":[{"line_number":80,"context_line":"# repo server certificate"},{"line_number":81,"context_line":"repo_pki_keys_path: \"{{ repo_pki_dir ~ \u0027/certs/private/\u0027 }}\""},{"line_number":82,"context_line":"repo_pki_certs_path: \"{{ repo_pki_dir ~ \u0027/certs/certs/\u0027 }}\""},{"line_number":83,"context_line":"repo_pki_intermediate_cert_name: \"{{ openstack_pki_service_intermediate_cert_name }}\""},{"line_number":84,"context_line":"repo_pki_intermediate_cert_path: \"{{ repo_pki_dir ~ \u0027/roots/\u0027 ~ repo_pki_intermediate_cert_name ~ \u0027/certs/\u0027 ~ repo_pki_intermediate_cert_name ~ \u0027.crt\u0027 }}\""},{"line_number":85,"context_line":"repo_pki_regen_cert: \u0027\u0027"},{"line_number":86,"context_line":"repo_pki_certificates:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9de54b98_3d2ea55b","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":81},"updated":"2023-04-24 14:59:25.000000000","message":"ditto","commit_id":"386b680d42d4cfba8c37fae5597a342f35897c90"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"ee1eae8ed26b10338a98d5beb96b7c5d6f08c418","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# repo server certificate"},{"line_number":81,"context_line":"repo_pki_keys_path: \"{{ repo_pki_dir ~ \u0027/certs/private/\u0027 }}\""},{"line_number":82,"context_line":"repo_pki_certs_path: \"{{ repo_pki_dir ~ \u0027/certs/certs/\u0027 }}\""},{"line_number":83,"context_line":"repo_pki_intermediate_cert_name: \"{{ openstack_pki_service_intermediate_cert_name }}\""},{"line_number":84,"context_line":"repo_pki_intermediate_cert_path: \"{{ repo_pki_dir ~ \u0027/roots/\u0027 ~ repo_pki_intermediate_cert_name ~ \u0027/certs/\u0027 ~ repo_pki_intermediate_cert_name ~ \u0027.crt\u0027 }}\""},{"line_number":85,"context_line":"repo_pki_regen_cert: \u0027\u0027"},{"line_number":86,"context_line":"repo_pki_certificates:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"26091530_b571a352","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":81},"in_reply_to":"9de54b98_3d2ea55b","updated":"2023-04-24 22:09:05.000000000","message":"fixed(here and in other roles)","commit_id":"386b680d42d4cfba8c37fae5597a342f35897c90"}]}