)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3a6e017b236c8d3176b09306c0b030de71e544c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Gugino \u003cmichael.gugino@walmart.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-04 09:54:59 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Multi-distro support for rsyslog-server role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is intended to serve as an example of how we"},{"line_number":10,"context_line":"might be able to implement a single role for use in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_abb97130","line":7,"updated":"2016-02-10 08:46:36.000000000","message":"I think we\u0027re ready to remove the WIP now. There is a CentOS gate check that passes for this. :)","commit_id":"f3dce8b78405682dc16e9cca8ee2b3b32d6a51ea"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3a6e017b236c8d3176b09306c0b030de71e544c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Multi-distro support for rsyslog-server role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is intended to serve as an example of how we"},{"line_number":10,"context_line":"might be able to implement a single role for use in"},{"line_number":11,"context_line":"multiple distors.  I have tested these changes with"},{"line_number":12,"context_line":"Ubuntu 14.04 as well as CentOS 7.  I ran this role"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_eb968993","line":9,"updated":"2016-02-10 08:46:36.000000000","message":"The commit message can be updated to reflect what this is - an implementation of a pattern for Multi-OS Support which includes only CentOS for now.","commit_id":"f3dce8b78405682dc16e9cca8ee2b3b32d6a51ea"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"564671289e8242b536116acfb527262e40cbd71d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is intended to serve as an example of how we"},{"line_number":10,"context_line":"might be able to implement a single role for use in"},{"line_number":11,"context_line":"multiple distors.  I have tested these changes with"},{"line_number":12,"context_line":"Ubuntu 14.04 as well as CentOS 7.  I ran this role"},{"line_number":13,"context_line":"directly, outside of openstack-ansible, but I do not"},{"line_number":14,"context_line":"anticipate many changes to this role, only that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_1ff7f659","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":16},"updated":"2016-02-07 23:00:00.000000000","message":"distros","commit_id":"f3dce8b78405682dc16e9cca8ee2b3b32d6a51ea"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f779cc059cd754d399d1227f26eee414ed388602","unresolved":false,"context_lines":[{"line_number":21,"context_line":"have been provided.  The included \u0027families\u0027 are \u0027debian\u0027 and \u0027redhat\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This allows for support of distros other than Ubuntu and CentOS, such"},{"line_number":24,"context_line":"as Debian and Fedora, more easily in the future."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I78c8c3be9d00fc505fabc83de36dfd43b8e85848"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_f6154b49","line":24,"updated":"2016-03-08 17:54:01.000000000","message":"Can we add meta information in this patch too for the updated support matric. An example is here: https://github.com/bennojoy/mysql/blob/master/meta/main.yml#L7-L22","commit_id":"d452f84928d210a80444ba6f3a3ef8330ad2aae7"}],"README.rst":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"99563031d2b105dba157392045cff4a66857f959","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Role to deploy rsyslog for use within OpenStack when deploying services using"},{"line_number":7,"context_line":"containers."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Distro Support:  Ubuntu 14.04, EL 7."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. code-block:: yaml"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_f90ffb2b","line":9,"updated":"2016-03-08 18:12:27.000000000","message":"nit: \u0027Linux Distribution Support\u0027","commit_id":"a79694ea5b3d9d0f65c27b0d572a379610e696d3"}],"defaults/main.yml":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"dfc3bbac88a4462cd8ef75a733088f14e9d11105","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   - { repo: \"ppa:adiscon/v8-stable\", state: \"present\" }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#We create a dictionary of distros in case there are name descrepancies."},{"line_number":20,"context_line":"rsyslog_apt_distros:"},{"line_number":21,"context_line":"  Ubuntu: \"{{ rsyslog_server_apt_packages }}\""},{"line_number":22,"context_line":"  Debian: \"{{ rsyslog_server_apt_packages }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"rsyslog_yum_distros:"},{"line_number":25,"context_line":"  CentOS: \"{{ rsyslog_server_yum_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_7d989fc0","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":45},"updated":"2016-01-29 23:32:51.000000000","message":"I feel this format will allow us to more easily add distros later.","commit_id":"9a39e191cb1454a1b07d2972d54d792c73319e4a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ff64e05531f61bbc7319891cb9cd2cc129a5d452","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  - rsyslog"},{"line_number":31,"context_line":"  - logrotate"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"rsyslog_server_yum_packages:"},{"line_number":34,"context_line":"  - rsyslog"},{"line_number":35,"context_line":"  - logrotate"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_687f3be0","line":33,"updated":"2016-02-01 18:22:46.000000000","message":"This seems to me to make the use of overrides less user friendly. If the package list var name is consistent between platforms then we don\u0027t have to know the platform/installer in order to know which var to override.\n\nThis is why the bootstrap-host role implements a vars file per platform:\n\nhttps://github.com/openstack/openstack-ansible/blob/master/tests/roles/bootstrap-host/vars/ubuntu.yml\n\nhttps://github.com/openstack/openstack-ansible/blob/master/tests/roles/bootstrap-host/tasks/main.yml#L21-L30","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# rsyslog_server_apt_repos:"},{"line_number":17,"context_line":"#   - { repo: \"ppa:adiscon/v8-stable\", state: \"present\" }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"rsyslog_server_packages:"},{"line_number":20,"context_line":"  - rsyslog"},{"line_number":21,"context_line":"  - logrotate"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_fa2cda4b","line":19,"updated":"2016-02-04 11:53:06.000000000","message":"While in this particular case the package names may be the same across all supported distributions, I\u0027d prefer to establish a pattern assuming that they aren\u0027t. As such I think the package list should be in the vars.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"}],"tasks/install-yum.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# yum-based distors"},{"line_number":17,"context_line":"- name: Rsyslog yum repository"},{"line_number":18,"context_line":"  template:"},{"line_number":19,"context_line":"    src: yumrepo.conf.j2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_4782f795","line":16,"updated":"2016-02-04 11:53:06.000000000","message":"nit: spelling error, although I think this comment can just be removed entirely.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":29,"context_line":"- name: yum clean all"},{"line_number":30,"context_line":"  command: \"/usr/bin/yum clean all\""},{"line_number":31,"context_line":"  register: yum_clean"},{"line_number":32,"context_line":"  until: yum_clean|success"},{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    - rsyslog-yum-packages"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_07195f88","line":32,"updated":"2016-02-04 11:53:06.000000000","message":"nit: Ideally \u0027|\u0027 should have spaces on either side to increase readability.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  tags:"},{"line_number":46,"context_line":"    - rsyslog-yum-packages"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# End yum-based distros"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_4707571c","line":48,"updated":"2016-02-04 11:53:06.000000000","message":"This comment can be removed entirely now.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3a6e017b236c8d3176b09306c0b030de71e544c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a57f1b5_cb314dee","line":2,"updated":"2016-02-10 08:46:36.000000000","message":"I expect that as this is new content, the Copyright should either be removed or should reflect the author or author\u0027s company.","commit_id":"f3dce8b78405682dc16e9cca8ee2b3b32d6a51ea"}],"tasks/rsyslog_server_install.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"5abe1bc7bf1f22efc24b31367f600bfe02d2cef9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  with_items: rsyslog_server_apt_repos"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - rsyslog_server_apt_repos is defined"},{"line_number":23,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":24,"context_line":"  register: add_repos"},{"line_number":25,"context_line":"  until: add_repos|success"},{"line_number":26,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_96bf4360","line":23,"updated":"2016-02-01 15:51:42.000000000","message":"I\u0027d rather this fail loudly, perhaps an assert task to ensure this would be appropriate","commit_id":"9a39e191cb1454a1b07d2972d54d792c73319e4a"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"a112198fd8a815766b1480207abbfaa4c8c74554","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  with_items: rsyslog_server_apt_repos"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - rsyslog_server_apt_repos is defined"},{"line_number":23,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":24,"context_line":"  register: add_repos"},{"line_number":25,"context_line":"  until: add_repos|success"},{"line_number":26,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_ec99067a","line":23,"in_reply_to":"7a5de9d1_96bf4360","updated":"2016-02-01 16:14:08.000000000","message":"I\u0027m not sure I follow you.  This particular step is optional in the current version.  I don\u0027t see a reason to fail on this step.","commit_id":"9a39e191cb1454a1b07d2972d54d792c73319e4a"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"fd1ce4bf9d00962714a7f03810f7d16785b5d418","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  with_items: rsyslog_server_apt_repos"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - rsyslog_server_apt_repos is defined"},{"line_number":23,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":24,"context_line":"  register: add_repos"},{"line_number":25,"context_line":"  until: add_repos|success"},{"line_number":26,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_6c46767c","line":23,"in_reply_to":"7a5de9d1_ec99067a","updated":"2016-02-01 16:20:42.000000000","message":"My bad, I reread the entire role and now see clearly that the definition of rsyslog_server_apt_repos is entirely optional","commit_id":"9a39e191cb1454a1b07d2972d54d792c73319e4a"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"dfc3bbac88a4462cd8ef75a733088f14e9d11105","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  until: install_apt_packages|success"},{"line_number":70,"context_line":"  retries: 5"},{"line_number":71,"context_line":"  delay: 2"},{"line_number":72,"context_line":"  with_items: \"{{ rsyslog_apt_distros[ansible_distribution] | default([]) }}\""},{"line_number":73,"context_line":"  tags:"},{"line_number":74,"context_line":"    - rsyslog-apt-packages"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_5db92314","line":72,"range":{"start_line":72,"start_character":2,"end_line":72,"end_character":77},"updated":"2016-01-29 23:32:51.000000000","message":"without default([]) being included, ansible fails by complaining there needs to be a list.  With_items changes how the when statement is applied, according to docs.","commit_id":"9a39e191cb1454a1b07d2972d54d792c73319e4a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8a899cb86e5fad995d72cbb88cc02c2a02668a86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_8945d643","updated":"2016-02-01 20:37:38.000000000","message":"FYI there is another example of how stuff could be done in https://github.com/openstack/ansible-role-diskimage-builder","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4755618b6e06f9d6e9c54b4a9b4e861347f2341b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_82eccbbb","in_reply_to":"7a5de9d1_824feb32","updated":"2016-02-01 22:05:15.000000000","message":"The package install and distro-specific vars file pattern in diskimage-builder is definitely the one I see most commonly in the broader Ansible community","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"00f91a018e75f469ac6d38fd36d3f57b314ccc29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_824feb32","in_reply_to":"7a5de9d1_8945d643","updated":"2016-02-01 21:52:59.000000000","message":"That approach feels clean.  But is it something we want to do for every module?","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"e717a3eac135dffd2f36a71ff75614e702970fc7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Ensure a supported distro is found"},{"line_number":17,"context_line":"- assert:"},{"line_number":18,"context_line":"    that:"},{"line_number":19,"context_line":"      - (ansible_distribution in {{ rsyslog_apt_distros }} or"},{"line_number":20,"context_line":"        ansible_distribution in {{ rsyslog_yum_distros }})"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# apt-based distros"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_87662b28","line":19,"updated":"2016-02-01 16:35:19.000000000","message":"Minor quibble, but should we check this in pre_install rather than here?","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ff64e05531f61bbc7319891cb9cd2cc129a5d452","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Ensure a supported distro is found"},{"line_number":17,"context_line":"- assert:"},{"line_number":18,"context_line":"    that:"},{"line_number":19,"context_line":"      - (ansible_distribution in {{ rsyslog_apt_distros }} or"},{"line_number":20,"context_line":"        ansible_distribution in {{ rsyslog_yum_distros }})"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# apt-based distros"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_48bd9fd6","line":19,"in_reply_to":"7a5de9d1_02eb09e0","updated":"2016-02-01 18:22:46.000000000","message":"I do like the idea of doing a pre-flight check and failing fast, but the way that\u0027s done here is quite laborious. I\u0027d rather see this either directly in the main.yml or as an included task file first in the main.yml as is done in the tests/bootstrap-host role. That way the role fails fast if the appropriate platform is not catered for. It could potentially be added to the pre_install task list too, but it seems like other things happen there.","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"798328840d8550261a09f6065f50569aace4bb11","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Ensure a supported distro is found"},{"line_number":17,"context_line":"- assert:"},{"line_number":18,"context_line":"    that:"},{"line_number":19,"context_line":"      - (ansible_distribution in {{ rsyslog_apt_distros }} or"},{"line_number":20,"context_line":"        ansible_distribution in {{ rsyslog_yum_distros }})"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# apt-based distros"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_b68a7462","line":19,"in_reply_to":"7a5de9d1_48bd9fd6","updated":"2016-02-01 19:02:01.000000000","message":"With your other suggestions, we may be able to do away with this check.","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"90578289b09b40bacf0caf2551d12fb0bd4b43eb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Ensure a supported distro is found"},{"line_number":17,"context_line":"- assert:"},{"line_number":18,"context_line":"    that:"},{"line_number":19,"context_line":"      - (ansible_distribution in {{ rsyslog_apt_distros }} or"},{"line_number":20,"context_line":"        ansible_distribution in {{ rsyslog_yum_distros }})"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# apt-based distros"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_02eb09e0","line":19,"in_reply_to":"7a5de9d1_87662b28","updated":"2016-02-01 16:42:48.000000000","message":"I don\u0027t disagree that it would be a logical choice for that to be located there; however, putting it here makes it easier for future developers to find it and make changes in fewer files.\n\nAlso, the preinstall task will still succeed, just nothing will be installed if the distro is not in the supported list.","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ff64e05531f61bbc7319891cb9cd2cc129a5d452","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  with_items: rsyslog_server_apt_repos"},{"line_number":28,"context_line":"  when:"},{"line_number":29,"context_line":"    - rsyslog_server_apt_repos is defined"},{"line_number":30,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":31,"context_line":"  register: add_repos"},{"line_number":32,"context_line":"  until: add_repos|success"},{"line_number":33,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_88acf78c","line":30,"updated":"2016-02-01 18:22:46.000000000","message":"This seems to be quite a laborious way of doing it. Why not have a special task file that does any apt related things, similar to https://github.com/openstack/openstack-ansible/blob/master/tests/roles/bootstrap-host/tasks/main.yml#L41-L46 ?","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"798328840d8550261a09f6065f50569aace4bb11","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  with_items: rsyslog_server_apt_repos"},{"line_number":28,"context_line":"  when:"},{"line_number":29,"context_line":"    - rsyslog_server_apt_repos is defined"},{"line_number":30,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":31,"context_line":"  register: add_repos"},{"line_number":32,"context_line":"  until: add_repos|success"},{"line_number":33,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_b614b4e8","line":30,"in_reply_to":"7a5de9d1_88acf78c","updated":"2016-02-01 19:02:01.000000000","message":"I like your suggestion here, but there is some debate around having lots of different files to maintain, and that it might be harder to maintain several files instead of just maintaining one larger one.","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4755618b6e06f9d6e9c54b4a9b4e861347f2341b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  with_items: rsyslog_server_apt_repos"},{"line_number":28,"context_line":"  when:"},{"line_number":29,"context_line":"    - rsyslog_server_apt_repos is defined"},{"line_number":30,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":31,"context_line":"  register: add_repos"},{"line_number":32,"context_line":"  until: add_repos|success"},{"line_number":33,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_421813d3","line":30,"in_reply_to":"7a5de9d1_b614b4e8","updated":"2016-02-01 22:05:15.000000000","message":"I agree with Jesse on this because its become a widespread Ansible community pattern","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ff64e05531f61bbc7319891cb9cd2cc129a5d452","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# yum-based distors"},{"line_number":68,"context_line":"- name: Rsyslog yum repository"},{"line_number":69,"context_line":"  template:"},{"line_number":70,"context_line":"    src: yumrepo.conf.j2"},{"line_number":71,"context_line":"    dest: \"/etc/yum.repos.d/{{ item.dest }}\""},{"line_number":72,"context_line":"    owner: \"root\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_88571725","line":69,"updated":"2016-02-01 18:22:46.000000000","message":"Any reason for not using the yum module for this? http://docs.ansible.com/ansible/yum_module.html","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"798328840d8550261a09f6065f50569aace4bb11","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# yum-based distors"},{"line_number":68,"context_line":"- name: Rsyslog yum repository"},{"line_number":69,"context_line":"  template:"},{"line_number":70,"context_line":"    src: yumrepo.conf.j2"},{"line_number":71,"context_line":"    dest: \"/etc/yum.repos.d/{{ item.dest }}\""},{"line_number":72,"context_line":"    owner: \"root\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_0b980169","line":69,"in_reply_to":"7a5de9d1_88571725","updated":"2016-02-01 19:02:01.000000000","message":"This does not enable to you set custom repos, and the yumrepo module isn\u0027t available until 2.0 (or 2.1, not sure which).","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ff64e05531f61bbc7319891cb9cd2cc129a5d452","unresolved":false,"context_lines":[{"line_number":67,"context_line":"# yum-based distors"},{"line_number":68,"context_line":"- name: Rsyslog yum repository"},{"line_number":69,"context_line":"  template:"},{"line_number":70,"context_line":"    src: yumrepo.conf.j2"},{"line_number":71,"context_line":"    dest: \"/etc/yum.repos.d/{{ item.dest }}\""},{"line_number":72,"context_line":"    owner: \"root\""},{"line_number":73,"context_line":"    group: \"root\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_88a95726","line":70,"updated":"2016-02-01 18:22:46.000000000","message":"This template appears to be missing?","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"798328840d8550261a09f6065f50569aace4bb11","unresolved":false,"context_lines":[{"line_number":67,"context_line":"# yum-based distors"},{"line_number":68,"context_line":"- name: Rsyslog yum repository"},{"line_number":69,"context_line":"  template:"},{"line_number":70,"context_line":"    src: yumrepo.conf.j2"},{"line_number":71,"context_line":"    dest: \"/etc/yum.repos.d/{{ item.dest }}\""},{"line_number":72,"context_line":"    owner: \"root\""},{"line_number":73,"context_line":"    group: \"root\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_0bafa17d","line":70,"in_reply_to":"7a5de9d1_88a95726","updated":"2016-02-01 19:02:01.000000000","message":"It is indeed missing! WIP, I intend to add it in the next commit, didn\u0027t want to spend too much time on this yet.","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# apt-based distros"},{"line_number":17,"context_line":"- include: install-apt.yml"},{"line_number":18,"context_line":"  when:"},{"line_number":19,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_5aa96e7a","line":16,"updated":"2016-02-04 11:53:06.000000000","message":"I don\u0027t think this comment is really needed - the include task itself makes it quite clear.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - install-apt"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# yum-based distros"},{"line_number":24,"context_line":"- include: install-yum.yml"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_fab61adb","line":23,"updated":"2016-02-04 11:53:06.000000000","message":"I don\u0027t think this comment is really needed - the include task itself makes it quite clear.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"}],"tasks/rsyslog_server_pre_install.yml":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"dfc3bbac88a4462cd8ef75a733088f14e9d11105","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  with_items:"},{"line_number":23,"context_line":"    - \"{{ rsyslog_server_storage_directory }}\""},{"line_number":24,"context_line":"    - \"{{ rsyslog_server_spool_directory }}\""},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - rsyslog-server-dirs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_7ddf3f69","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":55},"updated":"2016-01-29 23:32:51.000000000","message":"the syslog user isn\u0027t present in CentOS 7 by default, we need to make this step more modular, or possibly have it performed post-install.","commit_id":"9a39e191cb1454a1b07d2972d54d792c73319e4a"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"ad350cc99852eb49e0ba8d1b13b67bec7cb3217d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - \"{{ rsyslog_server_storage_directory }}\""},{"line_number":24,"context_line":"    - \"{{ rsyslog_server_spool_directory }}\""},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - rsyslog-server-dirs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_4734b348","line":26,"updated":"2016-02-01 16:30:56.000000000","message":"We still need to figure out what to do with CentOS/RedHat?  Manually create the user?","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"798328840d8550261a09f6065f50569aace4bb11","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - \"{{ rsyslog_server_storage_directory }}\""},{"line_number":24,"context_line":"    - \"{{ rsyslog_server_spool_directory }}\""},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - rsyslog-server-dirs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_96f17897","line":26,"in_reply_to":"7a5de9d1_08e7a7ac","updated":"2016-02-01 19:02:01.000000000","message":"This particular step assumes a syslog user exists.  This user is not created in RPM distros.  It is not intended to fail the role, just only be included in the relevant distros.","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ff64e05531f61bbc7319891cb9cd2cc129a5d452","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - \"{{ rsyslog_server_storage_directory }}\""},{"line_number":24,"context_line":"    - \"{{ rsyslog_server_spool_directory }}\""},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - ansible_distribution in {{ rsyslog_apt_distros }}"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - rsyslog-server-dirs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_08e7a7ac","line":26,"in_reply_to":"7a5de9d1_4734b348","updated":"2016-02-01 18:22:46.000000000","message":"This is why I think the distro check must happen before anything that changes a target. The role should fail fast if the distro is not supported.","commit_id":"086785d96aead148fffb7ecd6af5778a10097de6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"- name: Ensure adm group exists"},{"line_number":16,"context_line":"  group:"},{"line_number":17,"context_line":"    name: \"adm\""},{"line_number":18,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_da447e1c","line":15,"updated":"2016-02-04 11:53:06.000000000","message":"nit: please include an empty line between the license boilerplate and the first task","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"}],"templates/yumrepo.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"99563031d2b105dba157392045cff4a66857f959","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5aef4532_f1155549","updated":"2016-03-08 18:12:27.000000000","message":"This file is no longer needed as it is no longer used.","commit_id":"a79694ea5b3d9d0f65c27b0d572a379610e696d3"}],"vars/debian.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_faddba14","line":1,"updated":"2016-02-04 11:53:06.000000000","message":"Please add the Apache 2.0 license boilerplate.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3a6e017b236c8d3176b09306c0b030de71e544c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a57f1b5_4b731db2","line":2,"updated":"2016-02-10 08:46:36.000000000","message":"New content, so s/2014/2016/ and change the cCopyright to your company/person.","commit_id":"f3dce8b78405682dc16e9cca8ee2b3b32d6a51ea"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"af7e35be0e763635970734bd656fa5bc8ba53c7a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# rsyslog_server_apt_repos:"},{"line_number":21,"context_line":"#   - { repo: \"ppa:adiscon/v8-stable\", state: \"present\" }"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_9749d662","line":20,"updated":"2016-02-11 16:43:42.000000000","message":"why wasn\u0027t this just removed, why is it commented?","commit_id":"44762315333d4bbf3742902beed7268569c9614d"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0100d2f4c0a9c6f7a6856dc6fe762ca1a1d28226","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# rsyslog_server_apt_repos:"},{"line_number":21,"context_line":"#   - { repo: \"ppa:adiscon/v8-stable\", state: \"present\" }"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_f7012a39","line":20,"in_reply_to":"3a57f1b5_9749d662","updated":"2016-02-11 16:55:42.000000000","message":"It was always commented.  It demonstrates the format if someone wishes to supply a custom repository for this role.","commit_id":"44762315333d4bbf3742902beed7268569c9614d"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"23e918516af20a8fbb4777a94374cf0932cd1272","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# rsyslog_server_apt_repos:"},{"line_number":21,"context_line":"#   - { repo: \"ppa:adiscon/v8-stable\", state: \"present\" }"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_fa127156","line":20,"in_reply_to":"3a57f1b5_f7012a39","updated":"2016-02-11 16:58:36.000000000","message":"Mind adding a comment clarifying why this is here?","commit_id":"44762315333d4bbf3742902beed7268569c9614d"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"67251c0121b545422f2db6638436dc2e10489a32","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# rsyslog_server_apt_repos:"},{"line_number":21,"context_line":"#   - { repo: \"ppa:adiscon/v8-stable\", state: \"present\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7af24918_025f0e0f","line":20,"updated":"2016-03-05 18:58:51.000000000","message":"I think this probably would find a better home in the example playbooks section of the role docs","commit_id":"d452f84928d210a80444ba6f3a3ef8330ad2aae7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f779cc059cd754d399d1227f26eee414ed388602","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# rsyslog_server_apt_repos:"},{"line_number":21,"context_line":"#   - { repo: \"ppa:adiscon/v8-stable\", state: \"present\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_96fde73c","line":20,"in_reply_to":"7af24918_025f0e0f","updated":"2016-03-08 17:54:01.000000000","message":"Yeah, that\u0027s probably true. This is a leftover piece from Icehouse though, so I\u0027d actually rather see this removed in a subsequent patch as it is never used by the project, and probably never will be.","commit_id":"d452f84928d210a80444ba6f3a3ef8330ad2aae7"}],"vars/redhat.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6569c1c4d7faa68fdd6d6f7ba0d31b42b1f0d668","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"#rsyslog_server_yum_repos:"},{"line_number":3,"context_line":"#  - dest: \"filename.repo\""},{"line_number":4,"context_line":"#    repo: \"ExampleRepo\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a5ae5dd_daea3eac","line":1,"updated":"2016-02-04 11:53:06.000000000","message":"Please add the Apache 2.0 license boilerplate.","commit_id":"861f7baa0558c927d3d497a81a529c4ca9371000"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3a6e017b236c8d3176b09306c0b030de71e544c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a57f1b5_ab62d1d6","line":2,"updated":"2016-02-10 08:46:36.000000000","message":"New content, so s/2014/2016/ and change the cCopyright to your company/person.","commit_id":"f3dce8b78405682dc16e9cca8ee2b3b32d6a51ea"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"af7e35be0e763635970734bd656fa5bc8ba53c7a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#rsyslog_server_yum_repos:"},{"line_number":21,"context_line":"#  - dest: \"filename.repo\""},{"line_number":22,"context_line":"#    repo: \"ExampleRepo\""},{"line_number":23,"context_line":"#    name: \"Example Repo\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_9760f6d0","line":20,"updated":"2016-02-11 16:43:42.000000000","message":"why is this commented and not removed?","commit_id":"44762315333d4bbf3742902beed7268569c9614d"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"23e918516af20a8fbb4777a94374cf0932cd1272","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#rsyslog_server_yum_repos:"},{"line_number":21,"context_line":"#  - dest: \"filename.repo\""},{"line_number":22,"context_line":"#    repo: \"ExampleRepo\""},{"line_number":23,"context_line":"#    name: \"Example Repo\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_ba187976","line":20,"in_reply_to":"3a57f1b5_57befe65","updated":"2016-02-11 16:58:36.000000000","message":"same","commit_id":"44762315333d4bbf3742902beed7268569c9614d"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0100d2f4c0a9c6f7a6856dc6fe762ca1a1d28226","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#rsyslog_server_yum_repos:"},{"line_number":21,"context_line":"#  - dest: \"filename.repo\""},{"line_number":22,"context_line":"#    repo: \"ExampleRepo\""},{"line_number":23,"context_line":"#    name: \"Example Repo\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a57f1b5_57befe65","line":20,"in_reply_to":"3a57f1b5_9760f6d0","updated":"2016-02-11 16:55:42.000000000","message":"This is a new feature.  It demonstrates how to properly add a new repository to this role.","commit_id":"44762315333d4bbf3742902beed7268569c9614d"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"67251c0121b545422f2db6638436dc2e10489a32","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#rsyslog_server_yum_repos:"},{"line_number":21,"context_line":"#  - dest: \"filename.repo\""},{"line_number":22,"context_line":"#    repo: \"ExampleRepo\""},{"line_number":23,"context_line":"#    name: \"Example Repo\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7af24918_a2a45a08","line":20,"updated":"2016-03-05 18:58:51.000000000","message":"I think this would find a better home in the example playbook section of the docs","commit_id":"d452f84928d210a80444ba6f3a3ef8330ad2aae7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f779cc059cd754d399d1227f26eee414ed388602","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  - rsyslog"},{"line_number":18,"context_line":"  - logrotate"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#rsyslog_server_yum_repos:"},{"line_number":21,"context_line":"#  - dest: \"filename.repo\""},{"line_number":22,"context_line":"#    repo: \"ExampleRepo\""},{"line_number":23,"context_line":"#    name: \"Example Repo\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_3685f3ac","line":20,"in_reply_to":"7af24918_a2a45a08","updated":"2016-03-08 17:54:01.000000000","message":"I\u0027d rather just not see this added. See my comment regarding the apt repo add. If there is a use-case where we can see this being necessary, then it changes things... but I don\u0027t.","commit_id":"d452f84928d210a80444ba6f3a3ef8330ad2aae7"}]}
