)]}'
{"tasks/rsyslog_server_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5b97900f7afd19b062b4beab276c8b6567f690b7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  tags:"},{"line_number":59,"context_line":"    - rsyslog-config"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- name: Ensure rsyslog server bound on ports (IPv4 and IPv6)"},{"line_number":62,"context_line":"  shell: \"ss -nlp{{ item.proto }} | grep rsyslogd\""},{"line_number":63,"context_line":"  register: rsyslog_listening_status"},{"line_number":64,"context_line":"  failed_when: false"},{"line_number":65,"context_line":"  changed_when: rsyslog_listening_status.stdout_lines | length !\u003d 2"},{"line_number":66,"context_line":"  retries: 3"},{"line_number":67,"context_line":"  delay: 5"},{"line_number":68,"context_line":"  until: rsyslog_listening_status.stdout_lines | length \u003d\u003d 2"},{"line_number":69,"context_line":"  when: \"{{ item.proto_enabled | bool }}\""},{"line_number":70,"context_line":"  with_items:"},{"line_number":71,"context_line":"    - { proto: \"t\", proto_enabled: \"{{ rsyslog_server_tcp_reception }}\" }"},{"line_number":72,"context_line":"    - { proto: \"u\", proto_enabled: \"{{ rsyslog_server_udp_reception }}\" }"},{"line_number":73,"context_line":"  notify: Restart rsyslog"},{"line_number":74,"context_line":"  tags:"},{"line_number":75,"context_line":"    - rsyslog-config"},{"line_number":76,"context_line":"    - skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a74a57a_8b5f18e4","line":76,"range":{"start_line":61,"start_character":0,"end_line":76,"end_character":23},"updated":"2016-11-28 07:57:55.000000000","message":"I\u0027m not sure I understand the intent here. It looks like what may be happening is that you want to force a restart if the service is in a particular state. Would the same thing not be achieved by forcing a restart if any config changes? Or perhaps forcing a shut down and a start up?","commit_id":"3a0e9b8220c7d457bfa13b4450d95bc8a0063aad"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"744f19bc74f5397d833f46e6c44d4528162602aa","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  tags:"},{"line_number":59,"context_line":"    - rsyslog-config"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- name: Ensure rsyslog server bound on ports (IPv4 and IPv6)"},{"line_number":62,"context_line":"  shell: \"ss -nlp{{ item.proto }} | grep rsyslogd\""},{"line_number":63,"context_line":"  register: rsyslog_listening_status"},{"line_number":64,"context_line":"  failed_when: false"},{"line_number":65,"context_line":"  changed_when: rsyslog_listening_status.stdout_lines | length !\u003d 2"},{"line_number":66,"context_line":"  retries: 3"},{"line_number":67,"context_line":"  delay: 5"},{"line_number":68,"context_line":"  until: rsyslog_listening_status.stdout_lines | length \u003d\u003d 2"},{"line_number":69,"context_line":"  when: \"{{ item.proto_enabled | bool }}\""},{"line_number":70,"context_line":"  with_items:"},{"line_number":71,"context_line":"    - { proto: \"t\", proto_enabled: \"{{ rsyslog_server_tcp_reception }}\" }"},{"line_number":72,"context_line":"    - { proto: \"u\", proto_enabled: \"{{ rsyslog_server_udp_reception }}\" }"},{"line_number":73,"context_line":"  notify: Restart rsyslog"},{"line_number":74,"context_line":"  tags:"},{"line_number":75,"context_line":"    - rsyslog-config"},{"line_number":76,"context_line":"    - skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a74a57a_059af5b8","line":76,"range":{"start_line":61,"start_character":0,"end_line":76,"end_character":23},"in_reply_to":"5a74a57a_8b5f18e4","updated":"2016-11-28 18:05:29.000000000","message":"I don\u0027t understand it either. This file starts by stopping rsyslog, and then the last task in the file starts rsyslog back up again. It seems like we have some other issue if yet another restart needs to be triggered.\n\nWe need a test in the role tests to confirm that it is listening on the expected ports, but also need to fix the separate problem that the role is broken and does not listen on the ports when it finishes configuring the syslog server.\n\nIf this is meant to implement the test I suggested here: https://bugs.launchpad.net/openstack-ansible/+bug/1636017/comments/7 then this is the wrong place to implement it (link to the correct place is in the bug comment, but note that this still does not fix the bug, only tests for it.)","commit_id":"3a0e9b8220c7d457bfa13b4450d95bc8a0063aad"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dc3417d574042b5f35938704a9dad4745cc9fdd8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  tags:"},{"line_number":59,"context_line":"    - rsyslog_server-config"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- name: Ensure rsyslog server bound on ports (IPv4 and IPv6)"},{"line_number":62,"context_line":"  shell: \"ss -nlp{{ item.proto }} | grep rsyslogd\""},{"line_number":63,"context_line":"  register: rsyslog_listening_status"},{"line_number":64,"context_line":"  failed_when: false"},{"line_number":65,"context_line":"  changed_when: rsyslog_listening_status.stdout_lines | length !\u003d 2"},{"line_number":66,"context_line":"  retries: 3"},{"line_number":67,"context_line":"  delay: 5"},{"line_number":68,"context_line":"  until: rsyslog_listening_status.stdout_lines | length \u003d\u003d 2"},{"line_number":69,"context_line":"  when: \"{{ item.proto_enabled | bool }}\""},{"line_number":70,"context_line":"  with_items:"},{"line_number":71,"context_line":"    - { proto: \"t\", proto_enabled: \"{{ rsyslog_server_tcp_reception }}\" }"},{"line_number":72,"context_line":"    - { proto: \"u\", proto_enabled: \"{{ rsyslog_server_udp_reception }}\" }"},{"line_number":73,"context_line":"  notify: Restart rsyslog"},{"line_number":74,"context_line":"  tags:"},{"line_number":75,"context_line":"    - rsyslog_server-config"},{"line_number":76,"context_line":"    - skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a3c09a3_53d8ba1d","line":76,"range":{"start_line":61,"start_character":0,"end_line":76,"end_character":23},"updated":"2017-01-16 10:39:51.000000000","message":"See https://review.openstack.org/#/c/401984/9/tasks/rsyslog_server_post_install.yml for comments.","commit_id":"55f3c399be4be863e6821ca6c9e4f609014463f0"}],"tests/test.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dc3417d574042b5f35938704a9dad4745cc9fdd8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      when: \"{{ item.proto_enabled | bool }}\""},{"line_number":46,"context_line":"      with_items:"},{"line_number":47,"context_line":"        - { proto: \"t\", proto_enabled: \"{{ rsyslog_server_tcp_reception }}\" }"},{"line_number":48,"context_line":"        - { proto: \"u\", proto_enabled: \"{{ rsyslog_server_udp_reception }}\" } "}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a3c09a3_b3b1dee3","line":48,"range":{"start_line":48,"start_character":77,"end_line":48,"end_character":78},"updated":"2017-01-16 10:39:51.000000000","message":"remove trailing whitespace","commit_id":"55f3c399be4be863e6821ca6c9e4f609014463f0"}]}