)]}'
{"Vagrantfile":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"f769d7d63326e4b46621c1e21b4710c32fc1d804","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Vagrant.configure(\"2\") do |config|"},{"line_number":4,"context_line":"  config.vm.box \u003d \"ubuntu/trusty64\""},{"line_number":5,"context_line":"  config.vm.hostname \u003d \"sec-ansible-test\""},{"line_number":6,"context_line":"  "},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    ansible.verbose \u003d \"vvvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da6ed579_d9823a94","line":6,"updated":"2016-01-13 14:49:44.000000000","message":"Trailing whitespace!!!!","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02a2f5d793ee6577031e6e40adadb0c232a76b24","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Vagrant.configure(\"2\") do |config|"},{"line_number":4,"context_line":"  config.vm.box \u003d \"ubuntu/trusty64\""},{"line_number":5,"context_line":"  config.vm.hostname \u003d \"sec-ansible-test\""},{"line_number":6,"context_line":"  "},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    ansible.verbose \u003d \"vvvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da6ed579_cc77d638","line":6,"in_reply_to":"da6ed579_d9823a94","updated":"2016-01-13 14:57:45.000000000","message":"Done","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9ae5756fa48304f66b0db7036bf140f6c160371b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  config.vm.hostname \u003d \"sec-ansible-test\""},{"line_number":6,"context_line":"  "},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    ansible.verbose \u003d \"vvvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":11,"context_line":"      rolename: \"../../\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da6ed579_ac03820c","line":8,"updated":"2016-01-13 14:51:18.000000000","message":"This is probably only necessary for debug purposes.","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02a2f5d793ee6577031e6e40adadb0c232a76b24","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  config.vm.hostname \u003d \"sec-ansible-test\""},{"line_number":6,"context_line":"  "},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    ansible.verbose \u003d \"vvvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":11,"context_line":"      rolename: \"../../\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da6ed579_ac93824e","line":8,"in_reply_to":"da6ed579_ac03820c","updated":"2016-01-13 14:57:45.000000000","message":"Done","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9ae5756fa48304f66b0db7036bf140f6c160371b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      rolename: \"../../\""},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"},{"line_number":14,"context_line":"    ansible.raw_arguments \u003d [\u0027-s\u0027, \u0027--check\u0027]"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da6ed579_ec309aea","line":14,"range":{"start_line":14,"start_character":36,"end_line":14,"end_character":43},"updated":"2016-01-13 14:51:18.000000000","message":"Leave in check mode?","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02a2f5d793ee6577031e6e40adadb0c232a76b24","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      rolename: \"../../\""},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"},{"line_number":14,"context_line":"    ansible.raw_arguments \u003d [\u0027-s\u0027, \u0027--check\u0027]"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da6ed579_0ca5eea0","line":14,"range":{"start_line":14,"start_character":36,"end_line":14,"end_character":43},"in_reply_to":"da6ed579_ec309aea","updated":"2016-01-13 14:57:45.000000000","message":"Done","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"cdf1fee24c145d0d84b0345847a5ee3265778e9b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  config.vm.hostname \u003d \"sec-ansible-test\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    ansible.verbose \u003d \"vvvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":11,"context_line":"      rolename: \"../../\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da6ed579_6c802a47","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":27},"updated":"2016-01-13 14:54:18.000000000","message":"Maybe reduce verbosity","commit_id":"f95f558f3274fd8481a233cd9889ab0d2b6bcb29"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"d460592dccf6165897352c50717896b6290007a3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  config.vm.hostname \u003d \"sec-ansible-test\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    ansible.verbose \u003d \"vvvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":11,"context_line":"      rolename: \"../../\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da6ed579_8c89de28","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":27},"in_reply_to":"da6ed579_6c802a47","updated":"2016-01-13 14:57:34.000000000","message":"Done","commit_id":"f95f558f3274fd8481a233cd9889ab0d2b6bcb29"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"cdf1fee24c145d0d84b0345847a5ee3265778e9b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":11,"context_line":"      rolename: \"../../\""},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"},{"line_number":14,"context_line":"    ansible.raw_arguments \u003d [\u0027-s\u0027, \u0027--check\u0027]"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da6ed579_ac62a2ab","line":13,"range":{"start_line":13,"start_character":28,"end_line":13,"end_character":33},"updated":"2016-01-13 14:54:18.000000000","message":"I think any skipped tags should have comments.","commit_id":"f95f558f3274fd8481a233cd9889ab0d2b6bcb29"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"d460592dccf6165897352c50717896b6290007a3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":11,"context_line":"      rolename: \"../../\""},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"},{"line_number":14,"context_line":"    ansible.raw_arguments \u003d [\u0027-s\u0027, \u0027--check\u0027]"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da6ed579_ac8ce235","line":13,"range":{"start_line":13,"start_character":28,"end_line":13,"end_character":33},"in_reply_to":"da6ed579_ac62a2ab","updated":"2016-01-13 14:57:34.000000000","message":"Done","commit_id":"f95f558f3274fd8481a233cd9889ab0d2b6bcb29"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"1a94a9d91b6a1099fae05b73e30776c6dcf7331c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      rolename: \"../../\""},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":14,"context_line":"    # this to vail"},{"line_number":15,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"},{"line_number":16,"context_line":"    ansible.raw_arguments \u003d [\u0027-s\u0027]"},{"line_number":17,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"da6ed579_4c368653","line":14,"range":{"start_line":14,"start_character":14,"end_line":14,"end_character":18},"updated":"2016-01-13 14:59:24.000000000","message":"Fail? You Fail.","commit_id":"479d285138f5d22f3b4d3e65cc9e7740bc7fb269"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"db486bf10832222baaccd6b5e36a8586f06f4c3c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # set the role name to openstack-ansible-security (relative from the"},{"line_number":11,"context_line":"    # playbook)"},{"line_number":12,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":13,"context_line":"      rolename: \"../../\""},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":16,"context_line":"    # this to fail"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_20d0f31e","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":23},"updated":"2016-01-13 15:54:11.000000000","message":"change to openstack-ansible-security\n\nthen create a new files called ansible.cfg in root dir. \n\n[defaults]\nroles_path \u003d ../","commit_id":"ce2c2ef5da134a53e3a879ffd48052f56445e20c"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"dfe50233295e59a57d986dc3df1b3b88731cc3b4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # set the role name to openstack-ansible-security (relative from the"},{"line_number":11,"context_line":"    # playbook)"},{"line_number":12,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":13,"context_line":"      rolename: \"../../../openstack-ansible-securty\""},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":16,"context_line":"    # this to fail"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba63e191_fdbaebbf","line":13,"updated":"2016-01-18 19:03:29.000000000","message":"s/securty/security/ -- I assume this is just a typo here.","commit_id":"3958bce0612316279d5fc0ebd6e071328f05d51c"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"a7c0955546dde41a335af9ec5338031b43111c40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # set the role name to openstack-ansible-security (relative from the"},{"line_number":11,"context_line":"    # playbook)"},{"line_number":12,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":13,"context_line":"      rolename: \"../../../openstack-ansible-securty\""},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":16,"context_line":"    # this to fail"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba63e191_c2e58da8","line":13,"in_reply_to":"ba63e191_fdbaebbf","updated":"2016-01-19 16:08:29.000000000","message":"Yeah good catch.  I actually had this fixed locally after testing and forgot to push the new one.","commit_id":"3958bce0612316279d5fc0ebd6e071328f05d51c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bb30f17dee7dcfacc7ec6d0a018da454c8f78a71","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # set the role name to openstack-ansible-security (relative from the"},{"line_number":11,"context_line":"    # playbook)"},{"line_number":12,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":13,"context_line":"      rolename: \u0027../../../openstack-ansible-security\u0027"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":16,"context_line":"    # this to fail"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a68dd71_996795b6","line":13,"updated":"2016-01-23 18:31:04.000000000","message":"This seems an odd way to do it. Is the role name not a static thing?","commit_id":"89b0156f1741fc1445490cf8a9b3f12061269c60"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"7b47cad4a32b9acbc643834e43be4fe36aeea939","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # set the role name to openstack-ansible-security (relative from the"},{"line_number":11,"context_line":"    # playbook)"},{"line_number":12,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":13,"context_line":"      rolename: \u0027../../../openstack-ansible-security\u0027"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":16,"context_line":"    # this to fail"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a68dd71_fe244960","line":13,"in_reply_to":"9a68dd71_996795b6","updated":"2016-01-25 15:26:55.000000000","message":"I agree, it does look odd.  Rolename seems to be a path to the role (a folder).  We found that either \u0027../..\u0027 or \u0027../../../openstack-ansible-security\u0027 work, and although neither looks great this one seems more descriptive.","commit_id":"89b0156f1741fc1445490cf8a9b3f12061269c60"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a3a22f7badc208498aa6adab94f6761585f91db3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # set the role name to openstack-ansible-security (relative from the"},{"line_number":11,"context_line":"    # playbook)"},{"line_number":12,"context_line":"    ansible.extra_vars \u003d {"},{"line_number":13,"context_line":"      rolename: \u0027../../../openstack-ansible-security\u0027"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":16,"context_line":"    # this to fail"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a68dd71_01dc6244","line":13,"in_reply_to":"9a68dd71_fe244960","updated":"2016-01-25 15:43:22.000000000","message":"I\u0027d suggest replacing the variablised rolename with the name of the role.","commit_id":"89b0156f1741fc1445490cf8a9b3f12061269c60"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"29a7e4876e9367a2fdca6e00f5765251b17ace8e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    # ansible.verbose \u003d \"vvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":11,"context_line":"    # this to fail"},{"line_number":12,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9a68dd71_27bf3162","line":9,"updated":"2016-01-25 17:40:39.000000000","message":"Ah, this is why the role name without the path isn\u0027t working. ansible-playbook needs to be run from the tests/ directory in order to pick up the ansible.cfg in that directory.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"f92a5fea16996911e634a588e97542b3f9fdfdf6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    # ansible.verbose \u003d \"vvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":11,"context_line":"    # this to fail"},{"line_number":12,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9a68dd71_ba49f432","line":9,"in_reply_to":"9a68dd71_27bf3162","updated":"2016-01-25 17:48:18.000000000","message":"if we use the same ansible.cfg file though the playbook fails because the remote temp path currently defined in that file (remote_tmp \u003d ../.ansible/tmp/) doesn\u0027t work.  So we either need to change the ansible.cfg file (something I\u0027m hesitant to do, I don\u0027t want to break other things with this change) or not use it.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"0b563e6521c20458141751465413b3eeb1dc6cb8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    # ansible.verbose \u003d \"vvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":11,"context_line":"    # this to fail"},{"line_number":12,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9a68dd71_ce498a32","line":9,"in_reply_to":"9a68dd71_9a619007","updated":"2016-01-25 19:38:50.000000000","message":"OK I\u0027ve played around and I don\u0027t see how it can work.  We need to set a local environment variable, as the ansible role path we need to set is on the local host system.  I could set an environment variable on the target system with a shell deployer, but that doesn\u0027t help us out here.\n\nI could write a shell script that exports the ANSIBLE_ROLES_PATH environment variable and then runs, \u0027vagrant up\u0027, but that doesn\u0027t seem as nice as having everything work without the shell script, despite the nasty rolepath.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3240efb2e6f964f8b7065380634d345eb7fd6243","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    # ansible.verbose \u003d \"vvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":11,"context_line":"    # this to fail"},{"line_number":12,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9a68dd71_9a619007","line":9,"in_reply_to":"9a68dd71_ba49f432","updated":"2016-01-25 18:02:52.000000000","message":"Blast. That\u0027s rather a pain. Would it be possible, perhaps, to set the environment variable ANSIBLE_ROLES_PATH in the Vagrantfile then? That would have the same effect as using the ansible.cfg but without the other setting.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8a2709337c99aba552f5828dd65476c437864d41","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  config.vm.provision \"ansible\" do |ansible|"},{"line_number":8,"context_line":"    # ansible.verbose \u003d \"vvv\""},{"line_number":9,"context_line":"    ansible.playbook \u003d \"tests/vagrant.yml\""},{"line_number":10,"context_line":"    # we\u0027ll skip V-38496 because Vagrant itself creates the user that causes"},{"line_number":11,"context_line":"    # this to fail"},{"line_number":12,"context_line":"    ansible.skip_tags \u003d [\u0027V-38496\u0027]"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9a68dd71_86ca7f6d","line":9,"in_reply_to":"9a68dd71_ce498a32","updated":"2016-01-26 10:32:26.000000000","message":"Great, thanks for trying. We can try and work out a better way to implement this role\u0027s testing in subsequent patches.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"}],"tests/vagrant.yml":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"f769d7d63326e4b46621c1e21b4710c32fc1d804","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_994b6287","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2016-01-13 14:49:44.000000000","message":"2016\n\nAnd don\u0027t you work for HP","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02a2f5d793ee6577031e6e40adadb0c232a76b24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_6c86ea14","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"da6ed579_994b6287","updated":"2016-01-13 14:57:45.000000000","message":"Done","commit_id":"c24b81931c5ab8f17e75960d70517b9f70e50dae"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1d363ff81390d0537956b96ecc023c5b313a82a5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"{{ rolename }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_af2a947c","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":18},"updated":"2016-01-13 15:05:56.000000000","message":"should be all","commit_id":"479d285138f5d22f3b4d3e65cc9e7740bc7fb269"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"af408863dd2614fac6813302411b7dfe6ddbb711","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"{{ rolename }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a68dd71_b974d967","line":16,"updated":"2016-01-23 18:30:03.000000000","message":"This file\u0027s contents appear to mirror the contents of the playbook tests/test.yml - would it not be possible for vagrant to simply consume that playbook? This way the vagrant test and the gate test would be consuming the same test playbook, which always makes for better testing. :)","commit_id":"89b0156f1741fc1445490cf8a9b3f12061269c60"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a3a22f7badc208498aa6adab94f6761585f91db3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"{{ rolename }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a68dd71_c1fc0aba","line":16,"in_reply_to":"9a68dd71_9e5c2d1a","updated":"2016-01-25 15:43:22.000000000","message":"Ah, that makes sense. I missed that bit. :)","commit_id":"89b0156f1741fc1445490cf8a9b3f12061269c60"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"7b47cad4a32b9acbc643834e43be4fe36aeea939","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"{{ rolename }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a68dd71_9e5c2d1a","line":16,"in_reply_to":"9a68dd71_b974d967","updated":"2016-01-25 15:26:55.000000000","message":"We had to change \"hosts\" to be all instead of localhost.  Localhost would cause Ansible to run against the host machine that is deploying Vagrant instead of the VM that Ansible is designed to be run within.","commit_id":"89b0156f1741fc1445490cf8a9b3f12061269c60"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a3a22f7badc208498aa6adab94f6761585f91db3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"{{ rolename }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a68dd71_a11476e8","line":19,"updated":"2016-01-25 15:43:22.000000000","message":"I\u0027d suggest replacing the variablised rolename with the name of the role.","commit_id":"89b0156f1741fc1445490cf8a9b3f12061269c60"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"de3f27d2ff75bd82af96e1036b7b327bfbbaebe0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"../../../openstack-ansible-security\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a68dd71_cf051146","line":19,"updated":"2016-01-25 16:20:45.000000000","message":"The roles path is already set in ansible.cfg, so there\u0027s no need to use a path here. It should just work with:\n\nroles:\n  - role: \"openstack-ansible-security\"","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"29a7e4876e9367a2fdca6e00f5765251b17ace8e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"../../../openstack-ansible-security\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a68dd71_67a9a923","line":19,"in_reply_to":"9a68dd71_27f1716b","updated":"2016-01-25 17:40:39.000000000","message":"Ah, figured out why - see my comment in the Vagrant file.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"818543e6989ae2fb61ddb556a914e9d7acedf017","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"../../../openstack-ansible-security\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a68dd71_27f1716b","line":19,"in_reply_to":"9a68dd71_55bf7060","updated":"2016-01-25 17:38:35.000000000","message":"That\u0027s correct.  I tried it again before PS11 and it doesn\u0027t work without the path.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"da4f17dd604057b0d5ec1d1e540797431f2aa6de","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: all"},{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - role: \"../../../openstack-ansible-security\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a68dd71_55bf7060","line":19,"in_reply_to":"9a68dd71_cf051146","updated":"2016-01-25 17:37:14.000000000","message":"My recollection is that was not the case when we tested it.","commit_id":"ac1093f98d998357d4fd321e498bc53fb67f2caf"}]}