)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b4e2d1bebe417b19bf3f35f4b389187caa7511b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Major Hayden \u003cmajor@mhtx.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-04 12:50:29 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from dict to invididual variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The dictionary-based variables didn\u0027t work properly and this patch"},{"line_number":10,"context_line":"changes them to individual variables. If users followed the existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a122d0e_0aa16ff7","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":30},"updated":"2016-05-05 12:40:06.000000000","message":"nit: individual","commit_id":"5baae1c77d286ce554d836bc72df8677f0c65eba"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"ec7ac0ccefed92ac28e07eecd0062915703fb832","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Major Hayden \u003cmajor@mhtx.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-04 12:50:29 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from dict to invididual variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The dictionary-based variables didn\u0027t work properly and this patch"},{"line_number":10,"context_line":"changes them to individual variables. If users followed the existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a122d0e_6dd47de8","line":7,"in_reply_to":"1a122d0e_0aa16ff7","updated":"2016-05-05 13:15:12.000000000","message":"Done","commit_id":"5baae1c77d286ce554d836bc72df8677f0c65eba"}],"defaults/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"561c330f9c58e60367d2a69d63f5d742ae610f30","unresolved":false,"context_lines":[{"line_number":149,"context_line":"# Setting a \u0027no\u0027 will ensure that this Ansible role does not alter the service"},{"line_number":150,"context_line":"# in any way from its current configuration."},{"line_number":151,"context_line":"#"},{"line_number":152,"context_line":"disable_abrtd: yes                                # V-38641"},{"line_number":153,"context_line":"disable_atd: yes                                  # V-38640"},{"line_number":154,"context_line":"disable_autofs: yes                               # V-38437"},{"line_number":155,"context_line":"disable_avahi: yes                                # V-31618"},{"line_number":156,"context_line":"disable_bluetooth: yes                            # V-38691"},{"line_number":157,"context_line":"disable_qpidd: yes                                # V-38648"},{"line_number":158,"context_line":"disable_rsh: yes                                  # V-38594"},{"line_number":159,"context_line":"disable_ypbind: yes                               # V-38604"},{"line_number":160,"context_line":"disable_xinetd: yes                               # V-38582"},{"line_number":161,"context_line":"#"},{"line_number":162,"context_line":"# The STIG recommends ensuring that some services aren\u0027t installed at ANY time."},{"line_number":163,"context_line":"# Those services are listed here.  Setting a boolean here to \u0027yes\u0027 wiil"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_b0d573b8","line":160,"range":{"start_line":152,"start_character":0,"end_line":160,"end_character":59},"updated":"2016-05-04 17:21:02.000000000","message":"to avoid collisions, I\u0027d use a variable name prepended by the role name. Here because the name is long, maybe use security_disable_something? \n\nDefinitely not mandatory, but recommended.","commit_id":"d2d3bde3dcda14f82652d71a8af80fe8fceb68f0"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"561c330f9c58e60367d2a69d63f5d742ae610f30","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# ensure that the STIG is followed and the service is removed.  Setting a"},{"line_number":165,"context_line":"# boolean to \u0027no\u0027 means that the playbook will not alter the service."},{"line_number":166,"context_line":"#"},{"line_number":167,"context_line":"remove_ldap_server: yes                           # V-38627"},{"line_number":168,"context_line":"remove_rsh_server: yes                            # V-38591"},{"line_number":169,"context_line":"remove_sendmail: yes                              # V-38671"},{"line_number":170,"context_line":"remove_telnet_server: yes                         # V-38587"},{"line_number":171,"context_line":"remove_tftp_server: yes                           # V-38606"},{"line_number":172,"context_line":"remove_xinetd: yes                                # V-38584"},{"line_number":173,"context_line":"remove_xorg: yes                                  # v-38676"},{"line_number":174,"context_line":"remove_ypserv: yes                                # V-38603"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"## SSH configuration"},{"line_number":177,"context_line":"# The following configuration items will adjust how the ssh daemon is"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_3097a3ec","line":174,"range":{"start_line":167,"start_character":1,"end_line":174,"end_character":59},"updated":"2016-05-04 17:21:02.000000000","message":"Same comment","commit_id":"d2d3bde3dcda14f82652d71a8af80fe8fceb68f0"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"561c330f9c58e60367d2a69d63f5d742ae610f30","unresolved":false,"context_lines":[{"line_number":193,"context_line":"## Kernel"},{"line_number":194,"context_line":"# Set these booleans to \u0027yes\u0027 to disable the kernel module (following the"},{"line_number":195,"context_line":"# STIG requirements). Set the boolean to \u0027no\u0027 to ensure no changes are made."},{"line_number":196,"context_line":"disable_module_bluetooth: yes                     # V-38682"},{"line_number":197,"context_line":"disable_module_dccp: yes                          # V-38514"},{"line_number":198,"context_line":"disable_module_rds: yes                           # V-38516"},{"line_number":199,"context_line":"disable_module_sctp: yes                          # V-38515"},{"line_number":200,"context_line":"disable_module_tipc: yes                          # V-38517"},{"line_number":201,"context_line":"disable_module_usb_storage: no                    # V-38490"},{"line_number":202,"context_line":"#"},{"line_number":203,"context_line":"# ** DANGER **"},{"line_number":204,"context_line":"# It\u0027s strongly recommended to fully understand the effects of changing the"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_70a11b46","line":201,"range":{"start_line":196,"start_character":0,"end_line":201,"end_character":59},"updated":"2016-05-04 17:21:02.000000000","message":"Same comment","commit_id":"d2d3bde3dcda14f82652d71a8af80fe8fceb68f0"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"561c330f9c58e60367d2a69d63f5d742ae610f30","unresolved":false,"context_lines":[{"line_number":206,"context_line":"# Notes\u0027 for each of the STIGs below before making any changes."},{"line_number":207,"context_line":"# ** DANGER **"},{"line_number":208,"context_line":"#"},{"line_number":209,"context_line":"sysctl_tcp_syncookies: 1                          # V-38539"},{"line_number":210,"context_line":"#"},{"line_number":211,"context_line":"# Deployers who wish to disable IPv6 entirely must set this configuration"},{"line_number":212,"context_line":"# variable to \u0027yes\u0027. See the documentation for V-38546 before making this"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_30be8364","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":59},"updated":"2016-05-04 17:21:02.000000000","message":"Same comment","commit_id":"d2d3bde3dcda14f82652d71a8af80fe8fceb68f0"}],"doc/source/configuration.rst":[{"author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"change_message_id":"a5d40d6c4e9d25f176203652cc05906c13ecd877","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Rules for auditd"},{"line_number":55,"context_line":"^^^^^^^^^^^^^^^^"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The openstack-ansible-security creates a file containing audit rules for hosts."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Each group of rules are controlled by Ansible variables that begin with"},{"line_number":60,"context_line":"``audit_``. To omit a set of rules on a host, set the variable to ``no``. To"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_7d3d74dc","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":4},"updated":"2016-05-04 17:07:25.000000000","message":"Either get rid of the the or after openstack-ansible-security add project","commit_id":"d2d3bde3dcda14f82652d71a8af80fe8fceb68f0"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"f6d2d4efa39780c9e1d6044b701c82af3f7bfdb9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Rules for auditd"},{"line_number":55,"context_line":"^^^^^^^^^^^^^^^^"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The openstack-ansible-security creates a file containing audit rules for hosts."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Each group of rules are controlled by Ansible variables that begin with"},{"line_number":60,"context_line":"``audit_``. To omit a set of rules on a host, set the variable to ``no``. To"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_93f20105","line":57,"in_reply_to":"1a122d0e_7d3d74dc","updated":"2016-05-04 17:24:57.000000000","message":"Done","commit_id":"d2d3bde3dcda14f82652d71a8af80fe8fceb68f0"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"cc3fba42ca1390316806f986203bf25655ea000c","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"For example, setting ``security_audit_filesystem_mounts`` to ``yes`` will"},{"line_number":65,"context_line":"ensure that the rules for auditing filesystem mounts are included on each host."},{"line_number":66,"context_line":"Setting ``audit_filesystem_mounts`` to ``no`` will omit that group of rules on"},{"line_number":67,"context_line":"each host."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To review the full list of rules and variables, refer to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_f06ea2c6","line":66,"updated":"2016-05-05 13:30:12.000000000","message":"This should be ``security_audit_filesystem_mounts``.","commit_id":"4a901eccb24038a2c08ca6e693ba76d728533a7a"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"dc087ac3ef73067b499892020b70dc798a3af8b4","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"For example, setting ``security_audit_filesystem_mounts`` to ``yes`` will"},{"line_number":65,"context_line":"ensure that the rules for auditing filesystem mounts are included on each host."},{"line_number":66,"context_line":"Setting ``audit_filesystem_mounts`` to ``no`` will omit that group of rules on"},{"line_number":67,"context_line":"each host."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To review the full list of rules and variables, refer to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_b0ba6abe","line":66,"in_reply_to":"1a122d0e_f06ea2c6","updated":"2016-05-05 13:32:49.000000000","message":"Done","commit_id":"4a901eccb24038a2c08ca6e693ba76d728533a7a"}],"doc/source/developer-notes/V-38627.rst":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"cc3fba42ca1390316806f986203bf25655ea000c","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":".. code-block:: yaml"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   security_remove_ldap-server: no"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_d0d28633","line":8,"updated":"2016-05-05 13:30:12.000000000","message":"s/ldap-server/ldap_server/","commit_id":"4a901eccb24038a2c08ca6e693ba76d728533a7a"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"dc087ac3ef73067b499892020b70dc798a3af8b4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":".. code-block:: yaml"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   security_remove_ldap-server: no"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_b0e1cad2","line":8,"in_reply_to":"1a122d0e_d0d28633","updated":"2016-05-05 13:32:49.000000000","message":"Done","commit_id":"4a901eccb24038a2c08ca6e693ba76d728533a7a"}],"releasenotes/notes/dictionary-variables-removed-957c7b7b2108ba1f.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3dad4dbedff56c37d3982d038b3c737f85546ca3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The dictionary-based variables in ``defaults/main.yml`` are now individual"},{"line_number":4,"context_line":"    variables. The dictionary-based variables did not work properly. Deployers"},{"line_number":5,"context_line":"    must use the new variable names to enable or disable the security"},{"line_number":6,"context_line":"    configuration changes applied by the security role. For more information,"},{"line_number":7,"context_line":"    see `Launchpad Bug 1577944 \u003chttps://bugs.launchpad.net/openstack-ansible/+bug/1577944\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a122d0e_b70e178a","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":67},"updated":"2016-05-04 13:58:38.000000000","message":"Well, they did. Perhaps this is better:\n\nThe dictionary-based variables could not be changed as the documentation instructed. Instead it was required to override the entire dictionary.","commit_id":"5530aaf809c568e79e55d6c85db08ebba41a5828"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"c20948509c1b1f3831b4a5633d34a51e638f6936","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The dictionary-based variables in ``defaults/main.yml`` are now individual"},{"line_number":4,"context_line":"    variables. The dictionary-based variables did not work properly. Deployers"},{"line_number":5,"context_line":"    must use the new variable names to enable or disable the security"},{"line_number":6,"context_line":"    configuration changes applied by the security role. For more information,"},{"line_number":7,"context_line":"    see `Launchpad Bug 1577944 \u003chttps://bugs.launchpad.net/openstack-ansible/+bug/1577944\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a122d0e_d2f2c105","line":4,"in_reply_to":"1a122d0e_b70e178a","updated":"2016-05-04 14:03:04.000000000","message":"Done","commit_id":"5530aaf809c568e79e55d6c85db08ebba41a5828"}],"tasks/auth.yml":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"f0944609c1f5ed9ce89f21e09bdfcafc69410499","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  tags:"},{"line_number":210,"context_line":"    - auth"},{"line_number":211,"context_line":"    - cat1"},{"line_number":212,"context_line":"    - V-38587"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"- name: Search /etc/passwd for password hashes (for V-38499)"},{"line_number":215,"context_line":"  shell: \"awk -F: \u0027($2 !\u003d \\\"x\\\") {print}\u0027 /etc/passwd | wc -l\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_8d68f989","side":"PARENT","line":212,"updated":"2016-05-05 13:08:55.000000000","message":"Does this change need to happen in this specific patch?  I think I see the reasoning but I feel it should happen separately.","commit_id":"263101853fba0adcd8aa940fdd93a8737ccdebf2"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"ec7ac0ccefed92ac28e07eecd0062915703fb832","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  tags:"},{"line_number":210,"context_line":"    - auth"},{"line_number":211,"context_line":"    - cat1"},{"line_number":212,"context_line":"    - V-38587"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"- name: Search /etc/passwd for password hashes (for V-38499)"},{"line_number":215,"context_line":"  shell: \"awk -F: \u0027($2 !\u003d \\\"x\\\") {print}\u0027 /etc/passwd | wc -l\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_4df8a17c","side":"PARENT","line":212,"in_reply_to":"1a122d0e_8d68f989","updated":"2016-05-05 13:15:12.000000000","message":"I\u0027ll put that in a subsequent commit.","commit_id":"263101853fba0adcd8aa940fdd93a8737ccdebf2"}]}
