)]}'
{"doc/source/developer-notes/V-38477.rst":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. code-block:: yaml"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":11,"context_line":"    security_assword_minimum_days: 14"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":13,"context_line":"    security_password_minimum_days: 14"},{"line_number":14,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e 49ec2dd27109d0721ce77d71b916620474929262"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_f91c0b15","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":48},"updated":"2016-05-09 15:10:04.000000000","message":"merge remnants...","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    security_assword_minimum_days: 14"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":13,"context_line":"    security_password_minimum_days: 14"},{"line_number":14,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e 49ec2dd27109d0721ce77d71b916620474929262"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_390965de","line":14,"in_reply_to":"dab17558_f91c0b15","updated":"2016-05-09 20:45:08.000000000","message":"Done","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"}],"tasks/auditd.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - auditd"},{"line_number":23,"context_line":"    - cat2"},{"line_number":24,"context_line":"    - V-38632"},{"line_number":25,"context_line":"    - V-38631"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: V-38631/38632 - The operating system must produce audit records (install auditd with yum)"},{"line_number":28,"context_line":"  yum:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_19a58fa1","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":13},"updated":"2016-05-09 15:10:04.000000000","message":"why don\u0027t you add the tag package here too?\n(same question with \u0027apt\u0027 tag for backwards compatbility)","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - auditd"},{"line_number":23,"context_line":"    - cat2"},{"line_number":24,"context_line":"    - V-38632"},{"line_number":25,"context_line":"    - V-38631"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: V-38631/38632 - The operating system must produce audit records (install auditd with yum)"},{"line_number":28,"context_line":"  yum:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_d9a499a7","line":25,"in_reply_to":"dab17558_19a58fa1","updated":"2016-05-09 20:45:08.000000000","message":"I mainly used the \u0027package\u0027 tag for the configurations that dealt directly with the package manager itself (in apt.yml and yum.yml).  I didn\u0027t think it would make much sense here.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - auditd"},{"line_number":105,"context_line":"    - cat2"},{"line_number":106,"context_line":"    - V-38637"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# The debsums command returns 0 if the files haven\u0027t been altered but it"},{"line_number":109,"context_line":"# returns 2 otherwise. We also will check to see if auditd has been installed"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_99b7bfd7","line":106,"range":{"start_line":106,"start_character":6,"end_line":106,"end_character":13},"updated":"2016-05-09 15:10:04.000000000","message":"see above remark","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - auditd"},{"line_number":105,"context_line":"    - cat2"},{"line_number":106,"context_line":"    - V-38637"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# The debsums command returns 0 if the files haven\u0027t been altered but it"},{"line_number":109,"context_line":"# returns 2 otherwise. We also will check to see if auditd has been installed"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_19af4182","line":106,"in_reply_to":"dab17558_99b7bfd7","updated":"2016-05-09 20:45:08.000000000","message":"Same as above.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  register: v38637_result"},{"line_number":137,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":138,"context_line":"  tags:"},{"line_number":139,"context_line":"    - auditd"},{"line_number":140,"context_line":"    - cat2"},{"line_number":141,"context_line":"    - V-38637"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_9905ff7b","line":139,"range":{"start_line":139,"start_character":6,"end_line":139,"end_character":12},"updated":"2016-05-09 15:10:04.000000000","message":"- yum\n- package","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  register: v38637_result"},{"line_number":137,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":138,"context_line":"  tags:"},{"line_number":139,"context_line":"    - auditd"},{"line_number":140,"context_line":"    - cat2"},{"line_number":141,"context_line":"    - V-38637"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_39ba05c1","line":139,"in_reply_to":"dab17558_9905ff7b","updated":"2016-05-09 20:45:08.000000000","message":"It feels like the auditd tag is sufficient here since the package-security related things are in apt.yml and yum.yml.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"}],"tasks/auth.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dab17558_594b97c9","updated":"2016-05-09 15:10:04.000000000","message":"see previous remarks about tags","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dab17558_d9cbf951","in_reply_to":"dab17558_594b97c9","updated":"2016-05-09 20:45:08.000000000","message":"Done","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"}],"tasks/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    yum:"},{"line_number":45,"context_line":"      name: libselinux-python"},{"line_number":46,"context_line":"      state: present"},{"line_number":47,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  - include: apt.yml"},{"line_number":50,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_d984a7d5","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":34},"updated":"2016-05-09 15:10:04.000000000","message":"We should add tags on this task","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    yum:"},{"line_number":45,"context_line":"      name: libselinux-python"},{"line_number":46,"context_line":"      state: present"},{"line_number":47,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  - include: apt.yml"},{"line_number":50,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_f9d7ddea","line":47,"in_reply_to":"dab17558_d984a7d5","updated":"2016-05-09 20:45:08.000000000","message":"Ah, I need to remove this since it\u0027s already in other-requirements.txt.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  - include: apt.yml"},{"line_number":50,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  - include: rpm.yml"},{"line_number":53,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027 or ansible_pkg_mgr \u003d\u003d \u0027dnf\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_99617f3c","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":34},"updated":"2016-05-09 15:10:04.000000000","message":"We should add \"\n- apt \n\" as tag for backwards compatibility","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  - include: apt.yml"},{"line_number":50,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  - include: rpm.yml"},{"line_number":53,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027 or ansible_pkg_mgr \u003d\u003d \u0027dnf\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_19f46184","line":50,"in_reply_to":"dab17558_99617f3c","updated":"2016-05-09 20:45:08.000000000","message":"Done","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  - include: rpm.yml"},{"line_number":53,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027 or ansible_pkg_mgr \u003d\u003d \u0027dnf\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  - include: auditd.yml"},{"line_number":56,"context_line":"  - include: auth.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_5950b75d","line":53,"range":{"start_line":53,"start_character":4,"end_line":53,"end_character":62},"updated":"2016-05-09 15:10:04.000000000","message":"maybe it\u0027s worth adding a rpm tag?","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  - include: rpm.yml"},{"line_number":53,"context_line":"    when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027 or ansible_pkg_mgr \u003d\u003d \u0027dnf\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  - include: auditd.yml"},{"line_number":56,"context_line":"  - include: auth.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_f9eebdb2","line":53,"in_reply_to":"dab17558_5950b75d","updated":"2016-05-09 20:45:08.000000000","message":"Done","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"}],"tasks/misc.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":418,"context_line":"  register: v51337_result"},{"line_number":419,"context_line":"  changed_when: False"},{"line_number":420,"context_line":"  always_run: True"},{"line_number":421,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":422,"context_line":"  tags:"},{"line_number":423,"context_line":"    - cat2"},{"line_number":424,"context_line":"    - V-51337"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"- name: V-51337 - The system must use a Linux Security Module at boot time"},{"line_number":427,"context_line":"  fail:"},{"line_number":428,"context_line":"    msg: \"FAILED: AppArmor isn\u0027t enabled\""},{"line_number":429,"context_line":"  when:"},{"line_number":430,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":431,"context_line":"    - \"\u0027apparmor module is loaded\u0027 not in v51337_result.stdout\""},{"line_number":432,"context_line":"  tags:"},{"line_number":433,"context_line":"    - cat2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_19046f48","line":430,"range":{"start_line":421,"start_character":0,"end_line":430,"end_character":30},"updated":"2016-05-09 15:10:04.000000000","message":"shouldn\u0027t this be when distribution is ubuntu instead?","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":427,"context_line":"  fail:"},{"line_number":428,"context_line":"    msg: \"FAILED: AppArmor isn\u0027t enabled\""},{"line_number":429,"context_line":"  when:"},{"line_number":430,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":431,"context_line":"    - \"\u0027apparmor module is loaded\u0027 not in v51337_result.stdout\""},{"line_number":432,"context_line":"  tags:"},{"line_number":433,"context_line":"    - cat2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_391685a7","line":430,"in_reply_to":"dab17558_19046f48","updated":"2016-05-09 20:45:08.000000000","message":"I figured that testing the package manager would yield the best results, especially since they could include Debian or Ubuntu.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":439,"context_line":"  register: v51337_result"},{"line_number":440,"context_line":"  changed_when: False"},{"line_number":441,"context_line":"  always_run: True"},{"line_number":442,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":443,"context_line":"  tags:"},{"line_number":444,"context_line":"    - cat2"},{"line_number":445,"context_line":"    - V-51337"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_d96e6700","line":442,"range":{"start_line":442,"start_character":0,"end_line":442,"end_character":32},"updated":"2016-05-09 15:10:04.000000000","message":"same kind of comment as above.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":439,"context_line":"  register: v51337_result"},{"line_number":440,"context_line":"  changed_when: False"},{"line_number":441,"context_line":"  always_run: True"},{"line_number":442,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":443,"context_line":"  tags:"},{"line_number":444,"context_line":"    - cat2"},{"line_number":445,"context_line":"    - V-51337"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_79100da9","line":442,"in_reply_to":"dab17558_d96e6700","updated":"2016-05-09 20:45:08.000000000","message":"I figured that testing the package manager would yield the best results, especially since they could include CentOS, Red Hat or Fedora.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"ea16beca0810b224a530b040f8cb3ceca955bfc9","unresolved":false,"context_lines":[{"line_number":374,"context_line":"   - V-38702"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"- name: Check for default runlevel (for V-38674)"},{"line_number":377,"context_line":"  shell: \"grep \u0027DEFAULT_RUNLEVEL\u003d2\u0027 /etc/init/rc-sysinit.conf\""},{"line_number":378,"context_line":"  register: v38674_result"},{"line_number":379,"context_line":"  changed_when: False"},{"line_number":380,"context_line":"  always_run: True"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dab17558_ba2fc386","line":377,"updated":"2016-05-10 20:41:55.000000000","message":"Good catch. Fixing this to use the systemd_running logic.","commit_id":"74ea01b83777ba99c911ba7efaa3ff76c938f1ab"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"02af202603c6d5473cbf656d8288219cce32d5b1","unresolved":false,"context_lines":[{"line_number":374,"context_line":"   - V-38702"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"- name: Check for default runlevel (for V-38674)"},{"line_number":377,"context_line":"  shell: \"grep \u0027DEFAULT_RUNLEVEL\u003d2\u0027 /etc/init/rc-sysinit.conf\""},{"line_number":378,"context_line":"  register: v38674_result"},{"line_number":379,"context_line":"  changed_when: False"},{"line_number":380,"context_line":"  always_run: True"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dab17558_4e3eddda","line":377,"updated":"2016-05-10 19:29:49.000000000","message":"The file /etc/init/rc-sysinit.conf is not available on Ubuntu 16.04. I think the output of systemctl get-default has to be checked here. multi-user.target emulates run level 3.","commit_id":"74ea01b83777ba99c911ba7efaa3ff76c938f1ab"}],"tasks/nfsd.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  shell: grep all_squash /etc/exports"},{"line_number":30,"context_line":"  register: v38460_result"},{"line_number":31,"context_line":"  changed_when: v38460_result.rc \u003d\u003d 0"},{"line_number":32,"context_line":"  failed_when: False"},{"line_number":33,"context_line":"  when: exports.stat.exists"},{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    - nfs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_b948c388","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":20},"updated":"2016-05-09 15:10:04.000000000","message":"was this supposed to be added?\n\nThis could be problematic for idempotency.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  shell: grep all_squash /etc/exports"},{"line_number":30,"context_line":"  register: v38460_result"},{"line_number":31,"context_line":"  changed_when: v38460_result.rc \u003d\u003d 0"},{"line_number":32,"context_line":"  failed_when: False"},{"line_number":33,"context_line":"  when: exports.stat.exists"},{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    - nfs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_9984d1d4","line":32,"in_reply_to":"dab17558_b948c388","updated":"2016-05-09 20:45:08.000000000","message":"Yes -- I didn\u0027t want this to fail if the grep found no matches.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"}],"tasks/services.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    - cat2"},{"line_number":155,"context_line":"    - V-38603"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# Ubuntu\u0027s equivalent of Red Hat\u0027s ypserv package is \u0027nis\u0027"},{"line_number":158,"context_line":"- name: V-38603 - Remove ypserv package with yum"},{"line_number":159,"context_line":"  yum:"},{"line_number":160,"context_line":"    name: \"{{ ypserv_pkg }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_190e2f3b","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":58},"updated":"2016-05-09 15:10:04.000000000","message":"why keeping this comment?","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    - cat2"},{"line_number":155,"context_line":"    - V-38603"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# Ubuntu\u0027s equivalent of Red Hat\u0027s ypserv package is \u0027nis\u0027"},{"line_number":158,"context_line":"- name: V-38603 - Remove ypserv package with yum"},{"line_number":159,"context_line":"  yum:"},{"line_number":160,"context_line":"    name: \"{{ ypserv_pkg }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_b969d527","line":157,"in_reply_to":"dab17558_190e2f3b","updated":"2016-05-09 20:45:08.000000000","message":"Good catch. I\u0027ll remove it.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"}],"tasks/sshd.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c49eeab7c60ccd0ecd35797bb11c8091f64a4e1e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    dest: /etc/ssh/sshd_config"},{"line_number":20,"context_line":"    regexp: \u0027^(#)?PrintLastLog\u0027"},{"line_number":21,"context_line":"    line: \u0027PrintLastLog yes\u0027"},{"line_number":22,"context_line":"    insertbefore: \"^Match\""},{"line_number":23,"context_line":"  notify:"},{"line_number":24,"context_line":"    - restart ssh"},{"line_number":25,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_1415563f","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":26},"updated":"2016-05-09 15:10:04.000000000","message":"shouldn\u0027t this be a separate change? For easier reviewing?","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"67c2732f6f07b3946d40e8340631a347bb0ac896","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    dest: /etc/ssh/sshd_config"},{"line_number":20,"context_line":"    regexp: \u0027^(#)?PrintLastLog\u0027"},{"line_number":21,"context_line":"    line: \u0027PrintLastLog yes\u0027"},{"line_number":22,"context_line":"    insertbefore: \"^Match\""},{"line_number":23,"context_line":"  notify:"},{"line_number":24,"context_line":"    - restart ssh"},{"line_number":25,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_b950b55f","line":22,"in_reply_to":"dab17558_1415563f","updated":"2016-05-09 20:45:08.000000000","message":"I\u0027ve had to change this up in previous revisions.","commit_id":"684dbb3c2a4844c8590d38ff4ea3a9a670dc8ffe"}],"tox.ini":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"71b40f9b5e61228fc61ba4fe53ea6a082243beef","unresolved":false,"context_lines":[{"line_number":114,"context_line":"              {homedir}/.ansible/plugins"},{"line_number":115,"context_line":"    ansible-playbook -i {toxinidir}/tests/inventory \\"},{"line_number":116,"context_line":"                     -e \"rolename\u003d{toxinidir}\" \\"},{"line_number":117,"context_line":"                     --skip-tag V-38462,V-51337,V-38574,V-38674 \\"},{"line_number":118,"context_line":"                     {toxinidir}/tests/test.yml"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-properties","patch_set":15,"id":"dab17558_79501b0b","line":117,"updated":"2016-05-13 19:19:35.000000000","message":"I\u0027ll try this once more to see if 38574 needs to be skipped and why.","commit_id":"18a7b8e370bd14f0b5b65ef3c5410b446db5c5cc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"78de067f86b82bcfe627d5639411c475ea3a108c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"              {homedir}/.ansible/plugins"},{"line_number":115,"context_line":"    ansible-playbook -i {toxinidir}/tests/inventory \\"},{"line_number":116,"context_line":"                     -e \"rolename\u003d{toxinidir}\" \\"},{"line_number":117,"context_line":"                     --skip-tag V-38462,V-51337,V-38574,V-38674 \\"},{"line_number":118,"context_line":"                     {toxinidir}/tests/test.yml"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-properties","patch_set":15,"id":"dab17558_aac98827","line":117,"range":{"start_line":117,"start_character":48,"end_line":117,"end_character":55},"updated":"2016-05-13 17:09:20.000000000","message":"There\u0027s no note above to explain why this is needed.","commit_id":"18a7b8e370bd14f0b5b65ef3c5410b446db5c5cc"}]}