)]}'
{"doc/source/developer-notes/V-51379.rst":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"a0b61a5a42886eb26f82ea79fd85e024630dfb54","unresolved":false,"context_lines":[{"line_number":4,"context_line":"will fail with an error message if any unlabeled devices are found."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Although SELinux works through a labeling system where every file (including"},{"line_number":7,"context_line":"devices) receive a label, AppArmor on Ubuntu works purely through policies"},{"line_number":8,"context_line":"without labels. However, OpenStack-Ansible does configure several AppArmor"},{"line_number":9,"context_line":"policies to reduce the chances and impact of LXC container breakouts on"},{"line_number":10,"context_line":"OpenStack hosts."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_50a49ab8","line":7,"updated":"2016-05-23 05:12:17.000000000","message":"nit: receives","commit_id":"7bfc261a701d5fc2866c93b117565699407d9c49"}],"releasenotes/notes/search-for-unlabeled-devices-cb047c5f767e93ce.yaml":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"d86474a9697857b836a9afa7f038ac1490885df0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The requirements for V-51379 were skipped in Ubuntu since they didn\u0027t apply"},{"line_number":5,"context_line":"    to AppArmor, but they were also unintentionally skipped on CentOS. Tasks"},{"line_number":6,"context_line":"    were added to search for any device files without a proper SELinux label on"},{"line_number":7,"context_line":"    CentOS systems."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_be194224","line":4,"updated":"2016-05-23 12:55:53.000000000","message":"Done","commit_id":"7bfc261a701d5fc2866c93b117565699407d9c49"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c54703a908f26743c229689f5e7b338e9fdaf94d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The requirements for V-51379 were skipped in Ubuntu since they didn\u0027t apply"},{"line_number":5,"context_line":"    to AppArmor, but they were also unintentionally skipped on CentOS. Tasks"},{"line_number":6,"context_line":"    were added to search for any device files without a proper SELinux label on"},{"line_number":7,"context_line":"    CentOS systems."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_47e33bd9","line":4,"range":{"start_line":4,"start_character":67,"end_line":4,"end_character":73},"updated":"2016-05-23 09:16:25.000000000","message":"nit: did not","commit_id":"7bfc261a701d5fc2866c93b117565699407d9c49"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"d86474a9697857b836a9afa7f038ac1490885df0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The requirements for V-51379 were skipped in Ubuntu since they didn\u0027t apply"},{"line_number":5,"context_line":"    to AppArmor, but they were also unintentionally skipped on CentOS. Tasks"},{"line_number":6,"context_line":"    were added to search for any device files without a proper SELinux label on"},{"line_number":7,"context_line":"    CentOS systems."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_9e143ee9","line":5,"updated":"2016-05-23 12:55:53.000000000","message":"Done","commit_id":"7bfc261a701d5fc2866c93b117565699407d9c49"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c54703a908f26743c229689f5e7b338e9fdaf94d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The requirements for V-51379 were skipped in Ubuntu since they didn\u0027t apply"},{"line_number":5,"context_line":"    to AppArmor, but they were also unintentionally skipped on CentOS. Tasks"},{"line_number":6,"context_line":"    were added to search for any device files without a proper SELinux label on"},{"line_number":7,"context_line":"    CentOS systems."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_878523d0","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":69},"updated":"2016-05-23 09:16:25.000000000","message":"If the Multi-OS work has only been applied in the master branch, then you don\u0027t need to indicate fixes like this since nothing has ever been released to Operators (and the release notes are targeted at Operators). You can possibly have the sentence that follows this be noted as a new feature?","commit_id":"7bfc261a701d5fc2866c93b117565699407d9c49"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"490e61afccfe544be3bf37b66ad2c4f01f5036e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The requirements for V-51379 were skipped in Ubuntu since they did not"},{"line_number":5,"context_line":"    apply to AppArmor, but they were also unintentionally skipped on CentOS."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Tasks were added to search for any device files without a proper SELinux"},{"line_number":8,"context_line":"    label on CentOS systems. If any of these device labels are found, the"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_21b027dd","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":76},"updated":"2016-05-25 08:41:06.000000000","message":"As mentioned in the previous patch set, this is unnecessary as the master branch has not yet released. You only need to notify operators about the new functionality, which happens to be the rest of this note.","commit_id":"d789f88879478466ef40808138fc615c011308cf"}],"tasks/misc.yml":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"d86474a9697857b836a9afa7f038ac1490885df0","unresolved":false,"context_lines":[{"line_number":459,"context_line":"  register: v51379_unlabeled_devices"},{"line_number":460,"context_line":"  always_run: True"},{"line_number":461,"context_line":"  when:"},{"line_number":462,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":463,"context_line":"  tags:"},{"line_number":464,"context_line":"    - cat1"},{"line_number":465,"context_line":"    - V-51379"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_fed58a1b","line":462,"updated":"2016-05-23 12:55:53.000000000","message":"Done","commit_id":"7bfc261a701d5fc2866c93b117565699407d9c49"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"805bcd50e9727c01087a5ff0ff71363717ded7c7","unresolved":false,"context_lines":[{"line_number":459,"context_line":"  register: v51379_unlabeled_devices"},{"line_number":460,"context_line":"  always_run: True"},{"line_number":461,"context_line":"  when:"},{"line_number":462,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":463,"context_line":"  tags:"},{"line_number":464,"context_line":"    - cat1"},{"line_number":465,"context_line":"    - V-51379"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_78c26eea","line":462,"updated":"2016-05-22 16:27:58.000000000","message":"I do not like this kind of check to identify the used distribution. The value will be dnf in the future. Why not checking ansible_distribution here?","commit_id":"7bfc261a701d5fc2866c93b117565699407d9c49"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"af6e507187736352b703cab5636dcaa4832310e8","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    - V-38674"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"- name: Check for unlabeled device files (for V-51379)"},{"line_number":417,"context_line":"  shell: \"ls -RZ /dev | grep unlabeled_t\""},{"line_number":418,"context_line":"  register: v51379_unlabeled_devices"},{"line_number":419,"context_line":"  always_run: True"},{"line_number":420,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_8740a835","line":417,"updated":"2016-06-01 03:44:28.000000000","message":"It looks like when this finds no matches it returns a 1 and fails the run.\nMaybe instead of a grep here filter the device list output with another task in between these two.","commit_id":"84fbab2f76320f0593ffa923ba02fa93fbb4b2e4"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"5e36c8bc3e81450f7faf5108422e95db5aec7d30","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    - V-38674"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"- name: Check for unlabeled device files (for V-51379)"},{"line_number":417,"context_line":"  shell: \"ls -RZ /dev | grep unlabeled_t\""},{"line_number":418,"context_line":"  register: v51379_unlabeled_devices"},{"line_number":419,"context_line":"  always_run: True"},{"line_number":420,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_2fe1bc2d","line":417,"in_reply_to":"9abb7d3a_8740a835","updated":"2016-06-01 12:43:27.000000000","message":"Ah, good catch. I\u0027m changing it to use `find` instead.","commit_id":"84fbab2f76320f0593ffa923ba02fa93fbb4b2e4"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"f3af2585b22bd87bab4bb9d517bcda519a207136","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"- name: V-51379 - All device files must be monitored by the Linux Security Module"},{"line_number":427,"context_line":"  fail:"},{"line_number":428,"context_line":"    msg: \"Devices were found without SELinux labels: {{ v51379_unlabeled_devices.stdout }}\""},{"line_number":429,"context_line":"  when:"},{"line_number":430,"context_line":"    - ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":431,"context_line":"    - v51379_unlabeled_devices.stdout is defined"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_87f7dad1","line":428,"updated":"2016-06-01 18:22:38.000000000","message":"Done","commit_id":"685c5293bc82c90f97e2ca77e428c1f6f423387c"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a70dc4f2420804865e7f5c1a4a1ac4bfb9bf5e18","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"- name: V-51379 - All device files must be monitored by the Linux Security Module"},{"line_number":427,"context_line":"  fail:"},{"line_number":428,"context_line":"    msg: \"Devices were found without SELinux labels: {{ v51379_unlabeled_devices.stdout }}\""},{"line_number":429,"context_line":"  when:"},{"line_number":430,"context_line":"    - ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":431,"context_line":"    - v51379_unlabeled_devices.stdout is defined"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_f92beb7f","line":428,"range":{"start_line":428,"start_character":56,"end_line":428,"end_character":87},"updated":"2016-06-01 17:44:50.000000000","message":"If this finds multiple devices it prints out \"dev1\\ndev2\"\nCould this use stdout_lines or replace \u0027\\n\u0027?","commit_id":"685c5293bc82c90f97e2ca77e428c1f6f423387c"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"209ff8c15ecd2235992c23ceb72542c381fc9ae5","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"- name: V-51379 - All device files must be monitored by the Linux Security Module"},{"line_number":427,"context_line":"  fail:"},{"line_number":428,"context_line":"    msg: \"Devices were found without SELinux labels: {{ v51379_unlabeled_devices.stdout_lines | join(\", \") }}\""},{"line_number":429,"context_line":"  when:"},{"line_number":430,"context_line":"    - ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":431,"context_line":"    - v51379_unlabeled_devices.stdout is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9abb7d3a_edb8452c","line":428,"range":{"start_line":428,"start_character":101,"end_line":428,"end_character":105},"updated":"2016-06-01 18:57:21.000000000","message":"single quotes","commit_id":"0522984206908709d69a6ed5d0c5c7cb580bed2a"}]}
