)]}'
{"id":"openstack%2Fopenstack-ansible-security~324960","triplet_id":"openstack%2Fopenstack-ansible-security~master~I228f8aa7b0df80cce16e54c5f1e11da678bfd67d","project":"openstack/openstack-ansible-security","branch":"master","topic":"features/V-38524","hashtags":[],"change_id":"I228f8aa7b0df80cce16e54c5f1e11da678bfd67d","subject":"Implemented: V-38524.","status":"MERGED","created":"2016-06-03 00:18:46.000000000","updated":"2016-06-07 21:04:21.000000000","submitted":"2016-06-07 21:04:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"338e101edd58939b46e3e6f61f6b2394acbfe665","_number":324960,"virtual_id_number":324960,"owner":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-06-07 21:04:21.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-07 19:52:30.000000000","_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},{"value":2,"date":"2016-06-07 20:27:32.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},{"value":1,"date":"2016-06-07 20:27:32.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-07 19:52:30.000000000","updated_by":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"reviewer":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"state":"REVIEWER"},{"updated":"2016-06-07 20:27:32.000000000","updated_by":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"reviewer":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"state":"REVIEWER"},{"updated":"2016-06-07 21:04:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"580d78494adc9b3c98a36c605301f033fed98ab1","author":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"date":"2016-06-03 00:18:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d4c76e2496484c6b1a028f03f5f45e51c5de3f06","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-03 00:55:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-security-docs http://docs-draft.openstack.org/60/324960/1/check/gate-openstack-ansible-security-docs/9a05560//doc/build/html/ : SUCCESS in 3m 23s\n- gate-openstack-ansible-security-linters http://logs.openstack.org/60/324960/1/check/gate-openstack-ansible-security-linters/0b6547b/ : SUCCESS in 45s\n- gate-openstack-ansible-security-ansible-func-centos-7-nv http://logs.openstack.org/60/324960/1/check/gate-openstack-ansible-security-ansible-func-centos-7-nv/c82df66/ : SUCCESS in 1m 43s (non-voting)\n- gate-openstack-ansible-security-ansible-func-ubuntu-trusty http://logs.openstack.org/60/324960/1/check/gate-openstack-ansible-security-ansible-func-ubuntu-trusty/c73c234/ : SUCCESS in 2m 28s\n- gate-openstack-ansible-security-ansible-func-ubuntu-xenial-nv http://logs.openstack.org/60/324960/1/check/gate-openstack-ansible-security-ansible-func-ubuntu-xenial-nv/e2bf1f3/ : SUCCESS in 2m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"789da39b8e1d7c7dfd69e7582168a8401592eb07","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-06-03 15:54:48.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nJust a few questions on this one inline.","accounts_in_message":[],"_revision_number":1},{"id":"8e406a5a7cbc65f1f20045510389c385ae6cd52c","author":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"date":"2016-06-03 19:00:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"08d9ebedc3bdfb05e1ad7f3bcdb0adaa7210fe3a","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-06-03 19:14:22.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThis one probably needs to be disabled by default since it will affect LXC container communication in OpenStack-Ansible deployments.\n\nAlso, could you add some documentation in docs/source/developer-notes/V-38524.rst? That file is currently symlinked to V-38523, so you\u0027ll need to remove the symlink before you add documentation.","accounts_in_message":[],"_revision_number":2},{"id":"6e48fe13ff135665ad3e02766fa4c96b651488d1","author":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"date":"2016-06-03 19:34:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d10370be1b25696bbcd4bbc75bfe4eac2247b59b","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-06-03 19:36:44.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nJust one adjustment and we should be all set!","accounts_in_message":[],"_revision_number":3},{"id":"65c6b04cfc916e50fec3855ac0ef37672a12408f","author":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"date":"2016-06-03 19:43:40.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"93580d7cd25a2da402e98132073ac5ada581402e","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-06-03 19:44:38.000000000","message":"Patch Set 4: Code-Review+1\n\nThanks for this! Just waiting on the gate.","accounts_in_message":[],"_revision_number":4},{"id":"e7d6f721ae383f51b42434ffd77ab02c8b0de18b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-04 02:33:13.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-security-docs http://docs-draft.openstack.org/60/324960/4/check/gate-openstack-ansible-security-docs/788f469//doc/build/html/ : SUCCESS in 2m 53s\n- gate-openstack-ansible-security-linters http://logs.openstack.org/60/324960/4/check/gate-openstack-ansible-security-linters/01cbece/ : SUCCESS in 34s\n- gate-openstack-ansible-security-ansible-func-centos-7-nv http://logs.openstack.org/60/324960/4/check/gate-openstack-ansible-security-ansible-func-centos-7-nv/0e710ba/ : SUCCESS in 1m 08s (non-voting)\n- gate-openstack-ansible-security-ansible-func-ubuntu-trusty http://logs.openstack.org/60/324960/4/check/gate-openstack-ansible-security-ansible-func-ubuntu-trusty/a79fe6b/ : SUCCESS in 1m 26s\n- gate-openstack-ansible-security-ansible-func-ubuntu-xenial-nv http://logs.openstack.org/60/324960/4/check/gate-openstack-ansible-security-ansible-func-ubuntu-xenial-nv/c19167f/ : SUCCESS in 2m 30s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"b30d29cfb85b6d74ab9cf75046d21a7c5030d093","author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"date":"2016-06-07 19:52:30.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"dc22450e7ae002589fe669e6f893c33e84c854bd","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-06-07 20:27:32.000000000","message":"Patch Set 4: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"945b8fa95d4f2317feed9d3e3b157422f606c20f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 20:27:37.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"0cea3ee17e661d7c6bb187bf056574a19af87c3a","date":"2016-06-07 21:04:21.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"fcb673b13c5396ff8a89af24cc694e9048a6c429","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 21:04:21.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-security-docs http://docs-draft.openstack.org/60/324960/4/gate/gate-openstack-ansible-security-docs/73bedbe//doc/build/html/ : SUCCESS in 1m 26s\n- gate-openstack-ansible-security-linters http://logs.openstack.org/60/324960/4/gate/gate-openstack-ansible-security-linters/e802a27/ : SUCCESS in 40s\n- gate-openstack-ansible-security-ansible-func-ubuntu-trusty http://logs.openstack.org/60/324960/4/gate/gate-openstack-ansible-security-ansible-func-ubuntu-trusty/99a3a34/ : SUCCESS in 1m 56s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"511256974308d0a973168f72ef8eb0d60a50a6f3","revisions":{"78609dadde2e566be1a9062e71c1b11e8bb706e0":{"kind":"REWORK","_number":1,"created":"2016-06-03 00:18:46.000000000","uploader":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"ref":"refs/changes/60/324960/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-security","ref":"refs/changes/60/324960/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/1"}}},"commit":{"parents":[{"commit":"ecb03290884e0ef6a05452b072e950f36a29610a","subject":"Consistency for multi-os in the includes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/ecb03290884e0ef6a05452b072e950f36a29610a"}]}],"author":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 00:18:30.000000000","tz":120},"committer":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 00:18:30.000000000","tz":120},"subject":"Implemented: V-38524.","message":"Implemented: V-38524.\n\nChange-Id: I228f8aa7b0df80cce16e54c5f1e11da678bfd67d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/78609dadde2e566be1a9062e71c1b11e8bb706e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/78609dadde2e566be1a9062e71c1b11e8bb706e0"}]},"branch":"refs/heads/master"},"62bc14e57577051df0b3864a748ee682b103ac2d":{"kind":"REWORK","_number":2,"created":"2016-06-03 19:00:17.000000000","uploader":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"ref":"refs/changes/60/324960/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-security","ref":"refs/changes/60/324960/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/2"}}},"commit":{"parents":[{"commit":"ecb03290884e0ef6a05452b072e950f36a29610a","subject":"Consistency for multi-os in the includes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/ecb03290884e0ef6a05452b072e950f36a29610a"}]}],"author":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 00:18:30.000000000","tz":120},"committer":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 18:59:14.000000000","tz":120},"subject":"Implemented: V-38524.","message":"Implemented: V-38524.\n\nThis patch disables ICMPv4 redirects feature on the host.\nAccepting ICMP redirects has few legitimate uses.\nIt should be disabled unless it is absolutely required.\n\nIt is configurable by `security_disable_icmpv4_redirects`.\n\nChange-Id: I228f8aa7b0df80cce16e54c5f1e11da678bfd67d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/62bc14e57577051df0b3864a748ee682b103ac2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/62bc14e57577051df0b3864a748ee682b103ac2d"}]},"branch":"refs/heads/master"},"8278c97f928c310355fb72877f69e8f481e0f664":{"kind":"REWORK","_number":3,"created":"2016-06-03 19:34:02.000000000","uploader":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"ref":"refs/changes/60/324960/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-security","ref":"refs/changes/60/324960/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/3"}}},"commit":{"parents":[{"commit":"ecb03290884e0ef6a05452b072e950f36a29610a","subject":"Consistency for multi-os in the includes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/ecb03290884e0ef6a05452b072e950f36a29610a"}]}],"author":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 00:18:30.000000000","tz":120},"committer":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 19:33:41.000000000","tz":120},"subject":"Implemented: V-38524.","message":"Implemented: V-38524.\n\nThis patch disables ICMPv4 redirects feature on the host.\nAccepting ICMP redirects has few legitimate uses.\nIt should be disabled unless it is absolutely required.\n\nIt is configurable by `security_disable_icmpv4_redirects`.\nThis feature is disabled by default as it can disrupt LXC deployments.\n\nChange-Id: I228f8aa7b0df80cce16e54c5f1e11da678bfd67d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/8278c97f928c310355fb72877f69e8f481e0f664"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/8278c97f928c310355fb72877f69e8f481e0f664"}]},"branch":"refs/heads/master"},"511256974308d0a973168f72ef8eb0d60a50a6f3":{"kind":"REWORK","_number":4,"created":"2016-06-03 19:43:40.000000000","uploader":{"_account_id":22142,"name":"kboratynski","email":"kamil.boratynski@icloud.com","username":"kboratynski"},"ref":"refs/changes/60/324960/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-security","ref":"refs/changes/60/324960/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-security refs/changes/60/324960/4"}}},"commit":{"parents":[{"commit":"ecb03290884e0ef6a05452b072e950f36a29610a","subject":"Consistency for multi-os in the includes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/ecb03290884e0ef6a05452b072e950f36a29610a"}]}],"author":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 00:18:30.000000000","tz":120},"committer":{"name":"Kamil Boratyński","email":"kamil.boratynski@icloud.com","date":"2016-06-03 19:42:58.000000000","tz":120},"subject":"Implemented: V-38524.","message":"Implemented: V-38524.\n\nThis patch disables ICMPv4 redirects feature on the host.\nAccepting ICMP redirects has few legitimate uses.\nIt should be disabled unless it is absolutely required.\n\nIt is configurable by `security_disable_icmpv4_redirects`.\nThis feature is disabled by default as it can disrupt LXC deployments.\n\nChange-Id: I228f8aa7b0df80cce16e54c5f1e11da678bfd67d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/511256974308d0a973168f72ef8eb0d60a50a6f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/511256974308d0a973168f72ef8eb0d60a50a6f3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}