)]}'
{"run_tests.sh":[{"author":{"_account_id":2556,"name":"Evan Callicoat","email":"apsu@propter.net","username":"diopter"},"change_message_id":"6d067cc1f43c02c932c54ad49cd91ec83631cc22","unresolved":false,"context_lines":[{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Install OS packages using bindep"},{"line_number":37,"context_line":"if apt-get -v \u003e/dev/null 2\u003e\u00261; then"},{"line_number":38,"context_line":"    sudo apt-get update"},{"line_number":39,"context_line":"    DEBIAN_FRONTEND\u003dnoninteractive \\"},{"line_number":40,"context_line":"      sudo apt-get -q --option \"Dpkg::Options::\u003d--force-confold\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_4cff1e67","line":37,"updated":"2017-01-04 17:15:13.000000000","message":"Why are we checking for apt-get differently than we checked for yum above? Also, \u0026\u003e /dev/null works for BASH 4.x+ which has been in use for a long time.","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"50960f8837a514fb9fae5a7ed99ec4d2546a8d60","unresolved":false,"context_lines":[{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Install OS packages using bindep"},{"line_number":37,"context_line":"if apt-get -v \u003e/dev/null 2\u003e\u00261; then"},{"line_number":38,"context_line":"    sudo apt-get update"},{"line_number":39,"context_line":"    DEBIAN_FRONTEND\u003dnoninteractive \\"},{"line_number":40,"context_line":"      sudo apt-get -q --option \"Dpkg::Options::\u003d--force-confold\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_e7baab09","line":37,"in_reply_to":"ba5201f7_4cff1e67","updated":"2017-01-04 17:16:42.000000000","message":"Done","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"},{"author":{"_account_id":2556,"name":"Evan Callicoat","email":"apsu@propter.net","username":"diopter"},"change_message_id":"6d067cc1f43c02c932c54ad49cd91ec83631cc22","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # Don\u0027t run yum with an empty list of packages. It will fail and"},{"line_number":46,"context_line":"    # cause the script to exit with an error."},{"line_number":47,"context_line":"    if [[ ${#YUM_PKGS} \u003e 0 ]]; then"},{"line_number":48,"context_line":"      sudo yum install -y `bindep -b -f bindep.txt test`"},{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_8c4026a7","line":48,"updated":"2017-01-04 17:15:13.000000000","message":"Don\u0027t mix $() and ``, and this bindep call is the same as the one in the other arm of the \u0027if\u0027 block, above. Should pull it out like YUM_PKGS to deduplicate.","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"50960f8837a514fb9fae5a7ed99ec4d2546a8d60","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # Don\u0027t run yum with an empty list of packages. It will fail and"},{"line_number":46,"context_line":"    # cause the script to exit with an error."},{"line_number":47,"context_line":"    if [[ ${#YUM_PKGS} \u003e 0 ]]; then"},{"line_number":48,"context_line":"      sudo yum install -y `bindep -b -f bindep.txt test`"},{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_273bd39d","line":48,"in_reply_to":"ba5201f7_8c4026a7","updated":"2017-01-04 17:16:42.000000000","message":"Done","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"},{"author":{"_account_id":2556,"name":"Evan Callicoat","email":"apsu@propter.net","username":"diopter"},"change_message_id":"6d067cc1f43c02c932c54ad49cd91ec83631cc22","unresolved":false,"context_lines":[{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# run through each tox env and execute the test"},{"line_number":53,"context_line":"for tox_env in $(awk -F\u003d \u0027/envlist/ {print $2}\u0027 tox.ini | sed \u0027s/,/ /g\u0027); do"},{"line_number":54,"context_line":"  if [ \"${tox_env}\" !\u003d \"ansible-functional\" ]; then"},{"line_number":55,"context_line":"    tox -e ${tox_env}"},{"line_number":56,"context_line":"  elif [ \"${tox_env}\" \u003d\u003d \"ansible-functional\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_6c3f82d6","line":53,"updated":"2017-01-04 17:15:13.000000000","message":"Don\u0027t mix awk and sed, either one can do the entire job necessary here, it\u0027s weird to combine them like this. For example, sed -nr \u0027s/^.*envlist.*\u003d[:space:]*(.*)$/\\1/,s/,/ /g\u0027 type thing, or gawk -F\u003d \u0027/envlist/ {print gensub(\"/,/\", \" \", \"g\", $2)}\u0027 type thing.","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"50960f8837a514fb9fae5a7ed99ec4d2546a8d60","unresolved":false,"context_lines":[{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# run through each tox env and execute the test"},{"line_number":53,"context_line":"for tox_env in $(awk -F\u003d \u0027/envlist/ {print $2}\u0027 tox.ini | sed \u0027s/,/ /g\u0027); do"},{"line_number":54,"context_line":"  if [ \"${tox_env}\" !\u003d \"ansible-functional\" ]; then"},{"line_number":55,"context_line":"    tox -e ${tox_env}"},{"line_number":56,"context_line":"  elif [ \"${tox_env}\" \u003d\u003d \"ansible-functional\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_47429711","line":53,"in_reply_to":"ba5201f7_6c3f82d6","updated":"2017-01-04 17:16:42.000000000","message":"Done","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"},{"author":{"_account_id":2556,"name":"Evan Callicoat","email":"apsu@propter.net","username":"diopter"},"change_message_id":"6d067cc1f43c02c932c54ad49cd91ec83631cc22","unresolved":false,"context_lines":[{"line_number":53,"context_line":"for tox_env in $(awk -F\u003d \u0027/envlist/ {print $2}\u0027 tox.ini | sed \u0027s/,/ /g\u0027); do"},{"line_number":54,"context_line":"  if [ \"${tox_env}\" !\u003d \"ansible-functional\" ]; then"},{"line_number":55,"context_line":"    tox -e ${tox_env}"},{"line_number":56,"context_line":"  elif [ \"${tox_env}\" \u003d\u003d \"ansible-functional\" ]; then"},{"line_number":57,"context_line":"    if ${FUNCTIONAL_TEST}; then"},{"line_number":58,"context_line":"      tox -e ${tox_env}"},{"line_number":59,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_4c139e66","line":56,"updated":"2017-01-04 17:15:13.000000000","message":"Any reason this is explicit and an elif instead of just \"else\" for this arm of the conditional?","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"50960f8837a514fb9fae5a7ed99ec4d2546a8d60","unresolved":false,"context_lines":[{"line_number":53,"context_line":"for tox_env in $(awk -F\u003d \u0027/envlist/ {print $2}\u0027 tox.ini | sed \u0027s/,/ /g\u0027); do"},{"line_number":54,"context_line":"  if [ \"${tox_env}\" !\u003d \"ansible-functional\" ]; then"},{"line_number":55,"context_line":"    tox -e ${tox_env}"},{"line_number":56,"context_line":"  elif [ \"${tox_env}\" \u003d\u003d \"ansible-functional\" ]; then"},{"line_number":57,"context_line":"    if ${FUNCTIONAL_TEST}; then"},{"line_number":58,"context_line":"      tox -e ${tox_env}"},{"line_number":59,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_6745db15","line":56,"in_reply_to":"ba5201f7_4c139e66","updated":"2017-01-04 17:16:42.000000000","message":"Done","commit_id":"5a91dc14ba1d0f874f07b39db814a244931efd04"}]}